2005-06-01 09:03:47 +07:00
|
|
|
/*
|
|
|
|
* drivers/cpufreq/cpufreq_conservative.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 2001 Russell King
|
|
|
|
* (C) 2003 Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>.
|
|
|
|
* Jun Nakajima <jun.nakajima@intel.com>
|
2009-02-14 02:01:01 +07:00
|
|
|
* (C) 2009 Alexander Clouter <alex@digriz.org.uk>
|
2005-06-01 09:03:47 +07:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
|
|
* published by the Free Software Foundation.
|
|
|
|
*/
|
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
#include <linux/slab.h>
|
2012-10-26 05:47:42 +07:00
|
|
|
#include "cpufreq_governor.h"
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2016-02-19 00:40:14 +07:00
|
|
|
struct cs_policy_dbs_info {
|
|
|
|
struct policy_dbs_info policy_dbs;
|
|
|
|
unsigned int down_skip;
|
|
|
|
unsigned int requested_freq;
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline struct cs_policy_dbs_info *to_dbs_info(struct policy_dbs_info *policy_dbs)
|
|
|
|
{
|
|
|
|
return container_of(policy_dbs, struct cs_policy_dbs_info, policy_dbs);
|
|
|
|
}
|
|
|
|
|
2013-02-09 00:24:24 +07:00
|
|
|
/* Conservative governor macros */
|
2005-06-01 09:03:47 +07:00
|
|
|
#define DEF_FREQUENCY_UP_THRESHOLD (80)
|
|
|
|
#define DEF_FREQUENCY_DOWN_THRESHOLD (20)
|
2013-03-22 15:03:17 +07:00
|
|
|
#define DEF_FREQUENCY_STEP (5)
|
2006-03-22 16:54:10 +07:00
|
|
|
#define DEF_SAMPLING_DOWN_FACTOR (1)
|
|
|
|
#define MAX_SAMPLING_DOWN_FACTOR (10)
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2012-10-26 05:47:42 +07:00
|
|
|
static DEFINE_PER_CPU(struct cs_cpu_dbs_info_s, cs_cpu_dbs_info);
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2016-02-18 08:26:55 +07:00
|
|
|
static struct dbs_governor cs_dbs_gov;
|
|
|
|
|
2013-03-22 15:03:17 +07:00
|
|
|
static inline unsigned int get_freq_target(struct cs_dbs_tuners *cs_tuners,
|
|
|
|
struct cpufreq_policy *policy)
|
|
|
|
{
|
|
|
|
unsigned int freq_target = (cs_tuners->freq_step * policy->max) / 100;
|
|
|
|
|
|
|
|
/* max freq cannot be less than 100. But who knows... */
|
|
|
|
if (unlikely(freq_target == 0))
|
|
|
|
freq_target = DEF_FREQUENCY_STEP;
|
|
|
|
|
|
|
|
return freq_target;
|
|
|
|
}
|
|
|
|
|
2012-10-26 05:47:42 +07:00
|
|
|
/*
|
|
|
|
* Every sampling_rate, we check, if current idle time is less than 20%
|
2013-03-06 05:06:29 +07:00
|
|
|
* (default), then we try to increase frequency. Every sampling_rate *
|
|
|
|
* sampling_down_factor, we check, if current idle time is more than 80%
|
|
|
|
* (default), then we try to decrease frequency
|
2012-10-26 05:47:42 +07:00
|
|
|
*
|
|
|
|
* Any frequency increase takes it to the maximum frequency. Frequency reduction
|
|
|
|
* happens at minimum steps of 5% (default) of maximum frequency
|
|
|
|
*/
|
2016-02-15 08:19:31 +07:00
|
|
|
static unsigned int cs_dbs_timer(struct cpufreq_policy *policy)
|
2007-10-22 14:50:13 +07:00
|
|
|
{
|
2016-02-07 22:24:26 +07:00
|
|
|
struct policy_dbs_info *policy_dbs = policy->governor_data;
|
2016-02-19 00:40:14 +07:00
|
|
|
struct cs_policy_dbs_info *dbs_info = to_dbs_info(policy_dbs);
|
2016-02-07 22:24:26 +07:00
|
|
|
struct dbs_data *dbs_data = policy_dbs->dbs_data;
|
2013-03-27 22:58:58 +07:00
|
|
|
struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
|
2016-02-15 08:19:31 +07:00
|
|
|
unsigned int load = dbs_update(policy);
|
2012-10-26 05:47:42 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* break out if we 'cannot' reduce the speed as the user might
|
|
|
|
* want freq_step to be zero
|
|
|
|
*/
|
2013-03-27 22:58:58 +07:00
|
|
|
if (cs_tuners->freq_step == 0)
|
2016-02-15 08:19:31 +07:00
|
|
|
goto out;
|
2012-10-26 05:47:42 +07:00
|
|
|
|
|
|
|
/* Check for frequency increase */
|
2016-02-09 10:31:32 +07:00
|
|
|
if (load > dbs_data->up_threshold) {
|
2012-10-26 05:47:42 +07:00
|
|
|
dbs_info->down_skip = 0;
|
|
|
|
|
|
|
|
/* if we are already at full speed then break out early */
|
|
|
|
if (dbs_info->requested_freq == policy->max)
|
2016-02-15 08:19:31 +07:00
|
|
|
goto out;
|
2012-10-26 05:47:42 +07:00
|
|
|
|
2013-03-22 15:03:17 +07:00
|
|
|
dbs_info->requested_freq += get_freq_target(cs_tuners, policy);
|
2007-10-22 14:50:13 +07:00
|
|
|
|
2013-11-08 12:23:52 +07:00
|
|
|
if (dbs_info->requested_freq > policy->max)
|
|
|
|
dbs_info->requested_freq = policy->max;
|
|
|
|
|
2012-10-26 05:47:42 +07:00
|
|
|
__cpufreq_driver_target(policy, dbs_info->requested_freq,
|
|
|
|
CPUFREQ_RELATION_H);
|
2016-02-15 08:19:31 +07:00
|
|
|
goto out;
|
2012-10-26 05:47:42 +07:00
|
|
|
}
|
|
|
|
|
2013-03-06 05:06:29 +07:00
|
|
|
/* if sampling_down_factor is active break out early */
|
2016-02-09 10:31:32 +07:00
|
|
|
if (++dbs_info->down_skip < dbs_data->sampling_down_factor)
|
2016-02-15 08:19:31 +07:00
|
|
|
goto out;
|
2013-03-06 05:06:29 +07:00
|
|
|
dbs_info->down_skip = 0;
|
|
|
|
|
2013-03-06 05:06:40 +07:00
|
|
|
/* Check for frequency decrease */
|
|
|
|
if (load < cs_tuners->down_threshold) {
|
2013-11-07 09:28:50 +07:00
|
|
|
unsigned int freq_target;
|
2012-10-26 05:47:42 +07:00
|
|
|
/*
|
|
|
|
* if we cannot reduce the frequency anymore, break out early
|
|
|
|
*/
|
|
|
|
if (policy->cur == policy->min)
|
2016-02-15 08:19:31 +07:00
|
|
|
goto out;
|
2012-10-26 05:47:42 +07:00
|
|
|
|
2013-11-07 09:28:50 +07:00
|
|
|
freq_target = get_freq_target(cs_tuners, policy);
|
|
|
|
if (dbs_info->requested_freq > freq_target)
|
|
|
|
dbs_info->requested_freq -= freq_target;
|
|
|
|
else
|
|
|
|
dbs_info->requested_freq = policy->min;
|
2013-02-28 12:38:01 +07:00
|
|
|
|
2012-10-26 05:47:42 +07:00
|
|
|
__cpufreq_driver_target(policy, dbs_info->requested_freq,
|
2013-02-28 12:38:02 +07:00
|
|
|
CPUFREQ_RELATION_L);
|
2012-10-26 05:47:42 +07:00
|
|
|
}
|
2015-07-18 13:01:00 +07:00
|
|
|
|
2016-02-15 08:19:31 +07:00
|
|
|
out:
|
2016-02-15 08:22:13 +07:00
|
|
|
return dbs_data->sampling_rate;
|
2012-12-27 21:55:41 +07:00
|
|
|
}
|
|
|
|
|
2012-10-26 05:47:42 +07:00
|
|
|
static int dbs_cpufreq_notifier(struct notifier_block *nb, unsigned long val,
|
2016-02-05 09:16:08 +07:00
|
|
|
void *data);
|
2007-10-22 14:50:13 +07:00
|
|
|
|
2015-06-03 17:27:11 +07:00
|
|
|
static struct notifier_block cs_cpufreq_notifier_block = {
|
|
|
|
.notifier_call = dbs_cpufreq_notifier,
|
|
|
|
};
|
|
|
|
|
2005-06-01 09:03:47 +07:00
|
|
|
/************************** sysfs interface ************************/
|
2016-02-07 22:05:07 +07:00
|
|
|
static struct dbs_governor cs_dbs_gov;
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
static ssize_t store_sampling_down_factor(struct dbs_data *dbs_data,
|
|
|
|
const char *buf, size_t count)
|
2005-06-01 09:03:47 +07:00
|
|
|
{
|
|
|
|
unsigned int input;
|
|
|
|
int ret;
|
2009-01-18 13:39:51 +07:00
|
|
|
ret = sscanf(buf, "%u", &input);
|
2009-02-14 02:02:34 +07:00
|
|
|
|
2006-03-22 16:54:10 +07:00
|
|
|
if (ret != 1 || input > MAX_SAMPLING_DOWN_FACTOR || input < 1)
|
2005-06-01 09:03:47 +07:00
|
|
|
return -EINVAL;
|
|
|
|
|
2016-02-09 10:31:32 +07:00
|
|
|
dbs_data->sampling_down_factor = input;
|
2005-06-01 09:03:47 +07:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
static ssize_t store_up_threshold(struct dbs_data *dbs_data, const char *buf,
|
|
|
|
size_t count)
|
2005-06-01 09:03:47 +07:00
|
|
|
{
|
2013-03-27 22:58:58 +07:00
|
|
|
struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
|
2005-06-01 09:03:47 +07:00
|
|
|
unsigned int input;
|
|
|
|
int ret;
|
2009-01-18 13:39:51 +07:00
|
|
|
ret = sscanf(buf, "%u", &input);
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
if (ret != 1 || input > 100 || input <= cs_tuners->down_threshold)
|
2005-06-01 09:03:47 +07:00
|
|
|
return -EINVAL;
|
|
|
|
|
2016-02-09 10:31:32 +07:00
|
|
|
dbs_data->up_threshold = input;
|
2005-06-01 09:03:47 +07:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
static ssize_t store_down_threshold(struct dbs_data *dbs_data, const char *buf,
|
|
|
|
size_t count)
|
2005-06-01 09:03:47 +07:00
|
|
|
{
|
2013-03-27 22:58:58 +07:00
|
|
|
struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
|
2005-06-01 09:03:47 +07:00
|
|
|
unsigned int input;
|
|
|
|
int ret;
|
2009-01-18 13:39:51 +07:00
|
|
|
ret = sscanf(buf, "%u", &input);
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2009-02-14 02:02:34 +07:00
|
|
|
/* cannot be lower than 11 otherwise freq will not fall */
|
|
|
|
if (ret != 1 || input < 11 || input > 100 ||
|
2016-02-09 10:31:32 +07:00
|
|
|
input >= dbs_data->up_threshold)
|
2005-06-01 09:03:47 +07:00
|
|
|
return -EINVAL;
|
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
cs_tuners->down_threshold = input;
|
2005-06-01 09:03:47 +07:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2013-08-05 13:58:02 +07:00
|
|
|
static ssize_t store_ignore_nice_load(struct dbs_data *dbs_data,
|
|
|
|
const char *buf, size_t count)
|
2005-06-01 09:03:47 +07:00
|
|
|
{
|
2016-02-18 08:26:55 +07:00
|
|
|
unsigned int input;
|
2005-06-01 09:03:47 +07:00
|
|
|
int ret;
|
|
|
|
|
2007-10-23 03:49:09 +07:00
|
|
|
ret = sscanf(buf, "%u", &input);
|
|
|
|
if (ret != 1)
|
2005-06-01 09:03:47 +07:00
|
|
|
return -EINVAL;
|
|
|
|
|
2007-10-23 03:49:09 +07:00
|
|
|
if (input > 1)
|
2005-06-01 09:03:47 +07:00
|
|
|
input = 1;
|
2007-10-23 03:49:09 +07:00
|
|
|
|
2016-02-09 10:31:32 +07:00
|
|
|
if (input == dbs_data->ignore_nice_load) /* nothing to do */
|
2005-06-01 09:03:47 +07:00
|
|
|
return count;
|
2011-03-04 03:31:27 +07:00
|
|
|
|
2016-02-09 10:31:32 +07:00
|
|
|
dbs_data->ignore_nice_load = input;
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2009-02-14 02:02:34 +07:00
|
|
|
/* we need to re-evaluate prev_cpu_idle */
|
2016-02-18 08:26:55 +07:00
|
|
|
gov_update_cpu_data(&cs_dbs_gov, dbs_data);
|
|
|
|
|
2005-06-01 09:03:47 +07:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
static ssize_t store_freq_step(struct dbs_data *dbs_data, const char *buf,
|
|
|
|
size_t count)
|
2005-06-01 09:03:47 +07:00
|
|
|
{
|
2013-03-27 22:58:58 +07:00
|
|
|
struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
|
2005-06-01 09:03:47 +07:00
|
|
|
unsigned int input;
|
|
|
|
int ret;
|
2007-10-23 03:49:09 +07:00
|
|
|
ret = sscanf(buf, "%u", &input);
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2007-10-23 03:49:09 +07:00
|
|
|
if (ret != 1)
|
2005-06-01 09:03:47 +07:00
|
|
|
return -EINVAL;
|
|
|
|
|
2007-10-23 03:49:09 +07:00
|
|
|
if (input > 100)
|
2005-06-01 09:03:47 +07:00
|
|
|
input = 100;
|
2007-10-23 03:49:09 +07:00
|
|
|
|
2012-10-26 05:47:42 +07:00
|
|
|
/*
|
|
|
|
* no need to test here if freq_step is zero as the user might actually
|
|
|
|
* want this, they would be crazy though :)
|
|
|
|
*/
|
2013-03-27 22:58:58 +07:00
|
|
|
cs_tuners->freq_step = input;
|
2005-06-01 09:03:47 +07:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
cpufreq: governor: New sysfs show/store callbacks for governor tunables
The ondemand and conservative governors use the global-attr or freq-attr
structures to represent sysfs attributes corresponding to their tunables
(which of them is actually used depends on whether or not different
policy objects can use the same governor with different tunables at the
same time and, consequently, on where those attributes are located in
sysfs).
Unfortunately, in the freq-attr case, the standard cpufreq show/store
sysfs attribute callbacks are applied to the governor tunable attributes
and they always acquire the policy->rwsem lock before carrying out the
operation. That may lead to an ABBA deadlock if governor tunable
attributes are removed under policy->rwsem while one of them is being
accessed concurrently (if sysfs attributes removal wins the race, it
will wait for the access to complete with policy->rwsem held while the
attribute callback will block on policy->rwsem indefinitely).
We attempted to address this issue by dropping policy->rwsem around
governor tunable attributes removal (that is, around invocations of the
->governor callback with the event arg equal to CPUFREQ_GOV_POLICY_EXIT)
in cpufreq_set_policy(), but that opened up race conditions that had not
been possible with policy->rwsem held all the time. Therefore
policy->rwsem cannot be dropped in cpufreq_set_policy() at any point,
but the deadlock situation described above must be avoided too.
To that end, use the observation that in principle governor tunables may
be represented by the same data type regardless of whether the governor
is system-wide or per-policy and introduce a new structure, struct
governor_attr, for representing them and new corresponding macros for
creating show/store sysfs callbacks for them. Also make their parent
kobject use a new kobject type whose default show/store callbacks are
not related to the standard core cpufreq ones in any way (and they don't
acquire policy->rwsem in particular).
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Juri Lelli <juri.lelli@arm.com>
Tested-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
[ rjw: Subject & changelog + rebase ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-02-09 10:31:33 +07:00
|
|
|
gov_show_one_common(sampling_rate);
|
|
|
|
gov_show_one_common(sampling_down_factor);
|
|
|
|
gov_show_one_common(up_threshold);
|
|
|
|
gov_show_one_common(ignore_nice_load);
|
|
|
|
gov_show_one_common(min_sampling_rate);
|
|
|
|
gov_show_one(cs, down_threshold);
|
|
|
|
gov_show_one(cs, freq_step);
|
|
|
|
|
|
|
|
gov_attr_rw(sampling_rate);
|
|
|
|
gov_attr_rw(sampling_down_factor);
|
|
|
|
gov_attr_rw(up_threshold);
|
|
|
|
gov_attr_rw(ignore_nice_load);
|
|
|
|
gov_attr_ro(min_sampling_rate);
|
|
|
|
gov_attr_rw(down_threshold);
|
|
|
|
gov_attr_rw(freq_step);
|
|
|
|
|
|
|
|
static struct attribute *cs_attributes[] = {
|
|
|
|
&min_sampling_rate.attr,
|
|
|
|
&sampling_rate.attr,
|
|
|
|
&sampling_down_factor.attr,
|
|
|
|
&up_threshold.attr,
|
|
|
|
&down_threshold.attr,
|
|
|
|
&ignore_nice_load.attr,
|
|
|
|
&freq_step.attr,
|
2005-06-01 09:03:47 +07:00
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
/************************** sysfs end ************************/
|
|
|
|
|
2016-02-19 00:40:14 +07:00
|
|
|
static struct policy_dbs_info *cs_alloc(void)
|
|
|
|
{
|
|
|
|
struct cs_policy_dbs_info *dbs_info;
|
|
|
|
|
|
|
|
dbs_info = kzalloc(sizeof(*dbs_info), GFP_KERNEL);
|
|
|
|
return dbs_info ? &dbs_info->policy_dbs : NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cs_free(struct policy_dbs_info *policy_dbs)
|
|
|
|
{
|
|
|
|
kfree(to_dbs_info(policy_dbs));
|
|
|
|
}
|
|
|
|
|
2015-06-03 17:27:11 +07:00
|
|
|
static int cs_init(struct dbs_data *dbs_data, bool notify)
|
2013-03-27 22:58:58 +07:00
|
|
|
{
|
|
|
|
struct cs_dbs_tuners *tuners;
|
|
|
|
|
2013-08-07 00:23:06 +07:00
|
|
|
tuners = kzalloc(sizeof(*tuners), GFP_KERNEL);
|
2013-03-27 22:58:58 +07:00
|
|
|
if (!tuners) {
|
|
|
|
pr_err("%s: kzalloc failed\n", __func__);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
tuners->down_threshold = DEF_FREQUENCY_DOWN_THRESHOLD;
|
2013-03-22 15:03:17 +07:00
|
|
|
tuners->freq_step = DEF_FREQUENCY_STEP;
|
2016-02-09 10:31:32 +07:00
|
|
|
dbs_data->up_threshold = DEF_FREQUENCY_UP_THRESHOLD;
|
|
|
|
dbs_data->sampling_down_factor = DEF_SAMPLING_DOWN_FACTOR;
|
|
|
|
dbs_data->ignore_nice_load = 0;
|
2013-03-27 22:58:58 +07:00
|
|
|
|
|
|
|
dbs_data->tuners = tuners;
|
|
|
|
dbs_data->min_sampling_rate = MIN_SAMPLING_RATE_RATIO *
|
|
|
|
jiffies_to_usecs(10);
|
2015-06-03 17:27:11 +07:00
|
|
|
|
|
|
|
if (notify)
|
|
|
|
cpufreq_register_notifier(&cs_cpufreq_notifier_block,
|
|
|
|
CPUFREQ_TRANSITION_NOTIFIER);
|
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-06-03 17:27:11 +07:00
|
|
|
static void cs_exit(struct dbs_data *dbs_data, bool notify)
|
2013-03-27 22:58:58 +07:00
|
|
|
{
|
2015-06-03 17:27:11 +07:00
|
|
|
if (notify)
|
|
|
|
cpufreq_unregister_notifier(&cs_cpufreq_notifier_block,
|
|
|
|
CPUFREQ_TRANSITION_NOTIFIER);
|
|
|
|
|
2013-03-27 22:58:58 +07:00
|
|
|
kfree(dbs_data->tuners);
|
|
|
|
}
|
|
|
|
|
2016-02-18 08:21:21 +07:00
|
|
|
static void cs_start(struct cpufreq_policy *policy)
|
|
|
|
{
|
2016-02-19 00:40:14 +07:00
|
|
|
struct cs_policy_dbs_info *dbs_info = to_dbs_info(policy->governor_data);
|
2016-02-18 08:21:21 +07:00
|
|
|
|
|
|
|
dbs_info->down_skip = 0;
|
|
|
|
dbs_info->requested_freq = policy->cur;
|
|
|
|
}
|
|
|
|
|
2012-10-26 05:47:42 +07:00
|
|
|
define_get_cpu_dbs_routines(cs_cpu_dbs_info);
|
2009-02-14 02:02:34 +07:00
|
|
|
|
2016-02-07 22:05:07 +07:00
|
|
|
static struct dbs_governor cs_dbs_gov = {
|
2016-02-05 09:16:08 +07:00
|
|
|
.gov = {
|
|
|
|
.name = "conservative",
|
2016-02-07 22:07:51 +07:00
|
|
|
.governor = cpufreq_governor_dbs,
|
2016-02-05 09:16:08 +07:00
|
|
|
.max_transition_latency = TRANSITION_LATENCY_LIMIT,
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
},
|
cpufreq: governor: New sysfs show/store callbacks for governor tunables
The ondemand and conservative governors use the global-attr or freq-attr
structures to represent sysfs attributes corresponding to their tunables
(which of them is actually used depends on whether or not different
policy objects can use the same governor with different tunables at the
same time and, consequently, on where those attributes are located in
sysfs).
Unfortunately, in the freq-attr case, the standard cpufreq show/store
sysfs attribute callbacks are applied to the governor tunable attributes
and they always acquire the policy->rwsem lock before carrying out the
operation. That may lead to an ABBA deadlock if governor tunable
attributes are removed under policy->rwsem while one of them is being
accessed concurrently (if sysfs attributes removal wins the race, it
will wait for the access to complete with policy->rwsem held while the
attribute callback will block on policy->rwsem indefinitely).
We attempted to address this issue by dropping policy->rwsem around
governor tunable attributes removal (that is, around invocations of the
->governor callback with the event arg equal to CPUFREQ_GOV_POLICY_EXIT)
in cpufreq_set_policy(), but that opened up race conditions that had not
been possible with policy->rwsem held all the time. Therefore
policy->rwsem cannot be dropped in cpufreq_set_policy() at any point,
but the deadlock situation described above must be avoided too.
To that end, use the observation that in principle governor tunables may
be represented by the same data type regardless of whether the governor
is system-wide or per-policy and introduce a new structure, struct
governor_attr, for representing them and new corresponding macros for
creating show/store sysfs callbacks for them. Also make their parent
kobject use a new kobject type whose default show/store callbacks are
not related to the standard core cpufreq ones in any way (and they don't
acquire policy->rwsem in particular).
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Juri Lelli <juri.lelli@arm.com>
Tested-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
[ rjw: Subject & changelog + rebase ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-02-09 10:31:33 +07:00
|
|
|
.kobj_type = { .default_attrs = cs_attributes },
|
2012-10-26 05:47:42 +07:00
|
|
|
.get_cpu_cdbs = get_cpu_cdbs,
|
|
|
|
.gov_dbs_timer = cs_dbs_timer,
|
2016-02-19 00:40:14 +07:00
|
|
|
.alloc = cs_alloc,
|
|
|
|
.free = cs_free,
|
2013-03-27 22:58:58 +07:00
|
|
|
.init = cs_init,
|
|
|
|
.exit = cs_exit,
|
2016-02-18 08:21:21 +07:00
|
|
|
.start = cs_start,
|
2012-10-26 05:47:42 +07:00
|
|
|
};
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2016-02-07 22:05:07 +07:00
|
|
|
#define CPU_FREQ_GOV_CONSERVATIVE (&cs_dbs_gov.gov)
|
2016-02-05 09:16:08 +07:00
|
|
|
|
|
|
|
static int dbs_cpufreq_notifier(struct notifier_block *nb, unsigned long val,
|
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
struct cpufreq_freqs *freq = data;
|
|
|
|
struct cpufreq_policy *policy = cpufreq_cpu_get_raw(freq->cpu);
|
2016-02-19 00:40:14 +07:00
|
|
|
struct cs_policy_dbs_info *dbs_info;
|
2016-02-05 09:16:08 +07:00
|
|
|
|
|
|
|
if (!policy)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* policy isn't governed by conservative governor */
|
|
|
|
if (policy->governor != CPU_FREQ_GOV_CONSERVATIVE)
|
|
|
|
return 0;
|
|
|
|
|
2016-02-19 00:40:14 +07:00
|
|
|
dbs_info = to_dbs_info(policy->governor_data);
|
2016-02-05 09:16:08 +07:00
|
|
|
/*
|
|
|
|
* we only care if our internally tracked freq moves outside the 'valid'
|
|
|
|
* ranges of frequency available to us otherwise we do not change it
|
|
|
|
*/
|
|
|
|
if (dbs_info->requested_freq > policy->max
|
|
|
|
|| dbs_info->requested_freq < policy->min)
|
|
|
|
dbs_info->requested_freq = freq->new;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-06-01 09:03:47 +07:00
|
|
|
static int __init cpufreq_gov_dbs_init(void)
|
|
|
|
{
|
2016-02-05 09:16:08 +07:00
|
|
|
return cpufreq_register_governor(CPU_FREQ_GOV_CONSERVATIVE);
|
2005-06-01 09:03:47 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit cpufreq_gov_dbs_exit(void)
|
|
|
|
{
|
2016-02-05 09:16:08 +07:00
|
|
|
cpufreq_unregister_governor(CPU_FREQ_GOV_CONSERVATIVE);
|
2005-06-01 09:03:47 +07:00
|
|
|
}
|
|
|
|
|
2009-02-14 02:01:01 +07:00
|
|
|
MODULE_AUTHOR("Alexander Clouter <alex@digriz.org.uk>");
|
2009-01-18 13:39:51 +07:00
|
|
|
MODULE_DESCRIPTION("'cpufreq_conservative' - A dynamic cpufreq governor for "
|
2005-06-01 09:03:47 +07:00
|
|
|
"Low Latency Frequency Transition capable processors "
|
|
|
|
"optimised for use in a battery environment");
|
2009-01-18 13:39:51 +07:00
|
|
|
MODULE_LICENSE("GPL");
|
2005-06-01 09:03:47 +07:00
|
|
|
|
2008-01-18 06:21:08 +07:00
|
|
|
#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE
|
2016-02-05 08:37:42 +07:00
|
|
|
struct cpufreq_governor *cpufreq_default_governor(void)
|
|
|
|
{
|
2016-02-05 09:16:08 +07:00
|
|
|
return CPU_FREQ_GOV_CONSERVATIVE;
|
2016-02-05 08:37:42 +07:00
|
|
|
}
|
|
|
|
|
2008-01-18 06:21:08 +07:00
|
|
|
fs_initcall(cpufreq_gov_dbs_init);
|
|
|
|
#else
|
2005-06-01 09:03:47 +07:00
|
|
|
module_init(cpufreq_gov_dbs_init);
|
2008-01-18 06:21:08 +07:00
|
|
|
#endif
|
2005-06-01 09:03:47 +07:00
|
|
|
module_exit(cpufreq_gov_dbs_exit);
|