License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 21:07:57 +07:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2013-10-18 00:21:36 +07:00
|
|
|
#ifndef __LINUX_GPIO_DRIVER_H
|
|
|
|
#define __LINUX_GPIO_DRIVER_H
|
|
|
|
|
2015-10-20 16:10:38 +07:00
|
|
|
#include <linux/device.h>
|
2013-10-18 00:21:36 +07:00
|
|
|
#include <linux/types.h>
|
2014-03-25 16:40:18 +07:00
|
|
|
#include <linux/irq.h>
|
|
|
|
#include <linux/irqchip/chained_irq.h>
|
|
|
|
#include <linux/irqdomain.h>
|
gpiolib: irqchip: use different lockdep class for each gpio irqchip
Since IRQ chip helpers were introduced drivers lose ability to
register separate lockdep classes for each registered GPIO IRQ
chip and the gpiolib now is using shared lockdep class for
all GPIO IRQ chips (gpiochip_irq_lock_class).
As result, lockdep will produce warning when there are min two
stacked GPIO chips and all of them are interrupt controllers.
HW configuration which generates lockdep warning (TI dra7-evm):
[SOC GPIO bankA.gpioX]
<- irq - [pcf875x.gpioY]
<- irq - DevZ.enable_irq_wake(pcf_gpioY_irq);
The issue was reported in [1] and discussed [2].
=============================================
[ INFO: possible recursive locking detected ]
4.2.0-rc6-00013-g5d050ed-dirty #55 Not tainted
---------------------------------------------
sh/63 is trying to acquire lock:
(class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
but task is already holding lock:
(class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
----
lock(class);
lock(class);
*** DEADLOCK ***
May be due to missing lock nesting notation
7 locks held by sh/63:
#0: (sb_writers#4){.+.+.+}, at: [<c016bbb8>] vfs_write+0x13c/0x164
#1: (&of->mutex){+.+.+.}, at: [<c01debf4>] kernfs_fop_write+0x4c/0x1a0
#2: (s_active#36){.+.+.+}, at: [<c01debfc>] kernfs_fop_write+0x54/0x1a0
#3: (pm_mutex){+.+.+.}, at: [<c009758c>] pm_suspend+0xec/0x4c4
#4: (&dev->mutex){......}, at: [<c03f77f8>] __device_suspend+0xd4/0x398
#5: (&gpio->lock){+.+.+.}, at: [<c009b940>] __irq_get_desc_lock+0x74/0x94
#6: (class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
stack backtrace:
CPU: 0 PID: 63 Comm: sh Not tainted 4.2.0-rc6-00013-g5d050ed-dirty #55
Hardware name: Generic DRA74X (Flattened Device Tree)
[<c0016e24>] (unwind_backtrace) from [<c0013338>] (show_stack+0x10/0x14)
[<c0013338>] (show_stack) from [<c05f6b24>] (dump_stack+0x84/0x9c)
[<c05f6b24>] (dump_stack) from [<c00903f4>] (__lock_acquire+0x19c0/0x1e20)
[<c00903f4>] (__lock_acquire) from [<c0091098>] (lock_acquire+0xa8/0x128)
[<c0091098>] (lock_acquire) from [<c05fd61c>] (_raw_spin_lock_irqsave+0x38/0x4c)
[<c05fd61c>] (_raw_spin_lock_irqsave) from [<c009b91c>] (__irq_get_desc_lock+0x50/0x94)
[<c009b91c>] (__irq_get_desc_lock) from [<c009c4f4>] (irq_set_irq_wake+0x20/0xfc)
[<c009c4f4>] (irq_set_irq_wake) from [<c0393ac4>] (pcf857x_irq_set_wake+0x24/0x54)
[<c0393ac4>] (pcf857x_irq_set_wake) from [<c009c560>] (irq_set_irq_wake+0x8c/0xfc)
[<c009c560>] (irq_set_irq_wake) from [<c04a02ac>] (gpio_keys_suspend+0x70/0xd4)
[<c04a02ac>] (gpio_keys_suspend) from [<c03f6a00>] (dpm_run_callback+0x50/0x124)
[<c03f6a00>] (dpm_run_callback) from [<c03f7830>] (__device_suspend+0x10c/0x398)
[<c03f7830>] (__device_suspend) from [<c03f90f0>] (dpm_suspend+0x134/0x2f4)
[<c03f90f0>] (dpm_suspend) from [<c0096e20>] (suspend_devices_and_enter+0xa8/0x728)
[<c0096e20>] (suspend_devices_and_enter) from [<c00977cc>] (pm_suspend+0x32c/0x4c4)
[<c00977cc>] (pm_suspend) from [<c0096060>] (state_store+0x64/0xb8)
[<c0096060>] (state_store) from [<c01dec64>] (kernfs_fop_write+0xbc/0x1a0)
[<c01dec64>] (kernfs_fop_write) from [<c016b280>] (__vfs_write+0x20/0xd8)
[<c016b280>] (__vfs_write) from [<c016bb0c>] (vfs_write+0x90/0x164)
[<c016bb0c>] (vfs_write) from [<c016c330>] (SyS_write+0x44/0x9c)
[<c016c330>] (SyS_write) from [<c000f500>] (ret_fast_syscall+0x0/0x54)
Lets fix it by using separate lockdep class for each registered GPIO
IRQ Chip. This is done by wrapping gpiochip_irqchip_add call into macros.
The implementation of this patch inspired by solution done by Nicolas
Boichat for regmap [3]
[1] http://www.spinics.net/lists/linux-gpio/msg05844.html
[2] http://www.spinics.net/lists/linux-gpio/msg06021.html
[3] http://www.spinics.net/lists/arm-kernel/msg429834.html
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roger Quadros <rogerq@ti.com>
Reported-by: Roger Quadros <rogerq@ti.com>
Tested-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2015-08-17 19:35:23 +07:00
|
|
|
#include <linux/lockdep.h>
|
2015-03-18 07:56:17 +07:00
|
|
|
#include <linux/pinctrl/pinctrl.h>
|
2017-01-23 19:34:34 +07:00
|
|
|
#include <linux/pinctrl/pinconf-generic.h>
|
2013-10-18 00:21:36 +07:00
|
|
|
|
|
|
|
struct gpio_desc;
|
2013-11-25 16:34:24 +07:00
|
|
|
struct of_phandle_args;
|
|
|
|
struct device_node;
|
2013-10-28 21:06:23 +07:00
|
|
|
struct seq_file;
|
2015-10-20 16:10:38 +07:00
|
|
|
struct gpio_device;
|
2016-09-13 05:16:31 +07:00
|
|
|
struct module;
|
2013-10-18 00:21:36 +07:00
|
|
|
|
2014-02-09 15:43:54 +07:00
|
|
|
#ifdef CONFIG_GPIOLIB
|
|
|
|
|
2017-11-08 01:15:45 +07:00
|
|
|
#ifdef CONFIG_GPIOLIB_IRQCHIP
|
|
|
|
/**
|
|
|
|
* struct gpio_irq_chip - GPIO interrupt controller
|
|
|
|
*/
|
|
|
|
struct gpio_irq_chip {
|
2017-11-08 01:15:46 +07:00
|
|
|
/**
|
|
|
|
* @chip:
|
|
|
|
*
|
|
|
|
* GPIO IRQ chip implementation, provided by GPIO driver.
|
|
|
|
*/
|
|
|
|
struct irq_chip *chip;
|
|
|
|
|
2017-11-08 01:15:47 +07:00
|
|
|
/**
|
|
|
|
* @domain:
|
|
|
|
*
|
|
|
|
* Interrupt translation domain; responsible for mapping between GPIO
|
|
|
|
* hwirq number and Linux IRQ number.
|
|
|
|
*/
|
|
|
|
struct irq_domain *domain;
|
|
|
|
|
2017-11-08 01:15:45 +07:00
|
|
|
/**
|
|
|
|
* @domain_ops:
|
|
|
|
*
|
|
|
|
* Table of interrupt domain operations for this IRQ chip.
|
|
|
|
*/
|
|
|
|
const struct irq_domain_ops *domain_ops;
|
|
|
|
|
2017-11-08 01:15:48 +07:00
|
|
|
/**
|
|
|
|
* @handler:
|
|
|
|
*
|
|
|
|
* The IRQ handler to use (often a predefined IRQ core function) for
|
|
|
|
* GPIO IRQs, provided by GPIO driver.
|
|
|
|
*/
|
|
|
|
irq_flow_handler_t handler;
|
|
|
|
|
2017-11-08 01:15:49 +07:00
|
|
|
/**
|
|
|
|
* @default_type:
|
|
|
|
*
|
|
|
|
* Default IRQ triggering type applied during GPIO driver
|
|
|
|
* initialization, provided by GPIO driver.
|
|
|
|
*/
|
|
|
|
unsigned int default_type;
|
|
|
|
|
2017-11-08 01:15:53 +07:00
|
|
|
/**
|
|
|
|
* @lock_key:
|
|
|
|
*
|
|
|
|
* Per GPIO IRQ chip lockdep class.
|
|
|
|
*/
|
|
|
|
struct lock_class_key *lock_key;
|
|
|
|
|
2017-11-08 01:15:45 +07:00
|
|
|
/**
|
|
|
|
* @parent_handler:
|
|
|
|
*
|
|
|
|
* The interrupt handler for the GPIO chip's parent interrupts, may be
|
|
|
|
* NULL if the parent interrupts are nested rather than cascaded.
|
|
|
|
*/
|
|
|
|
irq_flow_handler_t parent_handler;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @parent_handler_data:
|
|
|
|
*
|
|
|
|
* Data associated, and passed to, the handler for the parent
|
|
|
|
* interrupt.
|
|
|
|
*/
|
|
|
|
void *parent_handler_data;
|
2017-11-08 01:15:50 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @num_parents:
|
|
|
|
*
|
|
|
|
* The number of interrupt parents of a GPIO chip.
|
|
|
|
*/
|
|
|
|
unsigned int num_parents;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @parents:
|
|
|
|
*
|
|
|
|
* A list of interrupt parents of a GPIO chip. This is owned by the
|
|
|
|
* driver, so the core will only reference this list, not modify it.
|
|
|
|
*/
|
|
|
|
unsigned int *parents;
|
2017-11-08 01:15:51 +07:00
|
|
|
|
2017-11-08 01:15:54 +07:00
|
|
|
/**
|
|
|
|
* @map:
|
|
|
|
*
|
|
|
|
* A list of interrupt parents for each line of a GPIO chip.
|
|
|
|
*/
|
|
|
|
unsigned int *map;
|
|
|
|
|
2017-11-08 01:15:51 +07:00
|
|
|
/**
|
2017-11-08 01:15:57 +07:00
|
|
|
* @threaded:
|
2017-11-08 01:15:51 +07:00
|
|
|
*
|
2017-11-08 01:15:57 +07:00
|
|
|
* True if set the interrupt handling uses nested threads.
|
2017-11-08 01:15:51 +07:00
|
|
|
*/
|
2017-11-08 01:15:57 +07:00
|
|
|
bool threaded;
|
2017-11-08 01:15:52 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @need_valid_mask:
|
|
|
|
*
|
|
|
|
* If set core allocates @valid_mask with all bits set to one.
|
|
|
|
*/
|
|
|
|
bool need_valid_mask;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @valid_mask:
|
|
|
|
*
|
|
|
|
* If not %NULL holds bitmask of GPIOs which are valid to be included
|
|
|
|
* in IRQ domain of the chip.
|
|
|
|
*/
|
|
|
|
unsigned long *valid_mask;
|
2017-11-08 01:15:58 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @first:
|
|
|
|
*
|
|
|
|
* Required for static IRQ allocation. If set, irq_domain_add_simple()
|
|
|
|
* will allocate and map all IRQs during initialization.
|
|
|
|
*/
|
|
|
|
unsigned int first;
|
2017-11-08 01:15:45 +07:00
|
|
|
};
|
2017-11-08 01:15:46 +07:00
|
|
|
|
|
|
|
static inline struct gpio_irq_chip *to_gpio_irq_chip(struct irq_chip *chip)
|
|
|
|
{
|
|
|
|
return container_of(chip, struct gpio_irq_chip, chip);
|
|
|
|
}
|
2017-11-08 01:15:45 +07:00
|
|
|
#endif
|
|
|
|
|
2013-10-18 00:21:36 +07:00
|
|
|
/**
|
|
|
|
* struct gpio_chip - abstract a GPIO controller
|
2016-02-12 20:48:23 +07:00
|
|
|
* @label: a functional name for the GPIO device, such as a part
|
|
|
|
* number or the name of the SoC IP-block implementing it.
|
2015-10-20 16:10:38 +07:00
|
|
|
* @gpiodev: the internal state holder, opaque struct
|
2015-11-04 15:56:26 +07:00
|
|
|
* @parent: optional parent device providing the GPIOs
|
2013-10-18 00:21:36 +07:00
|
|
|
* @owner: helps prevent removal of modules exporting active GPIOs
|
|
|
|
* @request: optional hook for chip-specific activation, such as
|
|
|
|
* enabling module power and clock; may sleep
|
|
|
|
* @free: optional hook for chip-specific deactivation, such as
|
|
|
|
* disabling module power and clock; may sleep
|
|
|
|
* @get_direction: returns direction for signal "offset", 0=out, 1=in,
|
|
|
|
* (same as GPIOF_DIR_XXX), or negative error
|
|
|
|
* @direction_input: configures signal "offset" as input, or returns error
|
|
|
|
* @direction_output: configures signal "offset" as output, or returns error
|
2015-12-22 21:37:28 +07:00
|
|
|
* @get: returns value for signal "offset", 0=low, 1=high, or negative error
|
2017-10-12 17:40:10 +07:00
|
|
|
* @get_multiple: reads values for multiple signals defined by "mask" and
|
|
|
|
* stores them in "bits", returns 0 on success or negative error
|
2013-10-18 00:21:36 +07:00
|
|
|
* @set: assigns output value for signal "offset"
|
2014-11-04 23:12:06 +07:00
|
|
|
* @set_multiple: assigns output values for multiple signals defined by "mask"
|
2017-01-23 19:34:34 +07:00
|
|
|
* @set_config: optional hook for all kinds of settings. Uses the same
|
|
|
|
* packed config format as generic pinconf.
|
2013-10-18 00:21:36 +07:00
|
|
|
* @to_irq: optional hook supporting non-static gpio_to_irq() mappings;
|
|
|
|
* implementation may not sleep
|
|
|
|
* @dbg_show: optional routine to show contents in debugfs; default code
|
|
|
|
* will be used when this is omitted, but custom code can show extra
|
|
|
|
* state (such as pullup/pulldown configuration).
|
2015-05-13 18:03:21 +07:00
|
|
|
* @base: identifies the first GPIO number handled by this chip;
|
|
|
|
* or, if negative during registration, requests dynamic ID allocation.
|
|
|
|
* DEPRECATION: providing anything non-negative and nailing the base
|
2015-06-15 18:31:33 +07:00
|
|
|
* offset of GPIO chips is deprecated. Please pass -1 as base to
|
2015-05-13 18:03:21 +07:00
|
|
|
* let gpiolib select the chip base in all possible cases. We want to
|
|
|
|
* get rid of the static GPIO number space in the long run.
|
2013-10-18 00:21:36 +07:00
|
|
|
* @ngpio: the number of GPIOs handled by this controller; the last GPIO
|
|
|
|
* handled is (base + ngpio - 1).
|
|
|
|
* @names: if set, must be an array of strings to use as alternative
|
|
|
|
* names for the GPIOs in this chip. Any entry in the array
|
|
|
|
* may be NULL if there is no alias for the GPIO, however the
|
|
|
|
* array must be @ngpio entries long. A name can include a single printk
|
|
|
|
* format specifier for an unsigned int. It is substituted by the actual
|
|
|
|
* number of the gpio.
|
2013-12-04 20:42:46 +07:00
|
|
|
* @can_sleep: flag must be set iff get()/set() methods sleep, as they
|
2014-04-09 18:34:39 +07:00
|
|
|
* must while accessing GPIO expander chips over I2C or SPI. This
|
|
|
|
* implies that if the chip supports IRQs, these IRQs need to be threaded
|
|
|
|
* as the chip access may sleep when e.g. reading out the IRQ status
|
|
|
|
* registers.
|
2015-12-04 20:02:58 +07:00
|
|
|
* @read_reg: reader function for generic GPIO
|
|
|
|
* @write_reg: writer function for generic GPIO
|
2017-10-20 21:31:27 +07:00
|
|
|
* @be_bits: if the generic GPIO has big endian bit order (bit 31 is representing
|
|
|
|
* line 0, bit 30 is line 1 ... bit 0 is line 31) this is set to true by the
|
|
|
|
* generic GPIO core. It is for internal housekeeping only.
|
2015-12-04 20:02:58 +07:00
|
|
|
* @reg_dat: data (in) register for generic GPIO
|
|
|
|
* @reg_set: output set register (out=high) for generic GPIO
|
2016-10-05 03:15:42 +07:00
|
|
|
* @reg_clr: output clear register (out=low) for generic GPIO
|
2015-12-04 20:02:58 +07:00
|
|
|
* @reg_dir: direction setting register for generic GPIO
|
|
|
|
* @bgpio_bits: number of register bits used for a generic GPIO i.e.
|
|
|
|
* <register width> * 8
|
|
|
|
* @bgpio_lock: used to lock chip->bgpio_data. Also, this is needed to keep
|
|
|
|
* shadowed and real data registers writes together.
|
|
|
|
* @bgpio_data: shadowed data register for generic GPIO to clear/set bits
|
|
|
|
* safely.
|
|
|
|
* @bgpio_dir: shadowed direction register for generic GPIO to clear/set
|
|
|
|
* direction safely.
|
2013-10-18 00:21:36 +07:00
|
|
|
*
|
|
|
|
* A gpio_chip can help platforms abstract various sources of GPIOs so
|
|
|
|
* they can all be accessed through a common programing interface.
|
|
|
|
* Example sources would be SOC controllers, FPGAs, multifunction
|
|
|
|
* chips, dedicated GPIO expanders, and so on.
|
|
|
|
*
|
|
|
|
* Each chip controls a number of signals, identified in method calls
|
|
|
|
* by "offset" values in the range 0..(@ngpio - 1). When those signals
|
|
|
|
* are referenced through calls like gpio_get_value(gpio), the offset
|
|
|
|
* is calculated by subtracting @base from the gpio number.
|
|
|
|
*/
|
|
|
|
struct gpio_chip {
|
|
|
|
const char *label;
|
2015-10-20 16:10:38 +07:00
|
|
|
struct gpio_device *gpiodev;
|
2015-11-04 15:56:26 +07:00
|
|
|
struct device *parent;
|
2013-10-18 00:21:36 +07:00
|
|
|
struct module *owner;
|
|
|
|
|
|
|
|
int (*request)(struct gpio_chip *chip,
|
|
|
|
unsigned offset);
|
|
|
|
void (*free)(struct gpio_chip *chip,
|
|
|
|
unsigned offset);
|
|
|
|
int (*get_direction)(struct gpio_chip *chip,
|
|
|
|
unsigned offset);
|
|
|
|
int (*direction_input)(struct gpio_chip *chip,
|
|
|
|
unsigned offset);
|
|
|
|
int (*direction_output)(struct gpio_chip *chip,
|
|
|
|
unsigned offset, int value);
|
|
|
|
int (*get)(struct gpio_chip *chip,
|
|
|
|
unsigned offset);
|
2017-10-12 17:40:10 +07:00
|
|
|
int (*get_multiple)(struct gpio_chip *chip,
|
|
|
|
unsigned long *mask,
|
|
|
|
unsigned long *bits);
|
2013-10-18 00:21:36 +07:00
|
|
|
void (*set)(struct gpio_chip *chip,
|
|
|
|
unsigned offset, int value);
|
2014-11-04 23:12:06 +07:00
|
|
|
void (*set_multiple)(struct gpio_chip *chip,
|
|
|
|
unsigned long *mask,
|
|
|
|
unsigned long *bits);
|
2017-01-23 19:34:34 +07:00
|
|
|
int (*set_config)(struct gpio_chip *chip,
|
|
|
|
unsigned offset,
|
|
|
|
unsigned long config);
|
2013-10-18 00:21:36 +07:00
|
|
|
int (*to_irq)(struct gpio_chip *chip,
|
|
|
|
unsigned offset);
|
|
|
|
|
|
|
|
void (*dbg_show)(struct seq_file *s,
|
|
|
|
struct gpio_chip *chip);
|
|
|
|
int base;
|
|
|
|
u16 ngpio;
|
|
|
|
const char *const *names;
|
2013-12-04 20:42:46 +07:00
|
|
|
bool can_sleep;
|
2013-10-18 00:21:36 +07:00
|
|
|
|
2015-12-04 20:02:58 +07:00
|
|
|
#if IS_ENABLED(CONFIG_GPIO_GENERIC)
|
|
|
|
unsigned long (*read_reg)(void __iomem *reg);
|
|
|
|
void (*write_reg)(void __iomem *reg, unsigned long data);
|
2017-10-20 21:31:27 +07:00
|
|
|
bool be_bits;
|
2015-12-04 20:02:58 +07:00
|
|
|
void __iomem *reg_dat;
|
|
|
|
void __iomem *reg_set;
|
|
|
|
void __iomem *reg_clr;
|
|
|
|
void __iomem *reg_dir;
|
|
|
|
int bgpio_bits;
|
|
|
|
spinlock_t bgpio_lock;
|
|
|
|
unsigned long bgpio_data;
|
|
|
|
unsigned long bgpio_dir;
|
|
|
|
#endif
|
|
|
|
|
2014-03-25 16:40:18 +07:00
|
|
|
#ifdef CONFIG_GPIOLIB_IRQCHIP
|
|
|
|
/*
|
2014-09-05 18:09:25 +07:00
|
|
|
* With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib
|
2014-03-25 16:40:18 +07:00
|
|
|
* to handle IRQs for most practical cases.
|
|
|
|
*/
|
2017-11-08 01:15:45 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @irq:
|
|
|
|
*
|
|
|
|
* Integrates interrupt chip functionality with the GPIO chip. Can be
|
|
|
|
* used to handle IRQs for most practical cases.
|
|
|
|
*/
|
|
|
|
struct gpio_irq_chip irq;
|
2014-03-25 16:40:18 +07:00
|
|
|
#endif
|
|
|
|
|
2013-10-18 00:21:36 +07:00
|
|
|
#if defined(CONFIG_OF_GPIO)
|
|
|
|
/*
|
|
|
|
* If CONFIG_OF is enabled, then all GPIO controllers described in the
|
|
|
|
* device tree automatically may have an OF translation
|
|
|
|
*/
|
2017-07-24 21:57:23 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @of_node:
|
|
|
|
*
|
|
|
|
* Pointer to a device tree node representing this GPIO controller.
|
|
|
|
*/
|
2013-10-18 00:21:36 +07:00
|
|
|
struct device_node *of_node;
|
2017-07-24 21:57:23 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @of_gpio_n_cells:
|
|
|
|
*
|
|
|
|
* Number of cells used to form the GPIO specifier.
|
|
|
|
*/
|
2017-07-24 21:57:28 +07:00
|
|
|
unsigned int of_gpio_n_cells;
|
2017-07-24 21:57:23 +07:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @of_xlate:
|
|
|
|
*
|
|
|
|
* Callback to translate a device tree GPIO specifier into a chip-
|
|
|
|
* relative GPIO number and flags.
|
|
|
|
*/
|
2013-10-18 00:21:36 +07:00
|
|
|
int (*of_xlate)(struct gpio_chip *gc,
|
|
|
|
const struct of_phandle_args *gpiospec, u32 *flags);
|
|
|
|
#endif
|
|
|
|
};
|
|
|
|
|
|
|
|
extern const char *gpiochip_is_requested(struct gpio_chip *chip,
|
|
|
|
unsigned offset);
|
|
|
|
|
|
|
|
/* add/remove chips */
|
2017-11-08 01:15:59 +07:00
|
|
|
extern int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data,
|
|
|
|
struct lock_class_key *lock_key);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* gpiochip_add_data() - register a gpio_chip
|
|
|
|
* @chip: the chip to register, with chip->base initialized
|
|
|
|
* @data: driver-private data associated with this chip
|
|
|
|
*
|
|
|
|
* Context: potentially before irqs will work
|
|
|
|
*
|
|
|
|
* When gpiochip_add_data() is called very early during boot, so that GPIOs
|
|
|
|
* can be freely used, the chip->parent device must be registered before
|
|
|
|
* the gpio framework's arch_initcall(). Otherwise sysfs initialization
|
|
|
|
* for GPIOs will fail rudely.
|
|
|
|
*
|
|
|
|
* gpiochip_add_data() must only be called after gpiolib initialization,
|
|
|
|
* ie after core_initcall().
|
|
|
|
*
|
|
|
|
* If chip->base is negative, this requests dynamic assignment of
|
|
|
|
* a range of valid GPIOs.
|
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* A negative errno if the chip can't be registered, such as because the
|
|
|
|
* chip->base is invalid or already associated with a different chip.
|
|
|
|
* Otherwise it returns zero as a success code.
|
|
|
|
*/
|
|
|
|
#ifdef CONFIG_LOCKDEP
|
|
|
|
#define gpiochip_add_data(chip, data) ({ \
|
|
|
|
static struct lock_class_key key; \
|
|
|
|
gpiochip_add_data_with_key(chip, data, &key); \
|
|
|
|
})
|
|
|
|
#else
|
|
|
|
#define gpiochip_add_data(chip, data) gpiochip_add_data_with_key(chip, data, NULL)
|
|
|
|
#endif
|
|
|
|
|
2015-12-03 21:14:13 +07:00
|
|
|
static inline int gpiochip_add(struct gpio_chip *chip)
|
|
|
|
{
|
|
|
|
return gpiochip_add_data(chip, NULL);
|
|
|
|
}
|
2014-07-05 23:28:50 +07:00
|
|
|
extern void gpiochip_remove(struct gpio_chip *chip);
|
2016-02-15 18:02:09 +07:00
|
|
|
extern int devm_gpiochip_add_data(struct device *dev, struct gpio_chip *chip,
|
|
|
|
void *data);
|
|
|
|
extern void devm_gpiochip_remove(struct device *dev, struct gpio_chip *chip);
|
|
|
|
|
2013-10-18 00:21:36 +07:00
|
|
|
extern struct gpio_chip *gpiochip_find(void *data,
|
|
|
|
int (*match)(struct gpio_chip *chip, void *data));
|
|
|
|
|
|
|
|
/* lock/unlock as IRQ */
|
2014-10-23 15:27:07 +07:00
|
|
|
int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned int offset);
|
|
|
|
void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned int offset);
|
2016-02-12 02:16:45 +07:00
|
|
|
bool gpiochip_line_is_irq(struct gpio_chip *chip, unsigned int offset);
|
2013-10-18 00:21:36 +07:00
|
|
|
|
2016-02-16 21:41:42 +07:00
|
|
|
/* Line status inquiry for drivers */
|
|
|
|
bool gpiochip_line_is_open_drain(struct gpio_chip *chip, unsigned int offset);
|
|
|
|
bool gpiochip_line_is_open_source(struct gpio_chip *chip, unsigned int offset);
|
|
|
|
|
2017-05-23 21:47:29 +07:00
|
|
|
/* Sleep persistence inquiry for drivers */
|
|
|
|
bool gpiochip_line_is_persistent(struct gpio_chip *chip, unsigned int offset);
|
|
|
|
|
2015-12-03 21:14:13 +07:00
|
|
|
/* get driver data */
|
2016-02-11 17:37:48 +07:00
|
|
|
void *gpiochip_get_data(struct gpio_chip *chip);
|
2015-12-03 21:14:13 +07:00
|
|
|
|
2014-02-09 15:43:54 +07:00
|
|
|
struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
|
|
|
|
|
2015-12-04 20:02:58 +07:00
|
|
|
struct bgpio_pdata {
|
|
|
|
const char *label;
|
|
|
|
int base;
|
|
|
|
int ngpio;
|
|
|
|
};
|
|
|
|
|
2016-01-10 04:16:42 +07:00
|
|
|
#if IS_ENABLED(CONFIG_GPIO_GENERIC)
|
|
|
|
|
2015-12-04 20:02:58 +07:00
|
|
|
int bgpio_init(struct gpio_chip *gc, struct device *dev,
|
|
|
|
unsigned long sz, void __iomem *dat, void __iomem *set,
|
|
|
|
void __iomem *clr, void __iomem *dirout, void __iomem *dirin,
|
|
|
|
unsigned long flags);
|
|
|
|
|
|
|
|
#define BGPIOF_BIG_ENDIAN BIT(0)
|
|
|
|
#define BGPIOF_UNREADABLE_REG_SET BIT(1) /* reg_set is unreadable */
|
|
|
|
#define BGPIOF_UNREADABLE_REG_DIR BIT(2) /* reg_dir is unreadable */
|
|
|
|
#define BGPIOF_BIG_ENDIAN_BYTE_ORDER BIT(3)
|
|
|
|
#define BGPIOF_READ_OUTPUT_REG_SET BIT(4) /* reg_set stores output value */
|
|
|
|
#define BGPIOF_NO_OUTPUT BIT(5) /* only input */
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
2014-03-25 16:40:18 +07:00
|
|
|
#ifdef CONFIG_GPIOLIB_IRQCHIP
|
|
|
|
|
2017-11-08 01:15:55 +07:00
|
|
|
int gpiochip_irq_map(struct irq_domain *d, unsigned int irq,
|
|
|
|
irq_hw_number_t hwirq);
|
|
|
|
void gpiochip_irq_unmap(struct irq_domain *d, unsigned int irq);
|
|
|
|
|
2014-03-25 16:40:18 +07:00
|
|
|
void gpiochip_set_chained_irqchip(struct gpio_chip *gpiochip,
|
|
|
|
struct irq_chip *irqchip,
|
2017-04-03 23:05:21 +07:00
|
|
|
unsigned int parent_irq,
|
2014-03-25 16:40:18 +07:00
|
|
|
irq_flow_handler_t parent_handler);
|
|
|
|
|
2016-11-24 16:57:25 +07:00
|
|
|
void gpiochip_set_nested_irqchip(struct gpio_chip *gpiochip,
|
|
|
|
struct irq_chip *irqchip,
|
2017-04-03 23:05:21 +07:00
|
|
|
unsigned int parent_irq);
|
2016-11-24 16:57:25 +07:00
|
|
|
|
2017-01-11 19:37:07 +07:00
|
|
|
int gpiochip_irqchip_add_key(struct gpio_chip *gpiochip,
|
|
|
|
struct irq_chip *irqchip,
|
|
|
|
unsigned int first_irq,
|
|
|
|
irq_flow_handler_t handler,
|
|
|
|
unsigned int type,
|
2017-11-08 01:15:57 +07:00
|
|
|
bool threaded,
|
2017-01-11 19:37:07 +07:00
|
|
|
struct lock_class_key *lock_key);
|
|
|
|
|
2018-01-10 08:58:46 +07:00
|
|
|
bool gpiochip_irqchip_irq_valid(const struct gpio_chip *gpiochip,
|
|
|
|
unsigned int offset);
|
|
|
|
|
2017-01-11 19:37:07 +07:00
|
|
|
#ifdef CONFIG_LOCKDEP
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Lockdep requires that each irqchip instance be created with a
|
|
|
|
* unique key so as to avoid unnecessary warnings. This upfront
|
|
|
|
* boilerplate static inlines provides such a key for each
|
|
|
|
* unique instance.
|
|
|
|
*/
|
|
|
|
static inline int gpiochip_irqchip_add(struct gpio_chip *gpiochip,
|
|
|
|
struct irq_chip *irqchip,
|
|
|
|
unsigned int first_irq,
|
|
|
|
irq_flow_handler_t handler,
|
|
|
|
unsigned int type)
|
|
|
|
{
|
|
|
|
static struct lock_class_key key;
|
|
|
|
|
|
|
|
return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,
|
|
|
|
handler, type, false, &key);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int gpiochip_irqchip_add_nested(struct gpio_chip *gpiochip,
|
gpiolib: irqchip: use different lockdep class for each gpio irqchip
Since IRQ chip helpers were introduced drivers lose ability to
register separate lockdep classes for each registered GPIO IRQ
chip and the gpiolib now is using shared lockdep class for
all GPIO IRQ chips (gpiochip_irq_lock_class).
As result, lockdep will produce warning when there are min two
stacked GPIO chips and all of them are interrupt controllers.
HW configuration which generates lockdep warning (TI dra7-evm):
[SOC GPIO bankA.gpioX]
<- irq - [pcf875x.gpioY]
<- irq - DevZ.enable_irq_wake(pcf_gpioY_irq);
The issue was reported in [1] and discussed [2].
=============================================
[ INFO: possible recursive locking detected ]
4.2.0-rc6-00013-g5d050ed-dirty #55 Not tainted
---------------------------------------------
sh/63 is trying to acquire lock:
(class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
but task is already holding lock:
(class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
----
lock(class);
lock(class);
*** DEADLOCK ***
May be due to missing lock nesting notation
7 locks held by sh/63:
#0: (sb_writers#4){.+.+.+}, at: [<c016bbb8>] vfs_write+0x13c/0x164
#1: (&of->mutex){+.+.+.}, at: [<c01debf4>] kernfs_fop_write+0x4c/0x1a0
#2: (s_active#36){.+.+.+}, at: [<c01debfc>] kernfs_fop_write+0x54/0x1a0
#3: (pm_mutex){+.+.+.}, at: [<c009758c>] pm_suspend+0xec/0x4c4
#4: (&dev->mutex){......}, at: [<c03f77f8>] __device_suspend+0xd4/0x398
#5: (&gpio->lock){+.+.+.}, at: [<c009b940>] __irq_get_desc_lock+0x74/0x94
#6: (class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
stack backtrace:
CPU: 0 PID: 63 Comm: sh Not tainted 4.2.0-rc6-00013-g5d050ed-dirty #55
Hardware name: Generic DRA74X (Flattened Device Tree)
[<c0016e24>] (unwind_backtrace) from [<c0013338>] (show_stack+0x10/0x14)
[<c0013338>] (show_stack) from [<c05f6b24>] (dump_stack+0x84/0x9c)
[<c05f6b24>] (dump_stack) from [<c00903f4>] (__lock_acquire+0x19c0/0x1e20)
[<c00903f4>] (__lock_acquire) from [<c0091098>] (lock_acquire+0xa8/0x128)
[<c0091098>] (lock_acquire) from [<c05fd61c>] (_raw_spin_lock_irqsave+0x38/0x4c)
[<c05fd61c>] (_raw_spin_lock_irqsave) from [<c009b91c>] (__irq_get_desc_lock+0x50/0x94)
[<c009b91c>] (__irq_get_desc_lock) from [<c009c4f4>] (irq_set_irq_wake+0x20/0xfc)
[<c009c4f4>] (irq_set_irq_wake) from [<c0393ac4>] (pcf857x_irq_set_wake+0x24/0x54)
[<c0393ac4>] (pcf857x_irq_set_wake) from [<c009c560>] (irq_set_irq_wake+0x8c/0xfc)
[<c009c560>] (irq_set_irq_wake) from [<c04a02ac>] (gpio_keys_suspend+0x70/0xd4)
[<c04a02ac>] (gpio_keys_suspend) from [<c03f6a00>] (dpm_run_callback+0x50/0x124)
[<c03f6a00>] (dpm_run_callback) from [<c03f7830>] (__device_suspend+0x10c/0x398)
[<c03f7830>] (__device_suspend) from [<c03f90f0>] (dpm_suspend+0x134/0x2f4)
[<c03f90f0>] (dpm_suspend) from [<c0096e20>] (suspend_devices_and_enter+0xa8/0x728)
[<c0096e20>] (suspend_devices_and_enter) from [<c00977cc>] (pm_suspend+0x32c/0x4c4)
[<c00977cc>] (pm_suspend) from [<c0096060>] (state_store+0x64/0xb8)
[<c0096060>] (state_store) from [<c01dec64>] (kernfs_fop_write+0xbc/0x1a0)
[<c01dec64>] (kernfs_fop_write) from [<c016b280>] (__vfs_write+0x20/0xd8)
[<c016b280>] (__vfs_write) from [<c016bb0c>] (vfs_write+0x90/0x164)
[<c016bb0c>] (vfs_write) from [<c016c330>] (SyS_write+0x44/0x9c)
[<c016c330>] (SyS_write) from [<c000f500>] (ret_fast_syscall+0x0/0x54)
Lets fix it by using separate lockdep class for each registered GPIO
IRQ Chip. This is done by wrapping gpiochip_irqchip_add call into macros.
The implementation of this patch inspired by solution done by Nicolas
Boichat for regmap [3]
[1] http://www.spinics.net/lists/linux-gpio/msg05844.html
[2] http://www.spinics.net/lists/linux-gpio/msg06021.html
[3] http://www.spinics.net/lists/arm-kernel/msg429834.html
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roger Quadros <rogerq@ti.com>
Reported-by: Roger Quadros <rogerq@ti.com>
Tested-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2015-08-17 19:35:23 +07:00
|
|
|
struct irq_chip *irqchip,
|
|
|
|
unsigned int first_irq,
|
|
|
|
irq_flow_handler_t handler,
|
2017-01-11 19:37:07 +07:00
|
|
|
unsigned int type)
|
|
|
|
{
|
|
|
|
|
|
|
|
static struct lock_class_key key;
|
|
|
|
|
|
|
|
return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,
|
|
|
|
handler, type, true, &key);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline int gpiochip_irqchip_add(struct gpio_chip *gpiochip,
|
|
|
|
struct irq_chip *irqchip,
|
|
|
|
unsigned int first_irq,
|
|
|
|
irq_flow_handler_t handler,
|
|
|
|
unsigned int type)
|
|
|
|
{
|
|
|
|
return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,
|
|
|
|
handler, type, false, NULL);
|
|
|
|
}
|
gpiolib: irqchip: use different lockdep class for each gpio irqchip
Since IRQ chip helpers were introduced drivers lose ability to
register separate lockdep classes for each registered GPIO IRQ
chip and the gpiolib now is using shared lockdep class for
all GPIO IRQ chips (gpiochip_irq_lock_class).
As result, lockdep will produce warning when there are min two
stacked GPIO chips and all of them are interrupt controllers.
HW configuration which generates lockdep warning (TI dra7-evm):
[SOC GPIO bankA.gpioX]
<- irq - [pcf875x.gpioY]
<- irq - DevZ.enable_irq_wake(pcf_gpioY_irq);
The issue was reported in [1] and discussed [2].
=============================================
[ INFO: possible recursive locking detected ]
4.2.0-rc6-00013-g5d050ed-dirty #55 Not tainted
---------------------------------------------
sh/63 is trying to acquire lock:
(class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
but task is already holding lock:
(class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
----
lock(class);
lock(class);
*** DEADLOCK ***
May be due to missing lock nesting notation
7 locks held by sh/63:
#0: (sb_writers#4){.+.+.+}, at: [<c016bbb8>] vfs_write+0x13c/0x164
#1: (&of->mutex){+.+.+.}, at: [<c01debf4>] kernfs_fop_write+0x4c/0x1a0
#2: (s_active#36){.+.+.+}, at: [<c01debfc>] kernfs_fop_write+0x54/0x1a0
#3: (pm_mutex){+.+.+.}, at: [<c009758c>] pm_suspend+0xec/0x4c4
#4: (&dev->mutex){......}, at: [<c03f77f8>] __device_suspend+0xd4/0x398
#5: (&gpio->lock){+.+.+.}, at: [<c009b940>] __irq_get_desc_lock+0x74/0x94
#6: (class){......}, at: [<c009b91c>] __irq_get_desc_lock+0x50/0x94
stack backtrace:
CPU: 0 PID: 63 Comm: sh Not tainted 4.2.0-rc6-00013-g5d050ed-dirty #55
Hardware name: Generic DRA74X (Flattened Device Tree)
[<c0016e24>] (unwind_backtrace) from [<c0013338>] (show_stack+0x10/0x14)
[<c0013338>] (show_stack) from [<c05f6b24>] (dump_stack+0x84/0x9c)
[<c05f6b24>] (dump_stack) from [<c00903f4>] (__lock_acquire+0x19c0/0x1e20)
[<c00903f4>] (__lock_acquire) from [<c0091098>] (lock_acquire+0xa8/0x128)
[<c0091098>] (lock_acquire) from [<c05fd61c>] (_raw_spin_lock_irqsave+0x38/0x4c)
[<c05fd61c>] (_raw_spin_lock_irqsave) from [<c009b91c>] (__irq_get_desc_lock+0x50/0x94)
[<c009b91c>] (__irq_get_desc_lock) from [<c009c4f4>] (irq_set_irq_wake+0x20/0xfc)
[<c009c4f4>] (irq_set_irq_wake) from [<c0393ac4>] (pcf857x_irq_set_wake+0x24/0x54)
[<c0393ac4>] (pcf857x_irq_set_wake) from [<c009c560>] (irq_set_irq_wake+0x8c/0xfc)
[<c009c560>] (irq_set_irq_wake) from [<c04a02ac>] (gpio_keys_suspend+0x70/0xd4)
[<c04a02ac>] (gpio_keys_suspend) from [<c03f6a00>] (dpm_run_callback+0x50/0x124)
[<c03f6a00>] (dpm_run_callback) from [<c03f7830>] (__device_suspend+0x10c/0x398)
[<c03f7830>] (__device_suspend) from [<c03f90f0>] (dpm_suspend+0x134/0x2f4)
[<c03f90f0>] (dpm_suspend) from [<c0096e20>] (suspend_devices_and_enter+0xa8/0x728)
[<c0096e20>] (suspend_devices_and_enter) from [<c00977cc>] (pm_suspend+0x32c/0x4c4)
[<c00977cc>] (pm_suspend) from [<c0096060>] (state_store+0x64/0xb8)
[<c0096060>] (state_store) from [<c01dec64>] (kernfs_fop_write+0xbc/0x1a0)
[<c01dec64>] (kernfs_fop_write) from [<c016b280>] (__vfs_write+0x20/0xd8)
[<c016b280>] (__vfs_write) from [<c016bb0c>] (vfs_write+0x90/0x164)
[<c016bb0c>] (vfs_write) from [<c016c330>] (SyS_write+0x44/0x9c)
[<c016c330>] (SyS_write) from [<c000f500>] (ret_fast_syscall+0x0/0x54)
Lets fix it by using separate lockdep class for each registered GPIO
IRQ Chip. This is done by wrapping gpiochip_irqchip_add call into macros.
The implementation of this patch inspired by solution done by Nicolas
Boichat for regmap [3]
[1] http://www.spinics.net/lists/linux-gpio/msg05844.html
[2] http://www.spinics.net/lists/linux-gpio/msg06021.html
[3] http://www.spinics.net/lists/arm-kernel/msg429834.html
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roger Quadros <rogerq@ti.com>
Reported-by: Roger Quadros <rogerq@ti.com>
Tested-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2015-08-17 19:35:23 +07:00
|
|
|
|
2016-11-24 16:57:25 +07:00
|
|
|
static inline int gpiochip_irqchip_add_nested(struct gpio_chip *gpiochip,
|
|
|
|
struct irq_chip *irqchip,
|
|
|
|
unsigned int first_irq,
|
|
|
|
irq_flow_handler_t handler,
|
|
|
|
unsigned int type)
|
|
|
|
{
|
2017-01-11 19:37:07 +07:00
|
|
|
return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,
|
|
|
|
handler, type, true, NULL);
|
2016-11-24 16:57:25 +07:00
|
|
|
}
|
2017-01-11 19:37:07 +07:00
|
|
|
#endif /* CONFIG_LOCKDEP */
|
2014-03-25 16:40:18 +07:00
|
|
|
|
2014-09-05 18:09:25 +07:00
|
|
|
#endif /* CONFIG_GPIOLIB_IRQCHIP */
|
2014-03-25 16:40:18 +07:00
|
|
|
|
2015-10-11 22:34:15 +07:00
|
|
|
int gpiochip_generic_request(struct gpio_chip *chip, unsigned offset);
|
|
|
|
void gpiochip_generic_free(struct gpio_chip *chip, unsigned offset);
|
2017-01-23 19:34:34 +07:00
|
|
|
int gpiochip_generic_config(struct gpio_chip *chip, unsigned offset,
|
|
|
|
unsigned long config);
|
2015-10-11 22:34:15 +07:00
|
|
|
|
2015-03-18 07:56:17 +07:00
|
|
|
#ifdef CONFIG_PINCTRL
|
|
|
|
|
|
|
|
/**
|
|
|
|
* struct gpio_pin_range - pin range controlled by a gpio chip
|
2017-07-24 21:57:22 +07:00
|
|
|
* @node: list for maintaining set of pin ranges, used internally
|
2015-03-18 07:56:17 +07:00
|
|
|
* @pctldev: pinctrl device which handles corresponding pins
|
|
|
|
* @range: actual range of pins controlled by a gpio controller
|
|
|
|
*/
|
|
|
|
struct gpio_pin_range {
|
|
|
|
struct list_head node;
|
|
|
|
struct pinctrl_dev *pctldev;
|
|
|
|
struct pinctrl_gpio_range range;
|
|
|
|
};
|
|
|
|
|
|
|
|
int gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name,
|
|
|
|
unsigned int gpio_offset, unsigned int pin_offset,
|
|
|
|
unsigned int npins);
|
|
|
|
int gpiochip_add_pingroup_range(struct gpio_chip *chip,
|
|
|
|
struct pinctrl_dev *pctldev,
|
|
|
|
unsigned int gpio_offset, const char *pin_group);
|
|
|
|
void gpiochip_remove_pin_ranges(struct gpio_chip *chip);
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
|
|
|
static inline int
|
|
|
|
gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name,
|
|
|
|
unsigned int gpio_offset, unsigned int pin_offset,
|
|
|
|
unsigned int npins)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
static inline int
|
|
|
|
gpiochip_add_pingroup_range(struct gpio_chip *chip,
|
|
|
|
struct pinctrl_dev *pctldev,
|
|
|
|
unsigned int gpio_offset, const char *pin_group)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void
|
|
|
|
gpiochip_remove_pin_ranges(struct gpio_chip *chip)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_PINCTRL */
|
|
|
|
|
2014-08-20 00:06:09 +07:00
|
|
|
struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *chip, u16 hwnum,
|
|
|
|
const char *label);
|
2014-07-22 22:01:01 +07:00
|
|
|
void gpiochip_free_own_desc(struct gpio_desc *desc);
|
|
|
|
|
2014-02-09 15:43:54 +07:00
|
|
|
#else /* CONFIG_GPIOLIB */
|
|
|
|
|
|
|
|
static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
|
|
|
|
{
|
|
|
|
/* GPIO can never have been requested */
|
|
|
|
WARN_ON(1);
|
|
|
|
return ERR_PTR(-ENODEV);
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_GPIOLIB */
|
|
|
|
|
2013-10-18 00:21:36 +07:00
|
|
|
#endif
|