2013-07-07 21:25:49 +07:00
|
|
|
/*
|
2015-04-02 21:07:30 +07:00
|
|
|
* Copyright (c) 2013-2015, Mellanox Technologies. All rights reserved.
|
2013-07-07 21:25:49 +07:00
|
|
|
*
|
|
|
|
* This software is available to you under a choice of one of two
|
|
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
|
|
* General Public License (GPL) Version 2, available from the file
|
|
|
|
* COPYING in the main directory of this source tree, or the
|
|
|
|
* OpenIB.org BSD license below:
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or
|
|
|
|
* without modification, are permitted provided that the following
|
|
|
|
* conditions are met:
|
|
|
|
*
|
|
|
|
* - Redistributions of source code must retain the above
|
|
|
|
* copyright notice, this list of conditions and the following
|
|
|
|
* disclaimer.
|
|
|
|
*
|
|
|
|
* - Redistributions in binary form must reproduce the above
|
|
|
|
* copyright notice, this list of conditions and the following
|
|
|
|
* disclaimer in the documentation and/or other materials
|
|
|
|
* provided with the distribution.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
|
|
* SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/kref.h>
|
|
|
|
#include <rdma/ib_umem.h>
|
IB/mlx5: add missing padding at end of struct mlx5_ib_create_cq
The i386 ABI disagrees with most other ABIs regarding alignment of
data type larger than 4 bytes: on most ABIs a padding must be added at
end of the structures, while it is not required on i386.
So for most ABI struct mlx5_ib_create_cq get padded to be aligned on a
8 bytes multiple, while for i386, such padding is not added.
The tool pahole can be used to find such implicit padding:
$ pahole --anon_include \
--nested_anon_include \
--recursive \
--class_name mlx5_ib_create_cq \
drivers/infiniband/hw/mlx5/mlx5_ib.o
Then, structure layout can be compared between i386 and x86_64:
+++ obj-i386/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-28 11:43:07.386413682 +0100
--- obj-x86_64/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-27 13:06:17.788472721 +0100
@@ -34,9 +34,8 @@ struct mlx5_ib_create_cq {
__u64 db_addr; /* 8 8 */
__u32 cqe_size; /* 16 4 */
- /* size: 20, cachelines: 1, members: 3 */
- /* last cacheline: 20 bytes */
+ /* size: 24, cachelines: 1, members: 3 */
+ /* padding: 4 */
+ /* last cacheline: 24 bytes */
};
This ABI disagreement will make an x86_64 kernel try to read past the
buffer provided by an i386 binary.
When boundary check will be implemented, a x86_64 kernel will refuse
to read past the i386 userspace provided buffer and the uverb will
fail.
Anyway, if the structure lies in memory on a page boundary and next
page is not mapped, ib_copy_from_udata() will fail when trying to read
the 4 bytes of padding and the uverb will fail.
This patch makes create_cq_user() takes care of the input data size to
handle the case where no padding is provided.
This way, x86_64 kernel will be able to handle struct
mlx5_ib_create_cq as sent by unpatched and patched i386 libmlx5.
Link: http://marc.info/?i=cover.1399309513.git.ydroneaud@opteya.com
Cc: <stable@vger.kernel.org>
Fixes: e126ba97dba9e ("mlx5: Add driver for Mellanox Connect-IB adapter")
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
2014-05-06 00:33:21 +07:00
|
|
|
#include <rdma/ib_user_verbs.h>
|
2015-09-03 02:23:04 +07:00
|
|
|
#include <rdma/ib_cache.h>
|
2013-07-07 21:25:49 +07:00
|
|
|
#include "mlx5_ib.h"
|
|
|
|
|
|
|
|
static void mlx5_ib_cq_comp(struct mlx5_core_cq *cq)
|
|
|
|
{
|
|
|
|
struct ib_cq *ibcq = &to_mibcq(cq)->ibcq;
|
|
|
|
|
|
|
|
ibcq->comp_handler(ibcq, ibcq->cq_context);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mlx5_ib_cq_event(struct mlx5_core_cq *mcq, enum mlx5_event type)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_cq *cq = container_of(mcq, struct mlx5_ib_cq, mcq);
|
|
|
|
struct mlx5_ib_dev *dev = to_mdev(cq->ibcq.device);
|
|
|
|
struct ib_cq *ibcq = &cq->ibcq;
|
|
|
|
struct ib_event event;
|
|
|
|
|
|
|
|
if (type != MLX5_EVENT_TYPE_CQ_ERROR) {
|
|
|
|
mlx5_ib_warn(dev, "Unexpected event type %d on CQ %06x\n",
|
|
|
|
type, mcq->cqn);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ibcq->event_handler) {
|
|
|
|
event.device = &dev->ib_dev;
|
|
|
|
event.event = IB_EVENT_CQ_ERR;
|
|
|
|
event.element.cq = ibcq;
|
|
|
|
ibcq->event_handler(&event, ibcq->cq_context);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *get_cqe_from_buf(struct mlx5_ib_cq_buf *buf, int n, int size)
|
|
|
|
{
|
|
|
|
return mlx5_buf_offset(&buf->buf, n * size);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *get_cqe(struct mlx5_ib_cq *cq, int n)
|
|
|
|
{
|
|
|
|
return get_cqe_from_buf(&cq->buf, n, cq->mcq.cqe_sz);
|
|
|
|
}
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
static u8 sw_ownership_bit(int n, int nent)
|
|
|
|
{
|
|
|
|
return (n & nent) ? 1 : 0;
|
|
|
|
}
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
static void *get_sw_cqe(struct mlx5_ib_cq *cq, int n)
|
|
|
|
{
|
|
|
|
void *cqe = get_cqe(cq, n & cq->ibcq.cqe);
|
|
|
|
struct mlx5_cqe64 *cqe64;
|
|
|
|
|
|
|
|
cqe64 = (cq->mcq.cqe_sz == 64) ? cqe : cqe + 64;
|
2014-01-14 22:45:18 +07:00
|
|
|
|
|
|
|
if (likely((cqe64->op_own) >> 4 != MLX5_CQE_INVALID) &&
|
|
|
|
!((cqe64->op_own & MLX5_CQE_OWNER_MASK) ^ !!(n & (cq->ibcq.cqe + 1)))) {
|
|
|
|
return cqe;
|
|
|
|
} else {
|
|
|
|
return NULL;
|
|
|
|
}
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void *next_cqe_sw(struct mlx5_ib_cq *cq)
|
|
|
|
{
|
|
|
|
return get_sw_cqe(cq, cq->mcq.cons_index);
|
|
|
|
}
|
|
|
|
|
|
|
|
static enum ib_wc_opcode get_umr_comp(struct mlx5_ib_wq *wq, int idx)
|
|
|
|
{
|
|
|
|
switch (wq->wr_data[idx]) {
|
|
|
|
case MLX5_IB_WR_UMR:
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
case IB_WR_LOCAL_INV:
|
|
|
|
return IB_WC_LOCAL_INV;
|
|
|
|
|
2015-10-13 23:11:26 +07:00
|
|
|
case IB_WR_REG_MR:
|
|
|
|
return IB_WC_REG_MR;
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
default:
|
|
|
|
pr_warn("unknown completion status\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void handle_good_req(struct ib_wc *wc, struct mlx5_cqe64 *cqe,
|
|
|
|
struct mlx5_ib_wq *wq, int idx)
|
|
|
|
{
|
|
|
|
wc->wc_flags = 0;
|
|
|
|
switch (be32_to_cpu(cqe->sop_drop_qpn) >> 24) {
|
|
|
|
case MLX5_OPCODE_RDMA_WRITE_IMM:
|
|
|
|
wc->wc_flags |= IB_WC_WITH_IMM;
|
|
|
|
case MLX5_OPCODE_RDMA_WRITE:
|
|
|
|
wc->opcode = IB_WC_RDMA_WRITE;
|
|
|
|
break;
|
|
|
|
case MLX5_OPCODE_SEND_IMM:
|
|
|
|
wc->wc_flags |= IB_WC_WITH_IMM;
|
|
|
|
case MLX5_OPCODE_SEND:
|
|
|
|
case MLX5_OPCODE_SEND_INVAL:
|
|
|
|
wc->opcode = IB_WC_SEND;
|
|
|
|
break;
|
|
|
|
case MLX5_OPCODE_RDMA_READ:
|
|
|
|
wc->opcode = IB_WC_RDMA_READ;
|
|
|
|
wc->byte_len = be32_to_cpu(cqe->byte_cnt);
|
|
|
|
break;
|
|
|
|
case MLX5_OPCODE_ATOMIC_CS:
|
|
|
|
wc->opcode = IB_WC_COMP_SWAP;
|
|
|
|
wc->byte_len = 8;
|
|
|
|
break;
|
|
|
|
case MLX5_OPCODE_ATOMIC_FA:
|
|
|
|
wc->opcode = IB_WC_FETCH_ADD;
|
|
|
|
wc->byte_len = 8;
|
|
|
|
break;
|
|
|
|
case MLX5_OPCODE_ATOMIC_MASKED_CS:
|
|
|
|
wc->opcode = IB_WC_MASKED_COMP_SWAP;
|
|
|
|
wc->byte_len = 8;
|
|
|
|
break;
|
|
|
|
case MLX5_OPCODE_ATOMIC_MASKED_FA:
|
|
|
|
wc->opcode = IB_WC_MASKED_FETCH_ADD;
|
|
|
|
wc->byte_len = 8;
|
|
|
|
break;
|
|
|
|
case MLX5_OPCODE_UMR:
|
|
|
|
wc->opcode = get_umr_comp(wq, idx);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
enum {
|
|
|
|
MLX5_GRH_IN_BUFFER = 1,
|
|
|
|
MLX5_GRH_IN_CQE = 2,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void handle_responder(struct ib_wc *wc, struct mlx5_cqe64 *cqe,
|
|
|
|
struct mlx5_ib_qp *qp)
|
|
|
|
{
|
2015-12-23 23:47:22 +07:00
|
|
|
enum rdma_link_layer ll = rdma_port_get_link_layer(qp->ibqp.device, 1);
|
2013-07-07 21:25:49 +07:00
|
|
|
struct mlx5_ib_dev *dev = to_mdev(qp->ibqp.device);
|
|
|
|
struct mlx5_ib_srq *srq;
|
|
|
|
struct mlx5_ib_wq *wq;
|
|
|
|
u16 wqe_ctr;
|
|
|
|
u8 g;
|
|
|
|
|
|
|
|
if (qp->ibqp.srq || qp->ibqp.xrcd) {
|
|
|
|
struct mlx5_core_srq *msrq = NULL;
|
|
|
|
|
|
|
|
if (qp->ibqp.xrcd) {
|
2014-07-29 03:30:22 +07:00
|
|
|
msrq = mlx5_core_get_srq(dev->mdev,
|
2013-07-07 21:25:49 +07:00
|
|
|
be32_to_cpu(cqe->srqn));
|
|
|
|
srq = to_mibsrq(msrq);
|
|
|
|
} else {
|
|
|
|
srq = to_msrq(qp->ibqp.srq);
|
|
|
|
}
|
|
|
|
if (srq) {
|
|
|
|
wqe_ctr = be16_to_cpu(cqe->wqe_counter);
|
|
|
|
wc->wr_id = srq->wrid[wqe_ctr];
|
|
|
|
mlx5_ib_free_srq_wqe(srq, wqe_ctr);
|
|
|
|
if (msrq && atomic_dec_and_test(&msrq->refcount))
|
|
|
|
complete(&msrq->free);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
wq = &qp->rq;
|
|
|
|
wc->wr_id = wq->wrid[wq->tail & (wq->wqe_cnt - 1)];
|
|
|
|
++wq->tail;
|
|
|
|
}
|
|
|
|
wc->byte_len = be32_to_cpu(cqe->byte_cnt);
|
|
|
|
|
|
|
|
switch (cqe->op_own >> 4) {
|
|
|
|
case MLX5_CQE_RESP_WR_IMM:
|
|
|
|
wc->opcode = IB_WC_RECV_RDMA_WITH_IMM;
|
|
|
|
wc->wc_flags = IB_WC_WITH_IMM;
|
|
|
|
wc->ex.imm_data = cqe->imm_inval_pkey;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_RESP_SEND:
|
|
|
|
wc->opcode = IB_WC_RECV;
|
2016-02-21 21:27:18 +07:00
|
|
|
wc->wc_flags = IB_WC_IP_CSUM_OK;
|
|
|
|
if (unlikely(!((cqe->hds_ip_ext & CQE_L3_OK) &&
|
|
|
|
(cqe->hds_ip_ext & CQE_L4_OK))))
|
|
|
|
wc->wc_flags = 0;
|
2013-07-07 21:25:49 +07:00
|
|
|
break;
|
|
|
|
case MLX5_CQE_RESP_SEND_IMM:
|
|
|
|
wc->opcode = IB_WC_RECV;
|
|
|
|
wc->wc_flags = IB_WC_WITH_IMM;
|
|
|
|
wc->ex.imm_data = cqe->imm_inval_pkey;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_RESP_SEND_INV:
|
|
|
|
wc->opcode = IB_WC_RECV;
|
|
|
|
wc->wc_flags = IB_WC_WITH_INVALIDATE;
|
|
|
|
wc->ex.invalidate_rkey = be32_to_cpu(cqe->imm_inval_pkey);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
wc->slid = be16_to_cpu(cqe->slid);
|
|
|
|
wc->sl = (be32_to_cpu(cqe->flags_rqpn) >> 24) & 0xf;
|
|
|
|
wc->src_qp = be32_to_cpu(cqe->flags_rqpn) & 0xffffff;
|
|
|
|
wc->dlid_path_bits = cqe->ml_path;
|
|
|
|
g = (be32_to_cpu(cqe->flags_rqpn) >> 28) & 3;
|
|
|
|
wc->wc_flags |= g ? IB_WC_GRH : 0;
|
2015-09-03 02:23:04 +07:00
|
|
|
if (unlikely(is_qp1(qp->ibqp.qp_type))) {
|
|
|
|
u16 pkey = be32_to_cpu(cqe->imm_inval_pkey) & 0xffff;
|
|
|
|
|
|
|
|
ib_find_cached_pkey(&dev->ib_dev, qp->port, pkey,
|
|
|
|
&wc->pkey_index);
|
|
|
|
} else {
|
|
|
|
wc->pkey_index = 0;
|
|
|
|
}
|
2015-12-23 23:47:22 +07:00
|
|
|
|
|
|
|
if (ll != IB_LINK_LAYER_ETHERNET)
|
|
|
|
return;
|
|
|
|
|
|
|
|
switch (wc->sl & 0x3) {
|
|
|
|
case MLX5_CQE_ROCE_L3_HEADER_TYPE_GRH:
|
|
|
|
wc->network_hdr_type = RDMA_NETWORK_IB;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_ROCE_L3_HEADER_TYPE_IPV6:
|
|
|
|
wc->network_hdr_type = RDMA_NETWORK_IPV6;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_ROCE_L3_HEADER_TYPE_IPV4:
|
|
|
|
wc->network_hdr_type = RDMA_NETWORK_IPV4;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
wc->wc_flags |= IB_WC_WITH_NETWORK_HDR_TYPE;
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void dump_cqe(struct mlx5_ib_dev *dev, struct mlx5_err_cqe *cqe)
|
|
|
|
{
|
|
|
|
__be32 *p = (__be32 *)cqe;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
mlx5_ib_warn(dev, "dump error cqe\n");
|
|
|
|
for (i = 0; i < sizeof(*cqe) / 16; i++, p += 4)
|
|
|
|
pr_info("%08x %08x %08x %08x\n", be32_to_cpu(p[0]),
|
|
|
|
be32_to_cpu(p[1]), be32_to_cpu(p[2]),
|
|
|
|
be32_to_cpu(p[3]));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mlx5_handle_error_cqe(struct mlx5_ib_dev *dev,
|
|
|
|
struct mlx5_err_cqe *cqe,
|
|
|
|
struct ib_wc *wc)
|
|
|
|
{
|
|
|
|
int dump = 1;
|
|
|
|
|
|
|
|
switch (cqe->syndrome) {
|
|
|
|
case MLX5_CQE_SYNDROME_LOCAL_LENGTH_ERR:
|
|
|
|
wc->status = IB_WC_LOC_LEN_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_LOCAL_QP_OP_ERR:
|
|
|
|
wc->status = IB_WC_LOC_QP_OP_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_LOCAL_PROT_ERR:
|
|
|
|
wc->status = IB_WC_LOC_PROT_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_WR_FLUSH_ERR:
|
|
|
|
dump = 0;
|
|
|
|
wc->status = IB_WC_WR_FLUSH_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_MW_BIND_ERR:
|
|
|
|
wc->status = IB_WC_MW_BIND_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_BAD_RESP_ERR:
|
|
|
|
wc->status = IB_WC_BAD_RESP_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_LOCAL_ACCESS_ERR:
|
|
|
|
wc->status = IB_WC_LOC_ACCESS_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_REMOTE_INVAL_REQ_ERR:
|
|
|
|
wc->status = IB_WC_REM_INV_REQ_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_REMOTE_ACCESS_ERR:
|
|
|
|
wc->status = IB_WC_REM_ACCESS_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_REMOTE_OP_ERR:
|
|
|
|
wc->status = IB_WC_REM_OP_ERR;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_TRANSPORT_RETRY_EXC_ERR:
|
|
|
|
wc->status = IB_WC_RETRY_EXC_ERR;
|
|
|
|
dump = 0;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_RNR_RETRY_EXC_ERR:
|
|
|
|
wc->status = IB_WC_RNR_RETRY_EXC_ERR;
|
|
|
|
dump = 0;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_SYNDROME_REMOTE_ABORTED_ERR:
|
|
|
|
wc->status = IB_WC_REM_ABORT_ERR;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
wc->status = IB_WC_GENERAL_ERR;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
wc->vendor_err = cqe->vendor_err_synd;
|
|
|
|
if (dump)
|
|
|
|
dump_cqe(dev, cqe);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int is_atomic_response(struct mlx5_ib_qp *qp, uint16_t idx)
|
|
|
|
{
|
|
|
|
/* TBD: waiting decision
|
|
|
|
*/
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *mlx5_get_atomic_laddr(struct mlx5_ib_qp *qp, uint16_t idx)
|
|
|
|
{
|
|
|
|
struct mlx5_wqe_data_seg *dpseg;
|
|
|
|
void *addr;
|
|
|
|
|
|
|
|
dpseg = mlx5_get_send_wqe(qp, idx) + sizeof(struct mlx5_wqe_ctrl_seg) +
|
|
|
|
sizeof(struct mlx5_wqe_raddr_seg) +
|
|
|
|
sizeof(struct mlx5_wqe_atomic_seg);
|
|
|
|
addr = (void *)(unsigned long)be64_to_cpu(dpseg->addr);
|
|
|
|
return addr;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void handle_atomic(struct mlx5_ib_qp *qp, struct mlx5_cqe64 *cqe64,
|
|
|
|
uint16_t idx)
|
|
|
|
{
|
|
|
|
void *addr;
|
|
|
|
int byte_count;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
if (!is_atomic_response(qp, idx))
|
|
|
|
return;
|
|
|
|
|
|
|
|
byte_count = be32_to_cpu(cqe64->byte_cnt);
|
|
|
|
addr = mlx5_get_atomic_laddr(qp, idx);
|
|
|
|
|
|
|
|
if (byte_count == 4) {
|
|
|
|
*(uint32_t *)addr = be32_to_cpu(*((__be32 *)addr));
|
|
|
|
} else {
|
|
|
|
for (i = 0; i < byte_count; i += 8) {
|
|
|
|
*(uint64_t *)addr = be64_to_cpu(*((__be64 *)addr));
|
|
|
|
addr += 8;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void handle_atomics(struct mlx5_ib_qp *qp, struct mlx5_cqe64 *cqe64,
|
|
|
|
u16 tail, u16 head)
|
|
|
|
{
|
2014-07-29 03:30:23 +07:00
|
|
|
u16 idx;
|
2013-07-07 21:25:49 +07:00
|
|
|
|
|
|
|
do {
|
|
|
|
idx = tail & (qp->sq.wqe_cnt - 1);
|
|
|
|
handle_atomic(qp, cqe64, idx);
|
|
|
|
if (idx == head)
|
|
|
|
break;
|
|
|
|
|
|
|
|
tail = qp->sq.w_list[idx].next;
|
|
|
|
} while (1);
|
|
|
|
tail = qp->sq.w_list[idx].next;
|
|
|
|
qp->sq.last_poll = tail;
|
|
|
|
}
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
static void free_cq_buf(struct mlx5_ib_dev *dev, struct mlx5_ib_cq_buf *buf)
|
|
|
|
{
|
2014-07-29 03:30:22 +07:00
|
|
|
mlx5_buf_free(dev->mdev, &buf->buf);
|
2014-01-14 22:45:18 +07:00
|
|
|
}
|
|
|
|
|
2014-02-23 19:19:12 +07:00
|
|
|
static void get_sig_err_item(struct mlx5_sig_err_cqe *cqe,
|
|
|
|
struct ib_sig_err *item)
|
|
|
|
{
|
|
|
|
u16 syndrome = be16_to_cpu(cqe->syndrome);
|
|
|
|
|
|
|
|
#define GUARD_ERR (1 << 13)
|
|
|
|
#define APPTAG_ERR (1 << 12)
|
|
|
|
#define REFTAG_ERR (1 << 11)
|
|
|
|
|
|
|
|
if (syndrome & GUARD_ERR) {
|
|
|
|
item->err_type = IB_SIG_BAD_GUARD;
|
|
|
|
item->expected = be32_to_cpu(cqe->expected_trans_sig) >> 16;
|
|
|
|
item->actual = be32_to_cpu(cqe->actual_trans_sig) >> 16;
|
|
|
|
} else
|
|
|
|
if (syndrome & REFTAG_ERR) {
|
|
|
|
item->err_type = IB_SIG_BAD_REFTAG;
|
|
|
|
item->expected = be32_to_cpu(cqe->expected_reftag);
|
|
|
|
item->actual = be32_to_cpu(cqe->actual_reftag);
|
|
|
|
} else
|
|
|
|
if (syndrome & APPTAG_ERR) {
|
|
|
|
item->err_type = IB_SIG_BAD_APPTAG;
|
|
|
|
item->expected = be32_to_cpu(cqe->expected_trans_sig) & 0xffff;
|
|
|
|
item->actual = be32_to_cpu(cqe->actual_trans_sig) & 0xffff;
|
|
|
|
} else {
|
|
|
|
pr_err("Got signature completion error with bad syndrome %04x\n",
|
|
|
|
syndrome);
|
|
|
|
}
|
|
|
|
|
|
|
|
item->sig_err_offset = be64_to_cpu(cqe->err_offset);
|
|
|
|
item->key = be32_to_cpu(cqe->mkey);
|
|
|
|
}
|
|
|
|
|
2016-06-17 19:01:38 +07:00
|
|
|
static void sw_send_comp(struct mlx5_ib_qp *qp, int num_entries,
|
|
|
|
struct ib_wc *wc, int *npolled)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_wq *wq;
|
|
|
|
unsigned int cur;
|
|
|
|
unsigned int idx;
|
|
|
|
int np;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
wq = &qp->sq;
|
|
|
|
cur = wq->head - wq->tail;
|
|
|
|
np = *npolled;
|
|
|
|
|
|
|
|
if (cur == 0)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < cur && np < num_entries; i++) {
|
|
|
|
idx = wq->last_poll & (wq->wqe_cnt - 1);
|
|
|
|
wc->wr_id = wq->wrid[idx];
|
|
|
|
wc->status = IB_WC_WR_FLUSH_ERR;
|
|
|
|
wc->vendor_err = MLX5_CQE_SYNDROME_WR_FLUSH_ERR;
|
|
|
|
wq->tail++;
|
|
|
|
np++;
|
|
|
|
wc->qp = &qp->ibqp;
|
|
|
|
wc++;
|
|
|
|
wq->last_poll = wq->w_list[idx].next;
|
|
|
|
}
|
|
|
|
*npolled = np;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sw_recv_comp(struct mlx5_ib_qp *qp, int num_entries,
|
|
|
|
struct ib_wc *wc, int *npolled)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_wq *wq;
|
|
|
|
unsigned int cur;
|
|
|
|
int np;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
wq = &qp->rq;
|
|
|
|
cur = wq->head - wq->tail;
|
|
|
|
np = *npolled;
|
|
|
|
|
|
|
|
if (cur == 0)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < cur && np < num_entries; i++) {
|
|
|
|
wc->wr_id = wq->wrid[wq->tail & (wq->wqe_cnt - 1)];
|
|
|
|
wc->status = IB_WC_WR_FLUSH_ERR;
|
|
|
|
wc->vendor_err = MLX5_CQE_SYNDROME_WR_FLUSH_ERR;
|
|
|
|
wq->tail++;
|
|
|
|
np++;
|
|
|
|
wc->qp = &qp->ibqp;
|
|
|
|
wc++;
|
|
|
|
}
|
|
|
|
*npolled = np;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mlx5_ib_poll_sw_comp(struct mlx5_ib_cq *cq, int num_entries,
|
|
|
|
struct ib_wc *wc, int *npolled)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_qp *qp;
|
|
|
|
|
|
|
|
*npolled = 0;
|
|
|
|
/* Find uncompleted WQEs belonging to that cq and retrun mmics ones */
|
|
|
|
list_for_each_entry(qp, &cq->list_send_qp, cq_send_list) {
|
|
|
|
sw_send_comp(qp, num_entries, wc + *npolled, npolled);
|
|
|
|
if (*npolled >= num_entries)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
list_for_each_entry(qp, &cq->list_recv_qp, cq_recv_list) {
|
|
|
|
sw_recv_comp(qp, num_entries, wc + *npolled, npolled);
|
|
|
|
if (*npolled >= num_entries)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
static int mlx5_poll_one(struct mlx5_ib_cq *cq,
|
|
|
|
struct mlx5_ib_qp **cur_qp,
|
|
|
|
struct ib_wc *wc)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_dev *dev = to_mdev(cq->ibcq.device);
|
|
|
|
struct mlx5_err_cqe *err_cqe;
|
|
|
|
struct mlx5_cqe64 *cqe64;
|
|
|
|
struct mlx5_core_qp *mqp;
|
|
|
|
struct mlx5_ib_wq *wq;
|
2014-02-23 19:19:12 +07:00
|
|
|
struct mlx5_sig_err_cqe *sig_err_cqe;
|
2016-02-29 23:05:28 +07:00
|
|
|
struct mlx5_core_mkey *mmkey;
|
2014-02-23 19:19:12 +07:00
|
|
|
struct mlx5_ib_mr *mr;
|
2013-07-07 21:25:49 +07:00
|
|
|
uint8_t opcode;
|
|
|
|
uint32_t qpn;
|
|
|
|
u16 wqe_ctr;
|
|
|
|
void *cqe;
|
|
|
|
int idx;
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
repoll:
|
2013-07-07 21:25:49 +07:00
|
|
|
cqe = next_cqe_sw(cq);
|
|
|
|
if (!cqe)
|
|
|
|
return -EAGAIN;
|
|
|
|
|
|
|
|
cqe64 = (cq->mcq.cqe_sz == 64) ? cqe : cqe + 64;
|
|
|
|
|
|
|
|
++cq->mcq.cons_index;
|
|
|
|
|
|
|
|
/* Make sure we read CQ entry contents after we've checked the
|
|
|
|
* ownership bit.
|
|
|
|
*/
|
|
|
|
rmb();
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
opcode = cqe64->op_own >> 4;
|
|
|
|
if (unlikely(opcode == MLX5_CQE_RESIZE_CQ)) {
|
|
|
|
if (likely(cq->resize_buf)) {
|
|
|
|
free_cq_buf(dev, &cq->buf);
|
|
|
|
cq->buf = *cq->resize_buf;
|
|
|
|
kfree(cq->resize_buf);
|
|
|
|
cq->resize_buf = NULL;
|
|
|
|
goto repoll;
|
|
|
|
} else {
|
|
|
|
mlx5_ib_warn(dev, "unexpected resize cqe\n");
|
|
|
|
}
|
|
|
|
}
|
2013-07-07 21:25:49 +07:00
|
|
|
|
|
|
|
qpn = ntohl(cqe64->sop_drop_qpn) & 0xffffff;
|
|
|
|
if (!*cur_qp || (qpn != (*cur_qp)->ibqp.qp_num)) {
|
|
|
|
/* We do not have to take the QP table lock here,
|
|
|
|
* because CQs will be locked while QPs are removed
|
|
|
|
* from the table.
|
|
|
|
*/
|
2014-07-29 03:30:22 +07:00
|
|
|
mqp = __mlx5_qp_lookup(dev->mdev, qpn);
|
2013-07-07 21:25:49 +07:00
|
|
|
*cur_qp = to_mibqp(mqp);
|
|
|
|
}
|
|
|
|
|
|
|
|
wc->qp = &(*cur_qp)->ibqp;
|
|
|
|
switch (opcode) {
|
|
|
|
case MLX5_CQE_REQ:
|
|
|
|
wq = &(*cur_qp)->sq;
|
|
|
|
wqe_ctr = be16_to_cpu(cqe64->wqe_counter);
|
|
|
|
idx = wqe_ctr & (wq->wqe_cnt - 1);
|
|
|
|
handle_good_req(wc, cqe64, wq, idx);
|
|
|
|
handle_atomics(*cur_qp, cqe64, wq->last_poll, idx);
|
|
|
|
wc->wr_id = wq->wrid[idx];
|
|
|
|
wq->tail = wq->wqe_head[idx] + 1;
|
|
|
|
wc->status = IB_WC_SUCCESS;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_RESP_WR_IMM:
|
|
|
|
case MLX5_CQE_RESP_SEND:
|
|
|
|
case MLX5_CQE_RESP_SEND_IMM:
|
|
|
|
case MLX5_CQE_RESP_SEND_INV:
|
|
|
|
handle_responder(wc, cqe64, *cur_qp);
|
|
|
|
wc->status = IB_WC_SUCCESS;
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_RESIZE_CQ:
|
|
|
|
break;
|
|
|
|
case MLX5_CQE_REQ_ERR:
|
|
|
|
case MLX5_CQE_RESP_ERR:
|
|
|
|
err_cqe = (struct mlx5_err_cqe *)cqe64;
|
|
|
|
mlx5_handle_error_cqe(dev, err_cqe, wc);
|
|
|
|
mlx5_ib_dbg(dev, "%s error cqe on cqn 0x%x:\n",
|
|
|
|
opcode == MLX5_CQE_REQ_ERR ?
|
|
|
|
"Requestor" : "Responder", cq->mcq.cqn);
|
|
|
|
mlx5_ib_dbg(dev, "syndrome 0x%x, vendor syndrome 0x%x\n",
|
|
|
|
err_cqe->syndrome, err_cqe->vendor_err_synd);
|
|
|
|
if (opcode == MLX5_CQE_REQ_ERR) {
|
|
|
|
wq = &(*cur_qp)->sq;
|
|
|
|
wqe_ctr = be16_to_cpu(cqe64->wqe_counter);
|
|
|
|
idx = wqe_ctr & (wq->wqe_cnt - 1);
|
|
|
|
wc->wr_id = wq->wrid[idx];
|
|
|
|
wq->tail = wq->wqe_head[idx] + 1;
|
|
|
|
} else {
|
|
|
|
struct mlx5_ib_srq *srq;
|
|
|
|
|
|
|
|
if ((*cur_qp)->ibqp.srq) {
|
|
|
|
srq = to_msrq((*cur_qp)->ibqp.srq);
|
|
|
|
wqe_ctr = be16_to_cpu(cqe64->wqe_counter);
|
|
|
|
wc->wr_id = srq->wrid[wqe_ctr];
|
|
|
|
mlx5_ib_free_srq_wqe(srq, wqe_ctr);
|
|
|
|
} else {
|
|
|
|
wq = &(*cur_qp)->rq;
|
|
|
|
wc->wr_id = wq->wrid[wq->tail & (wq->wqe_cnt - 1)];
|
|
|
|
++wq->tail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
2014-02-23 19:19:12 +07:00
|
|
|
case MLX5_CQE_SIG_ERR:
|
|
|
|
sig_err_cqe = (struct mlx5_sig_err_cqe *)cqe64;
|
|
|
|
|
2016-02-29 23:05:28 +07:00
|
|
|
read_lock(&dev->mdev->priv.mkey_table.lock);
|
|
|
|
mmkey = __mlx5_mr_lookup(dev->mdev,
|
|
|
|
mlx5_base_mkey(be32_to_cpu(sig_err_cqe->mkey)));
|
|
|
|
mr = to_mibmr(mmkey);
|
2014-02-23 19:19:12 +07:00
|
|
|
get_sig_err_item(sig_err_cqe, &mr->sig->err_item);
|
|
|
|
mr->sig->sig_err_exists = true;
|
|
|
|
mr->sig->sigerr_count++;
|
|
|
|
|
|
|
|
mlx5_ib_warn(dev, "CQN: 0x%x Got SIGERR on key: 0x%x err_type %x err_offset %llx expected %x actual %x\n",
|
|
|
|
cq->mcq.cqn, mr->sig->err_item.key,
|
|
|
|
mr->sig->err_item.err_type,
|
|
|
|
mr->sig->err_item.sig_err_offset,
|
|
|
|
mr->sig->err_item.expected,
|
|
|
|
mr->sig->err_item.actual);
|
|
|
|
|
2016-02-29 23:05:28 +07:00
|
|
|
read_unlock(&dev->mdev->priv.mkey_table.lock);
|
2014-02-23 19:19:12 +07:00
|
|
|
goto repoll;
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-02-29 20:45:08 +07:00
|
|
|
static int poll_soft_wc(struct mlx5_ib_cq *cq, int num_entries,
|
|
|
|
struct ib_wc *wc)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_dev *dev = to_mdev(cq->ibcq.device);
|
|
|
|
struct mlx5_ib_wc *soft_wc, *next;
|
|
|
|
int npolled = 0;
|
|
|
|
|
|
|
|
list_for_each_entry_safe(soft_wc, next, &cq->wc_list, list) {
|
|
|
|
if (npolled >= num_entries)
|
|
|
|
break;
|
|
|
|
|
|
|
|
mlx5_ib_dbg(dev, "polled software generated completion on CQ 0x%x\n",
|
|
|
|
cq->mcq.cqn);
|
|
|
|
|
|
|
|
wc[npolled++] = soft_wc->wc;
|
|
|
|
list_del(&soft_wc->list);
|
|
|
|
kfree(soft_wc);
|
|
|
|
}
|
|
|
|
|
|
|
|
return npolled;
|
|
|
|
}
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
int mlx5_ib_poll_cq(struct ib_cq *ibcq, int num_entries, struct ib_wc *wc)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_cq *cq = to_mcq(ibcq);
|
|
|
|
struct mlx5_ib_qp *cur_qp = NULL;
|
2016-06-17 19:01:38 +07:00
|
|
|
struct mlx5_ib_dev *dev = to_mdev(cq->ibcq.device);
|
|
|
|
struct mlx5_core_dev *mdev = dev->mdev;
|
2013-07-07 21:25:49 +07:00
|
|
|
unsigned long flags;
|
2016-02-29 20:45:08 +07:00
|
|
|
int soft_polled = 0;
|
2013-07-07 21:25:49 +07:00
|
|
|
int npolled;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&cq->lock, flags);
|
2016-06-17 19:01:38 +07:00
|
|
|
if (mdev->state == MLX5_DEVICE_STATE_INTERNAL_ERROR) {
|
|
|
|
mlx5_ib_poll_sw_comp(cq, num_entries, wc, &npolled);
|
|
|
|
goto out;
|
|
|
|
}
|
2013-07-07 21:25:49 +07:00
|
|
|
|
2016-02-29 20:45:08 +07:00
|
|
|
if (unlikely(!list_empty(&cq->wc_list)))
|
|
|
|
soft_polled = poll_soft_wc(cq, num_entries, wc);
|
|
|
|
|
|
|
|
for (npolled = 0; npolled < num_entries - soft_polled; npolled++) {
|
2016-08-28 14:58:38 +07:00
|
|
|
if (mlx5_poll_one(cq, &cur_qp, wc + soft_polled + npolled))
|
2013-07-07 21:25:49 +07:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (npolled)
|
|
|
|
mlx5_cq_set_ci(&cq->mcq);
|
2016-06-17 19:01:38 +07:00
|
|
|
out:
|
2013-07-07 21:25:49 +07:00
|
|
|
spin_unlock_irqrestore(&cq->lock, flags);
|
|
|
|
|
2016-08-28 14:58:38 +07:00
|
|
|
return soft_polled + npolled;
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
int mlx5_ib_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags)
|
|
|
|
{
|
2015-04-02 21:07:33 +07:00
|
|
|
struct mlx5_core_dev *mdev = to_mdev(ibcq->device)->mdev;
|
2016-02-29 20:45:08 +07:00
|
|
|
struct mlx5_ib_cq *cq = to_mcq(ibcq);
|
2017-01-04 04:55:25 +07:00
|
|
|
void __iomem *uar_page = mdev->priv.uar->map;
|
2016-02-29 20:45:08 +07:00
|
|
|
unsigned long irq_flags;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&cq->lock, irq_flags);
|
|
|
|
if (cq->notify_flags != IB_CQ_NEXT_COMP)
|
|
|
|
cq->notify_flags = flags & IB_CQ_SOLICITED_MASK;
|
2015-04-02 21:07:33 +07:00
|
|
|
|
2016-02-29 20:45:08 +07:00
|
|
|
if ((flags & IB_CQ_REPORT_MISSED_EVENTS) && !list_empty(&cq->wc_list))
|
|
|
|
ret = 1;
|
|
|
|
spin_unlock_irqrestore(&cq->lock, irq_flags);
|
|
|
|
|
|
|
|
mlx5_cq_arm(&cq->mcq,
|
2013-07-07 21:25:49 +07:00
|
|
|
(flags & IB_CQ_SOLICITED_MASK) == IB_CQ_SOLICITED ?
|
|
|
|
MLX5_CQ_DB_REQ_NOT_SOL : MLX5_CQ_DB_REQ_NOT,
|
2017-01-04 04:55:25 +07:00
|
|
|
uar_page, to_mcq(ibcq)->mcq.cons_index);
|
2013-07-07 21:25:49 +07:00
|
|
|
|
2016-02-29 20:45:08 +07:00
|
|
|
return ret;
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int alloc_cq_buf(struct mlx5_ib_dev *dev, struct mlx5_ib_cq_buf *buf,
|
|
|
|
int nent, int cqe_size)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
2015-05-29 02:28:38 +07:00
|
|
|
err = mlx5_buf_alloc(dev->mdev, nent * cqe_size, &buf->buf);
|
2013-07-07 21:25:49 +07:00
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
buf->cqe_size = cqe_size;
|
2014-01-14 22:45:18 +07:00
|
|
|
buf->nent = nent;
|
2013-07-07 21:25:49 +07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int create_cq_user(struct mlx5_ib_dev *dev, struct ib_udata *udata,
|
|
|
|
struct ib_ucontext *context, struct mlx5_ib_cq *cq,
|
2016-07-16 06:33:22 +07:00
|
|
|
int entries, u32 **cqb,
|
2013-07-07 21:25:49 +07:00
|
|
|
int *cqe_size, int *index, int *inlen)
|
|
|
|
{
|
2016-10-31 17:16:45 +07:00
|
|
|
struct mlx5_ib_create_cq ucmd = {};
|
IB/mlx5: add missing padding at end of struct mlx5_ib_create_cq
The i386 ABI disagrees with most other ABIs regarding alignment of
data type larger than 4 bytes: on most ABIs a padding must be added at
end of the structures, while it is not required on i386.
So for most ABI struct mlx5_ib_create_cq get padded to be aligned on a
8 bytes multiple, while for i386, such padding is not added.
The tool pahole can be used to find such implicit padding:
$ pahole --anon_include \
--nested_anon_include \
--recursive \
--class_name mlx5_ib_create_cq \
drivers/infiniband/hw/mlx5/mlx5_ib.o
Then, structure layout can be compared between i386 and x86_64:
+++ obj-i386/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-28 11:43:07.386413682 +0100
--- obj-x86_64/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-27 13:06:17.788472721 +0100
@@ -34,9 +34,8 @@ struct mlx5_ib_create_cq {
__u64 db_addr; /* 8 8 */
__u32 cqe_size; /* 16 4 */
- /* size: 20, cachelines: 1, members: 3 */
- /* last cacheline: 20 bytes */
+ /* size: 24, cachelines: 1, members: 3 */
+ /* padding: 4 */
+ /* last cacheline: 24 bytes */
};
This ABI disagreement will make an x86_64 kernel try to read past the
buffer provided by an i386 binary.
When boundary check will be implemented, a x86_64 kernel will refuse
to read past the i386 userspace provided buffer and the uverb will
fail.
Anyway, if the structure lies in memory on a page boundary and next
page is not mapped, ib_copy_from_udata() will fail when trying to read
the 4 bytes of padding and the uverb will fail.
This patch makes create_cq_user() takes care of the input data size to
handle the case where no padding is provided.
This way, x86_64 kernel will be able to handle struct
mlx5_ib_create_cq as sent by unpatched and patched i386 libmlx5.
Link: http://marc.info/?i=cover.1399309513.git.ydroneaud@opteya.com
Cc: <stable@vger.kernel.org>
Fixes: e126ba97dba9e ("mlx5: Add driver for Mellanox Connect-IB adapter")
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
2014-05-06 00:33:21 +07:00
|
|
|
size_t ucmdlen;
|
2013-07-07 21:25:49 +07:00
|
|
|
int page_shift;
|
2016-07-16 06:33:22 +07:00
|
|
|
__be64 *pas;
|
2013-07-07 21:25:49 +07:00
|
|
|
int npages;
|
|
|
|
int ncont;
|
2016-07-16 06:33:22 +07:00
|
|
|
void *cqc;
|
2013-07-07 21:25:49 +07:00
|
|
|
int err;
|
|
|
|
|
IB/mlx5: add missing padding at end of struct mlx5_ib_create_cq
The i386 ABI disagrees with most other ABIs regarding alignment of
data type larger than 4 bytes: on most ABIs a padding must be added at
end of the structures, while it is not required on i386.
So for most ABI struct mlx5_ib_create_cq get padded to be aligned on a
8 bytes multiple, while for i386, such padding is not added.
The tool pahole can be used to find such implicit padding:
$ pahole --anon_include \
--nested_anon_include \
--recursive \
--class_name mlx5_ib_create_cq \
drivers/infiniband/hw/mlx5/mlx5_ib.o
Then, structure layout can be compared between i386 and x86_64:
+++ obj-i386/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-28 11:43:07.386413682 +0100
--- obj-x86_64/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-27 13:06:17.788472721 +0100
@@ -34,9 +34,8 @@ struct mlx5_ib_create_cq {
__u64 db_addr; /* 8 8 */
__u32 cqe_size; /* 16 4 */
- /* size: 20, cachelines: 1, members: 3 */
- /* last cacheline: 20 bytes */
+ /* size: 24, cachelines: 1, members: 3 */
+ /* padding: 4 */
+ /* last cacheline: 24 bytes */
};
This ABI disagreement will make an x86_64 kernel try to read past the
buffer provided by an i386 binary.
When boundary check will be implemented, a x86_64 kernel will refuse
to read past the i386 userspace provided buffer and the uverb will
fail.
Anyway, if the structure lies in memory on a page boundary and next
page is not mapped, ib_copy_from_udata() will fail when trying to read
the 4 bytes of padding and the uverb will fail.
This patch makes create_cq_user() takes care of the input data size to
handle the case where no padding is provided.
This way, x86_64 kernel will be able to handle struct
mlx5_ib_create_cq as sent by unpatched and patched i386 libmlx5.
Link: http://marc.info/?i=cover.1399309513.git.ydroneaud@opteya.com
Cc: <stable@vger.kernel.org>
Fixes: e126ba97dba9e ("mlx5: Add driver for Mellanox Connect-IB adapter")
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
2014-05-06 00:33:21 +07:00
|
|
|
ucmdlen =
|
|
|
|
(udata->inlen - sizeof(struct ib_uverbs_cmd_hdr) <
|
|
|
|
sizeof(ucmd)) ? (sizeof(ucmd) -
|
|
|
|
sizeof(ucmd.reserved)) : sizeof(ucmd);
|
|
|
|
|
|
|
|
if (ib_copy_from_udata(&ucmd, udata, ucmdlen))
|
2013-07-07 21:25:49 +07:00
|
|
|
return -EFAULT;
|
|
|
|
|
IB/mlx5: add missing padding at end of struct mlx5_ib_create_cq
The i386 ABI disagrees with most other ABIs regarding alignment of
data type larger than 4 bytes: on most ABIs a padding must be added at
end of the structures, while it is not required on i386.
So for most ABI struct mlx5_ib_create_cq get padded to be aligned on a
8 bytes multiple, while for i386, such padding is not added.
The tool pahole can be used to find such implicit padding:
$ pahole --anon_include \
--nested_anon_include \
--recursive \
--class_name mlx5_ib_create_cq \
drivers/infiniband/hw/mlx5/mlx5_ib.o
Then, structure layout can be compared between i386 and x86_64:
+++ obj-i386/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-28 11:43:07.386413682 +0100
--- obj-x86_64/drivers/infiniband/hw/mlx5/mlx5_ib.o.pahole.txt 2014-03-27 13:06:17.788472721 +0100
@@ -34,9 +34,8 @@ struct mlx5_ib_create_cq {
__u64 db_addr; /* 8 8 */
__u32 cqe_size; /* 16 4 */
- /* size: 20, cachelines: 1, members: 3 */
- /* last cacheline: 20 bytes */
+ /* size: 24, cachelines: 1, members: 3 */
+ /* padding: 4 */
+ /* last cacheline: 24 bytes */
};
This ABI disagreement will make an x86_64 kernel try to read past the
buffer provided by an i386 binary.
When boundary check will be implemented, a x86_64 kernel will refuse
to read past the i386 userspace provided buffer and the uverb will
fail.
Anyway, if the structure lies in memory on a page boundary and next
page is not mapped, ib_copy_from_udata() will fail when trying to read
the 4 bytes of padding and the uverb will fail.
This patch makes create_cq_user() takes care of the input data size to
handle the case where no padding is provided.
This way, x86_64 kernel will be able to handle struct
mlx5_ib_create_cq as sent by unpatched and patched i386 libmlx5.
Link: http://marc.info/?i=cover.1399309513.git.ydroneaud@opteya.com
Cc: <stable@vger.kernel.org>
Fixes: e126ba97dba9e ("mlx5: Add driver for Mellanox Connect-IB adapter")
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
2014-05-06 00:33:21 +07:00
|
|
|
if (ucmdlen == sizeof(ucmd) &&
|
|
|
|
ucmd.reserved != 0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
if (ucmd.cqe_size != 64 && ucmd.cqe_size != 128)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
*cqe_size = ucmd.cqe_size;
|
|
|
|
|
|
|
|
cq->buf.umem = ib_umem_get(context, ucmd.buf_addr,
|
|
|
|
entries * ucmd.cqe_size,
|
|
|
|
IB_ACCESS_LOCAL_WRITE, 1);
|
|
|
|
if (IS_ERR(cq->buf.umem)) {
|
|
|
|
err = PTR_ERR(cq->buf.umem);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = mlx5_ib_db_map_user(to_mucontext(context), ucmd.db_addr,
|
|
|
|
&cq->db);
|
|
|
|
if (err)
|
|
|
|
goto err_umem;
|
|
|
|
|
2016-10-27 20:36:47 +07:00
|
|
|
mlx5_ib_cont_pages(cq->buf.umem, ucmd.buf_addr, 0, &npages, &page_shift,
|
2013-07-07 21:25:49 +07:00
|
|
|
&ncont, NULL);
|
|
|
|
mlx5_ib_dbg(dev, "addr 0x%llx, size %u, npages %d, page_shift %d, ncont %d\n",
|
|
|
|
ucmd.buf_addr, entries * ucmd.cqe_size, npages, page_shift, ncont);
|
|
|
|
|
2016-07-16 06:33:22 +07:00
|
|
|
*inlen = MLX5_ST_SZ_BYTES(create_cq_in) +
|
|
|
|
MLX5_FLD_SZ_BYTES(create_cq_in, pas[0]) * ncont;
|
2013-07-07 21:25:49 +07:00
|
|
|
*cqb = mlx5_vzalloc(*inlen);
|
|
|
|
if (!*cqb) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
goto err_db;
|
|
|
|
}
|
2016-07-16 06:33:22 +07:00
|
|
|
|
|
|
|
pas = (__be64 *)MLX5_ADDR_OF(create_cq_in, *cqb, pas);
|
|
|
|
mlx5_ib_populate_pas(dev, cq->buf.umem, page_shift, pas, 0);
|
|
|
|
|
|
|
|
cqc = MLX5_ADDR_OF(create_cq_in, *cqb, cq_context);
|
|
|
|
MLX5_SET(cqc, cqc, log_page_size,
|
|
|
|
page_shift - MLX5_ADAPTER_PAGE_SHIFT);
|
2013-07-07 21:25:49 +07:00
|
|
|
|
2017-01-04 04:55:21 +07:00
|
|
|
*index = to_mucontext(context)->bfregi.uars[0].index;
|
2013-07-07 21:25:49 +07:00
|
|
|
|
2016-10-31 17:16:45 +07:00
|
|
|
if (ucmd.cqe_comp_en == 1) {
|
|
|
|
if (unlikely((*cqe_size != 64) ||
|
|
|
|
!MLX5_CAP_GEN(dev->mdev, cqe_compression))) {
|
|
|
|
err = -EOPNOTSUPP;
|
|
|
|
mlx5_ib_warn(dev, "CQE compression is not supported for size %d!\n",
|
|
|
|
*cqe_size);
|
|
|
|
goto err_cqb;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (unlikely(!ucmd.cqe_comp_res_format ||
|
|
|
|
!(ucmd.cqe_comp_res_format <
|
|
|
|
MLX5_IB_CQE_RES_RESERVED) ||
|
|
|
|
(ucmd.cqe_comp_res_format &
|
|
|
|
(ucmd.cqe_comp_res_format - 1)))) {
|
|
|
|
err = -EOPNOTSUPP;
|
|
|
|
mlx5_ib_warn(dev, "CQE compression res format %d is not supported!\n",
|
|
|
|
ucmd.cqe_comp_res_format);
|
|
|
|
goto err_cqb;
|
|
|
|
}
|
|
|
|
|
|
|
|
MLX5_SET(cqc, cqc, cqe_comp_en, 1);
|
|
|
|
MLX5_SET(cqc, cqc, mini_cqe_res_format,
|
|
|
|
ilog2(ucmd.cqe_comp_res_format));
|
|
|
|
}
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
return 0;
|
|
|
|
|
2016-10-31 17:16:45 +07:00
|
|
|
err_cqb:
|
|
|
|
kfree(cqb);
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
err_db:
|
|
|
|
mlx5_ib_db_unmap_user(to_mucontext(context), &cq->db);
|
|
|
|
|
|
|
|
err_umem:
|
|
|
|
ib_umem_release(cq->buf.umem);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void destroy_cq_user(struct mlx5_ib_cq *cq, struct ib_ucontext *context)
|
|
|
|
{
|
|
|
|
mlx5_ib_db_unmap_user(to_mucontext(context), &cq->db);
|
|
|
|
ib_umem_release(cq->buf.umem);
|
|
|
|
}
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
static void init_cq_buf(struct mlx5_ib_cq *cq, struct mlx5_ib_cq_buf *buf)
|
2013-07-07 21:25:49 +07:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
void *cqe;
|
|
|
|
struct mlx5_cqe64 *cqe64;
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
for (i = 0; i < buf->nent; i++) {
|
|
|
|
cqe = get_cqe_from_buf(buf, i, buf->cqe_size);
|
|
|
|
cqe64 = buf->cqe_size == 64 ? cqe : cqe + 64;
|
|
|
|
cqe64->op_own = MLX5_CQE_INVALID << 4;
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int create_cq_kernel(struct mlx5_ib_dev *dev, struct mlx5_ib_cq *cq,
|
|
|
|
int entries, int cqe_size,
|
2016-07-16 06:33:22 +07:00
|
|
|
u32 **cqb, int *index, int *inlen)
|
2013-07-07 21:25:49 +07:00
|
|
|
{
|
2016-07-16 06:33:22 +07:00
|
|
|
__be64 *pas;
|
|
|
|
void *cqc;
|
2013-07-07 21:25:49 +07:00
|
|
|
int err;
|
|
|
|
|
2014-07-29 03:30:22 +07:00
|
|
|
err = mlx5_db_alloc(dev->mdev, &cq->db);
|
2013-07-07 21:25:49 +07:00
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
cq->mcq.set_ci_db = cq->db.db;
|
|
|
|
cq->mcq.arm_db = cq->db.db + 1;
|
|
|
|
cq->mcq.cqe_sz = cqe_size;
|
|
|
|
|
|
|
|
err = alloc_cq_buf(dev, &cq->buf, entries, cqe_size);
|
|
|
|
if (err)
|
|
|
|
goto err_db;
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
init_cq_buf(cq, &cq->buf);
|
2013-07-07 21:25:49 +07:00
|
|
|
|
2016-07-16 06:33:22 +07:00
|
|
|
*inlen = MLX5_ST_SZ_BYTES(create_cq_in) +
|
|
|
|
MLX5_FLD_SZ_BYTES(create_cq_in, pas[0]) * cq->buf.buf.npages;
|
2013-07-07 21:25:49 +07:00
|
|
|
*cqb = mlx5_vzalloc(*inlen);
|
|
|
|
if (!*cqb) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
goto err_buf;
|
|
|
|
}
|
|
|
|
|
2016-07-16 06:33:22 +07:00
|
|
|
pas = (__be64 *)MLX5_ADDR_OF(create_cq_in, *cqb, pas);
|
|
|
|
mlx5_fill_page_array(&cq->buf.buf, pas);
|
|
|
|
|
|
|
|
cqc = MLX5_ADDR_OF(create_cq_in, *cqb, cq_context);
|
|
|
|
MLX5_SET(cqc, cqc, log_page_size,
|
|
|
|
cq->buf.buf.page_shift - MLX5_ADAPTER_PAGE_SHIFT);
|
|
|
|
|
2017-01-04 04:55:25 +07:00
|
|
|
*index = dev->mdev->priv.uar->index;
|
2013-07-07 21:25:49 +07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_buf:
|
|
|
|
free_cq_buf(dev, &cq->buf);
|
|
|
|
|
|
|
|
err_db:
|
2014-07-29 03:30:22 +07:00
|
|
|
mlx5_db_free(dev->mdev, &cq->db);
|
2013-07-07 21:25:49 +07:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void destroy_cq_kernel(struct mlx5_ib_dev *dev, struct mlx5_ib_cq *cq)
|
|
|
|
{
|
|
|
|
free_cq_buf(dev, &cq->buf);
|
2014-07-29 03:30:22 +07:00
|
|
|
mlx5_db_free(dev->mdev, &cq->db);
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
2016-02-29 20:45:08 +07:00
|
|
|
static void notify_soft_wc_handler(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_cq *cq = container_of(work, struct mlx5_ib_cq,
|
|
|
|
notify_work);
|
|
|
|
|
|
|
|
cq->ibcq.comp_handler(&cq->ibcq, cq->ibcq.cq_context);
|
|
|
|
}
|
|
|
|
|
2015-06-11 20:35:20 +07:00
|
|
|
struct ib_cq *mlx5_ib_create_cq(struct ib_device *ibdev,
|
|
|
|
const struct ib_cq_init_attr *attr,
|
|
|
|
struct ib_ucontext *context,
|
2013-07-07 21:25:49 +07:00
|
|
|
struct ib_udata *udata)
|
|
|
|
{
|
2015-06-11 20:35:20 +07:00
|
|
|
int entries = attr->cqe;
|
|
|
|
int vector = attr->comp_vector;
|
2013-07-07 21:25:49 +07:00
|
|
|
struct mlx5_ib_dev *dev = to_mdev(ibdev);
|
|
|
|
struct mlx5_ib_cq *cq;
|
|
|
|
int uninitialized_var(index);
|
|
|
|
int uninitialized_var(inlen);
|
2016-07-16 06:33:22 +07:00
|
|
|
u32 *cqb = NULL;
|
|
|
|
void *cqc;
|
2013-07-07 21:25:49 +07:00
|
|
|
int cqe_size;
|
2016-01-17 16:25:47 +07:00
|
|
|
unsigned int irqn;
|
2013-07-07 21:25:49 +07:00
|
|
|
int eqn;
|
|
|
|
int err;
|
|
|
|
|
2016-06-04 19:15:34 +07:00
|
|
|
if (entries < 0 ||
|
|
|
|
(entries > (1 << MLX5_CAP_GEN(dev->mdev, log_max_cq_sz))))
|
2013-10-23 13:53:13 +07:00
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
|
2015-12-29 22:01:30 +07:00
|
|
|
if (check_cq_create_flags(attr->flags))
|
2015-12-16 01:30:09 +07:00
|
|
|
return ERR_PTR(-EOPNOTSUPP);
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
entries = roundup_pow_of_two(entries + 1);
|
2015-05-29 02:28:41 +07:00
|
|
|
if (entries > (1 << MLX5_CAP_GEN(dev->mdev, log_max_cq_sz)))
|
2013-07-07 21:25:49 +07:00
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
|
|
|
|
cq = kzalloc(sizeof(*cq), GFP_KERNEL);
|
|
|
|
if (!cq)
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
|
|
|
|
cq->ibcq.cqe = entries - 1;
|
|
|
|
mutex_init(&cq->resize_mutex);
|
|
|
|
spin_lock_init(&cq->lock);
|
|
|
|
cq->resize_buf = NULL;
|
|
|
|
cq->resize_umem = NULL;
|
2015-12-20 17:16:11 +07:00
|
|
|
cq->create_flags = attr->flags;
|
2016-06-17 19:01:38 +07:00
|
|
|
INIT_LIST_HEAD(&cq->list_send_qp);
|
|
|
|
INIT_LIST_HEAD(&cq->list_recv_qp);
|
2013-07-07 21:25:49 +07:00
|
|
|
|
|
|
|
if (context) {
|
|
|
|
err = create_cq_user(dev, udata, context, cq, entries,
|
|
|
|
&cqb, &cqe_size, &index, &inlen);
|
|
|
|
if (err)
|
|
|
|
goto err_create;
|
|
|
|
} else {
|
2016-10-27 20:36:41 +07:00
|
|
|
cqe_size = cache_line_size() == 128 ? 128 : 64;
|
2013-07-07 21:25:49 +07:00
|
|
|
err = create_cq_kernel(dev, cq, entries, cqe_size, &cqb,
|
|
|
|
&index, &inlen);
|
|
|
|
if (err)
|
|
|
|
goto err_create;
|
2016-02-29 20:45:08 +07:00
|
|
|
|
|
|
|
INIT_WORK(&cq->notify_work, notify_soft_wc_handler);
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
2015-04-02 21:07:32 +07:00
|
|
|
err = mlx5_vector2eqn(dev->mdev, vector, &eqn, &irqn);
|
2013-07-07 21:25:49 +07:00
|
|
|
if (err)
|
|
|
|
goto err_cqb;
|
|
|
|
|
2016-07-16 06:33:22 +07:00
|
|
|
cq->cqe_size = cqe_size;
|
|
|
|
|
|
|
|
cqc = MLX5_ADDR_OF(create_cq_in, cqb, cq_context);
|
|
|
|
MLX5_SET(cqc, cqc, cqe_sz, cqe_sz_to_mlx_sz(cqe_size));
|
|
|
|
MLX5_SET(cqc, cqc, log_cq_size, ilog2(entries));
|
|
|
|
MLX5_SET(cqc, cqc, uar_page, index);
|
|
|
|
MLX5_SET(cqc, cqc, c_eqn, eqn);
|
|
|
|
MLX5_SET64(cqc, cqc, dbr_addr, cq->db.dma);
|
|
|
|
if (cq->create_flags & IB_CQ_FLAGS_IGNORE_OVERRUN)
|
|
|
|
MLX5_SET(cqc, cqc, oi, 1);
|
2013-07-07 21:25:49 +07:00
|
|
|
|
2014-07-29 03:30:22 +07:00
|
|
|
err = mlx5_core_create_cq(dev->mdev, &cq->mcq, cqb, inlen);
|
2013-07-07 21:25:49 +07:00
|
|
|
if (err)
|
|
|
|
goto err_cqb;
|
|
|
|
|
|
|
|
mlx5_ib_dbg(dev, "cqn 0x%x\n", cq->mcq.cqn);
|
|
|
|
cq->mcq.irqn = irqn;
|
2016-04-17 21:08:41 +07:00
|
|
|
if (context)
|
|
|
|
cq->mcq.tasklet_ctx.comp = mlx5_ib_cq_comp;
|
|
|
|
else
|
|
|
|
cq->mcq.comp = mlx5_ib_cq_comp;
|
2013-07-07 21:25:49 +07:00
|
|
|
cq->mcq.event = mlx5_ib_cq_event;
|
|
|
|
|
2016-02-29 20:45:08 +07:00
|
|
|
INIT_LIST_HEAD(&cq->wc_list);
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
if (context)
|
|
|
|
if (ib_copy_to_udata(udata, &cq->mcq.cqn, sizeof(__u32))) {
|
|
|
|
err = -EFAULT;
|
|
|
|
goto err_cmd;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-11-20 15:13:57 +07:00
|
|
|
kvfree(cqb);
|
2013-07-07 21:25:49 +07:00
|
|
|
return &cq->ibcq;
|
|
|
|
|
|
|
|
err_cmd:
|
2014-07-29 03:30:22 +07:00
|
|
|
mlx5_core_destroy_cq(dev->mdev, &cq->mcq);
|
2013-07-07 21:25:49 +07:00
|
|
|
|
|
|
|
err_cqb:
|
2014-11-20 15:13:57 +07:00
|
|
|
kvfree(cqb);
|
2013-07-07 21:25:49 +07:00
|
|
|
if (context)
|
|
|
|
destroy_cq_user(cq, context);
|
|
|
|
else
|
|
|
|
destroy_cq_kernel(dev, cq);
|
|
|
|
|
|
|
|
err_create:
|
|
|
|
kfree(cq);
|
|
|
|
|
|
|
|
return ERR_PTR(err);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
int mlx5_ib_destroy_cq(struct ib_cq *cq)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_dev *dev = to_mdev(cq->device);
|
|
|
|
struct mlx5_ib_cq *mcq = to_mcq(cq);
|
|
|
|
struct ib_ucontext *context = NULL;
|
|
|
|
|
|
|
|
if (cq->uobject)
|
|
|
|
context = cq->uobject->context;
|
|
|
|
|
2014-07-29 03:30:22 +07:00
|
|
|
mlx5_core_destroy_cq(dev->mdev, &mcq->mcq);
|
2013-07-07 21:25:49 +07:00
|
|
|
if (context)
|
|
|
|
destroy_cq_user(mcq, context);
|
|
|
|
else
|
|
|
|
destroy_cq_kernel(dev, mcq);
|
|
|
|
|
|
|
|
kfree(mcq);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-10-23 13:53:17 +07:00
|
|
|
static int is_equal_rsn(struct mlx5_cqe64 *cqe64, u32 rsn)
|
2013-07-07 21:25:49 +07:00
|
|
|
{
|
2013-10-23 13:53:17 +07:00
|
|
|
return rsn == (ntohl(cqe64->sop_drop_qpn) & 0xffffff);
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
void __mlx5_ib_cq_clean(struct mlx5_ib_cq *cq, u32 rsn, struct mlx5_ib_srq *srq)
|
|
|
|
{
|
|
|
|
struct mlx5_cqe64 *cqe64, *dest64;
|
|
|
|
void *cqe, *dest;
|
|
|
|
u32 prod_index;
|
|
|
|
int nfreed = 0;
|
|
|
|
u8 owner_bit;
|
|
|
|
|
|
|
|
if (!cq)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* First we need to find the current producer index, so we
|
|
|
|
* know where to start cleaning from. It doesn't matter if HW
|
|
|
|
* adds new entries after this loop -- the QP we're worried
|
|
|
|
* about is already in RESET, so the new entries won't come
|
|
|
|
* from our QP and therefore don't need to be checked.
|
|
|
|
*/
|
|
|
|
for (prod_index = cq->mcq.cons_index; get_sw_cqe(cq, prod_index); prod_index++)
|
|
|
|
if (prod_index == cq->mcq.cons_index + cq->ibcq.cqe)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Now sweep backwards through the CQ, removing CQ entries
|
|
|
|
* that match our QP by copying older entries on top of them.
|
|
|
|
*/
|
|
|
|
while ((int) --prod_index - (int) cq->mcq.cons_index >= 0) {
|
|
|
|
cqe = get_cqe(cq, prod_index & cq->ibcq.cqe);
|
|
|
|
cqe64 = (cq->mcq.cqe_sz == 64) ? cqe : cqe + 64;
|
2013-10-23 13:53:17 +07:00
|
|
|
if (is_equal_rsn(cqe64, rsn)) {
|
|
|
|
if (srq && (ntohl(cqe64->srqn) & 0xffffff))
|
2013-07-07 21:25:49 +07:00
|
|
|
mlx5_ib_free_srq_wqe(srq, be16_to_cpu(cqe64->wqe_counter));
|
|
|
|
++nfreed;
|
|
|
|
} else if (nfreed) {
|
|
|
|
dest = get_cqe(cq, (prod_index + nfreed) & cq->ibcq.cqe);
|
|
|
|
dest64 = (cq->mcq.cqe_sz == 64) ? dest : dest + 64;
|
|
|
|
owner_bit = dest64->op_own & MLX5_CQE_OWNER_MASK;
|
|
|
|
memcpy(dest, cqe, cq->mcq.cqe_sz);
|
|
|
|
dest64->op_own = owner_bit |
|
|
|
|
(dest64->op_own & ~MLX5_CQE_OWNER_MASK);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (nfreed) {
|
|
|
|
cq->mcq.cons_index += nfreed;
|
|
|
|
/* Make sure update of buffer contents is done before
|
|
|
|
* updating consumer index.
|
|
|
|
*/
|
|
|
|
wmb();
|
|
|
|
mlx5_cq_set_ci(&cq->mcq);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void mlx5_ib_cq_clean(struct mlx5_ib_cq *cq, u32 qpn, struct mlx5_ib_srq *srq)
|
|
|
|
{
|
|
|
|
if (!cq)
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_irq(&cq->lock);
|
|
|
|
__mlx5_ib_cq_clean(cq, qpn, srq);
|
|
|
|
spin_unlock_irq(&cq->lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
int mlx5_ib_modify_cq(struct ib_cq *cq, u16 cq_count, u16 cq_period)
|
|
|
|
{
|
2014-01-14 22:45:17 +07:00
|
|
|
struct mlx5_ib_dev *dev = to_mdev(cq->device);
|
|
|
|
struct mlx5_ib_cq *mcq = to_mcq(cq);
|
|
|
|
int err;
|
|
|
|
|
2015-05-29 02:28:41 +07:00
|
|
|
if (!MLX5_CAP_GEN(dev->mdev, cq_moderation))
|
2014-01-14 22:45:17 +07:00
|
|
|
return -ENOSYS;
|
|
|
|
|
2016-07-16 06:33:22 +07:00
|
|
|
err = mlx5_core_modify_cq_moderation(dev->mdev, &mcq->mcq,
|
|
|
|
cq_period, cq_count);
|
2014-01-14 22:45:17 +07:00
|
|
|
if (err)
|
|
|
|
mlx5_ib_warn(dev, "modify cq 0x%x failed\n", mcq->mcq.cqn);
|
|
|
|
|
|
|
|
return err;
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
static int resize_user(struct mlx5_ib_dev *dev, struct mlx5_ib_cq *cq,
|
|
|
|
int entries, struct ib_udata *udata, int *npas,
|
|
|
|
int *page_shift, int *cqe_size)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_resize_cq ucmd;
|
|
|
|
struct ib_umem *umem;
|
|
|
|
int err;
|
|
|
|
int npages;
|
|
|
|
struct ib_ucontext *context = cq->buf.umem->context;
|
|
|
|
|
2014-01-15 19:56:44 +07:00
|
|
|
err = ib_copy_from_udata(&ucmd, udata, sizeof(ucmd));
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
if (ucmd.reserved0 || ucmd.reserved1)
|
|
|
|
return -EINVAL;
|
2014-01-14 22:45:18 +07:00
|
|
|
|
|
|
|
umem = ib_umem_get(context, ucmd.buf_addr, entries * ucmd.cqe_size,
|
|
|
|
IB_ACCESS_LOCAL_WRITE, 1);
|
|
|
|
if (IS_ERR(umem)) {
|
|
|
|
err = PTR_ERR(umem);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2016-10-27 20:36:47 +07:00
|
|
|
mlx5_ib_cont_pages(umem, ucmd.buf_addr, 0, &npages, page_shift,
|
2014-01-14 22:45:18 +07:00
|
|
|
npas, NULL);
|
|
|
|
|
|
|
|
cq->resize_umem = umem;
|
|
|
|
*cqe_size = ucmd.cqe_size;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void un_resize_user(struct mlx5_ib_cq *cq)
|
|
|
|
{
|
|
|
|
ib_umem_release(cq->resize_umem);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int resize_kernel(struct mlx5_ib_dev *dev, struct mlx5_ib_cq *cq,
|
|
|
|
int entries, int cqe_size)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
|
|
|
cq->resize_buf = kzalloc(sizeof(*cq->resize_buf), GFP_KERNEL);
|
|
|
|
if (!cq->resize_buf)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
err = alloc_cq_buf(dev, cq->resize_buf, entries, cqe_size);
|
|
|
|
if (err)
|
|
|
|
goto ex;
|
|
|
|
|
|
|
|
init_cq_buf(cq, cq->resize_buf);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
ex:
|
|
|
|
kfree(cq->resize_buf);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void un_resize_kernel(struct mlx5_ib_dev *dev, struct mlx5_ib_cq *cq)
|
|
|
|
{
|
|
|
|
free_cq_buf(dev, cq->resize_buf);
|
|
|
|
cq->resize_buf = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int copy_resize_cqes(struct mlx5_ib_cq *cq)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_dev *dev = to_mdev(cq->ibcq.device);
|
|
|
|
struct mlx5_cqe64 *scqe64;
|
|
|
|
struct mlx5_cqe64 *dcqe64;
|
|
|
|
void *start_cqe;
|
|
|
|
void *scqe;
|
|
|
|
void *dcqe;
|
|
|
|
int ssize;
|
|
|
|
int dsize;
|
|
|
|
int i;
|
|
|
|
u8 sw_own;
|
|
|
|
|
|
|
|
ssize = cq->buf.cqe_size;
|
|
|
|
dsize = cq->resize_buf->cqe_size;
|
|
|
|
if (ssize != dsize) {
|
|
|
|
mlx5_ib_warn(dev, "resize from different cqe size is not supported\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
i = cq->mcq.cons_index;
|
|
|
|
scqe = get_sw_cqe(cq, i);
|
|
|
|
scqe64 = ssize == 64 ? scqe : scqe + 64;
|
|
|
|
start_cqe = scqe;
|
|
|
|
if (!scqe) {
|
|
|
|
mlx5_ib_warn(dev, "expected cqe in sw ownership\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
while ((scqe64->op_own >> 4) != MLX5_CQE_RESIZE_CQ) {
|
|
|
|
dcqe = get_cqe_from_buf(cq->resize_buf,
|
|
|
|
(i + 1) & (cq->resize_buf->nent),
|
|
|
|
dsize);
|
|
|
|
dcqe64 = dsize == 64 ? dcqe : dcqe + 64;
|
|
|
|
sw_own = sw_ownership_bit(i + 1, cq->resize_buf->nent);
|
|
|
|
memcpy(dcqe, scqe, dsize);
|
|
|
|
dcqe64->op_own = (dcqe64->op_own & ~MLX5_CQE_OWNER_MASK) | sw_own;
|
|
|
|
|
|
|
|
++i;
|
|
|
|
scqe = get_sw_cqe(cq, i);
|
|
|
|
scqe64 = ssize == 64 ? scqe : scqe + 64;
|
|
|
|
if (!scqe) {
|
|
|
|
mlx5_ib_warn(dev, "expected cqe in sw ownership\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (scqe == start_cqe) {
|
|
|
|
pr_warn("resize CQ failed to get resize CQE, CQN 0x%x\n",
|
|
|
|
cq->mcq.cqn);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
++cq->mcq.cons_index;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-07-07 21:25:49 +07:00
|
|
|
int mlx5_ib_resize_cq(struct ib_cq *ibcq, int entries, struct ib_udata *udata)
|
|
|
|
{
|
2014-01-14 22:45:18 +07:00
|
|
|
struct mlx5_ib_dev *dev = to_mdev(ibcq->device);
|
|
|
|
struct mlx5_ib_cq *cq = to_mcq(ibcq);
|
2016-07-16 06:33:22 +07:00
|
|
|
void *cqc;
|
|
|
|
u32 *in;
|
2014-01-14 22:45:18 +07:00
|
|
|
int err;
|
|
|
|
int npas;
|
2016-07-16 06:33:22 +07:00
|
|
|
__be64 *pas;
|
2014-01-14 22:45:18 +07:00
|
|
|
int page_shift;
|
|
|
|
int inlen;
|
|
|
|
int uninitialized_var(cqe_size);
|
|
|
|
unsigned long flags;
|
|
|
|
|
2015-05-29 02:28:41 +07:00
|
|
|
if (!MLX5_CAP_GEN(dev->mdev, cq_resize)) {
|
2014-01-14 22:45:18 +07:00
|
|
|
pr_info("Firmware does not support resize CQ\n");
|
|
|
|
return -ENOSYS;
|
|
|
|
}
|
|
|
|
|
2016-06-04 19:15:35 +07:00
|
|
|
if (entries < 1 ||
|
|
|
|
entries > (1 << MLX5_CAP_GEN(dev->mdev, log_max_cq_sz))) {
|
|
|
|
mlx5_ib_warn(dev, "wrong entries number %d, max %d\n",
|
|
|
|
entries,
|
|
|
|
1 << MLX5_CAP_GEN(dev->mdev, log_max_cq_sz));
|
2014-01-14 22:45:18 +07:00
|
|
|
return -EINVAL;
|
2016-06-04 19:15:35 +07:00
|
|
|
}
|
2014-01-14 22:45:18 +07:00
|
|
|
|
|
|
|
entries = roundup_pow_of_two(entries + 1);
|
2016-06-04 19:15:35 +07:00
|
|
|
if (entries > (1 << MLX5_CAP_GEN(dev->mdev, log_max_cq_sz)) + 1)
|
2014-01-14 22:45:18 +07:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (entries == ibcq->cqe + 1)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
mutex_lock(&cq->resize_mutex);
|
|
|
|
if (udata) {
|
|
|
|
err = resize_user(dev, cq, entries, udata, &npas, &page_shift,
|
|
|
|
&cqe_size);
|
|
|
|
} else {
|
|
|
|
cqe_size = 64;
|
|
|
|
err = resize_kernel(dev, cq, entries, cqe_size);
|
|
|
|
if (!err) {
|
|
|
|
npas = cq->resize_buf->buf.npages;
|
|
|
|
page_shift = cq->resize_buf->buf.page_shift;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (err)
|
|
|
|
goto ex;
|
|
|
|
|
2016-07-16 06:33:22 +07:00
|
|
|
inlen = MLX5_ST_SZ_BYTES(modify_cq_in) +
|
|
|
|
MLX5_FLD_SZ_BYTES(modify_cq_in, pas[0]) * npas;
|
|
|
|
|
2014-01-14 22:45:18 +07:00
|
|
|
in = mlx5_vzalloc(inlen);
|
|
|
|
if (!in) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
goto ex_resize;
|
|
|
|
}
|
|
|
|
|
2016-07-16 06:33:22 +07:00
|
|
|
pas = (__be64 *)MLX5_ADDR_OF(modify_cq_in, in, pas);
|
2014-01-14 22:45:18 +07:00
|
|
|
if (udata)
|
|
|
|
mlx5_ib_populate_pas(dev, cq->resize_umem, page_shift,
|
2016-07-16 06:33:22 +07:00
|
|
|
pas, 0);
|
2014-01-14 22:45:18 +07:00
|
|
|
else
|
2016-07-16 06:33:22 +07:00
|
|
|
mlx5_fill_page_array(&cq->resize_buf->buf, pas);
|
|
|
|
|
|
|
|
MLX5_SET(modify_cq_in, in,
|
|
|
|
modify_field_select_resize_field_select.resize_field_select.resize_field_select,
|
|
|
|
MLX5_MODIFY_CQ_MASK_LOG_SIZE |
|
|
|
|
MLX5_MODIFY_CQ_MASK_PG_OFFSET |
|
|
|
|
MLX5_MODIFY_CQ_MASK_PG_SIZE);
|
|
|
|
|
|
|
|
cqc = MLX5_ADDR_OF(modify_cq_in, in, cq_context);
|
|
|
|
|
|
|
|
MLX5_SET(cqc, cqc, log_page_size,
|
|
|
|
page_shift - MLX5_ADAPTER_PAGE_SHIFT);
|
|
|
|
MLX5_SET(cqc, cqc, cqe_sz, cqe_sz_to_mlx_sz(cqe_size));
|
|
|
|
MLX5_SET(cqc, cqc, log_cq_size, ilog2(entries));
|
|
|
|
|
|
|
|
MLX5_SET(modify_cq_in, in, op_mod, MLX5_CQ_OPMOD_RESIZE);
|
|
|
|
MLX5_SET(modify_cq_in, in, cqn, cq->mcq.cqn);
|
2014-01-14 22:45:18 +07:00
|
|
|
|
2014-07-29 03:30:22 +07:00
|
|
|
err = mlx5_core_modify_cq(dev->mdev, &cq->mcq, in, inlen);
|
2014-01-14 22:45:18 +07:00
|
|
|
if (err)
|
|
|
|
goto ex_alloc;
|
|
|
|
|
|
|
|
if (udata) {
|
|
|
|
cq->ibcq.cqe = entries - 1;
|
|
|
|
ib_umem_release(cq->buf.umem);
|
|
|
|
cq->buf.umem = cq->resize_umem;
|
|
|
|
cq->resize_umem = NULL;
|
|
|
|
} else {
|
|
|
|
struct mlx5_ib_cq_buf tbuf;
|
|
|
|
int resized = 0;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&cq->lock, flags);
|
|
|
|
if (cq->resize_buf) {
|
|
|
|
err = copy_resize_cqes(cq);
|
|
|
|
if (!err) {
|
|
|
|
tbuf = cq->buf;
|
|
|
|
cq->buf = *cq->resize_buf;
|
|
|
|
kfree(cq->resize_buf);
|
|
|
|
cq->resize_buf = NULL;
|
|
|
|
resized = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
cq->ibcq.cqe = entries - 1;
|
|
|
|
spin_unlock_irqrestore(&cq->lock, flags);
|
|
|
|
if (resized)
|
|
|
|
free_cq_buf(dev, &tbuf);
|
|
|
|
}
|
|
|
|
mutex_unlock(&cq->resize_mutex);
|
|
|
|
|
2014-11-20 15:13:57 +07:00
|
|
|
kvfree(in);
|
2014-01-14 22:45:18 +07:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
ex_alloc:
|
2014-11-20 15:13:57 +07:00
|
|
|
kvfree(in);
|
2014-01-14 22:45:18 +07:00
|
|
|
|
|
|
|
ex_resize:
|
|
|
|
if (udata)
|
|
|
|
un_resize_user(cq);
|
|
|
|
else
|
|
|
|
un_resize_kernel(dev, cq);
|
|
|
|
ex:
|
|
|
|
mutex_unlock(&cq->resize_mutex);
|
|
|
|
return err;
|
2013-07-07 21:25:49 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
int mlx5_ib_get_cqe_size(struct mlx5_ib_dev *dev, struct ib_cq *ibcq)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_cq *cq;
|
|
|
|
|
|
|
|
if (!ibcq)
|
|
|
|
return 128;
|
|
|
|
|
|
|
|
cq = to_mcq(ibcq);
|
|
|
|
return cq->cqe_size;
|
|
|
|
}
|
2016-02-29 20:45:08 +07:00
|
|
|
|
|
|
|
/* Called from atomic context */
|
|
|
|
int mlx5_ib_generate_wc(struct ib_cq *ibcq, struct ib_wc *wc)
|
|
|
|
{
|
|
|
|
struct mlx5_ib_wc *soft_wc;
|
|
|
|
struct mlx5_ib_cq *cq = to_mcq(ibcq);
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
soft_wc = kmalloc(sizeof(*soft_wc), GFP_ATOMIC);
|
|
|
|
if (!soft_wc)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
soft_wc->wc = *wc;
|
|
|
|
spin_lock_irqsave(&cq->lock, flags);
|
|
|
|
list_add_tail(&soft_wc->list, &cq->wc_list);
|
|
|
|
if (cq->notify_flags == IB_CQ_NEXT_COMP ||
|
|
|
|
wc->status != IB_WC_SUCCESS) {
|
|
|
|
cq->notify_flags = 0;
|
|
|
|
schedule_work(&cq->notify_work);
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&cq->lock, flags);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|