2014-06-10 21:06:10 +07:00
|
|
|
menuconfig ARCH_U300
|
ARM: use "depends on" for SoC configs instead of "if" after prompt
Many ARM sub-architectures use prompts followed by "if" conditional,
but it is wrong.
Please notice the difference between
config ARCH_FOO
bool "Foo SoCs" if ARCH_MULTI_V7
and
config ARCH_FOO
bool "Foo SoCs"
depends on ARCH_MULTI_V7
These two are *not* equivalent!
In the former statement, it is not ARCH_FOO, but its prompt that
depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
not unmet dependency, Kconfig never warns. This is probably not what
you want.
The former should be used only when you need to do so, and you really
understand what you are doing. (In most cases, it should be wrong!)
For enabling/disabling sub-architectures, the latter is always correct.
As a good side effect, this commit fixes some entries over 80 columns
(mach-imx, mach-integrator, mach-mbevu).
[Arnd: I note that there is not really a bug here, according to
the discussion that followed, but I can see value in being consistent
and in making the lines shorter]
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Jun Nie <jun.nie@linaro.org>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Krzysztof Halasa <khc@piap.pl>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
2015-11-16 10:06:10 +07:00
|
|
|
bool "ST-Ericsson U300 Series"
|
|
|
|
|
depends on ARCH_MULTI_V5 && MMU
|
2013-05-02 23:01:46 +07:00
|
|
|
select ARM_AMBA
|
|
|
|
|
select ARM_VIC
|
2016-06-03 19:31:16 +07:00
|
|
|
select U300_TIMER
|
2013-05-02 23:01:46 +07:00
|
|
|
select CPU_ARM926T
|
2016-06-02 19:10:16 +07:00
|
|
|
select GPIOLIB
|
2013-05-02 23:01:46 +07:00
|
|
|
select HAVE_TCM
|
2011-05-03 01:54:38 +07:00
|
|
|
select PINCTRL
|
2011-11-16 15:22:59 +07:00
|
|
|
select PINCTRL_COH901
|
ARM: config: sort select statements alphanumerically
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
lets sort all our select statements alphanumerically. This commit was
created by the following perl:
while (<>) {
while (/\\\s*$/) {
$_ .= <>;
}
undef %selects if /^\s*config\s+/;
if (/^\s+select\s+(\w+).*/) {
if (defined($selects{$1})) {
if ($selects{$1} eq $_) {
print STDERR "Warning: removing duplicated $1 entry\n";
} else {
print STDERR "Error: $1 differently selected\n".
"\tOld: $selects{$1}\n".
"\tNew: $_\n";
exit 1;
}
}
$selects{$1} = $_;
next;
}
if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
/^endif/ or /^endchoice/)) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
undef %selects;
}
print;
}
if (%selects) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
}
It found two duplicates:
Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry
and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.
We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2012-10-06 23:12:25 +07:00
|
|
|
select PINCTRL_U300
|
2013-06-14 02:21:31 +07:00
|
|
|
select MFD_SYSCON
|
2013-05-02 23:01:46 +07:00
|
|
|
help
|
|
|
|
|
Support for ST-Ericsson U300 series mobile platforms.
|
2009-04-23 16:22:13 +07:00
|
|
|
|
2013-09-18 20:08:52 +07:00
|
|
|
if ARCH_U300
|
|
|
|
|
|
2013-05-02 23:01:46 +07:00
|
|
|
config MACH_U300
|
|
|
|
|
depends on ARCH_U300
|
|
|
|
|
bool "U300"
|
|
|
|
|
default y
|
|
|
|
|
|
2009-04-23 16:22:13 +07:00
|
|
|
config U300_DEBUG
|
2013-05-02 23:01:46 +07:00
|
|
|
depends on ARCH_U300
|
2009-04-23 16:22:13 +07:00
|
|
|
bool "Debug support for U300"
|
|
|
|
|
depends on PM
|
|
|
|
|
help
|
|
|
|
|
Debug support for U300 in sysfs, procfs etc.
|
|
|
|
|
|
2009-08-14 16:59:05 +07:00
|
|
|
config MACH_U300_SPIDUMMY
|
2013-05-02 23:01:46 +07:00
|
|
|
depends on ARCH_U300
|
2009-08-14 16:59:05 +07:00
|
|
|
bool "SSP/SPI dummy chip"
|
|
|
|
|
select SPI
|
|
|
|
|
select SPI_MASTER
|
|
|
|
|
select SPI_PL022
|
|
|
|
|
help
|
|
|
|
|
This creates a small kernel module that creates a dummy
|
|
|
|
|
SPI device to be used for loopback tests. Regularly used
|
|
|
|
|
to test reference designs. If you're not testing SPI,
|
|
|
|
|
you don't need it. Selecting this will activate the
|
|
|
|
|
SPI framework and ARM PL022 support.
|
|
|
|
|
|
2013-09-18 20:08:52 +07:00
|
|
|
endif
|