2010-05-13 21:57:33 +07:00
|
|
|
/*
|
|
|
|
* NAND Flash Controller Device Driver
|
|
|
|
* Copyright © 2009-2010, Intel Corporation and its suppliers.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
|
|
* under the terms and conditions of the GNU General Public License,
|
|
|
|
* version 2, as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
|
|
* more details.
|
|
|
|
*/
|
2017-09-22 10:46:40 +07:00
|
|
|
|
2017-09-22 10:46:43 +07:00
|
|
|
#include <linux/bitfield.h>
|
2017-09-22 10:46:40 +07:00
|
|
|
#include <linux/completion.h>
|
2011-05-06 21:28:55 +07:00
|
|
|
#include <linux/dma-mapping.h>
|
2017-09-22 10:46:40 +07:00
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/io.h>
|
2010-05-13 21:57:33 +07:00
|
|
|
#include <linux/module.h>
|
2017-09-22 10:46:40 +07:00
|
|
|
#include <linux/mtd/mtd.h>
|
|
|
|
#include <linux/mtd/rawnand.h>
|
2017-06-13 20:45:48 +07:00
|
|
|
#include <linux/slab.h>
|
2017-09-22 10:46:40 +07:00
|
|
|
#include <linux/spinlock.h>
|
2010-05-13 21:57:33 +07:00
|
|
|
|
|
|
|
#include "denali.h"
|
|
|
|
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
|
|
|
|
#define DENALI_NAND_NAME "denali-nand"
|
|
|
|
|
2017-09-22 10:46:48 +07:00
|
|
|
/* for Indexed Addressing */
|
|
|
|
#define DENALI_INDEXED_CTRL 0x00
|
|
|
|
#define DENALI_INDEXED_DATA 0x10
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
|
|
|
|
#define DENALI_MAP00 (0 << 26) /* direct access to buffer */
|
|
|
|
#define DENALI_MAP01 (1 << 26) /* read/write pages in PIO */
|
|
|
|
#define DENALI_MAP10 (2 << 26) /* high-level control plane */
|
|
|
|
#define DENALI_MAP11 (3 << 26) /* direct controller access */
|
|
|
|
|
|
|
|
/* MAP11 access cycle type */
|
|
|
|
#define DENALI_MAP11_CMD ((DENALI_MAP11) | 0) /* command cycle */
|
|
|
|
#define DENALI_MAP11_ADDR ((DENALI_MAP11) | 1) /* address cycle */
|
|
|
|
#define DENALI_MAP11_DATA ((DENALI_MAP11) | 2) /* data cycle */
|
|
|
|
|
|
|
|
/* MAP10 commands */
|
|
|
|
#define DENALI_ERASE 0x01
|
|
|
|
|
|
|
|
#define DENALI_BANK(denali) ((denali)->active_bank << 24)
|
2010-05-13 21:57:33 +07:00
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
#define DENALI_INVALID_BANK -1
|
2017-06-13 20:45:38 +07:00
|
|
|
#define DENALI_NR_BANKS 4
|
|
|
|
|
2015-12-11 21:06:00 +07:00
|
|
|
static inline struct denali_nand_info *mtd_to_denali(struct mtd_info *mtd)
|
|
|
|
{
|
|
|
|
return container_of(mtd_to_nand(mtd), struct denali_nand_info, nand);
|
|
|
|
}
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-09-22 10:46:48 +07:00
|
|
|
/*
|
|
|
|
* Direct Addressing - the slave address forms the control information (command
|
|
|
|
* type, bank, block, and page address). The slave data is the actual data to
|
|
|
|
* be transferred. This mode requires 28 bits of address region allocated.
|
|
|
|
*/
|
|
|
|
static u32 denali_direct_read(struct denali_nand_info *denali, u32 addr)
|
|
|
|
{
|
|
|
|
return ioread32(denali->host + addr);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_direct_write(struct denali_nand_info *denali, u32 addr,
|
|
|
|
u32 data)
|
|
|
|
{
|
|
|
|
iowrite32(data, denali->host + addr);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Indexed Addressing - address translation module intervenes in passing the
|
|
|
|
* control information. This mode reduces the required address range. The
|
|
|
|
* control information and transferred data are latched by the registers in
|
|
|
|
* the translation module.
|
|
|
|
*/
|
|
|
|
static u32 denali_indexed_read(struct denali_nand_info *denali, u32 addr)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-09-22 10:46:48 +07:00
|
|
|
iowrite32(addr, denali->host + DENALI_INDEXED_CTRL);
|
|
|
|
return ioread32(denali->host + DENALI_INDEXED_DATA);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_indexed_write(struct denali_nand_info *denali, u32 addr,
|
|
|
|
u32 data)
|
|
|
|
{
|
|
|
|
iowrite32(addr, denali->host + DENALI_INDEXED_CTRL);
|
|
|
|
iowrite32(data, denali->host + DENALI_INDEXED_DATA);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2011-05-06 21:28:57 +07:00
|
|
|
/*
|
|
|
|
* Use the configuration feature register to determine the maximum number of
|
|
|
|
* banks that the hardware supports.
|
|
|
|
*/
|
2017-09-22 10:46:39 +07:00
|
|
|
static void denali_detect_max_banks(struct denali_nand_info *denali)
|
2011-05-06 21:28:57 +07:00
|
|
|
{
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
uint32_t features = ioread32(denali->reg + FEATURES);
|
2011-05-06 21:28:57 +07:00
|
|
|
|
2017-09-22 10:46:44 +07:00
|
|
|
denali->max_banks = 1 << FIELD_GET(FEATURES__N_BANKS, features);
|
2017-03-30 13:45:57 +07:00
|
|
|
|
|
|
|
/* the encoding changed from rev 5.0 to 5.1 */
|
|
|
|
if (denali->revision < 0x0501)
|
|
|
|
denali->max_banks <<= 1;
|
2011-05-06 21:28:57 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
static void denali_enable_irq(struct denali_nand_info *denali)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:38 +07:00
|
|
|
int i;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
for (i = 0; i < DENALI_NR_BANKS; i++)
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(U32_MAX, denali->reg + INTR_EN(i));
|
|
|
|
iowrite32(GLOBAL_INT_EN_FLAG, denali->reg + GLOBAL_INT_ENABLE);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
static void denali_disable_irq(struct denali_nand_info *denali)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2011-05-06 21:28:56 +07:00
|
|
|
int i;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
for (i = 0; i < DENALI_NR_BANKS; i++)
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(0, denali->reg + INTR_EN(i));
|
|
|
|
iowrite32(0, denali->reg + GLOBAL_INT_ENABLE);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
static void denali_clear_irq(struct denali_nand_info *denali,
|
|
|
|
int bank, uint32_t irq_status)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:38 +07:00
|
|
|
/* write one to clear bits */
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(irq_status, denali->reg + INTR_STATUS(bank));
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
static void denali_clear_irq_all(struct denali_nand_info *denali)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2011-05-06 21:28:56 +07:00
|
|
|
int i;
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
for (i = 0; i < DENALI_NR_BANKS; i++)
|
|
|
|
denali_clear_irq(denali, i, U32_MAX);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
static irqreturn_t denali_isr(int irq, void *dev_id)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:38 +07:00
|
|
|
struct denali_nand_info *denali = dev_id;
|
|
|
|
irqreturn_t ret = IRQ_NONE;
|
|
|
|
uint32_t irq_status;
|
|
|
|
int i;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
spin_lock(&denali->irq_lock);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
for (i = 0; i < DENALI_NR_BANKS; i++) {
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
irq_status = ioread32(denali->reg + INTR_STATUS(i));
|
2017-06-13 20:45:38 +07:00
|
|
|
if (irq_status)
|
|
|
|
ret = IRQ_HANDLED;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
denali_clear_irq(denali, i, irq_status);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
if (i != denali->active_bank)
|
2017-06-13 20:45:38 +07:00
|
|
|
continue;
|
|
|
|
|
|
|
|
denali->irq_status |= irq_status;
|
2014-09-09 09:01:52 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
if (denali->irq_status & denali->irq_mask)
|
|
|
|
complete(&denali->complete);
|
|
|
|
}
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
spin_unlock(&denali->irq_lock);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
return ret;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
static void denali_reset_irq(struct denali_nand_info *denali)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:38 +07:00
|
|
|
unsigned long flags;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
spin_lock_irqsave(&denali->irq_lock, flags);
|
|
|
|
denali->irq_status = 0;
|
|
|
|
denali->irq_mask = 0;
|
|
|
|
spin_unlock_irqrestore(&denali->irq_lock, flags);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
static uint32_t denali_wait_for_irq(struct denali_nand_info *denali,
|
|
|
|
uint32_t irq_mask)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:38 +07:00
|
|
|
unsigned long time_left, flags;
|
2014-09-09 09:01:52 +07:00
|
|
|
uint32_t irq_status;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
spin_lock_irqsave(&denali->irq_lock, flags);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
irq_status = denali->irq_status;
|
|
|
|
|
|
|
|
if (irq_mask & irq_status) {
|
|
|
|
/* return immediately if the IRQ has already happened. */
|
|
|
|
spin_unlock_irqrestore(&denali->irq_lock, flags);
|
|
|
|
return irq_status;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
2017-06-13 20:45:38 +07:00
|
|
|
|
|
|
|
denali->irq_mask = irq_mask;
|
|
|
|
reinit_completion(&denali->complete);
|
|
|
|
spin_unlock_irqrestore(&denali->irq_lock, flags);
|
|
|
|
|
|
|
|
time_left = wait_for_completion_timeout(&denali->complete,
|
|
|
|
msecs_to_jiffies(1000));
|
|
|
|
if (!time_left) {
|
|
|
|
dev_err(denali->dev, "timeout while waiting for irq 0x%x\n",
|
2017-09-22 10:46:42 +07:00
|
|
|
irq_mask);
|
2017-06-13 20:45:38 +07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return denali->irq_status;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:39 +07:00
|
|
|
static uint32_t denali_check_irq(struct denali_nand_info *denali)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:39 +07:00
|
|
|
unsigned long flags;
|
2017-06-13 20:45:38 +07:00
|
|
|
uint32_t irq_status;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:39 +07:00
|
|
|
spin_lock_irqsave(&denali->irq_lock, flags);
|
|
|
|
irq_status = denali->irq_status;
|
|
|
|
spin_unlock_irqrestore(&denali->irq_lock, flags);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:39 +07:00
|
|
|
return irq_status;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:39 +07:00
|
|
|
static void denali_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2017-09-22 10:46:48 +07:00
|
|
|
u32 addr = DENALI_MAP11_DATA | DENALI_BANK(denali);
|
2017-06-13 20:45:39 +07:00
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < len; i++)
|
2017-09-22 10:46:48 +07:00
|
|
|
buf[i] = denali->host_read(denali, addr);
|
2017-06-13 20:45:39 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_write_buf(struct mtd_info *mtd, const uint8_t *buf, int len)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2017-09-22 10:46:48 +07:00
|
|
|
u32 addr = DENALI_MAP11_DATA | DENALI_BANK(denali);
|
2017-06-13 20:45:39 +07:00
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < len; i++)
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, addr, buf[i]);
|
2017-06-13 20:45:39 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_read_buf16(struct mtd_info *mtd, uint8_t *buf, int len)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2017-09-22 10:46:48 +07:00
|
|
|
u32 addr = DENALI_MAP11_DATA | DENALI_BANK(denali);
|
2017-06-13 20:45:39 +07:00
|
|
|
uint16_t *buf16 = (uint16_t *)buf;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < len / 2; i++)
|
2017-09-22 10:46:48 +07:00
|
|
|
buf16[i] = denali->host_read(denali, addr);
|
2017-06-13 20:45:39 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_write_buf16(struct mtd_info *mtd, const uint8_t *buf,
|
|
|
|
int len)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2017-09-22 10:46:48 +07:00
|
|
|
u32 addr = DENALI_MAP11_DATA | DENALI_BANK(denali);
|
2017-06-13 20:45:39 +07:00
|
|
|
const uint16_t *buf16 = (const uint16_t *)buf;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < len / 2; i++)
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, addr, buf16[i]);
|
2017-06-13 20:45:39 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static uint8_t denali_read_byte(struct mtd_info *mtd)
|
|
|
|
{
|
|
|
|
uint8_t byte;
|
|
|
|
|
|
|
|
denali_read_buf(mtd, &byte, 1);
|
|
|
|
|
|
|
|
return byte;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_write_byte(struct mtd_info *mtd, uint8_t byte)
|
|
|
|
{
|
|
|
|
denali_write_buf(mtd, &byte, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint16_t denali_read_word(struct mtd_info *mtd)
|
|
|
|
{
|
|
|
|
uint16_t word;
|
|
|
|
|
|
|
|
denali_read_buf16(mtd, (uint8_t *)&word, 2);
|
|
|
|
|
|
|
|
return word;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_cmd_ctrl(struct mtd_info *mtd, int dat, unsigned int ctrl)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
uint32_t type;
|
|
|
|
|
|
|
|
if (ctrl & NAND_CLE)
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
type = DENALI_MAP11_CMD;
|
2017-06-13 20:45:39 +07:00
|
|
|
else if (ctrl & NAND_ALE)
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
type = DENALI_MAP11_ADDR;
|
2017-06-13 20:45:39 +07:00
|
|
|
else
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Some commands are followed by chip->dev_ready or chip->waitfunc.
|
|
|
|
* irq_status must be cleared here to catch the R/B# interrupt later.
|
|
|
|
*/
|
|
|
|
if (ctrl & NAND_CTRL_CHANGE)
|
|
|
|
denali_reset_irq(denali);
|
|
|
|
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, DENALI_BANK(denali) | type, dat);
|
2017-06-13 20:45:39 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_dev_ready(struct mtd_info *mtd)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
|
|
|
|
return !!(denali_check_irq(denali) & INTR__INT_ACT);
|
|
|
|
}
|
|
|
|
|
2017-03-30 13:45:51 +07:00
|
|
|
static int denali_check_erased_page(struct mtd_info *mtd,
|
|
|
|
struct nand_chip *chip, uint8_t *buf,
|
|
|
|
unsigned long uncor_ecc_flags,
|
|
|
|
unsigned int max_bitflips)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-12-05 18:09:28 +07:00
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
uint8_t *ecc_code = chip->oob_poi + denali->oob_skip_bytes;
|
2017-03-30 13:45:51 +07:00
|
|
|
int ecc_steps = chip->ecc.steps;
|
|
|
|
int ecc_size = chip->ecc.size;
|
|
|
|
int ecc_bytes = chip->ecc.bytes;
|
2017-12-05 18:09:28 +07:00
|
|
|
int i, stat;
|
2017-03-30 13:45:51 +07:00
|
|
|
|
|
|
|
for (i = 0; i < ecc_steps; i++) {
|
|
|
|
if (!(uncor_ecc_flags & BIT(i)))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
stat = nand_check_erased_ecc_chunk(buf, ecc_size,
|
|
|
|
ecc_code, ecc_bytes,
|
|
|
|
NULL, 0,
|
|
|
|
chip->ecc.strength);
|
|
|
|
if (stat < 0) {
|
|
|
|
mtd->ecc_stats.failed++;
|
|
|
|
} else {
|
|
|
|
mtd->ecc_stats.corrected += stat;
|
|
|
|
max_bitflips = max_t(unsigned int, max_bitflips, stat);
|
|
|
|
}
|
|
|
|
|
|
|
|
buf += ecc_size;
|
|
|
|
ecc_code += ecc_bytes;
|
|
|
|
}
|
2014-09-16 18:04:25 +07:00
|
|
|
|
2017-03-30 13:45:51 +07:00
|
|
|
return max_bitflips;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
2017-03-30 13:45:51 +07:00
|
|
|
|
2017-03-30 13:45:52 +07:00
|
|
|
static int denali_hw_ecc_fixup(struct mtd_info *mtd,
|
|
|
|
struct denali_nand_info *denali,
|
|
|
|
unsigned long *uncor_ecc_flags)
|
|
|
|
{
|
|
|
|
struct nand_chip *chip = mtd_to_nand(mtd);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
int bank = denali->active_bank;
|
2017-03-30 13:45:52 +07:00
|
|
|
uint32_t ecc_cor;
|
|
|
|
unsigned int max_bitflips;
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
ecc_cor = ioread32(denali->reg + ECC_COR_INFO(bank));
|
2017-03-30 13:45:52 +07:00
|
|
|
ecc_cor >>= ECC_COR_INFO__SHIFT(bank);
|
|
|
|
|
|
|
|
if (ecc_cor & ECC_COR_INFO__UNCOR_ERR) {
|
|
|
|
/*
|
|
|
|
* This flag is set when uncorrectable error occurs at least in
|
|
|
|
* one ECC sector. We can not know "how many sectors", or
|
|
|
|
* "which sector(s)". We need erase-page check for all sectors.
|
|
|
|
*/
|
|
|
|
*uncor_ecc_flags = GENMASK(chip->ecc.steps - 1, 0);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-09-22 10:46:44 +07:00
|
|
|
max_bitflips = FIELD_GET(ECC_COR_INFO__MAX_ERRORS, ecc_cor);
|
2017-03-30 13:45:52 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The register holds the maximum of per-sector corrected bitflips.
|
|
|
|
* This is suitable for the return value of the ->read_page() callback.
|
|
|
|
* Unfortunately, we can not know the total number of corrected bits in
|
|
|
|
* the page. Increase the stats by max_bitflips. (compromised solution)
|
|
|
|
*/
|
|
|
|
mtd->ecc_stats.corrected += max_bitflips;
|
|
|
|
|
|
|
|
return max_bitflips;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_sw_ecc_fixup(struct mtd_info *mtd,
|
|
|
|
struct denali_nand_info *denali,
|
|
|
|
unsigned long *uncor_ecc_flags, uint8_t *buf)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
unsigned int ecc_size = denali->nand.ecc.size;
|
2012-04-26 02:06:09 +07:00
|
|
|
unsigned int bitflips = 0;
|
2017-03-30 13:45:50 +07:00
|
|
|
unsigned int max_bitflips = 0;
|
|
|
|
uint32_t err_addr, err_cor_info;
|
|
|
|
unsigned int err_byte, err_sector, err_device;
|
|
|
|
uint8_t err_cor_value;
|
|
|
|
unsigned int prev_sector = 0;
|
2017-06-13 20:45:38 +07:00
|
|
|
uint32_t irq_status;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
denali_reset_irq(denali);
|
2017-03-30 13:45:50 +07:00
|
|
|
|
|
|
|
do {
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
err_addr = ioread32(denali->reg + ECC_ERROR_ADDRESS);
|
2017-09-22 10:46:43 +07:00
|
|
|
err_sector = FIELD_GET(ECC_ERROR_ADDRESS__SECTOR, err_addr);
|
|
|
|
err_byte = FIELD_GET(ECC_ERROR_ADDRESS__OFFSET, err_addr);
|
2017-03-30 13:45:50 +07:00
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
err_cor_info = ioread32(denali->reg + ERR_CORRECTION_INFO);
|
2017-09-22 10:46:43 +07:00
|
|
|
err_cor_value = FIELD_GET(ERR_CORRECTION_INFO__BYTE,
|
|
|
|
err_cor_info);
|
|
|
|
err_device = FIELD_GET(ERR_CORRECTION_INFO__DEVICE,
|
|
|
|
err_cor_info);
|
2017-03-30 13:45:50 +07:00
|
|
|
|
|
|
|
/* reset the bitflip counter when crossing ECC sector */
|
|
|
|
if (err_sector != prev_sector)
|
|
|
|
bitflips = 0;
|
|
|
|
|
2017-09-22 10:46:43 +07:00
|
|
|
if (err_cor_info & ERR_CORRECTION_INFO__UNCOR) {
|
2017-03-30 13:45:50 +07:00
|
|
|
/*
|
2017-03-30 13:45:51 +07:00
|
|
|
* Check later if this is a real ECC error, or
|
|
|
|
* an erased sector.
|
2017-03-30 13:45:50 +07:00
|
|
|
*/
|
2017-03-30 13:45:51 +07:00
|
|
|
*uncor_ecc_flags |= BIT(err_sector);
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
} else if (err_byte < ecc_size) {
|
2017-03-30 13:45:50 +07:00
|
|
|
/*
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
* If err_byte is larger than ecc_size, means error
|
2017-03-30 13:45:50 +07:00
|
|
|
* happened in OOB, so we ignore it. It's no need for
|
|
|
|
* us to correct it err_device is represented the NAND
|
|
|
|
* error bits are happened in if there are more than
|
|
|
|
* one NAND connected.
|
|
|
|
*/
|
|
|
|
int offset;
|
|
|
|
unsigned int flips_in_byte;
|
|
|
|
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
offset = (err_sector * ecc_size + err_byte) *
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->devs_per_cs + err_device;
|
2017-03-30 13:45:50 +07:00
|
|
|
|
|
|
|
/* correct the ECC error */
|
|
|
|
flips_in_byte = hweight8(buf[offset] ^ err_cor_value);
|
|
|
|
buf[offset] ^= err_cor_value;
|
|
|
|
mtd->ecc_stats.corrected += flips_in_byte;
|
|
|
|
bitflips += flips_in_byte;
|
|
|
|
|
|
|
|
max_bitflips = max(max_bitflips, bitflips);
|
|
|
|
}
|
|
|
|
|
|
|
|
prev_sector = err_sector;
|
2017-09-22 10:46:43 +07:00
|
|
|
} while (!(err_cor_info & ERR_CORRECTION_INFO__LAST_ERR));
|
2017-03-30 13:45:50 +07:00
|
|
|
|
|
|
|
/*
|
2017-09-22 10:46:45 +07:00
|
|
|
* Once handle all ECC errors, controller will trigger an
|
|
|
|
* ECC_TRANSACTION_DONE interrupt.
|
2017-03-30 13:45:50 +07:00
|
|
|
*/
|
2017-06-13 20:45:38 +07:00
|
|
|
irq_status = denali_wait_for_irq(denali, INTR__ECC_TRANSACTION_DONE);
|
|
|
|
if (!(irq_status & INTR__ECC_TRANSACTION_DONE))
|
|
|
|
return -EIO;
|
2017-03-30 13:45:50 +07:00
|
|
|
|
|
|
|
return max_bitflips;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:42 +07:00
|
|
|
static void denali_setup_dma64(struct denali_nand_info *denali,
|
2017-06-13 20:45:44 +07:00
|
|
|
dma_addr_t dma_addr, int page, int write)
|
2017-03-30 13:45:54 +07:00
|
|
|
{
|
|
|
|
uint32_t mode;
|
|
|
|
const int page_count = 1;
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
mode = DENALI_MAP10 | DENALI_BANK(denali) | page;
|
2017-03-30 13:45:54 +07:00
|
|
|
|
|
|
|
/* DMA is a three step process */
|
|
|
|
|
|
|
|
/*
|
|
|
|
* 1. setup transfer type, interrupt when complete,
|
|
|
|
* burst len = 64 bytes, the number of pages
|
|
|
|
*/
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, mode,
|
|
|
|
0x01002000 | (64 << 16) | (write << 8) | page_count);
|
2017-03-30 13:45:54 +07:00
|
|
|
|
|
|
|
/* 2. set memory low address */
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, mode, lower_32_bits(dma_addr));
|
2017-03-30 13:45:54 +07:00
|
|
|
|
|
|
|
/* 3. set memory high address */
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, mode, upper_32_bits(dma_addr));
|
2017-03-30 13:45:54 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:42 +07:00
|
|
|
static void denali_setup_dma32(struct denali_nand_info *denali,
|
2017-06-13 20:45:44 +07:00
|
|
|
dma_addr_t dma_addr, int page, int write)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2014-09-09 09:01:52 +07:00
|
|
|
uint32_t mode;
|
2010-05-13 21:57:33 +07:00
|
|
|
const int page_count = 1;
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
mode = DENALI_MAP10 | DENALI_BANK(denali);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
|
|
|
/* DMA is a four step process */
|
|
|
|
|
|
|
|
/* 1. setup transfer type and # of pages */
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, mode | page,
|
|
|
|
0x2000 | (write << 8) | page_count);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
|
|
|
/* 2. set memory high address bits 23:8 */
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, mode | ((dma_addr >> 16) << 8), 0x2200);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
|
|
|
/* 3. set memory low address bits 23:8 */
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, mode | ((dma_addr & 0xffff) << 8), 0x2300);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2014-09-09 09:01:51 +07:00
|
|
|
/* 4. interrupt when complete, burst len = 64 bytes */
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, mode | 0x14000, 0x2400);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
static int denali_pio_read(struct denali_nand_info *denali, void *buf,
|
|
|
|
size_t size, int page, int raw)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-09-22 10:46:48 +07:00
|
|
|
u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page;
|
2017-06-13 20:45:45 +07:00
|
|
|
uint32_t *buf32 = (uint32_t *)buf;
|
|
|
|
uint32_t irq_status, ecc_err_mask;
|
|
|
|
int i;
|
2017-06-13 20:45:35 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
if (denali->caps & DENALI_CAP_HW_ECC_FIXUP)
|
|
|
|
ecc_err_mask = INTR__ECC_UNCOR_ERR;
|
|
|
|
else
|
|
|
|
ecc_err_mask = INTR__ECC_ERR;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
denali_reset_irq(denali);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
for (i = 0; i < size / 4; i++)
|
2017-09-22 10:46:48 +07:00
|
|
|
*buf32++ = denali->host_read(denali, addr);
|
2017-06-13 20:45:45 +07:00
|
|
|
|
|
|
|
irq_status = denali_wait_for_irq(denali, INTR__PAGE_XFER_INC);
|
|
|
|
if (!(irq_status & INTR__PAGE_XFER_INC))
|
|
|
|
return -EIO;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
mtd: nand: denali: support hardware-assisted erased page detection
Recent versions of this IP support automatic erased page detection.
If an erased page is detected on reads, the controller does not set
INTR__ECC_UNCOR_ERR, but INTR__ERASED_PAGE.
The detection of erased pages is based on the number of zeros in a
page; if the number of zeros is less than the value in the field
ERASED_THRESHOLD, the page is assumed as erased.
Please note ERASED_THRESHOLD specifies the number of zeros in a _page_
instead of an ECC chunk. Moreover, the controller does not provide a
way to know the actual number of bitflips.
Actually, an erased page (all 0xff) is not an ECC correctable pattern
on the Denali ECC engine. In other words, there may be overlap between
the following two:
[1] a bit pattern reachable from a valid payload + ECC pattern within
ecc.strength bitflips
[2] a bit pattern reachable from an erased state (all 0xff) within
ecc.strength bitflips
So, this feature may intercept ECC correctable patterns, then replace
[1] with [2].
After all, this feature can work safely only when ECC_THRESHOLD == 1,
i.e. detect erased pages without any bitflips. This should be the
case most of the time. If there is a bitflip or more, the driver will
fallback to the software method by using nand_check_erased_ecc_chunk().
Strangely enough, the driver still has to fill the buffer with 0xff
in case of INTR__ERASED_PAGE because the ECC correction engine has
already manipulated the data in the buffer before it judges erased
pages.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:46 +07:00
|
|
|
if (irq_status & INTR__ERASED_PAGE)
|
|
|
|
memset(buf, 0xff, size);
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
return irq_status & ecc_err_mask ? -EBADMSG : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_pio_write(struct denali_nand_info *denali,
|
|
|
|
const void *buf, size_t size, int page, int raw)
|
|
|
|
{
|
2017-09-22 10:46:48 +07:00
|
|
|
u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page;
|
2017-06-13 20:45:45 +07:00
|
|
|
const uint32_t *buf32 = (uint32_t *)buf;
|
|
|
|
uint32_t irq_status;
|
|
|
|
int i;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
denali_reset_irq(denali);
|
2017-06-13 20:45:45 +07:00
|
|
|
|
|
|
|
for (i = 0; i < size / 4; i++)
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, addr, *buf32++);
|
2017-06-13 20:45:45 +07:00
|
|
|
|
|
|
|
irq_status = denali_wait_for_irq(denali,
|
|
|
|
INTR__PROGRAM_COMP | INTR__PROGRAM_FAIL);
|
|
|
|
if (!(irq_status & INTR__PROGRAM_COMP))
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_pio_xfer(struct denali_nand_info *denali, void *buf,
|
|
|
|
size_t size, int page, int raw, int write)
|
|
|
|
{
|
|
|
|
if (write)
|
|
|
|
return denali_pio_write(denali, buf, size, page, raw);
|
|
|
|
else
|
|
|
|
return denali_pio_read(denali, buf, size, page, raw);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_dma_xfer(struct denali_nand_info *denali, void *buf,
|
|
|
|
size_t size, int page, int raw, int write)
|
|
|
|
{
|
2017-06-13 20:45:47 +07:00
|
|
|
dma_addr_t dma_addr;
|
2017-06-13 20:45:45 +07:00
|
|
|
uint32_t irq_mask, irq_status, ecc_err_mask;
|
|
|
|
enum dma_data_direction dir = write ? DMA_TO_DEVICE : DMA_FROM_DEVICE;
|
|
|
|
int ret = 0;
|
|
|
|
|
2017-06-13 20:45:47 +07:00
|
|
|
dma_addr = dma_map_single(denali->dev, buf, size, dir);
|
|
|
|
if (dma_mapping_error(denali->dev, dma_addr)) {
|
|
|
|
dev_dbg(denali->dev, "Failed to DMA-map buffer. Trying PIO.\n");
|
|
|
|
return denali_pio_xfer(denali, buf, size, page, raw, write);
|
|
|
|
}
|
2017-06-13 20:45:45 +07:00
|
|
|
|
|
|
|
if (write) {
|
|
|
|
/*
|
|
|
|
* INTR__PROGRAM_COMP is never asserted for the DMA transfer.
|
|
|
|
* We can use INTR__DMA_CMD_COMP instead. This flag is asserted
|
|
|
|
* when the page program is completed.
|
|
|
|
*/
|
|
|
|
irq_mask = INTR__DMA_CMD_COMP | INTR__PROGRAM_FAIL;
|
|
|
|
ecc_err_mask = 0;
|
|
|
|
} else if (denali->caps & DENALI_CAP_HW_ECC_FIXUP) {
|
|
|
|
irq_mask = INTR__DMA_CMD_COMP;
|
|
|
|
ecc_err_mask = INTR__ECC_UNCOR_ERR;
|
|
|
|
} else {
|
|
|
|
irq_mask = INTR__DMA_CMD_COMP;
|
|
|
|
ecc_err_mask = INTR__ECC_ERR;
|
|
|
|
}
|
|
|
|
|
2017-09-22 10:46:41 +07:00
|
|
|
iowrite32(DMA_ENABLE__FLAG, denali->reg + DMA_ENABLE);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
denali_reset_irq(denali);
|
2017-09-22 10:46:49 +07:00
|
|
|
denali->setup_dma(denali, dma_addr, page, write);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
irq_status = denali_wait_for_irq(denali, irq_mask);
|
2017-06-13 20:45:45 +07:00
|
|
|
if (!(irq_status & INTR__DMA_CMD_COMP))
|
2017-06-13 20:45:35 +07:00
|
|
|
ret = -EIO;
|
2017-06-13 20:45:45 +07:00
|
|
|
else if (irq_status & ecc_err_mask)
|
|
|
|
ret = -EBADMSG;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-09-22 10:46:41 +07:00
|
|
|
iowrite32(0, denali->reg + DMA_ENABLE);
|
|
|
|
|
2017-06-13 20:45:47 +07:00
|
|
|
dma_unmap_single(denali->dev, dma_addr, size, dir);
|
2012-06-25 17:07:45 +07:00
|
|
|
|
mtd: nand: denali: support hardware-assisted erased page detection
Recent versions of this IP support automatic erased page detection.
If an erased page is detected on reads, the controller does not set
INTR__ECC_UNCOR_ERR, but INTR__ERASED_PAGE.
The detection of erased pages is based on the number of zeros in a
page; if the number of zeros is less than the value in the field
ERASED_THRESHOLD, the page is assumed as erased.
Please note ERASED_THRESHOLD specifies the number of zeros in a _page_
instead of an ECC chunk. Moreover, the controller does not provide a
way to know the actual number of bitflips.
Actually, an erased page (all 0xff) is not an ECC correctable pattern
on the Denali ECC engine. In other words, there may be overlap between
the following two:
[1] a bit pattern reachable from a valid payload + ECC pattern within
ecc.strength bitflips
[2] a bit pattern reachable from an erased state (all 0xff) within
ecc.strength bitflips
So, this feature may intercept ECC correctable patterns, then replace
[1] with [2].
After all, this feature can work safely only when ECC_THRESHOLD == 1,
i.e. detect erased pages without any bitflips. This should be the
case most of the time. If there is a bitflip or more, the driver will
fallback to the software method by using nand_check_erased_ecc_chunk().
Strangely enough, the driver still has to fill the buffer with 0xff
in case of INTR__ERASED_PAGE because the ECC correction engine has
already manipulated the data in the buffer before it judges erased
pages.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:46 +07:00
|
|
|
if (irq_status & INTR__ERASED_PAGE)
|
|
|
|
memset(buf, 0xff, size);
|
|
|
|
|
2017-06-13 20:45:35 +07:00
|
|
|
return ret;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
static int denali_data_xfer(struct denali_nand_info *denali, void *buf,
|
|
|
|
size_t size, int page, int raw, int write)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-09-22 10:46:38 +07:00
|
|
|
iowrite32(raw ? 0 : ECC_ENABLE__FLAG, denali->reg + ECC_ENABLE);
|
|
|
|
iowrite32(raw ? TRANSFER_SPARE_REG__FLAG : 0,
|
|
|
|
denali->reg + TRANSFER_SPARE_REG);
|
2017-06-13 20:45:45 +07:00
|
|
|
|
|
|
|
if (denali->dma_avail)
|
|
|
|
return denali_dma_xfer(denali, buf, size, page, raw, write);
|
|
|
|
else
|
|
|
|
return denali_pio_xfer(denali, buf, size, page, raw, write);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
static void denali_oob_xfer(struct mtd_info *mtd, struct nand_chip *chip,
|
|
|
|
int page, int write)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:45 +07:00
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
int writesize = mtd->writesize;
|
|
|
|
int oobsize = mtd->oobsize;
|
|
|
|
uint8_t *bufpoi = chip->oob_poi;
|
|
|
|
int ecc_steps = chip->ecc.steps;
|
|
|
|
int ecc_size = chip->ecc.size;
|
|
|
|
int ecc_bytes = chip->ecc.bytes;
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
int oob_skip = denali->oob_skip_bytes;
|
2017-06-13 20:45:45 +07:00
|
|
|
size_t size = writesize + oobsize;
|
|
|
|
int i, pos, len;
|
|
|
|
|
|
|
|
/* BBM at the beginning of the OOB area */
|
|
|
|
if (write)
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_prog_page_begin_op(chip, page, writesize, bufpoi,
|
|
|
|
oob_skip);
|
2017-06-13 20:45:45 +07:00
|
|
|
else
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_read_page_op(chip, page, writesize, bufpoi, oob_skip);
|
2017-06-13 20:45:45 +07:00
|
|
|
bufpoi += oob_skip;
|
|
|
|
|
|
|
|
/* OOB ECC */
|
|
|
|
for (i = 0; i < ecc_steps; i++) {
|
|
|
|
pos = ecc_size + i * (ecc_size + ecc_bytes);
|
|
|
|
len = ecc_bytes;
|
|
|
|
|
|
|
|
if (pos >= writesize)
|
|
|
|
pos += oob_skip;
|
|
|
|
else if (pos + len > writesize)
|
|
|
|
len = writesize - pos;
|
|
|
|
|
|
|
|
if (write)
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_change_write_column_op(chip, pos, bufpoi, len,
|
|
|
|
false);
|
2017-06-13 20:45:45 +07:00
|
|
|
else
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_change_read_column_op(chip, pos, bufpoi, len,
|
|
|
|
false);
|
2017-06-13 20:45:45 +07:00
|
|
|
bufpoi += len;
|
|
|
|
if (len < ecc_bytes) {
|
|
|
|
len = ecc_bytes - len;
|
|
|
|
if (write)
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_change_write_column_op(chip, writesize +
|
|
|
|
oob_skip, bufpoi,
|
|
|
|
len, false);
|
2017-06-13 20:45:45 +07:00
|
|
|
else
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_change_read_column_op(chip, writesize +
|
|
|
|
oob_skip, bufpoi,
|
|
|
|
len, false);
|
2017-06-13 20:45:45 +07:00
|
|
|
bufpoi += len;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* OOB free */
|
|
|
|
len = oobsize - (bufpoi - chip->oob_poi);
|
|
|
|
if (write)
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_change_write_column_op(chip, size - len, bufpoi, len,
|
|
|
|
false);
|
2017-06-13 20:45:45 +07:00
|
|
|
else
|
2017-12-01 00:01:29 +07:00
|
|
|
nand_change_read_column_op(chip, size - len, bufpoi, len,
|
|
|
|
false);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
static int denali_read_page_raw(struct mtd_info *mtd, struct nand_chip *chip,
|
|
|
|
uint8_t *buf, int oob_required, int page)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:45 +07:00
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
int writesize = mtd->writesize;
|
|
|
|
int oobsize = mtd->oobsize;
|
|
|
|
int ecc_steps = chip->ecc.steps;
|
|
|
|
int ecc_size = chip->ecc.size;
|
|
|
|
int ecc_bytes = chip->ecc.bytes;
|
2017-11-23 20:32:28 +07:00
|
|
|
void *tmp_buf = denali->buf;
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
int oob_skip = denali->oob_skip_bytes;
|
2017-06-13 20:45:45 +07:00
|
|
|
size_t size = writesize + oobsize;
|
|
|
|
int ret, i, pos, len;
|
|
|
|
|
2017-11-23 20:32:28 +07:00
|
|
|
ret = denali_data_xfer(denali, tmp_buf, size, page, 1, 0);
|
2017-06-13 20:45:45 +07:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* Arrange the buffer for syndrome payload/ecc layout */
|
|
|
|
if (buf) {
|
|
|
|
for (i = 0; i < ecc_steps; i++) {
|
|
|
|
pos = i * (ecc_size + ecc_bytes);
|
|
|
|
len = ecc_size;
|
|
|
|
|
|
|
|
if (pos >= writesize)
|
|
|
|
pos += oob_skip;
|
|
|
|
else if (pos + len > writesize)
|
|
|
|
len = writesize - pos;
|
|
|
|
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(buf, tmp_buf + pos, len);
|
2017-06-13 20:45:45 +07:00
|
|
|
buf += len;
|
|
|
|
if (len < ecc_size) {
|
|
|
|
len = ecc_size - len;
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(buf, tmp_buf + writesize + oob_skip,
|
2017-06-13 20:45:45 +07:00
|
|
|
len);
|
|
|
|
buf += len;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (oob_required) {
|
|
|
|
uint8_t *oob = chip->oob_poi;
|
|
|
|
|
|
|
|
/* BBM at the beginning of the OOB area */
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(oob, tmp_buf + writesize, oob_skip);
|
2017-06-13 20:45:45 +07:00
|
|
|
oob += oob_skip;
|
|
|
|
|
|
|
|
/* OOB ECC */
|
|
|
|
for (i = 0; i < ecc_steps; i++) {
|
|
|
|
pos = ecc_size + i * (ecc_size + ecc_bytes);
|
|
|
|
len = ecc_bytes;
|
|
|
|
|
|
|
|
if (pos >= writesize)
|
|
|
|
pos += oob_skip;
|
|
|
|
else if (pos + len > writesize)
|
|
|
|
len = writesize - pos;
|
|
|
|
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(oob, tmp_buf + pos, len);
|
2017-06-13 20:45:45 +07:00
|
|
|
oob += len;
|
|
|
|
if (len < ecc_bytes) {
|
|
|
|
len = ecc_bytes - len;
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(oob, tmp_buf + writesize + oob_skip,
|
2017-06-13 20:45:45 +07:00
|
|
|
len);
|
|
|
|
oob += len;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* OOB free */
|
|
|
|
len = oobsize - (oob - chip->oob_poi);
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(oob, tmp_buf + size - len, len);
|
2017-06-13 20:45:45 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2010-08-05 22:06:04 +07:00
|
|
|
static int denali_read_oob(struct mtd_info *mtd, struct nand_chip *chip,
|
2012-05-09 17:06:35 +07:00
|
|
|
int page)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-06-13 20:45:45 +07:00
|
|
|
denali_oob_xfer(mtd, chip, page, 0);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2012-05-09 17:06:35 +07:00
|
|
|
return 0;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
static int denali_write_oob(struct mtd_info *mtd, struct nand_chip *chip,
|
|
|
|
int page)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
denali_reset_irq(denali);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
denali_oob_xfer(mtd, chip, page, 1);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-12-01 00:01:29 +07:00
|
|
|
return nand_prog_page_end_op(chip);
|
2017-06-13 20:45:45 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip,
|
|
|
|
uint8_t *buf, int oob_required, int page)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
unsigned long uncor_ecc_flags = 0;
|
|
|
|
int stat = 0;
|
|
|
|
int ret;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:47 +07:00
|
|
|
ret = denali_data_xfer(denali, buf, mtd->writesize, page, 0, 0);
|
2017-06-13 20:45:45 +07:00
|
|
|
if (ret && ret != -EBADMSG)
|
|
|
|
return ret;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-03-30 13:45:52 +07:00
|
|
|
if (denali->caps & DENALI_CAP_HW_ECC_FIXUP)
|
|
|
|
stat = denali_hw_ecc_fixup(mtd, denali, &uncor_ecc_flags);
|
2017-06-13 20:45:45 +07:00
|
|
|
else if (ret == -EBADMSG)
|
2017-03-30 13:45:52 +07:00
|
|
|
stat = denali_sw_ecc_fixup(mtd, denali, &uncor_ecc_flags, buf);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-03-30 13:45:51 +07:00
|
|
|
if (stat < 0)
|
|
|
|
return stat;
|
|
|
|
|
|
|
|
if (uncor_ecc_flags) {
|
2017-06-13 20:45:45 +07:00
|
|
|
ret = denali_read_oob(mtd, chip, page);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-03-30 13:45:51 +07:00
|
|
|
stat = denali_check_erased_page(mtd, chip, buf,
|
|
|
|
uncor_ecc_flags, stat);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
2017-03-30 13:45:51 +07:00
|
|
|
|
|
|
|
return stat;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
static int denali_write_page_raw(struct mtd_info *mtd, struct nand_chip *chip,
|
|
|
|
const uint8_t *buf, int oob_required, int page)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2017-06-13 20:45:45 +07:00
|
|
|
int writesize = mtd->writesize;
|
|
|
|
int oobsize = mtd->oobsize;
|
|
|
|
int ecc_steps = chip->ecc.steps;
|
|
|
|
int ecc_size = chip->ecc.size;
|
|
|
|
int ecc_bytes = chip->ecc.bytes;
|
2017-11-23 20:32:28 +07:00
|
|
|
void *tmp_buf = denali->buf;
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
int oob_skip = denali->oob_skip_bytes;
|
2017-06-13 20:45:45 +07:00
|
|
|
size_t size = writesize + oobsize;
|
|
|
|
int i, pos, len;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
/*
|
|
|
|
* Fill the buffer with 0xff first except the full page transfer.
|
|
|
|
* This simplifies the logic.
|
|
|
|
*/
|
|
|
|
if (!buf || !oob_required)
|
2017-11-23 20:32:28 +07:00
|
|
|
memset(tmp_buf, 0xff, size);
|
2017-06-13 20:45:45 +07:00
|
|
|
|
|
|
|
/* Arrange the buffer for syndrome payload/ecc layout */
|
|
|
|
if (buf) {
|
|
|
|
for (i = 0; i < ecc_steps; i++) {
|
|
|
|
pos = i * (ecc_size + ecc_bytes);
|
|
|
|
len = ecc_size;
|
|
|
|
|
|
|
|
if (pos >= writesize)
|
|
|
|
pos += oob_skip;
|
|
|
|
else if (pos + len > writesize)
|
|
|
|
len = writesize - pos;
|
|
|
|
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(tmp_buf + pos, buf, len);
|
2017-06-13 20:45:45 +07:00
|
|
|
buf += len;
|
|
|
|
if (len < ecc_size) {
|
|
|
|
len = ecc_size - len;
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(tmp_buf + writesize + oob_skip, buf,
|
2017-06-13 20:45:45 +07:00
|
|
|
len);
|
|
|
|
buf += len;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
if (oob_required) {
|
|
|
|
const uint8_t *oob = chip->oob_poi;
|
|
|
|
|
|
|
|
/* BBM at the beginning of the OOB area */
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(tmp_buf + writesize, oob, oob_skip);
|
2017-06-13 20:45:45 +07:00
|
|
|
oob += oob_skip;
|
|
|
|
|
|
|
|
/* OOB ECC */
|
|
|
|
for (i = 0; i < ecc_steps; i++) {
|
|
|
|
pos = ecc_size + i * (ecc_size + ecc_bytes);
|
|
|
|
len = ecc_bytes;
|
|
|
|
|
|
|
|
if (pos >= writesize)
|
|
|
|
pos += oob_skip;
|
|
|
|
else if (pos + len > writesize)
|
|
|
|
len = writesize - pos;
|
|
|
|
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(tmp_buf + pos, oob, len);
|
2017-06-13 20:45:45 +07:00
|
|
|
oob += len;
|
|
|
|
if (len < ecc_bytes) {
|
|
|
|
len = ecc_bytes - len;
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(tmp_buf + writesize + oob_skip, oob,
|
2017-06-13 20:45:45 +07:00
|
|
|
len);
|
|
|
|
oob += len;
|
|
|
|
}
|
|
|
|
}
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
/* OOB free */
|
|
|
|
len = oobsize - (oob - chip->oob_poi);
|
2017-11-23 20:32:28 +07:00
|
|
|
memcpy(tmp_buf + size - len, oob, len);
|
2017-06-13 20:45:45 +07:00
|
|
|
}
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-11-23 20:32:28 +07:00
|
|
|
return denali_data_xfer(denali, tmp_buf, size, page, 1, 1);
|
2017-06-13 20:45:45 +07:00
|
|
|
}
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
static int denali_write_page(struct mtd_info *mtd, struct nand_chip *chip,
|
|
|
|
const uint8_t *buf, int oob_required, int page)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:47 +07:00
|
|
|
return denali_data_xfer(denali, (void *)buf, mtd->writesize,
|
|
|
|
page, 0, 1);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_select_chip(struct mtd_info *mtd, int chip)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2010-08-09 23:16:51 +07:00
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->active_bank = chip;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_waitfunc(struct mtd_info *mtd, struct nand_chip *chip)
|
|
|
|
{
|
2017-06-13 20:45:39 +07:00
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
uint32_t irq_status;
|
|
|
|
|
|
|
|
/* R/B# pin transitioned from low to high? */
|
|
|
|
irq_status = denali_wait_for_irq(denali, INTR__INT_ACT);
|
|
|
|
|
|
|
|
return irq_status & INTR__INT_ACT ? 0 : NAND_STATUS_FAIL;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
2014-05-07 06:02:19 +07:00
|
|
|
static int denali_erase(struct mtd_info *mtd, int page)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
uint32_t irq_status;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-06-13 20:45:38 +07:00
|
|
|
denali_reset_irq(denali);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-09-22 10:46:48 +07:00
|
|
|
denali->host_write(denali, DENALI_MAP10 | DENALI_BANK(denali) | page,
|
|
|
|
DENALI_ERASE);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
|
|
|
/* wait for erase to complete or failure to occur */
|
2017-06-13 20:45:38 +07:00
|
|
|
irq_status = denali_wait_for_irq(denali,
|
|
|
|
INTR__ERASE_COMP | INTR__ERASE_FAIL);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-12-01 00:01:28 +07:00
|
|
|
return irq_status & INTR__ERASE_COMP ? 0 : -EIO;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
static int denali_setup_data_interface(struct mtd_info *mtd, int chipnr,
|
|
|
|
const struct nand_data_interface *conf)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
const struct nand_sdr_timings *timings;
|
2018-06-22 23:06:38 +07:00
|
|
|
unsigned long t_x, mult_x;
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
int acc_clks, re_2_we, re_2_re, we_2_re, addr_2_data;
|
|
|
|
int rdwr_en_lo, rdwr_en_hi, rdwr_en_lo_hi, cs_setup;
|
|
|
|
int addr_2_data_mask;
|
|
|
|
uint32_t tmp;
|
|
|
|
|
|
|
|
timings = nand_get_sdr_timings(conf);
|
|
|
|
if (IS_ERR(timings))
|
|
|
|
return PTR_ERR(timings);
|
|
|
|
|
|
|
|
/* clk_x period in picoseconds */
|
2018-06-22 23:06:38 +07:00
|
|
|
t_x = DIV_ROUND_DOWN_ULL(1000000000000ULL, denali->clk_x_rate);
|
|
|
|
if (!t_x)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The bus interface clock, clk_x, is phase aligned with the core clock.
|
|
|
|
* The clk_x is an integral multiple N of the core clk. The value N is
|
|
|
|
* configured at IP delivery time, and its available value is 4, 5, 6.
|
|
|
|
*/
|
|
|
|
mult_x = DIV_ROUND_CLOSEST_ULL(denali->clk_x_rate, denali->clk_rate);
|
|
|
|
if (mult_x < 4 || mult_x > 6)
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (chipnr == NAND_DATA_IFACE_CHECK_ONLY)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* tREA -> ACC_CLKS */
|
2018-06-22 23:06:38 +07:00
|
|
|
acc_clks = DIV_ROUND_UP(timings->tREA_max, t_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
acc_clks = min_t(int, acc_clks, ACC_CLKS__VALUE);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + ACC_CLKS);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
tmp &= ~ACC_CLKS__VALUE;
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp |= FIELD_PREP(ACC_CLKS__VALUE, acc_clks);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + ACC_CLKS);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
|
|
|
/* tRWH -> RE_2_WE */
|
2018-06-22 23:06:38 +07:00
|
|
|
re_2_we = DIV_ROUND_UP(timings->tRHW_min, t_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
re_2_we = min_t(int, re_2_we, RE_2_WE__VALUE);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + RE_2_WE);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
tmp &= ~RE_2_WE__VALUE;
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp |= FIELD_PREP(RE_2_WE__VALUE, re_2_we);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + RE_2_WE);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
|
|
|
/* tRHZ -> RE_2_RE */
|
2018-06-22 23:06:38 +07:00
|
|
|
re_2_re = DIV_ROUND_UP(timings->tRHZ_max, t_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
re_2_re = min_t(int, re_2_re, RE_2_RE__VALUE);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + RE_2_RE);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
tmp &= ~RE_2_RE__VALUE;
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp |= FIELD_PREP(RE_2_RE__VALUE, re_2_re);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + RE_2_RE);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
2017-09-29 21:12:57 +07:00
|
|
|
/*
|
|
|
|
* tCCS, tWHR -> WE_2_RE
|
|
|
|
*
|
|
|
|
* With WE_2_RE properly set, the Denali controller automatically takes
|
|
|
|
* care of the delay; the driver need not set NAND_WAIT_TCCS.
|
|
|
|
*/
|
2018-06-22 23:06:38 +07:00
|
|
|
we_2_re = DIV_ROUND_UP(max(timings->tCCS_min, timings->tWHR_min), t_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
we_2_re = min_t(int, we_2_re, TWHR2_AND_WE_2_RE__WE_2_RE);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + TWHR2_AND_WE_2_RE);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
tmp &= ~TWHR2_AND_WE_2_RE__WE_2_RE;
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp |= FIELD_PREP(TWHR2_AND_WE_2_RE__WE_2_RE, we_2_re);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + TWHR2_AND_WE_2_RE);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
|
|
|
/* tADL -> ADDR_2_DATA */
|
|
|
|
|
|
|
|
/* for older versions, ADDR_2_DATA is only 6 bit wide */
|
|
|
|
addr_2_data_mask = TCWAW_AND_ADDR_2_DATA__ADDR_2_DATA;
|
|
|
|
if (denali->revision < 0x0501)
|
|
|
|
addr_2_data_mask >>= 1;
|
|
|
|
|
2018-06-22 23:06:38 +07:00
|
|
|
addr_2_data = DIV_ROUND_UP(timings->tADL_min, t_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
addr_2_data = min_t(int, addr_2_data, addr_2_data_mask);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + TCWAW_AND_ADDR_2_DATA);
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp &= ~TCWAW_AND_ADDR_2_DATA__ADDR_2_DATA;
|
|
|
|
tmp |= FIELD_PREP(TCWAW_AND_ADDR_2_DATA__ADDR_2_DATA, addr_2_data);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + TCWAW_AND_ADDR_2_DATA);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
|
|
|
/* tREH, tWH -> RDWR_EN_HI_CNT */
|
|
|
|
rdwr_en_hi = DIV_ROUND_UP(max(timings->tREH_min, timings->tWH_min),
|
2018-06-22 23:06:38 +07:00
|
|
|
t_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
rdwr_en_hi = min_t(int, rdwr_en_hi, RDWR_EN_HI_CNT__VALUE);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + RDWR_EN_HI_CNT);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
tmp &= ~RDWR_EN_HI_CNT__VALUE;
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp |= FIELD_PREP(RDWR_EN_HI_CNT__VALUE, rdwr_en_hi);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + RDWR_EN_HI_CNT);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
|
|
|
/* tRP, tWP -> RDWR_EN_LO_CNT */
|
2018-06-22 23:06:38 +07:00
|
|
|
rdwr_en_lo = DIV_ROUND_UP(max(timings->tRP_min, timings->tWP_min), t_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
rdwr_en_lo_hi = DIV_ROUND_UP(max(timings->tRC_min, timings->tWC_min),
|
2018-06-22 23:06:38 +07:00
|
|
|
t_x);
|
|
|
|
rdwr_en_lo_hi = max_t(int, rdwr_en_lo_hi, mult_x);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
rdwr_en_lo = max(rdwr_en_lo, rdwr_en_lo_hi - rdwr_en_hi);
|
|
|
|
rdwr_en_lo = min_t(int, rdwr_en_lo, RDWR_EN_LO_CNT__VALUE);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + RDWR_EN_LO_CNT);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
tmp &= ~RDWR_EN_LO_CNT__VALUE;
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp |= FIELD_PREP(RDWR_EN_LO_CNT__VALUE, rdwr_en_lo);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + RDWR_EN_LO_CNT);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
|
|
|
/* tCS, tCEA -> CS_SETUP_CNT */
|
2018-06-22 23:06:38 +07:00
|
|
|
cs_setup = max3((int)DIV_ROUND_UP(timings->tCS_min, t_x) - rdwr_en_lo,
|
|
|
|
(int)DIV_ROUND_UP(timings->tCEA_max, t_x) - acc_clks,
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
0);
|
|
|
|
cs_setup = min_t(int, cs_setup, CS_SETUP_CNT__VALUE);
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
tmp = ioread32(denali->reg + CS_SETUP_CNT);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
tmp &= ~CS_SETUP_CNT__VALUE;
|
2017-09-22 10:46:44 +07:00
|
|
|
tmp |= FIELD_PREP(CS_SETUP_CNT__VALUE, cs_setup);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(tmp, denali->reg + CS_SETUP_CNT);
|
mtd: nand: denali: handle timing parameters by setup_data_interface()
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_para() is weird as well.
Now, the core framework provides .setup_data_interface() hook, which
handles timing parameters in a generic manner.
While I am working on this, I found even more issues in the current
code, so fixed the following as well:
- In recent IP versions, WE_2_RE and TWHR2 share the same register.
Likewise for ADDR_2_DATA and TCWAW, CS_SETUP_CNT and TWB. When
updating one, the other must be masked. Otherwise, the other will
be set to 0, then timing settings will be broken.
- The recent IP release expanded the ADDR_2_DATA to 7-bit wide.
This register is related to tADL. As commit 74a332e78e8f ("mtd:
nand: timings: Fix tADL_min for ONFI 4.0 chips") addressed, the
ONFi 4.0 increased the minimum of tADL to 400 nsec. This may not
fit in the 6-bit ADDR_2_DATA in older versions. Check the IP
revision and handle this correctly, otherwise the register value
would wrap around.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:37 +07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2010-05-13 21:57:33 +07:00
|
|
|
|
mtd: nand: denali: fix bank reset function to detect the number of chips
The nand_scan_ident() iterates over maxchips, and calls nand_reset()
for each. This driver currently passes the maximum number of banks
(=chip selects) supported by the controller as maxchips. So, maxchips
is typically 4 or 8. Usually, less number of NAND chips are connected
to the controller.
This can be a problem for ONFi devices. Now, this driver implements
->setup_data_interface() hook, so nand_setup_data_interface() issues
Set Features (0xEF) command, which waits until the chip returns R/B#
response. If no chip there, we know it never happens, but the driver
still ends up with waiting for a long time. It will finally bail-out
with timeout error and the driver will work with existing chips, but
unnecessary wait will give a bad user experience.
The denali_nand_reset() polls the INTR__RST_COMP and INTR__TIME_OUT
bits, but they are always set even if not NAND chip is connected to
that bank. To know the chip existence, INTR__INT_ACT bit must be
checked; this flag is set only when R/B# is toggled. Since the Reset
(0xFF) command toggles the R/B# pin, this can be used to know the
actual number of chips, and update denali->max_banks.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:40 +07:00
|
|
|
static void denali_reset_banks(struct denali_nand_info *denali)
|
|
|
|
{
|
2017-06-13 20:45:41 +07:00
|
|
|
u32 irq_status;
|
mtd: nand: denali: fix bank reset function to detect the number of chips
The nand_scan_ident() iterates over maxchips, and calls nand_reset()
for each. This driver currently passes the maximum number of banks
(=chip selects) supported by the controller as maxchips. So, maxchips
is typically 4 or 8. Usually, less number of NAND chips are connected
to the controller.
This can be a problem for ONFi devices. Now, this driver implements
->setup_data_interface() hook, so nand_setup_data_interface() issues
Set Features (0xEF) command, which waits until the chip returns R/B#
response. If no chip there, we know it never happens, but the driver
still ends up with waiting for a long time. It will finally bail-out
with timeout error and the driver will work with existing chips, but
unnecessary wait will give a bad user experience.
The denali_nand_reset() polls the INTR__RST_COMP and INTR__TIME_OUT
bits, but they are always set even if not NAND chip is connected to
that bank. To know the chip existence, INTR__INT_ACT bit must be
checked; this flag is set only when R/B# is toggled. Since the Reset
(0xFF) command toggles the R/B# pin, this can be used to know the
actual number of chips, and update denali->max_banks.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:40 +07:00
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < denali->max_banks; i++) {
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->active_bank = i;
|
2017-06-13 20:45:41 +07:00
|
|
|
|
|
|
|
denali_reset_irq(denali);
|
|
|
|
|
|
|
|
iowrite32(DEVICE_RESET__BANK(i),
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->reg + DEVICE_RESET);
|
2017-06-13 20:45:41 +07:00
|
|
|
|
|
|
|
irq_status = denali_wait_for_irq(denali,
|
|
|
|
INTR__RST_COMP | INTR__INT_ACT | INTR__TIME_OUT);
|
|
|
|
if (!(irq_status & INTR__INT_ACT))
|
mtd: nand: denali: fix bank reset function to detect the number of chips
The nand_scan_ident() iterates over maxchips, and calls nand_reset()
for each. This driver currently passes the maximum number of banks
(=chip selects) supported by the controller as maxchips. So, maxchips
is typically 4 or 8. Usually, less number of NAND chips are connected
to the controller.
This can be a problem for ONFi devices. Now, this driver implements
->setup_data_interface() hook, so nand_setup_data_interface() issues
Set Features (0xEF) command, which waits until the chip returns R/B#
response. If no chip there, we know it never happens, but the driver
still ends up with waiting for a long time. It will finally bail-out
with timeout error and the driver will work with existing chips, but
unnecessary wait will give a bad user experience.
The denali_nand_reset() polls the INTR__RST_COMP and INTR__TIME_OUT
bits, but they are always set even if not NAND chip is connected to
that bank. To know the chip existence, INTR__INT_ACT bit must be
checked; this flag is set only when R/B# is toggled. Since the Reset
(0xFF) command toggles the R/B# pin, this can be used to know the
actual number of chips, and update denali->max_banks.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-13 20:45:40 +07:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev_dbg(denali->dev, "%d chips connected\n", i);
|
|
|
|
denali->max_banks = i;
|
|
|
|
}
|
|
|
|
|
2010-05-13 21:57:33 +07:00
|
|
|
static void denali_hw_init(struct denali_nand_info *denali)
|
|
|
|
{
|
2017-03-30 13:45:57 +07:00
|
|
|
/*
|
|
|
|
* The REVISION register may not be reliable. Platforms are allowed to
|
|
|
|
* override it.
|
|
|
|
*/
|
|
|
|
if (!denali->revision)
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->revision = swab16(ioread32(denali->reg + REVISION));
|
2017-03-30 13:45:57 +07:00
|
|
|
|
2014-09-09 09:01:51 +07:00
|
|
|
/*
|
|
|
|
* tell driver how many bit controller will skip before
|
2010-08-06 17:02:03 +07:00
|
|
|
* writing ECC code in OOB, this register may be already
|
|
|
|
* set by firmware. So we read this value out.
|
|
|
|
* if this value is 0, just let it be.
|
2014-09-09 09:01:51 +07:00
|
|
|
*/
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->oob_skip_bytes = ioread32(denali->reg + SPARE_AREA_SKIP_BYTES);
|
2017-09-22 10:46:39 +07:00
|
|
|
denali_detect_max_banks(denali);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(0x0F, denali->reg + RB_PIN_ENABLED);
|
|
|
|
iowrite32(CHIP_EN_DONT_CARE__FLAG, denali->reg + CHIP_ENABLE_DONT_CARE);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(0xffff, denali->reg + SPARE_AREA_MARKER);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
int denali_calc_ecc_bytes(int step_size, int strength)
|
|
|
|
{
|
|
|
|
/* BCH code. Denali requires ecc.bytes to be multiple of 2 */
|
|
|
|
return DIV_ROUND_UP(strength * fls(step_size * 8), 16) * 2;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(denali_calc_ecc_bytes);
|
|
|
|
|
2016-02-04 02:00:11 +07:00
|
|
|
static int denali_ooblayout_ecc(struct mtd_info *mtd, int section,
|
|
|
|
struct mtd_oob_region *oobregion)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
struct nand_chip *chip = mtd_to_nand(mtd);
|
|
|
|
|
|
|
|
if (section)
|
|
|
|
return -ERANGE;
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
oobregion->offset = denali->oob_skip_bytes;
|
2016-02-04 02:00:11 +07:00
|
|
|
oobregion->length = chip->ecc.total;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int denali_ooblayout_free(struct mtd_info *mtd, int section,
|
|
|
|
struct mtd_oob_region *oobregion)
|
|
|
|
{
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
struct nand_chip *chip = mtd_to_nand(mtd);
|
|
|
|
|
|
|
|
if (section)
|
|
|
|
return -ERANGE;
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
oobregion->offset = chip->ecc.total + denali->oob_skip_bytes;
|
2016-02-04 02:00:11 +07:00
|
|
|
oobregion->length = mtd->oobsize - oobregion->offset;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct mtd_ooblayout_ops denali_ooblayout_ops = {
|
|
|
|
.ecc = denali_ooblayout_ecc,
|
|
|
|
.free = denali_ooblayout_free,
|
2010-05-13 21:57:33 +07:00
|
|
|
};
|
|
|
|
|
2017-03-23 03:07:21 +07:00
|
|
|
static int denali_multidev_fixup(struct denali_nand_info *denali)
|
2017-03-23 03:07:20 +07:00
|
|
|
{
|
|
|
|
struct nand_chip *chip = &denali->nand;
|
|
|
|
struct mtd_info *mtd = nand_to_mtd(chip);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Support for multi device:
|
|
|
|
* When the IP configuration is x16 capable and two x8 chips are
|
|
|
|
* connected in parallel, DEVICES_CONNECTED should be set to 2.
|
|
|
|
* In this case, the core framework knows nothing about this fact,
|
|
|
|
* so we should tell it the _logical_ pagesize and anything necessary.
|
|
|
|
*/
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->devs_per_cs = ioread32(denali->reg + DEVICES_CONNECTED);
|
2017-03-23 03:07:20 +07:00
|
|
|
|
2017-03-23 03:07:22 +07:00
|
|
|
/*
|
|
|
|
* On some SoCs, DEVICES_CONNECTED is not auto-detected.
|
|
|
|
* For those, DEVICES_CONNECTED is left to 0. Set 1 if it is the case.
|
|
|
|
*/
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
if (denali->devs_per_cs == 0) {
|
|
|
|
denali->devs_per_cs = 1;
|
|
|
|
iowrite32(1, denali->reg + DEVICES_CONNECTED);
|
2017-03-23 03:07:22 +07:00
|
|
|
}
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
if (denali->devs_per_cs == 1)
|
2017-03-23 03:07:21 +07:00
|
|
|
return 0;
|
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
if (denali->devs_per_cs != 2) {
|
2017-03-23 03:07:21 +07:00
|
|
|
dev_err(denali->dev, "unsupported number of devices %d\n",
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->devs_per_cs);
|
2017-03-23 03:07:21 +07:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* 2 chips in parallel */
|
|
|
|
mtd->size <<= 1;
|
|
|
|
mtd->erasesize <<= 1;
|
|
|
|
mtd->writesize <<= 1;
|
|
|
|
mtd->oobsize <<= 1;
|
|
|
|
chip->chipsize <<= 1;
|
|
|
|
chip->page_shift += 1;
|
|
|
|
chip->phys_erase_shift += 1;
|
|
|
|
chip->bbt_erase_shift += 1;
|
|
|
|
chip->chip_shift += 1;
|
|
|
|
chip->pagemask <<= 1;
|
|
|
|
chip->ecc.size <<= 1;
|
|
|
|
chip->ecc.bytes <<= 1;
|
|
|
|
chip->ecc.strength <<= 1;
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->oob_skip_bytes <<= 1;
|
2017-03-23 03:07:21 +07:00
|
|
|
|
|
|
|
return 0;
|
2017-03-23 03:07:20 +07:00
|
|
|
}
|
|
|
|
|
2018-07-20 22:14:56 +07:00
|
|
|
static int denali_attach_chip(struct nand_chip *chip)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2017-03-23 03:07:17 +07:00
|
|
|
struct mtd_info *mtd = nand_to_mtd(chip);
|
2018-07-20 22:14:56 +07:00
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
2012-09-27 23:58:05 +07:00
|
|
|
int ret;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
if (ioread32(denali->reg + FEATURES) & FEATURES__DMA)
|
2017-06-13 20:45:45 +07:00
|
|
|
denali->dma_avail = 1;
|
|
|
|
|
|
|
|
if (denali->dma_avail) {
|
|
|
|
int dma_bit = denali->caps & DENALI_CAP_DMA_64BIT ? 64 : 32;
|
|
|
|
|
|
|
|
ret = dma_set_mask(denali->dev, DMA_BIT_MASK(dma_bit));
|
|
|
|
if (ret) {
|
|
|
|
dev_info(denali->dev,
|
|
|
|
"Failed to set DMA mask. Disabling DMA.\n");
|
|
|
|
denali->dma_avail = 0;
|
|
|
|
}
|
2013-12-20 23:02:28 +07:00
|
|
|
}
|
|
|
|
|
2017-06-13 20:45:45 +07:00
|
|
|
if (denali->dma_avail) {
|
2017-06-13 20:45:47 +07:00
|
|
|
chip->options |= NAND_USE_BOUNCE_BUFFER;
|
|
|
|
chip->buf_align = 16;
|
2017-09-22 10:46:49 +07:00
|
|
|
if (denali->caps & DENALI_CAP_DMA_64BIT)
|
|
|
|
denali->setup_dma = denali_setup_dma64;
|
|
|
|
else
|
|
|
|
denali->setup_dma = denali_setup_dma32;
|
2010-08-06 17:48:21 +07:00
|
|
|
}
|
|
|
|
|
2017-03-23 03:07:17 +07:00
|
|
|
chip->bbt_options |= NAND_BBT_USE_FLASH;
|
2017-06-13 20:45:49 +07:00
|
|
|
chip->bbt_options |= NAND_BBT_NO_OOB;
|
2017-03-23 03:07:17 +07:00
|
|
|
chip->ecc.mode = NAND_ECC_HW_SYNDROME;
|
|
|
|
chip->options |= NAND_NO_SUBPAGE_WRITE;
|
2015-01-14 22:38:50 +07:00
|
|
|
|
2018-06-20 14:27:29 +07:00
|
|
|
ret = nand_ecc_choose_conf(chip, denali->ecc_caps,
|
|
|
|
mtd->oobsize - denali->oob_skip_bytes);
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
if (ret) {
|
|
|
|
dev_err(denali->dev, "Failed to setup ECC settings.\n");
|
2018-07-20 22:14:56 +07:00
|
|
|
return ret;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
|
|
|
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
dev_dbg(denali->dev,
|
|
|
|
"chosen ECC settings: step=%d, strength=%d, bytes=%d\n",
|
|
|
|
chip->ecc.size, chip->ecc.strength, chip->ecc.bytes);
|
|
|
|
|
2017-09-22 10:46:43 +07:00
|
|
|
iowrite32(FIELD_PREP(ECC_CORRECTION__ERASE_THRESHOLD, 1) |
|
|
|
|
FIELD_PREP(ECC_CORRECTION__VALUE, chip->ecc.strength),
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->reg + ECC_CORRECTION);
|
2017-06-07 18:52:13 +07:00
|
|
|
iowrite32(mtd->erasesize / mtd->writesize,
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->reg + PAGES_PER_BLOCK);
|
2017-06-07 18:52:13 +07:00
|
|
|
iowrite32(chip->options & NAND_BUSWIDTH_16 ? 1 : 0,
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->reg + DEVICE_WIDTH);
|
2017-09-13 09:05:51 +07:00
|
|
|
iowrite32(chip->options & NAND_ROW_ADDR_3 ? 0 : TWO_ROW_ADDR_CYCLES__FLAG,
|
|
|
|
denali->reg + TWO_ROW_ADDR_CYCLES);
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(mtd->writesize, denali->reg + DEVICE_MAIN_AREA_SIZE);
|
|
|
|
iowrite32(mtd->oobsize, denali->reg + DEVICE_SPARE_AREA_SIZE);
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
iowrite32(chip->ecc.size, denali->reg + CFG_DATA_BLOCK_SIZE);
|
|
|
|
iowrite32(chip->ecc.size, denali->reg + CFG_LAST_DATA_BLOCK_SIZE);
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
/* chip->ecc.steps is set by nand_scan_tail(); not available here */
|
|
|
|
iowrite32(mtd->writesize / chip->ecc.size,
|
mtd: nand: denali: avoid magic numbers and rename for clarification
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 = Data Cycle
So, this commit added DENALI_MAP11_{CMD,ADDR,DATA} macros.
- We see 'denali->flash_mem + 0x10' in several places, but 0x10 is a
magic number. Actually, this accesses the data port of the Host
Data/Command Interface. So, this commit added DENALI_HOST_DATA.
On the other hand, 'denali->flash_mem' gets access to the address
port, so DENALI_HOST_ADDR was also added.
- We see 'index_addr(denali, cmd, 0x1)' in denali_erase(), but 0x1
is a magic number. 0x1 means the erase operation. Replace 0x1
with DENALI_ERASE.
- Rename index_addr() to denali_host_write() for clarification
- Denali User's Guide says MAP{00,01,10,11} for access mode. Match
the macros with terminology in the IP document.
- Rename struct members as follows:
flash_bank -> active_bank (currently selected bank)
flash_reg -> reg (base address of registers)
flash_mem -> host (base address of host interface)
devnum -> devs_per_cs (devices connected in parallel)
bbtskipbytes -> oob_skip_bytes (number of bytes to skip in OOB)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-16 12:36:39 +07:00
|
|
|
denali->reg + CFG_NUM_DATA_BLOCKS);
|
mtd: nand: denali: avoid hard-coding ECC step, strength, bytes
This driver was originally written for the Intel MRST platform with
several platform-specific parameters hard-coded.
Currently, the ECC settings are hard-coded as follows:
#define ECC_SECTOR_SIZE 512
#define ECC_8BITS 14
#define ECC_15BITS 26
Therefore, the driver can only support two cases.
- ecc.size = 512, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 512, ecc.strength = 15 --> ecc.bytes = 26
However, these are actually customizable parameters, for example,
UniPhier platform supports the following:
- ecc.size = 1024, ecc.strength = 8 --> ecc.bytes = 14
- ecc.size = 1024, ecc.strength = 16 --> ecc.bytes = 28
- ecc.size = 1024, ecc.strength = 24 --> ecc.bytes = 42
So, we need to handle the ECC parameters in a more generic manner.
Fortunately, the Denali User's Guide explains how to calculate the
ecc.bytes. The formula is:
ecc.bytes = 2 * CEIL(13 * ecc.strength / 16) (for ecc.size = 512)
ecc.bytes = 2 * CEIL(14 * ecc.strength / 16) (for ecc.size = 1024)
For DT platforms, it would be reasonable to allow DT to specify ECC
strength by either "nand-ecc-strength" or "nand-ecc-maximize". If
none of them is specified, the driver will try to meet the chip's ECC
requirement.
For PCI platforms, the max ECC strength is used to keep the original
behavior.
Newer versions of this IP need ecc.size and ecc.steps explicitly
set up via the following registers:
CFG_DATA_BLOCK_SIZE (0x6b0)
CFG_LAST_DATA_BLOCK_SIZE (0x6c0)
CFG_NUM_DATA_BLOCKS (0x6d0)
For older IP versions, write accesses to these registers are just
ignored.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
2017-06-07 18:52:12 +07:00
|
|
|
|
2016-02-04 02:00:11 +07:00
|
|
|
mtd_set_ooblayout(mtd, &denali_ooblayout_ops);
|
2010-08-06 17:02:03 +07:00
|
|
|
|
2017-06-13 20:45:39 +07:00
|
|
|
if (chip->options & NAND_BUSWIDTH_16) {
|
|
|
|
chip->read_buf = denali_read_buf16;
|
|
|
|
chip->write_buf = denali_write_buf16;
|
|
|
|
} else {
|
|
|
|
chip->read_buf = denali_read_buf;
|
|
|
|
chip->write_buf = denali_write_buf;
|
|
|
|
}
|
2017-03-23 03:07:17 +07:00
|
|
|
chip->ecc.read_page = denali_read_page;
|
|
|
|
chip->ecc.read_page_raw = denali_read_page_raw;
|
|
|
|
chip->ecc.write_page = denali_write_page;
|
|
|
|
chip->ecc.write_page_raw = denali_write_page_raw;
|
|
|
|
chip->ecc.read_oob = denali_read_oob;
|
|
|
|
chip->ecc.write_oob = denali_write_oob;
|
|
|
|
chip->erase = denali_erase;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2017-03-23 03:07:21 +07:00
|
|
|
ret = denali_multidev_fixup(denali);
|
|
|
|
if (ret)
|
2018-07-20 22:14:56 +07:00
|
|
|
return ret;
|
2017-03-23 03:07:20 +07:00
|
|
|
|
2017-06-13 20:45:48 +07:00
|
|
|
/*
|
|
|
|
* This buffer is DMA-mapped by denali_{read,write}_page_raw. Do not
|
|
|
|
* use devm_kmalloc() because the memory allocated by devm_ does not
|
|
|
|
* guarantee DMA-safe alignment.
|
|
|
|
*/
|
|
|
|
denali->buf = kmalloc(mtd->writesize + mtd->oobsize, GFP_KERNEL);
|
2018-07-20 22:14:56 +07:00
|
|
|
if (!denali->buf)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void denali_detach_chip(struct nand_chip *chip)
|
|
|
|
{
|
|
|
|
struct mtd_info *mtd = nand_to_mtd(chip);
|
|
|
|
struct denali_nand_info *denali = mtd_to_denali(mtd);
|
|
|
|
|
|
|
|
kfree(denali->buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct nand_controller_ops denali_controller_ops = {
|
|
|
|
.attach_chip = denali_attach_chip,
|
|
|
|
.detach_chip = denali_detach_chip,
|
|
|
|
};
|
|
|
|
|
|
|
|
int denali_init(struct denali_nand_info *denali)
|
|
|
|
{
|
|
|
|
struct nand_chip *chip = &denali->nand;
|
|
|
|
struct mtd_info *mtd = nand_to_mtd(chip);
|
|
|
|
u32 features = ioread32(denali->reg + FEATURES);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
mtd->dev.parent = denali->dev;
|
|
|
|
denali_hw_init(denali);
|
|
|
|
|
|
|
|
init_completion(&denali->complete);
|
|
|
|
spin_lock_init(&denali->irq_lock);
|
|
|
|
|
|
|
|
denali_clear_irq_all(denali);
|
|
|
|
|
|
|
|
ret = devm_request_irq(denali->dev, denali->irq, denali_isr,
|
|
|
|
IRQF_SHARED, DENALI_NAND_NAME, denali);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(denali->dev, "Unable to request IRQ\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
denali_enable_irq(denali);
|
|
|
|
denali_reset_banks(denali);
|
mtd: rawnand: denali: do not pass zero maxchips to nand_scan()
Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident()
if maxchips is zero") gave a new meaning for calling nand_scan_ident()
with maxchips=0.
It is a special usage for some drivers such as docg4, but actually
the Denali driver may pass maxchips=0 to nand_scan() when the driver
is enabled but no NAND chip is found on the board for some reasons.
If nand_scan_with_ids() is called with maxchips=0, nand_scan_ident()
is skipped, then nand_set_defaults() is skipped as well. Thus, the
driver must set chip->controller beforehand. Otherwise, nand_attach()
causes NULL pointer dereference.
In fact, the Denali controller knows the number of connected chips
before calling nand_scan_ident(); if DEVICE_RESET fails, there is no
chip in that chip select. Then, denali_reset_banks() sets the maxchips
to the number of detected chips. If no chip is found, maxchips is zero.
In this case, there is no point for calling nand_scan() because we know
it will fail for sure. Let's make the probe function fail immediately.
Fixes: 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() if maxchips is zero")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
2018-08-27 14:01:41 +07:00
|
|
|
if (!denali->max_banks) {
|
|
|
|
/* Error out earlier if no chip is found for some reasons. */
|
|
|
|
ret = -ENODEV;
|
|
|
|
goto disable_irq;
|
|
|
|
}
|
2018-07-20 22:14:56 +07:00
|
|
|
|
|
|
|
denali->active_bank = DENALI_INVALID_BANK;
|
|
|
|
|
|
|
|
nand_set_flash_node(chip, denali->dev->of_node);
|
|
|
|
/* Fallback to the default name if DT did not give "label" property */
|
|
|
|
if (!mtd->name)
|
|
|
|
mtd->name = "denali-nand";
|
|
|
|
|
|
|
|
chip->select_chip = denali_select_chip;
|
|
|
|
chip->read_byte = denali_read_byte;
|
|
|
|
chip->write_byte = denali_write_byte;
|
|
|
|
chip->read_word = denali_read_word;
|
|
|
|
chip->cmd_ctrl = denali_cmd_ctrl;
|
|
|
|
chip->dev_ready = denali_dev_ready;
|
|
|
|
chip->waitfunc = denali_waitfunc;
|
|
|
|
|
|
|
|
if (features & FEATURES__INDEX_ADDR) {
|
|
|
|
denali->host_read = denali_indexed_read;
|
|
|
|
denali->host_write = denali_indexed_write;
|
|
|
|
} else {
|
|
|
|
denali->host_read = denali_direct_read;
|
|
|
|
denali->host_write = denali_direct_write;
|
2017-06-13 20:45:48 +07:00
|
|
|
}
|
|
|
|
|
2018-07-20 22:14:56 +07:00
|
|
|
/* clk rate info is needed for setup_data_interface */
|
|
|
|
if (denali->clk_rate && denali->clk_x_rate)
|
|
|
|
chip->setup_data_interface = denali_setup_data_interface;
|
|
|
|
|
|
|
|
chip->dummy_controller.ops = &denali_controller_ops;
|
|
|
|
ret = nand_scan(mtd, denali->max_banks);
|
2016-11-09 11:35:28 +07:00
|
|
|
if (ret)
|
2018-07-20 22:14:56 +07:00
|
|
|
goto disable_irq;
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2015-12-11 21:06:00 +07:00
|
|
|
ret = mtd_device_register(mtd, NULL, 0);
|
2010-05-13 21:57:33 +07:00
|
|
|
if (ret) {
|
2016-11-09 11:35:24 +07:00
|
|
|
dev_err(denali->dev, "Failed to register MTD: %d\n", ret);
|
2018-03-21 20:01:45 +07:00
|
|
|
goto cleanup_nand;
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
2018-07-20 22:14:56 +07:00
|
|
|
|
2010-05-13 21:57:33 +07:00
|
|
|
return 0;
|
|
|
|
|
2018-03-21 20:01:45 +07:00
|
|
|
cleanup_nand:
|
|
|
|
nand_cleanup(chip);
|
2017-06-13 20:45:38 +07:00
|
|
|
disable_irq:
|
|
|
|
denali_disable_irq(denali);
|
2012-09-27 23:58:05 +07:00
|
|
|
|
2010-05-13 21:57:33 +07:00
|
|
|
return ret;
|
|
|
|
}
|
2012-09-27 23:58:05 +07:00
|
|
|
EXPORT_SYMBOL(denali_init);
|
2010-05-13 21:57:33 +07:00
|
|
|
|
2012-09-27 23:58:05 +07:00
|
|
|
void denali_remove(struct denali_nand_info *denali)
|
2010-05-13 21:57:33 +07:00
|
|
|
{
|
2015-12-11 21:06:00 +07:00
|
|
|
struct mtd_info *mtd = nand_to_mtd(&denali->nand);
|
2015-12-11 21:02:34 +07:00
|
|
|
|
2015-12-11 21:06:00 +07:00
|
|
|
nand_release(mtd);
|
2017-06-13 20:45:38 +07:00
|
|
|
denali_disable_irq(denali);
|
2010-05-13 21:57:33 +07:00
|
|
|
}
|
2012-09-27 23:58:05 +07:00
|
|
|
EXPORT_SYMBOL(denali_remove);
|