2010-04-07 05:14:15 +07:00
|
|
|
#include <linux/module.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 15:04:11 +07:00
|
|
|
#include <linux/gfp.h>
|
2014-09-16 16:50:45 +07:00
|
|
|
#include <linux/slab.h>
|
2009-12-24 03:12:31 +07:00
|
|
|
#include <linux/pagemap.h>
|
|
|
|
#include <linux/highmem.h>
|
2010-04-07 05:14:15 +07:00
|
|
|
#include <linux/ceph/pagelist.h>
|
2009-12-24 03:12:31 +07:00
|
|
|
|
2010-09-04 02:57:11 +07:00
|
|
|
static void ceph_pagelist_unmap_tail(struct ceph_pagelist *pl)
|
|
|
|
{
|
2010-09-18 00:10:55 +07:00
|
|
|
if (pl->mapped_tail) {
|
|
|
|
struct page *page = list_entry(pl->head.prev, struct page, lru);
|
|
|
|
kunmap(page);
|
|
|
|
pl->mapped_tail = NULL;
|
|
|
|
}
|
2010-09-04 02:57:11 +07:00
|
|
|
}
|
|
|
|
|
2014-09-16 16:50:45 +07:00
|
|
|
void ceph_pagelist_release(struct ceph_pagelist *pl)
|
2009-12-24 03:12:31 +07:00
|
|
|
{
|
2017-03-17 19:10:29 +07:00
|
|
|
if (!refcount_dec_and_test(&pl->refcnt))
|
2014-09-16 16:50:45 +07:00
|
|
|
return;
|
2010-09-18 00:10:55 +07:00
|
|
|
ceph_pagelist_unmap_tail(pl);
|
2009-12-24 03:12:31 +07:00
|
|
|
while (!list_empty(&pl->head)) {
|
|
|
|
struct page *page = list_first_entry(&pl->head, struct page,
|
|
|
|
lru);
|
|
|
|
list_del(&page->lru);
|
|
|
|
__free_page(page);
|
|
|
|
}
|
2010-09-18 00:10:55 +07:00
|
|
|
ceph_pagelist_free_reserve(pl);
|
2014-09-16 16:50:45 +07:00
|
|
|
kfree(pl);
|
2009-12-24 03:12:31 +07:00
|
|
|
}
|
2010-04-07 05:14:15 +07:00
|
|
|
EXPORT_SYMBOL(ceph_pagelist_release);
|
2009-12-24 03:12:31 +07:00
|
|
|
|
|
|
|
static int ceph_pagelist_addpage(struct ceph_pagelist *pl)
|
|
|
|
{
|
2010-09-18 00:10:55 +07:00
|
|
|
struct page *page;
|
|
|
|
|
|
|
|
if (!pl->num_pages_free) {
|
|
|
|
page = __page_cache_alloc(GFP_NOFS);
|
|
|
|
} else {
|
|
|
|
page = list_first_entry(&pl->free_list, struct page, lru);
|
|
|
|
list_del(&page->lru);
|
2010-10-06 02:03:23 +07:00
|
|
|
--pl->num_pages_free;
|
2010-09-18 00:10:55 +07:00
|
|
|
}
|
2009-12-24 03:12:31 +07:00
|
|
|
if (!page)
|
|
|
|
return -ENOMEM;
|
|
|
|
pl->room += PAGE_SIZE;
|
2010-09-18 00:10:55 +07:00
|
|
|
ceph_pagelist_unmap_tail(pl);
|
2009-12-24 03:12:31 +07:00
|
|
|
list_add_tail(&page->lru, &pl->head);
|
|
|
|
pl->mapped_tail = kmap(page);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-04-07 05:01:27 +07:00
|
|
|
int ceph_pagelist_append(struct ceph_pagelist *pl, const void *buf, size_t len)
|
2009-12-24 03:12:31 +07:00
|
|
|
{
|
|
|
|
while (pl->room < len) {
|
|
|
|
size_t bit = pl->room;
|
|
|
|
int ret;
|
|
|
|
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 19:29:47 +07:00
|
|
|
memcpy(pl->mapped_tail + (pl->length & ~PAGE_MASK),
|
2009-12-24 03:12:31 +07:00
|
|
|
buf, bit);
|
|
|
|
pl->length += bit;
|
|
|
|
pl->room -= bit;
|
|
|
|
buf += bit;
|
|
|
|
len -= bit;
|
|
|
|
ret = ceph_pagelist_addpage(pl);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 19:29:47 +07:00
|
|
|
memcpy(pl->mapped_tail + (pl->length & ~PAGE_MASK), buf, len);
|
2009-12-24 03:12:31 +07:00
|
|
|
pl->length += len;
|
|
|
|
pl->room -= len;
|
|
|
|
return 0;
|
|
|
|
}
|
2010-04-07 05:14:15 +07:00
|
|
|
EXPORT_SYMBOL(ceph_pagelist_append);
|
2010-09-18 00:10:55 +07:00
|
|
|
|
2012-07-10 17:55:35 +07:00
|
|
|
/* Allocate enough pages for a pagelist to append the given amount
|
2010-09-18 00:10:55 +07:00
|
|
|
* of data without without allocating.
|
|
|
|
* Returns: 0 on success, -ENOMEM on error.
|
|
|
|
*/
|
|
|
|
int ceph_pagelist_reserve(struct ceph_pagelist *pl, size_t space)
|
|
|
|
{
|
|
|
|
if (space <= pl->room)
|
|
|
|
return 0;
|
|
|
|
space -= pl->room;
|
|
|
|
space = (space + PAGE_SIZE - 1) >> PAGE_SHIFT; /* conv to num pages */
|
|
|
|
|
|
|
|
while (space > pl->num_pages_free) {
|
|
|
|
struct page *page = __page_cache_alloc(GFP_NOFS);
|
|
|
|
if (!page)
|
|
|
|
return -ENOMEM;
|
|
|
|
list_add_tail(&page->lru, &pl->free_list);
|
|
|
|
++pl->num_pages_free;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ceph_pagelist_reserve);
|
|
|
|
|
2012-07-10 17:55:35 +07:00
|
|
|
/* Free any pages that have been preallocated. */
|
2010-09-18 00:10:55 +07:00
|
|
|
int ceph_pagelist_free_reserve(struct ceph_pagelist *pl)
|
|
|
|
{
|
|
|
|
while (!list_empty(&pl->free_list)) {
|
|
|
|
struct page *page = list_first_entry(&pl->free_list,
|
|
|
|
struct page, lru);
|
|
|
|
list_del(&page->lru);
|
|
|
|
__free_page(page);
|
|
|
|
--pl->num_pages_free;
|
|
|
|
}
|
|
|
|
BUG_ON(pl->num_pages_free);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ceph_pagelist_free_reserve);
|
|
|
|
|
2012-07-10 17:55:35 +07:00
|
|
|
/* Create a truncation point. */
|
2010-09-18 00:10:55 +07:00
|
|
|
void ceph_pagelist_set_cursor(struct ceph_pagelist *pl,
|
|
|
|
struct ceph_pagelist_cursor *c)
|
|
|
|
{
|
|
|
|
c->pl = pl;
|
|
|
|
c->page_lru = pl->head.prev;
|
|
|
|
c->room = pl->room;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ceph_pagelist_set_cursor);
|
|
|
|
|
2012-07-10 17:55:35 +07:00
|
|
|
/* Truncate a pagelist to the given point. Move extra pages to reserve.
|
2010-09-18 00:10:55 +07:00
|
|
|
* This won't sleep.
|
|
|
|
* Returns: 0 on success,
|
|
|
|
* -EINVAL if the pagelist doesn't match the trunc point pagelist
|
|
|
|
*/
|
|
|
|
int ceph_pagelist_truncate(struct ceph_pagelist *pl,
|
|
|
|
struct ceph_pagelist_cursor *c)
|
|
|
|
{
|
|
|
|
struct page *page;
|
|
|
|
|
|
|
|
if (pl != c->pl)
|
|
|
|
return -EINVAL;
|
|
|
|
ceph_pagelist_unmap_tail(pl);
|
|
|
|
while (pl->head.prev != c->page_lru) {
|
|
|
|
page = list_entry(pl->head.prev, struct page, lru);
|
2012-09-05 13:34:32 +07:00
|
|
|
/* move from pagelist to reserve */
|
|
|
|
list_move_tail(&page->lru, &pl->free_list);
|
2010-09-18 00:10:55 +07:00
|
|
|
++pl->num_pages_free;
|
|
|
|
}
|
|
|
|
pl->room = c->room;
|
|
|
|
if (!list_empty(&pl->head)) {
|
|
|
|
page = list_entry(pl->head.prev, struct page, lru);
|
|
|
|
pl->mapped_tail = kmap(page);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ceph_pagelist_truncate);
|