License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 21:07:57 +07:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2013-08-27 15:23:08 +07:00
|
|
|
#include "evlist.h"
|
|
|
|
#include "evsel.h"
|
|
|
|
#include "cpumap.h"
|
2013-08-27 15:23:09 +07:00
|
|
|
#include "parse-events.h"
|
2017-04-18 20:46:11 +07:00
|
|
|
#include <errno.h>
|
2013-12-09 23:14:24 +07:00
|
|
|
#include <api/fs/fs.h>
|
perf record: Allow asking for the maximum allowed sample rate
Add the handy '-F max' shortcut to reading and using the
kernel.perf_event_max_sample_rate value as the user supplied
sampling frequency:
# perf record -F max sleep 1
info: Using a maximum frequency rate of 15,000 Hz
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.019 MB perf.data (14 samples) ]
# sysctl kernel.perf_event_max_sample_rate
kernel.perf_event_max_sample_rate = 15000
# perf evlist -v
cycles:ppp: size: 112, { sample_period, sample_freq }: 15000, sample_type: IP|TID|TIME|PERIOD, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 3, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
# perf record -F 10 sleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.019 MB perf.data (4 samples) ]
# perf evlist -v
cycles:ppp: size: 112, { sample_period, sample_freq }: 10, sample_type: IP|TID|TIME|PERIOD, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 3, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
#
Suggested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-4y0tiuws62c64gp4cf0hme0m@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2018-03-01 23:46:23 +07:00
|
|
|
#include <subcmd/parse-options.h>
|
2013-11-05 21:14:47 +07:00
|
|
|
#include "util.h"
|
2014-07-01 03:28:47 +07:00
|
|
|
#include "cloexec.h"
|
2013-08-27 15:23:09 +07:00
|
|
|
|
|
|
|
typedef void (*setup_probe_fn_t)(struct perf_evsel *evsel);
|
|
|
|
|
|
|
|
static int perf_do_probe_api(setup_probe_fn_t fn, int cpu, const char *str)
|
|
|
|
{
|
|
|
|
struct perf_evlist *evlist;
|
|
|
|
struct perf_evsel *evsel;
|
2014-07-01 03:28:47 +07:00
|
|
|
unsigned long flags = perf_event_open_cloexec_flag();
|
2013-08-27 15:23:09 +07:00
|
|
|
int err = -EAGAIN, fd;
|
2014-08-12 22:04:30 +07:00
|
|
|
static pid_t pid = -1;
|
2013-08-27 15:23:09 +07:00
|
|
|
|
|
|
|
evlist = perf_evlist__new();
|
|
|
|
if (!evlist)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
perf tools: Add parse_events_error interface
Adding support to return error information from parse_events function.
Following struct will be populated by parse_events function on return:
struct parse_events_error {
int idx;
char *str;
char *help;
};
where 'idx' is the position in the string where the parsing failed,
'str' contains dynamically allocated error string describing the error
and 'help' is optional help string.
The change contains reporting function, which currently does not display
anything. The code changes to supply error data for specific event types
are coming in next patches. However this is what the expected output is:
$ sudo perf record -e 'sched:krava' ls
event syntax error: 'sched:krava'
\___ unknown tracepoint
...
$ perf record -e 'cpu/even=0x1/' ls
event syntax error: 'cpu/even=0x1/'
\___ unknown term
valid terms: pc,any,inv,edge,cmask,event,in_tx,ldlat,umask,in_tx_cp,offcore_rsp,config,config1,config2,name,period,branch_type
...
$ perf record -e cycles,cache-mises ls
event syntax error: '..es,cache-mises'
\___ parser error
...
The output functions cut the beginning of the event string so the error
starts up to 10th character and cut the end of the string of it crosses
the terminal width.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1429729824-13932-2-git-send-email-jolsa@kernel.org
[ Renamed 'error' variables to 'err', not to clash with util.h error() ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-04-23 02:10:16 +07:00
|
|
|
if (parse_events(evlist, str, NULL))
|
2013-08-27 15:23:09 +07:00
|
|
|
goto out_delete;
|
|
|
|
|
|
|
|
evsel = perf_evlist__first(evlist);
|
|
|
|
|
2014-08-12 22:04:30 +07:00
|
|
|
while (1) {
|
|
|
|
fd = sys_perf_event_open(&evsel->attr, pid, cpu, -1, flags);
|
|
|
|
if (fd < 0) {
|
|
|
|
if (pid == -1 && errno == EACCES) {
|
|
|
|
pid = 0;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
goto out_delete;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2013-08-27 15:23:09 +07:00
|
|
|
close(fd);
|
|
|
|
|
|
|
|
fn(evsel);
|
|
|
|
|
2014-08-12 22:04:30 +07:00
|
|
|
fd = sys_perf_event_open(&evsel->attr, pid, cpu, -1, flags);
|
2013-08-27 15:23:09 +07:00
|
|
|
if (fd < 0) {
|
|
|
|
if (errno == EINVAL)
|
|
|
|
err = -EINVAL;
|
|
|
|
goto out_delete;
|
|
|
|
}
|
|
|
|
close(fd);
|
|
|
|
err = 0;
|
|
|
|
|
|
|
|
out_delete:
|
|
|
|
perf_evlist__delete(evlist);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool perf_probe_api(setup_probe_fn_t fn)
|
|
|
|
{
|
2014-08-12 22:04:29 +07:00
|
|
|
const char *try[] = {"cycles:u", "instructions:u", "cpu-clock:u", NULL};
|
2013-08-27 15:23:09 +07:00
|
|
|
struct cpu_map *cpus;
|
|
|
|
int cpu, ret, i = 0;
|
|
|
|
|
|
|
|
cpus = cpu_map__new(NULL);
|
|
|
|
if (!cpus)
|
|
|
|
return false;
|
|
|
|
cpu = cpus->map[0];
|
2015-06-23 05:36:04 +07:00
|
|
|
cpu_map__put(cpus);
|
2013-08-27 15:23:09 +07:00
|
|
|
|
|
|
|
do {
|
|
|
|
ret = perf_do_probe_api(fn, cpu, try[i++]);
|
|
|
|
if (!ret)
|
|
|
|
return true;
|
|
|
|
} while (ret == -EAGAIN && try[i]);
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void perf_probe_sample_identifier(struct perf_evsel *evsel)
|
|
|
|
{
|
|
|
|
evsel->attr.sample_type |= PERF_SAMPLE_IDENTIFIER;
|
|
|
|
}
|
|
|
|
|
2014-07-14 17:02:28 +07:00
|
|
|
static void perf_probe_comm_exec(struct perf_evsel *evsel)
|
|
|
|
{
|
|
|
|
evsel->attr.comm_exec = 1;
|
|
|
|
}
|
|
|
|
|
2015-07-21 16:44:04 +07:00
|
|
|
static void perf_probe_context_switch(struct perf_evsel *evsel)
|
|
|
|
{
|
|
|
|
evsel->attr.context_switch = 1;
|
|
|
|
}
|
|
|
|
|
2013-08-27 15:23:09 +07:00
|
|
|
bool perf_can_sample_identifier(void)
|
|
|
|
{
|
|
|
|
return perf_probe_api(perf_probe_sample_identifier);
|
|
|
|
}
|
2013-08-27 15:23:08 +07:00
|
|
|
|
2014-07-14 17:02:28 +07:00
|
|
|
static bool perf_can_comm_exec(void)
|
|
|
|
{
|
|
|
|
return perf_probe_api(perf_probe_comm_exec);
|
|
|
|
}
|
|
|
|
|
2015-07-21 16:44:04 +07:00
|
|
|
bool perf_can_record_switch_events(void)
|
|
|
|
{
|
|
|
|
return perf_probe_api(perf_probe_context_switch);
|
|
|
|
}
|
|
|
|
|
2015-08-13 16:40:56 +07:00
|
|
|
bool perf_can_record_cpu_wide(void)
|
|
|
|
{
|
|
|
|
struct perf_event_attr attr = {
|
|
|
|
.type = PERF_TYPE_SOFTWARE,
|
|
|
|
.config = PERF_COUNT_SW_CPU_CLOCK,
|
|
|
|
.exclude_kernel = 1,
|
|
|
|
};
|
|
|
|
struct cpu_map *cpus;
|
|
|
|
int cpu, fd;
|
|
|
|
|
|
|
|
cpus = cpu_map__new(NULL);
|
|
|
|
if (!cpus)
|
|
|
|
return false;
|
|
|
|
cpu = cpus->map[0];
|
|
|
|
cpu_map__put(cpus);
|
|
|
|
|
|
|
|
fd = sys_perf_event_open(&attr, -1, cpu, -1, 0);
|
|
|
|
if (fd < 0)
|
|
|
|
return false;
|
|
|
|
close(fd);
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2016-04-12 04:15:29 +07:00
|
|
|
void perf_evlist__config(struct perf_evlist *evlist, struct record_opts *opts,
|
|
|
|
struct callchain_param *callchain)
|
2013-08-27 15:23:08 +07:00
|
|
|
{
|
|
|
|
struct perf_evsel *evsel;
|
2013-08-27 15:23:09 +07:00
|
|
|
bool use_sample_identifier = false;
|
2014-07-14 17:02:28 +07:00
|
|
|
bool use_comm_exec;
|
2018-03-02 23:13:54 +07:00
|
|
|
bool sample_id = opts->sample_id;
|
2013-08-27 15:23:09 +07:00
|
|
|
|
2013-08-27 15:23:08 +07:00
|
|
|
/*
|
|
|
|
* Set the evsel leader links before we configure attributes,
|
|
|
|
* since some might depend on this info.
|
|
|
|
*/
|
|
|
|
if (opts->group)
|
|
|
|
perf_evlist__set_leader(evlist);
|
|
|
|
|
|
|
|
if (evlist->cpus->map[0] < 0)
|
|
|
|
opts->no_inherit = true;
|
|
|
|
|
2014-07-14 17:02:28 +07:00
|
|
|
use_comm_exec = perf_can_comm_exec();
|
|
|
|
|
2016-06-23 21:26:15 +07:00
|
|
|
evlist__for_each_entry(evlist, evsel) {
|
2016-04-12 04:15:29 +07:00
|
|
|
perf_evsel__config(evsel, opts, callchain);
|
2014-07-31 13:00:52 +07:00
|
|
|
if (evsel->tracking && use_comm_exec)
|
2014-07-14 17:02:28 +07:00
|
|
|
evsel->attr.comm_exec = 1;
|
|
|
|
}
|
2013-08-27 15:23:08 +07:00
|
|
|
|
2015-04-09 22:53:44 +07:00
|
|
|
if (opts->full_auxtrace) {
|
|
|
|
/*
|
|
|
|
* Need to be able to synthesize and parse selected events with
|
|
|
|
* arbitrary sample types, which requires always being able to
|
|
|
|
* match the id.
|
|
|
|
*/
|
|
|
|
use_sample_identifier = perf_can_sample_identifier();
|
2018-03-02 23:13:54 +07:00
|
|
|
sample_id = true;
|
2015-04-09 22:53:44 +07:00
|
|
|
} else if (evlist->nr_entries > 1) {
|
2013-08-27 15:23:09 +07:00
|
|
|
struct perf_evsel *first = perf_evlist__first(evlist);
|
|
|
|
|
2016-06-23 21:26:15 +07:00
|
|
|
evlist__for_each_entry(evlist, evsel) {
|
2013-08-27 15:23:09 +07:00
|
|
|
if (evsel->attr.sample_type == first->attr.sample_type)
|
|
|
|
continue;
|
|
|
|
use_sample_identifier = perf_can_sample_identifier();
|
|
|
|
break;
|
|
|
|
}
|
2018-03-02 23:13:54 +07:00
|
|
|
sample_id = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (sample_id) {
|
2016-06-23 21:26:15 +07:00
|
|
|
evlist__for_each_entry(evlist, evsel)
|
2013-08-27 15:23:09 +07:00
|
|
|
perf_evsel__set_sample_id(evsel, use_sample_identifier);
|
2013-08-27 15:23:08 +07:00
|
|
|
}
|
2013-08-27 15:23:09 +07:00
|
|
|
|
|
|
|
perf_evlist__set_id_pos(evlist);
|
2013-08-27 15:23:08 +07:00
|
|
|
}
|
2013-11-05 21:14:47 +07:00
|
|
|
|
|
|
|
static int get_max_rate(unsigned int *rate)
|
|
|
|
{
|
2014-12-11 23:37:59 +07:00
|
|
|
return sysctl__read_int("kernel/perf_event_max_sample_rate", (int *)rate);
|
2013-11-05 21:14:47 +07:00
|
|
|
}
|
|
|
|
|
2013-12-20 00:43:45 +07:00
|
|
|
static int record_opts__config_freq(struct record_opts *opts)
|
2013-11-05 21:14:47 +07:00
|
|
|
{
|
|
|
|
bool user_freq = opts->user_freq != UINT_MAX;
|
|
|
|
unsigned int max_rate;
|
|
|
|
|
|
|
|
if (opts->user_interval != ULLONG_MAX)
|
|
|
|
opts->default_interval = opts->user_interval;
|
|
|
|
if (user_freq)
|
|
|
|
opts->freq = opts->user_freq;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* User specified count overrides default frequency.
|
|
|
|
*/
|
|
|
|
if (opts->default_interval)
|
|
|
|
opts->freq = 0;
|
|
|
|
else if (opts->freq) {
|
|
|
|
opts->default_interval = opts->freq;
|
|
|
|
} else {
|
|
|
|
pr_err("frequency and count are zero, aborting\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (get_max_rate(&max_rate))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* User specified frequency is over current maximum.
|
|
|
|
*/
|
|
|
|
if (user_freq && (max_rate < opts->freq)) {
|
perf record: Throttle user defined frequencies to the maximum allowed
# perf record -F 200000 sleep 1
warning: Maximum frequency rate (15,000 Hz) exceeded, throttling from 200,000 Hz to 15,000 Hz.
The limit can be raised via /proc/sys/kernel/perf_event_max_sample_rate.
The kernel will lower it when perf's interrupts take too long.
Use --strict-freq to disable this throttling, refusing to record.
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.019 MB perf.data (15 samples) ]
# perf evlist -v
cycles:ppp: size: 112, { sample_period, sample_freq }: 15000, sample_type: IP|TID|TIME|PERIOD, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 3, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
For those wanting that it fails if the desired frequency can't be used:
# perf record --strict-freq -F 200000 sleep 1
error: Maximum frequency rate (15,000 Hz) exceeded.
Please use -F freq option with a lower value or consider
tweaking /proc/sys/kernel/perf_event_max_sample_rate.
#
Suggested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-oyebruc44nlja499nqkr1nzn@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2018-03-02 00:52:50 +07:00
|
|
|
if (opts->strict_freq) {
|
|
|
|
pr_err("error: Maximum frequency rate (%'u Hz) exceeded.\n"
|
|
|
|
" Please use -F freq option with a lower value or consider\n"
|
|
|
|
" tweaking /proc/sys/kernel/perf_event_max_sample_rate.\n",
|
|
|
|
max_rate);
|
|
|
|
return -1;
|
|
|
|
} else {
|
|
|
|
pr_warning("warning: Maximum frequency rate (%'u Hz) exceeded, throttling from %'u Hz to %'u Hz.\n"
|
|
|
|
" The limit can be raised via /proc/sys/kernel/perf_event_max_sample_rate.\n"
|
|
|
|
" The kernel will lower it when perf's interrupts take too long.\n"
|
|
|
|
" Use --strict-freq to disable this throttling, refusing to record.\n",
|
|
|
|
max_rate, opts->freq, max_rate);
|
|
|
|
|
|
|
|
opts->freq = max_rate;
|
|
|
|
}
|
2013-11-05 21:14:47 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Default frequency is over current maximum.
|
|
|
|
*/
|
|
|
|
if (max_rate < opts->freq) {
|
|
|
|
pr_warning("Lowering default frequency rate to %u.\n"
|
|
|
|
"Please consider tweaking "
|
|
|
|
"/proc/sys/kernel/perf_event_max_sample_rate.\n",
|
|
|
|
max_rate);
|
|
|
|
opts->freq = max_rate;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-12-20 00:43:45 +07:00
|
|
|
int record_opts__config(struct record_opts *opts)
|
2013-11-05 21:14:47 +07:00
|
|
|
{
|
2013-12-20 00:43:45 +07:00
|
|
|
return record_opts__config_freq(opts);
|
2013-11-05 21:14:47 +07:00
|
|
|
}
|
2013-12-11 19:36:29 +07:00
|
|
|
|
|
|
|
bool perf_evlist__can_select_event(struct perf_evlist *evlist, const char *str)
|
|
|
|
{
|
|
|
|
struct perf_evlist *temp_evlist;
|
|
|
|
struct perf_evsel *evsel;
|
|
|
|
int err, fd, cpu;
|
|
|
|
bool ret = false;
|
2014-08-12 22:04:30 +07:00
|
|
|
pid_t pid = -1;
|
2013-12-11 19:36:29 +07:00
|
|
|
|
|
|
|
temp_evlist = perf_evlist__new();
|
|
|
|
if (!temp_evlist)
|
|
|
|
return false;
|
|
|
|
|
perf tools: Add parse_events_error interface
Adding support to return error information from parse_events function.
Following struct will be populated by parse_events function on return:
struct parse_events_error {
int idx;
char *str;
char *help;
};
where 'idx' is the position in the string where the parsing failed,
'str' contains dynamically allocated error string describing the error
and 'help' is optional help string.
The change contains reporting function, which currently does not display
anything. The code changes to supply error data for specific event types
are coming in next patches. However this is what the expected output is:
$ sudo perf record -e 'sched:krava' ls
event syntax error: 'sched:krava'
\___ unknown tracepoint
...
$ perf record -e 'cpu/even=0x1/' ls
event syntax error: 'cpu/even=0x1/'
\___ unknown term
valid terms: pc,any,inv,edge,cmask,event,in_tx,ldlat,umask,in_tx_cp,offcore_rsp,config,config1,config2,name,period,branch_type
...
$ perf record -e cycles,cache-mises ls
event syntax error: '..es,cache-mises'
\___ parser error
...
The output functions cut the beginning of the event string so the error
starts up to 10th character and cut the end of the string of it crosses
the terminal width.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1429729824-13932-2-git-send-email-jolsa@kernel.org
[ Renamed 'error' variables to 'err', not to clash with util.h error() ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-04-23 02:10:16 +07:00
|
|
|
err = parse_events(temp_evlist, str, NULL);
|
2013-12-11 19:36:29 +07:00
|
|
|
if (err)
|
|
|
|
goto out_delete;
|
|
|
|
|
|
|
|
evsel = perf_evlist__last(temp_evlist);
|
|
|
|
|
|
|
|
if (!evlist || cpu_map__empty(evlist->cpus)) {
|
|
|
|
struct cpu_map *cpus = cpu_map__new(NULL);
|
|
|
|
|
|
|
|
cpu = cpus ? cpus->map[0] : 0;
|
2015-06-23 05:36:04 +07:00
|
|
|
cpu_map__put(cpus);
|
2013-12-11 19:36:29 +07:00
|
|
|
} else {
|
|
|
|
cpu = evlist->cpus->map[0];
|
|
|
|
}
|
|
|
|
|
2014-08-12 22:04:30 +07:00
|
|
|
while (1) {
|
|
|
|
fd = sys_perf_event_open(&evsel->attr, pid, cpu, -1,
|
|
|
|
perf_event_open_cloexec_flag());
|
|
|
|
if (fd < 0) {
|
|
|
|
if (pid == -1 && errno == EACCES) {
|
|
|
|
pid = 0;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
goto out_delete;
|
|
|
|
}
|
|
|
|
break;
|
2013-12-11 19:36:29 +07:00
|
|
|
}
|
2014-08-12 22:04:30 +07:00
|
|
|
close(fd);
|
|
|
|
ret = true;
|
2013-12-11 19:36:29 +07:00
|
|
|
|
|
|
|
out_delete:
|
|
|
|
perf_evlist__delete(temp_evlist);
|
|
|
|
return ret;
|
|
|
|
}
|
perf record: Allow asking for the maximum allowed sample rate
Add the handy '-F max' shortcut to reading and using the
kernel.perf_event_max_sample_rate value as the user supplied
sampling frequency:
# perf record -F max sleep 1
info: Using a maximum frequency rate of 15,000 Hz
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.019 MB perf.data (14 samples) ]
# sysctl kernel.perf_event_max_sample_rate
kernel.perf_event_max_sample_rate = 15000
# perf evlist -v
cycles:ppp: size: 112, { sample_period, sample_freq }: 15000, sample_type: IP|TID|TIME|PERIOD, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 3, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
# perf record -F 10 sleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.019 MB perf.data (4 samples) ]
# perf evlist -v
cycles:ppp: size: 112, { sample_period, sample_freq }: 10, sample_type: IP|TID|TIME|PERIOD, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 3, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
#
Suggested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-4y0tiuws62c64gp4cf0hme0m@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2018-03-01 23:46:23 +07:00
|
|
|
|
|
|
|
int record__parse_freq(const struct option *opt, const char *str, int unset __maybe_unused)
|
|
|
|
{
|
|
|
|
unsigned int freq;
|
|
|
|
struct record_opts *opts = opt->value;
|
|
|
|
|
|
|
|
if (!str)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (strcasecmp(str, "max") == 0) {
|
|
|
|
if (get_max_rate(&freq)) {
|
|
|
|
pr_err("couldn't read /proc/sys/kernel/perf_event_max_sample_rate\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
pr_info("info: Using a maximum frequency rate of %'d Hz\n", freq);
|
|
|
|
} else {
|
|
|
|
freq = atoi(str);
|
|
|
|
}
|
|
|
|
|
|
|
|
opts->user_freq = freq;
|
|
|
|
return 0;
|
|
|
|
}
|