License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 21:07:57 +07:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2005-04-17 05:20:36 +07:00
|
|
|
#ifndef _LINUX_KTHREAD_H
|
|
|
|
#define _LINUX_KTHREAD_H
|
|
|
|
/* Simple interface for creating and stopping kernel threads without mess. */
|
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/sched.h>
|
2017-09-15 04:02:04 +07:00
|
|
|
#include <linux/cgroup.h>
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2011-11-01 07:11:33 +07:00
|
|
|
__printf(4, 5)
|
2011-03-23 06:30:44 +07:00
|
|
|
struct task_struct *kthread_create_on_node(int (*threadfn)(void *data),
|
|
|
|
void *data,
|
|
|
|
int node,
|
2011-11-01 07:11:33 +07:00
|
|
|
const char namefmt[], ...);
|
2011-03-23 06:30:44 +07:00
|
|
|
|
2016-10-12 03:55:53 +07:00
|
|
|
/**
|
|
|
|
* kthread_create - create a kthread on the current node
|
|
|
|
* @threadfn: the function to run in the thread
|
|
|
|
* @data: data pointer for @threadfn()
|
|
|
|
* @namefmt: printf-style format string for the thread name
|
2017-08-03 03:32:01 +07:00
|
|
|
* @arg...: arguments for @namefmt.
|
2016-10-12 03:55:53 +07:00
|
|
|
*
|
|
|
|
* This macro will create a kthread on the current node, leaving it in
|
|
|
|
* the stopped state. This is just a helper for kthread_create_on_node();
|
|
|
|
* see the documentation there for more details.
|
|
|
|
*/
|
2011-03-23 06:30:44 +07:00
|
|
|
#define kthread_create(threadfn, data, namefmt, arg...) \
|
2015-09-05 05:42:42 +07:00
|
|
|
kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg)
|
2011-03-23 06:30:44 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2012-07-16 17:42:36 +07:00
|
|
|
struct task_struct *kthread_create_on_cpu(int (*threadfn)(void *data),
|
|
|
|
void *data,
|
|
|
|
unsigned int cpu,
|
|
|
|
const char *namefmt);
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
/**
|
2006-06-25 19:49:19 +07:00
|
|
|
* kthread_run - create and wake a thread.
|
2005-04-17 05:20:36 +07:00
|
|
|
* @threadfn: the function to run until signal_pending(current).
|
|
|
|
* @data: data ptr for @threadfn.
|
|
|
|
* @namefmt: printf-style name for the thread.
|
|
|
|
*
|
|
|
|
* Description: Convenient wrapper for kthread_create() followed by
|
2006-06-25 19:49:19 +07:00
|
|
|
* wake_up_process(). Returns the kthread or ERR_PTR(-ENOMEM).
|
|
|
|
*/
|
2005-04-17 05:20:36 +07:00
|
|
|
#define kthread_run(threadfn, data, namefmt, ...) \
|
|
|
|
({ \
|
|
|
|
struct task_struct *__k \
|
|
|
|
= kthread_create(threadfn, data, namefmt, ## __VA_ARGS__); \
|
|
|
|
if (!IS_ERR(__k)) \
|
|
|
|
wake_up_process(__k); \
|
|
|
|
__k; \
|
|
|
|
})
|
|
|
|
|
2016-11-30 00:50:57 +07:00
|
|
|
void free_kthread_struct(struct task_struct *k);
|
2005-04-17 05:20:36 +07:00
|
|
|
void kthread_bind(struct task_struct *k, unsigned int cpu);
|
2015-05-15 22:43:34 +07:00
|
|
|
void kthread_bind_mask(struct task_struct *k, const struct cpumask *mask);
|
2005-04-17 05:20:36 +07:00
|
|
|
int kthread_stop(struct task_struct *k);
|
2012-07-16 17:42:36 +07:00
|
|
|
bool kthread_should_stop(void);
|
|
|
|
bool kthread_should_park(void);
|
2011-11-22 03:32:23 +07:00
|
|
|
bool kthread_freezable_should_stop(bool *was_frozen);
|
2010-06-29 15:07:09 +07:00
|
|
|
void *kthread_data(struct task_struct *k);
|
2016-10-12 03:55:17 +07:00
|
|
|
void *kthread_probe_data(struct task_struct *k);
|
2012-07-16 17:42:36 +07:00
|
|
|
int kthread_park(struct task_struct *k);
|
|
|
|
void kthread_unpark(struct task_struct *k);
|
|
|
|
void kthread_parkme(void);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-05-09 16:34:32 +07:00
|
|
|
int kthreadd(void *unused);
|
|
|
|
extern struct task_struct *kthreadd_task;
|
2011-03-23 06:30:44 +07:00
|
|
|
extern int tsk_fork_get_node(struct task_struct *tsk);
|
2007-05-09 16:34:32 +07:00
|
|
|
|
2010-06-29 15:07:09 +07:00
|
|
|
/*
|
|
|
|
* Simple work processor based on kthread.
|
|
|
|
*
|
|
|
|
* This provides easier way to make use of kthreads. A kthread_work
|
2016-10-12 03:55:20 +07:00
|
|
|
* can be queued and flushed using queue/kthread_flush_work()
|
2010-06-29 15:07:09 +07:00
|
|
|
* respectively. Queued kthread_works are processed by a kthread
|
|
|
|
* running kthread_worker_fn().
|
|
|
|
*/
|
|
|
|
struct kthread_work;
|
|
|
|
typedef void (*kthread_work_func_t)(struct kthread_work *work);
|
2017-10-05 06:27:06 +07:00
|
|
|
void kthread_delayed_work_timer_fn(struct timer_list *t);
|
2010-06-29 15:07:09 +07:00
|
|
|
|
2016-10-12 03:55:50 +07:00
|
|
|
enum {
|
|
|
|
KTW_FREEZABLE = 1 << 0, /* freeze during suspend */
|
|
|
|
};
|
|
|
|
|
2010-06-29 15:07:09 +07:00
|
|
|
struct kthread_worker {
|
2016-10-12 03:55:50 +07:00
|
|
|
unsigned int flags;
|
2010-06-29 15:07:09 +07:00
|
|
|
spinlock_t lock;
|
|
|
|
struct list_head work_list;
|
2016-10-12 03:55:40 +07:00
|
|
|
struct list_head delayed_work_list;
|
2010-06-29 15:07:09 +07:00
|
|
|
struct task_struct *task;
|
2012-07-20 03:52:53 +07:00
|
|
|
struct kthread_work *current_work;
|
2010-06-29 15:07:09 +07:00
|
|
|
};
|
|
|
|
|
|
|
|
struct kthread_work {
|
|
|
|
struct list_head node;
|
|
|
|
kthread_work_func_t func;
|
2012-07-20 03:52:53 +07:00
|
|
|
struct kthread_worker *worker;
|
kthread: allow to cancel kthread work
We are going to use kthread workers more widely and sometimes we will need
to make sure that the work is neither pending nor running.
This patch implements cancel_*_sync() operations as inspired by
workqueues. Well, we are synchronized against the other operations via
the worker lock, we use del_timer_sync() and a counter to count parallel
cancel operations. Therefore the implementation might be easier.
First, we check if a worker is assigned. If not, the work has newer been
queued after it was initialized.
Second, we take the worker lock. It must be the right one. The work must
not be assigned to another worker unless it is initialized in between.
Third, we try to cancel the timer when it exists. The timer is deleted
synchronously to make sure that the timer call back is not running. We
need to temporary release the worker->lock to avoid a possible deadlock
with the callback. In the meantime, we set work->canceling counter to
avoid any queuing.
Fourth, we try to remove the work from a worker list. It might be
the list of either normal or delayed works.
Fifth, if the work is running, we call kthread_flush_work(). It might
take an arbitrary time. We need to release the worker-lock again. In the
meantime, we again block any queuing by the canceling counter.
As already mentioned, the check for a pending kthread work is done under a
lock. In compare with workqueues, we do not need to fight for a single
PENDING bit to block other operations. Therefore we do not suffer from
the thundering storm problem and all parallel canceling jobs might use
kthread_flush_work(). Any queuing is blocked until the counter gets zero.
Link: http://lkml.kernel.org/r/1470754545-17632-10-git-send-email-pmladek@suse.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Borislav Petkov <bp@suse.de>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-10-12 03:55:43 +07:00
|
|
|
/* Number of canceling calls that are running at the moment. */
|
|
|
|
int canceling;
|
2010-06-29 15:07:09 +07:00
|
|
|
};
|
|
|
|
|
2016-10-12 03:55:40 +07:00
|
|
|
struct kthread_delayed_work {
|
|
|
|
struct kthread_work work;
|
|
|
|
struct timer_list timer;
|
|
|
|
};
|
|
|
|
|
2010-06-29 15:07:09 +07:00
|
|
|
#define KTHREAD_WORKER_INIT(worker) { \
|
2011-01-23 21:24:55 +07:00
|
|
|
.lock = __SPIN_LOCK_UNLOCKED((worker).lock), \
|
2010-06-29 15:07:09 +07:00
|
|
|
.work_list = LIST_HEAD_INIT((worker).work_list), \
|
2016-10-12 03:55:40 +07:00
|
|
|
.delayed_work_list = LIST_HEAD_INIT((worker).delayed_work_list),\
|
2010-06-29 15:07:09 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
#define KTHREAD_WORK_INIT(work, fn) { \
|
|
|
|
.node = LIST_HEAD_INIT((work).node), \
|
|
|
|
.func = (fn), \
|
|
|
|
}
|
|
|
|
|
2016-10-12 03:55:40 +07:00
|
|
|
#define KTHREAD_DELAYED_WORK_INIT(dwork, fn) { \
|
|
|
|
.work = KTHREAD_WORK_INIT((dwork).work, (fn)), \
|
2017-10-23 14:40:42 +07:00
|
|
|
.timer = __TIMER_INITIALIZER(kthread_delayed_work_timer_fn,\
|
2016-10-12 03:55:40 +07:00
|
|
|
TIMER_IRQSAFE), \
|
|
|
|
}
|
|
|
|
|
2010-06-29 15:07:09 +07:00
|
|
|
#define DEFINE_KTHREAD_WORKER(worker) \
|
|
|
|
struct kthread_worker worker = KTHREAD_WORKER_INIT(worker)
|
|
|
|
|
|
|
|
#define DEFINE_KTHREAD_WORK(work, fn) \
|
|
|
|
struct kthread_work work = KTHREAD_WORK_INIT(work, fn)
|
|
|
|
|
2016-10-12 03:55:40 +07:00
|
|
|
#define DEFINE_KTHREAD_DELAYED_WORK(dwork, fn) \
|
|
|
|
struct kthread_delayed_work dwork = \
|
|
|
|
KTHREAD_DELAYED_WORK_INIT(dwork, fn)
|
|
|
|
|
2010-12-22 16:27:53 +07:00
|
|
|
/*
|
2014-07-26 11:04:00 +07:00
|
|
|
* kthread_worker.lock needs its own lockdep class key when defined on
|
|
|
|
* stack with lockdep enabled. Use the following macros in such cases.
|
2010-12-22 16:27:53 +07:00
|
|
|
*/
|
|
|
|
#ifdef CONFIG_LOCKDEP
|
|
|
|
# define KTHREAD_WORKER_INIT_ONSTACK(worker) \
|
2016-10-12 03:55:20 +07:00
|
|
|
({ kthread_init_worker(&worker); worker; })
|
2010-12-22 16:27:53 +07:00
|
|
|
# define DEFINE_KTHREAD_WORKER_ONSTACK(worker) \
|
|
|
|
struct kthread_worker worker = KTHREAD_WORKER_INIT_ONSTACK(worker)
|
|
|
|
#else
|
|
|
|
# define DEFINE_KTHREAD_WORKER_ONSTACK(worker) DEFINE_KTHREAD_WORKER(worker)
|
|
|
|
#endif
|
|
|
|
|
2016-10-12 03:55:20 +07:00
|
|
|
extern void __kthread_init_worker(struct kthread_worker *worker,
|
2010-12-22 16:27:53 +07:00
|
|
|
const char *name, struct lock_class_key *key);
|
|
|
|
|
2016-10-12 03:55:20 +07:00
|
|
|
#define kthread_init_worker(worker) \
|
2010-12-22 16:27:53 +07:00
|
|
|
do { \
|
|
|
|
static struct lock_class_key __key; \
|
2016-10-12 03:55:20 +07:00
|
|
|
__kthread_init_worker((worker), "("#worker")->lock", &__key); \
|
2010-12-22 16:27:53 +07:00
|
|
|
} while (0)
|
|
|
|
|
2016-10-12 03:55:20 +07:00
|
|
|
#define kthread_init_work(work, fn) \
|
2010-12-22 16:27:53 +07:00
|
|
|
do { \
|
|
|
|
memset((work), 0, sizeof(struct kthread_work)); \
|
|
|
|
INIT_LIST_HEAD(&(work)->node); \
|
|
|
|
(work)->func = (fn); \
|
|
|
|
} while (0)
|
2010-06-29 15:07:09 +07:00
|
|
|
|
2016-10-12 03:55:40 +07:00
|
|
|
#define kthread_init_delayed_work(dwork, fn) \
|
|
|
|
do { \
|
|
|
|
kthread_init_work(&(dwork)->work, (fn)); \
|
2017-10-23 08:48:43 +07:00
|
|
|
__init_timer(&(dwork)->timer, \
|
|
|
|
kthread_delayed_work_timer_fn, \
|
|
|
|
TIMER_IRQSAFE); \
|
2016-10-12 03:55:40 +07:00
|
|
|
} while (0)
|
|
|
|
|
2010-06-29 15:07:09 +07:00
|
|
|
int kthread_worker_fn(void *worker_ptr);
|
|
|
|
|
2016-10-12 03:55:50 +07:00
|
|
|
__printf(2, 3)
|
kthread: add kthread_create_worker*()
Kthread workers are currently created using the classic kthread API,
namely kthread_run(). kthread_worker_fn() is passed as the @threadfn
parameter.
This patch defines kthread_create_worker() and
kthread_create_worker_on_cpu() functions that hide implementation details.
They enforce using kthread_worker_fn() for the main thread. But I doubt
that there are any plans to create any alternative. In fact, I think that
we do not want any alternative main thread because it would be hard to
support consistency with the rest of the kthread worker API.
The naming and function of kthread_create_worker() is inspired by the
workqueues API like the rest of the kthread worker API.
The kthread_create_worker_on_cpu() variant is motivated by the original
kthread_create_on_cpu(). Note that we need to bind per-CPU kthread
workers already when they are created. It makes the life easier.
kthread_bind() could not be used later for an already running worker.
This patch does _not_ convert existing kthread workers. The kthread
worker API need more improvements first, e.g. a function to destroy the
worker.
IMPORTANT:
kthread_create_worker_on_cpu() allows to use any format of the worker
name, in compare with kthread_create_on_cpu(). The good thing is that it
is more generic. The bad thing is that most users will need to pass the
cpu number in two parameters, e.g. kthread_create_worker_on_cpu(cpu,
"helper/%d", cpu).
To be honest, the main motivation was to avoid the need for an empty
va_list. The only legal way was to create a helper function that would be
called with an empty list. Other attempts caused compilation warnings or
even errors on different architectures.
There were also other alternatives, for example, using #define or
splitting __kthread_create_worker(). The used solution looked like the
least ugly.
Link: http://lkml.kernel.org/r/1470754545-17632-6-git-send-email-pmladek@suse.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Borislav Petkov <bp@suse.de>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-10-12 03:55:30 +07:00
|
|
|
struct kthread_worker *
|
2016-10-12 03:55:50 +07:00
|
|
|
kthread_create_worker(unsigned int flags, const char namefmt[], ...);
|
kthread: add kthread_create_worker*()
Kthread workers are currently created using the classic kthread API,
namely kthread_run(). kthread_worker_fn() is passed as the @threadfn
parameter.
This patch defines kthread_create_worker() and
kthread_create_worker_on_cpu() functions that hide implementation details.
They enforce using kthread_worker_fn() for the main thread. But I doubt
that there are any plans to create any alternative. In fact, I think that
we do not want any alternative main thread because it would be hard to
support consistency with the rest of the kthread worker API.
The naming and function of kthread_create_worker() is inspired by the
workqueues API like the rest of the kthread worker API.
The kthread_create_worker_on_cpu() variant is motivated by the original
kthread_create_on_cpu(). Note that we need to bind per-CPU kthread
workers already when they are created. It makes the life easier.
kthread_bind() could not be used later for an already running worker.
This patch does _not_ convert existing kthread workers. The kthread
worker API need more improvements first, e.g. a function to destroy the
worker.
IMPORTANT:
kthread_create_worker_on_cpu() allows to use any format of the worker
name, in compare with kthread_create_on_cpu(). The good thing is that it
is more generic. The bad thing is that most users will need to pass the
cpu number in two parameters, e.g. kthread_create_worker_on_cpu(cpu,
"helper/%d", cpu).
To be honest, the main motivation was to avoid the need for an empty
va_list. The only legal way was to create a helper function that would be
called with an empty list. Other attempts caused compilation warnings or
even errors on different architectures.
There were also other alternatives, for example, using #define or
splitting __kthread_create_worker(). The used solution looked like the
least ugly.
Link: http://lkml.kernel.org/r/1470754545-17632-6-git-send-email-pmladek@suse.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Borislav Petkov <bp@suse.de>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-10-12 03:55:30 +07:00
|
|
|
|
2016-12-13 07:40:39 +07:00
|
|
|
__printf(3, 4) struct kthread_worker *
|
2016-10-12 03:55:50 +07:00
|
|
|
kthread_create_worker_on_cpu(int cpu, unsigned int flags,
|
|
|
|
const char namefmt[], ...);
|
kthread: add kthread_create_worker*()
Kthread workers are currently created using the classic kthread API,
namely kthread_run(). kthread_worker_fn() is passed as the @threadfn
parameter.
This patch defines kthread_create_worker() and
kthread_create_worker_on_cpu() functions that hide implementation details.
They enforce using kthread_worker_fn() for the main thread. But I doubt
that there are any plans to create any alternative. In fact, I think that
we do not want any alternative main thread because it would be hard to
support consistency with the rest of the kthread worker API.
The naming and function of kthread_create_worker() is inspired by the
workqueues API like the rest of the kthread worker API.
The kthread_create_worker_on_cpu() variant is motivated by the original
kthread_create_on_cpu(). Note that we need to bind per-CPU kthread
workers already when they are created. It makes the life easier.
kthread_bind() could not be used later for an already running worker.
This patch does _not_ convert existing kthread workers. The kthread
worker API need more improvements first, e.g. a function to destroy the
worker.
IMPORTANT:
kthread_create_worker_on_cpu() allows to use any format of the worker
name, in compare with kthread_create_on_cpu(). The good thing is that it
is more generic. The bad thing is that most users will need to pass the
cpu number in two parameters, e.g. kthread_create_worker_on_cpu(cpu,
"helper/%d", cpu).
To be honest, the main motivation was to avoid the need for an empty
va_list. The only legal way was to create a helper function that would be
called with an empty list. Other attempts caused compilation warnings or
even errors on different architectures.
There were also other alternatives, for example, using #define or
splitting __kthread_create_worker(). The used solution looked like the
least ugly.
Link: http://lkml.kernel.org/r/1470754545-17632-6-git-send-email-pmladek@suse.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Borislav Petkov <bp@suse.de>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-10-12 03:55:30 +07:00
|
|
|
|
2016-10-12 03:55:20 +07:00
|
|
|
bool kthread_queue_work(struct kthread_worker *worker,
|
2010-06-29 15:07:09 +07:00
|
|
|
struct kthread_work *work);
|
2016-10-12 03:55:40 +07:00
|
|
|
|
|
|
|
bool kthread_queue_delayed_work(struct kthread_worker *worker,
|
|
|
|
struct kthread_delayed_work *dwork,
|
|
|
|
unsigned long delay);
|
|
|
|
|
2016-10-12 03:55:46 +07:00
|
|
|
bool kthread_mod_delayed_work(struct kthread_worker *worker,
|
|
|
|
struct kthread_delayed_work *dwork,
|
|
|
|
unsigned long delay);
|
|
|
|
|
2016-10-12 03:55:20 +07:00
|
|
|
void kthread_flush_work(struct kthread_work *work);
|
|
|
|
void kthread_flush_worker(struct kthread_worker *worker);
|
2010-06-29 15:07:09 +07:00
|
|
|
|
kthread: allow to cancel kthread work
We are going to use kthread workers more widely and sometimes we will need
to make sure that the work is neither pending nor running.
This patch implements cancel_*_sync() operations as inspired by
workqueues. Well, we are synchronized against the other operations via
the worker lock, we use del_timer_sync() and a counter to count parallel
cancel operations. Therefore the implementation might be easier.
First, we check if a worker is assigned. If not, the work has newer been
queued after it was initialized.
Second, we take the worker lock. It must be the right one. The work must
not be assigned to another worker unless it is initialized in between.
Third, we try to cancel the timer when it exists. The timer is deleted
synchronously to make sure that the timer call back is not running. We
need to temporary release the worker->lock to avoid a possible deadlock
with the callback. In the meantime, we set work->canceling counter to
avoid any queuing.
Fourth, we try to remove the work from a worker list. It might be
the list of either normal or delayed works.
Fifth, if the work is running, we call kthread_flush_work(). It might
take an arbitrary time. We need to release the worker-lock again. In the
meantime, we again block any queuing by the canceling counter.
As already mentioned, the check for a pending kthread work is done under a
lock. In compare with workqueues, we do not need to fight for a single
PENDING bit to block other operations. Therefore we do not suffer from
the thundering storm problem and all parallel canceling jobs might use
kthread_flush_work(). Any queuing is blocked until the counter gets zero.
Link: http://lkml.kernel.org/r/1470754545-17632-10-git-send-email-pmladek@suse.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Borislav Petkov <bp@suse.de>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-10-12 03:55:43 +07:00
|
|
|
bool kthread_cancel_work_sync(struct kthread_work *work);
|
|
|
|
bool kthread_cancel_delayed_work_sync(struct kthread_delayed_work *work);
|
|
|
|
|
2016-10-12 03:55:33 +07:00
|
|
|
void kthread_destroy_worker(struct kthread_worker *worker);
|
|
|
|
|
2017-09-27 01:02:12 +07:00
|
|
|
#ifdef CONFIG_BLK_CGROUP
|
2017-09-15 04:02:04 +07:00
|
|
|
void kthread_associate_blkcg(struct cgroup_subsys_state *css);
|
|
|
|
struct cgroup_subsys_state *kthread_blkcg(void);
|
|
|
|
#else
|
|
|
|
static inline void kthread_associate_blkcg(struct cgroup_subsys_state *css) { }
|
|
|
|
static inline struct cgroup_subsys_state *kthread_blkcg(void)
|
|
|
|
{
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
#endif
|
2005-04-17 05:20:36 +07:00
|
|
|
#endif /* _LINUX_KTHREAD_H */
|