2005-04-17 05:20:36 +07:00
|
|
|
/*
|
2007-09-26 22:42:58 +07:00
|
|
|
* battery.c - ACPI Battery Driver (Revision: 2.0)
|
2005-04-17 05:20:36 +07:00
|
|
|
*
|
2007-09-26 22:42:58 +07:00
|
|
|
* Copyright (C) 2007 Alexey Starikovskiy <astarikovskiy@suse.de>
|
|
|
|
|
* Copyright (C) 2004-2007 Vladimir Lebedev <vladimir.p.lebedev@intel.com>
|
2005-04-17 05:20:36 +07:00
|
|
|
* Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
|
|
|
|
|
* Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
|
|
|
|
|
*
|
|
|
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
|
*
|
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or (at
|
|
|
|
|
* your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* This program is distributed in the hope that it will be useful, but
|
|
|
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
|
* General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
|
* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
|
|
|
|
|
*
|
|
|
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
|
#include <linux/module.h>
|
|
|
|
|
#include <linux/init.h>
|
|
|
|
|
#include <linux/types.h>
|
2007-09-26 22:42:52 +07:00
|
|
|
#include <linux/jiffies.h>
|
2009-01-11 02:19:05 +07:00
|
|
|
#include <linux/async.h>
|
2009-08-07 05:57:48 +07:00
|
|
|
#include <linux/dmi.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 15:04:11 +07:00
|
|
|
#include <linux/slab.h>
|
2011-03-23 03:19:50 +07:00
|
|
|
#include <linux/suspend.h>
|
ACPI / battery: Correct battery capacity values on Thinkpads
Add a quirk to correctly report battery capacity on 2010 and 2011
Lenovo Thinkpad models.
The affected models that I tested (x201, t410, t410s, and x220)
exhibit a problem where, when battery capacity reporting unit is mAh,
the values being reported are wrong. Pre-2010 and 2012 models appear
to always report in mWh and are thus unaffected. Also, in mid-2012
Lenovo issued a BIOS update for the 2011 models that fixes the issue
(tested on x220 with a post-1.29 BIOS). No such update is available
for the 2010 models, so those still need this patch.
Problem description: for some reason, the affected Thinkpads switch
the reporting unit between mAh and mWh; generally, mAh is used when a
laptop is plugged in and mWh when it's unplugged, although a
suspend/resume or rmmod/modprobe is needed for the switch to take
effect. The values reported in mAh are *always* wrong. This does
not appear to be a kernel regression; I believe that the values were
never reported correctly. I tested back to kernel 2.6.34, with
multiple machines and BIOS versions.
Simply plugging a laptop into mains before turning it on is enough to
reproduce the problem. Here's a sample /proc/acpi/battery/BAT0/info
from Thinkpad x220 (before a BIOS update) with a 4-cell battery:
present: yes
design capacity: 2886 mAh
last full capacity: 2909 mAh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 145 mAh
design capacity low: 13 mAh
cycle count: 0
capacity granularity 1: 1 mAh
capacity granularity 2: 1 mAh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Once the laptop switches the unit to mWh (unplug from mains, suspend,
resume), the output changes to:
present: yes
design capacity: 28860 mWh
last full capacity: 29090 mWh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 1454 mWh
design capacity low: 200 mWh
cycle count: 0
capacity granularity 1: 1 mWh
capacity granularity 2: 1 mWh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Can you see how the values for "design capacity", etc., differ by a
factor of 10 instead of 14.8 (the design voltage of this battery)?
On the battery itself it says: 14.8V, 1.95Ah, 29Wh, so clearly the
values reported in mWh are correct and the ones in mAh are not.
My guess is that this problem has been around ever since those
machines were released, but because the most common Thinkpad
batteries are rated at 10.8V, the error (8%) is small enough that it
simply hasn't been noticed or at least nobody could be bothered to
look into it.
My patch works around the problem by adjusting the incorrectly
reported mAh values by "10000 / design_voltage". The patch also has
code to figure out if it should be activated or not. It only
activates on Lenovo Thinkpads, only when the unit is mAh, and, as an
extra precaution, only when the battery capacity reported through
ACPI does not match what is reported through DMI (I've never
encountered a machine where the first two conditions would be true
but the last would not, but better safe than sorry).
I've been using this patch for close to a year on several systems
without any problems.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41062
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2012-11-17 04:28:58 +07:00
|
|
|
#include <asm/unaligned.h>
|
2007-09-26 22:43:04 +07:00
|
|
|
|
2013-12-03 07:49:16 +07:00
|
|
|
#include <linux/acpi.h>
|
2007-09-26 22:43:04 +07:00
|
|
|
#include <linux/power_supply.h>
|
|
|
|
|
|
2014-03-12 00:58:46 +07:00
|
|
|
#include "battery.h"
|
|
|
|
|
|
2009-07-29 03:45:54 +07:00
|
|
|
#define PREFIX "ACPI: "
|
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
#define ACPI_BATTERY_VALUE_UNKNOWN 0xFFFFFFFF
|
|
|
|
|
|
|
|
|
|
#define ACPI_BATTERY_DEVICE_NAME "Battery"
|
|
|
|
|
|
2011-06-30 10:32:40 +07:00
|
|
|
/* Battery power unit: 0 means mW, 1 means mA */
|
|
|
|
|
#define ACPI_BATTERY_POWER_UNIT_MA 1
|
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
#define _COMPONENT ACPI_BATTERY_COMPONENT
|
2007-02-20 19:48:06 +07:00
|
|
|
|
2007-02-13 10:42:12 +07:00
|
|
|
ACPI_MODULE_NAME("battery");
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-02-13 10:42:12 +07:00
|
|
|
MODULE_AUTHOR("Paul Diefenbaugh");
|
2007-09-26 22:42:58 +07:00
|
|
|
MODULE_AUTHOR("Alexey Starikovskiy <astarikovskiy@suse.de>");
|
2007-02-13 11:50:02 +07:00
|
|
|
MODULE_DESCRIPTION("ACPI Battery Driver");
|
2005-04-17 05:20:36 +07:00
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
|
|
2014-01-06 21:50:37 +07:00
|
|
|
static int battery_bix_broken_package;
|
2007-09-26 22:42:52 +07:00
|
|
|
static unsigned int cache_time = 1000;
|
|
|
|
|
module_param(cache_time, uint, 0644);
|
|
|
|
|
MODULE_PARM_DESC(cache_time, "cache time in milliseconds");
|
2007-02-20 19:48:06 +07:00
|
|
|
|
2007-07-23 19:44:41 +07:00
|
|
|
static const struct acpi_device_id battery_device_ids[] = {
|
|
|
|
|
{"PNP0C0A", 0},
|
|
|
|
|
{"", 0},
|
|
|
|
|
};
|
|
|
|
|
|
2007-09-26 22:42:58 +07:00
|
|
|
MODULE_DEVICE_TABLE(acpi, battery_device_ids);
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2009-10-15 17:31:24 +07:00
|
|
|
enum {
|
|
|
|
|
ACPI_BATTERY_ALARM_PRESENT,
|
2009-10-15 17:31:44 +07:00
|
|
|
ACPI_BATTERY_XINFO_PRESENT,
|
2010-10-22 09:02:06 +07:00
|
|
|
ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY,
|
ACPI / battery: Correct battery capacity values on Thinkpads
Add a quirk to correctly report battery capacity on 2010 and 2011
Lenovo Thinkpad models.
The affected models that I tested (x201, t410, t410s, and x220)
exhibit a problem where, when battery capacity reporting unit is mAh,
the values being reported are wrong. Pre-2010 and 2012 models appear
to always report in mWh and are thus unaffected. Also, in mid-2012
Lenovo issued a BIOS update for the 2011 models that fixes the issue
(tested on x220 with a post-1.29 BIOS). No such update is available
for the 2010 models, so those still need this patch.
Problem description: for some reason, the affected Thinkpads switch
the reporting unit between mAh and mWh; generally, mAh is used when a
laptop is plugged in and mWh when it's unplugged, although a
suspend/resume or rmmod/modprobe is needed for the switch to take
effect. The values reported in mAh are *always* wrong. This does
not appear to be a kernel regression; I believe that the values were
never reported correctly. I tested back to kernel 2.6.34, with
multiple machines and BIOS versions.
Simply plugging a laptop into mains before turning it on is enough to
reproduce the problem. Here's a sample /proc/acpi/battery/BAT0/info
from Thinkpad x220 (before a BIOS update) with a 4-cell battery:
present: yes
design capacity: 2886 mAh
last full capacity: 2909 mAh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 145 mAh
design capacity low: 13 mAh
cycle count: 0
capacity granularity 1: 1 mAh
capacity granularity 2: 1 mAh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Once the laptop switches the unit to mWh (unplug from mains, suspend,
resume), the output changes to:
present: yes
design capacity: 28860 mWh
last full capacity: 29090 mWh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 1454 mWh
design capacity low: 200 mWh
cycle count: 0
capacity granularity 1: 1 mWh
capacity granularity 2: 1 mWh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Can you see how the values for "design capacity", etc., differ by a
factor of 10 instead of 14.8 (the design voltage of this battery)?
On the battery itself it says: 14.8V, 1.95Ah, 29Wh, so clearly the
values reported in mWh are correct and the ones in mAh are not.
My guess is that this problem has been around ever since those
machines were released, but because the most common Thinkpad
batteries are rated at 10.8V, the error (8%) is small enough that it
simply hasn't been noticed or at least nobody could be bothered to
look into it.
My patch works around the problem by adjusting the incorrectly
reported mAh values by "10000 / design_voltage". The patch also has
code to figure out if it should be activated or not. It only
activates on Lenovo Thinkpads, only when the unit is mAh, and, as an
extra precaution, only when the battery capacity reported through
ACPI does not match what is reported through DMI (I've never
encountered a machine where the first two conditions would be true
but the last would not, but better safe than sorry).
I've been using this patch for close to a year on several systems
without any problems.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41062
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2012-11-17 04:28:58 +07:00
|
|
|
/* On Lenovo Thinkpad models from 2010 and 2011, the power unit
|
|
|
|
|
switches between mWh and mAh depending on whether the system
|
|
|
|
|
is running on battery or not. When mAh is the unit, most
|
|
|
|
|
reported values are incorrect and need to be adjusted by
|
|
|
|
|
10000/design_voltage. Verified on x201, t410, t410s, and x220.
|
|
|
|
|
Pre-2010 and 2012 models appear to always report in mWh and
|
|
|
|
|
are thus unaffected (tested with t42, t61, t500, x200, x300,
|
|
|
|
|
and x230). Also, in mid-2012 Lenovo issued a BIOS update for
|
|
|
|
|
the 2011 models that fixes the issue (tested on x220 with a
|
|
|
|
|
post-1.29 BIOS), but as of Nov. 2012, no such update is
|
|
|
|
|
available for the 2010 models. */
|
|
|
|
|
ACPI_BATTERY_QUIRK_THINKPAD_MAH,
|
2009-10-15 17:31:24 +07:00
|
|
|
};
|
2007-05-12 00:18:55 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
struct acpi_battery {
|
2007-09-26 22:42:46 +07:00
|
|
|
struct mutex lock;
|
2011-08-06 05:34:08 +07:00
|
|
|
struct mutex sysfs_lock;
|
2007-09-26 22:43:04 +07:00
|
|
|
struct power_supply bat;
|
2007-09-26 22:42:52 +07:00
|
|
|
struct acpi_device *device;
|
2011-03-23 03:19:50 +07:00
|
|
|
struct notifier_block pm_nb;
|
2007-09-26 22:42:52 +07:00
|
|
|
unsigned long update_time;
|
2013-07-30 19:00:42 +07:00
|
|
|
int revision;
|
2009-03-28 09:23:52 +07:00
|
|
|
int rate_now;
|
2007-09-26 22:43:04 +07:00
|
|
|
int capacity_now;
|
|
|
|
|
int voltage_now;
|
2007-09-26 22:42:46 +07:00
|
|
|
int design_capacity;
|
2007-09-26 22:43:04 +07:00
|
|
|
int full_charge_capacity;
|
2007-09-26 22:42:46 +07:00
|
|
|
int technology;
|
|
|
|
|
int design_voltage;
|
|
|
|
|
int design_capacity_warning;
|
|
|
|
|
int design_capacity_low;
|
2009-10-15 17:31:44 +07:00
|
|
|
int cycle_count;
|
|
|
|
|
int measurement_accuracy;
|
|
|
|
|
int max_sampling_time;
|
|
|
|
|
int min_sampling_time;
|
|
|
|
|
int max_averaging_interval;
|
|
|
|
|
int min_averaging_interval;
|
2007-09-26 22:42:46 +07:00
|
|
|
int capacity_granularity_1;
|
|
|
|
|
int capacity_granularity_2;
|
2007-09-26 22:42:52 +07:00
|
|
|
int alarm;
|
2007-09-26 22:42:46 +07:00
|
|
|
char model_number[32];
|
|
|
|
|
char serial_number[32];
|
|
|
|
|
char type[32];
|
|
|
|
|
char oem_info[32];
|
2007-09-26 22:42:52 +07:00
|
|
|
int state;
|
|
|
|
|
int power_unit;
|
2009-10-15 17:31:24 +07:00
|
|
|
unsigned long flags;
|
2005-04-17 05:20:36 +07:00
|
|
|
};
|
|
|
|
|
|
2011-07-14 19:07:13 +07:00
|
|
|
#define to_acpi_battery(x) container_of(x, struct acpi_battery, bat)
|
2007-09-26 22:43:04 +07:00
|
|
|
|
2013-03-11 16:17:06 +07:00
|
|
|
static inline int acpi_battery_present(struct acpi_battery *battery)
|
2007-02-20 19:48:06 +07:00
|
|
|
{
|
2007-05-12 00:18:55 +07:00
|
|
|
return battery->device->status.battery_present;
|
|
|
|
|
}
|
2007-09-26 22:42:46 +07:00
|
|
|
|
2007-09-26 22:43:04 +07:00
|
|
|
static int acpi_battery_technology(struct acpi_battery *battery)
|
|
|
|
|
{
|
|
|
|
|
if (!strcasecmp("NiCd", battery->type))
|
|
|
|
|
return POWER_SUPPLY_TECHNOLOGY_NiCd;
|
|
|
|
|
if (!strcasecmp("NiMH", battery->type))
|
|
|
|
|
return POWER_SUPPLY_TECHNOLOGY_NiMH;
|
|
|
|
|
if (!strcasecmp("LION", battery->type))
|
|
|
|
|
return POWER_SUPPLY_TECHNOLOGY_LION;
|
2007-11-11 00:02:49 +07:00
|
|
|
if (!strncasecmp("LI-ION", battery->type, 6))
|
2007-10-28 19:33:10 +07:00
|
|
|
return POWER_SUPPLY_TECHNOLOGY_LION;
|
2007-09-26 22:43:04 +07:00
|
|
|
if (!strcasecmp("LiP", battery->type))
|
|
|
|
|
return POWER_SUPPLY_TECHNOLOGY_LIPO;
|
|
|
|
|
return POWER_SUPPLY_TECHNOLOGY_UNKNOWN;
|
|
|
|
|
}
|
|
|
|
|
|
2007-11-13 16:23:06 +07:00
|
|
|
static int acpi_battery_get_state(struct acpi_battery *battery);
|
2007-10-26 04:10:47 +07:00
|
|
|
|
2009-01-25 22:05:50 +07:00
|
|
|
static int acpi_battery_is_charged(struct acpi_battery *battery)
|
|
|
|
|
{
|
|
|
|
|
/* either charging or discharging */
|
|
|
|
|
if (battery->state != 0)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
/* battery not reporting charge */
|
|
|
|
|
if (battery->capacity_now == ACPI_BATTERY_VALUE_UNKNOWN ||
|
|
|
|
|
battery->capacity_now == 0)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
/* good batteries update full_charge as the batteries degrade */
|
|
|
|
|
if (battery->full_charge_capacity == battery->capacity_now)
|
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
|
|
/* fallback to using design values for broken batteries */
|
|
|
|
|
if (battery->design_capacity == battery->capacity_now)
|
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
|
|
/* we don't do any sort of metric based on percentages */
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2007-09-26 22:43:04 +07:00
|
|
|
static int acpi_battery_get_property(struct power_supply *psy,
|
|
|
|
|
enum power_supply_property psp,
|
|
|
|
|
union power_supply_propval *val)
|
|
|
|
|
{
|
2010-10-24 00:35:15 +07:00
|
|
|
int ret = 0;
|
2007-09-26 22:43:04 +07:00
|
|
|
struct acpi_battery *battery = to_acpi_battery(psy);
|
|
|
|
|
|
2007-11-13 16:23:06 +07:00
|
|
|
if (acpi_battery_present(battery)) {
|
|
|
|
|
/* run battery update only if it is present */
|
|
|
|
|
acpi_battery_get_state(battery);
|
|
|
|
|
} else if (psp != POWER_SUPPLY_PROP_PRESENT)
|
2007-09-26 22:43:04 +07:00
|
|
|
return -ENODEV;
|
|
|
|
|
switch (psp) {
|
|
|
|
|
case POWER_SUPPLY_PROP_STATUS:
|
|
|
|
|
if (battery->state & 0x01)
|
|
|
|
|
val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
|
|
|
|
|
else if (battery->state & 0x02)
|
|
|
|
|
val->intval = POWER_SUPPLY_STATUS_CHARGING;
|
2009-01-25 22:05:50 +07:00
|
|
|
else if (acpi_battery_is_charged(battery))
|
2007-09-26 22:43:04 +07:00
|
|
|
val->intval = POWER_SUPPLY_STATUS_FULL;
|
2007-11-08 06:09:09 +07:00
|
|
|
else
|
|
|
|
|
val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
|
2007-09-26 22:43:04 +07:00
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_PRESENT:
|
|
|
|
|
val->intval = acpi_battery_present(battery);
|
|
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_TECHNOLOGY:
|
|
|
|
|
val->intval = acpi_battery_technology(battery);
|
|
|
|
|
break;
|
2009-10-15 17:31:44 +07:00
|
|
|
case POWER_SUPPLY_PROP_CYCLE_COUNT:
|
|
|
|
|
val->intval = battery->cycle_count;
|
|
|
|
|
break;
|
2007-09-26 22:43:04 +07:00
|
|
|
case POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN:
|
2010-10-24 00:35:15 +07:00
|
|
|
if (battery->design_voltage == ACPI_BATTERY_VALUE_UNKNOWN)
|
|
|
|
|
ret = -ENODEV;
|
|
|
|
|
else
|
|
|
|
|
val->intval = battery->design_voltage * 1000;
|
2007-09-26 22:43:04 +07:00
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_VOLTAGE_NOW:
|
2010-10-24 00:35:15 +07:00
|
|
|
if (battery->voltage_now == ACPI_BATTERY_VALUE_UNKNOWN)
|
|
|
|
|
ret = -ENODEV;
|
|
|
|
|
else
|
|
|
|
|
val->intval = battery->voltage_now * 1000;
|
2007-09-26 22:43:04 +07:00
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_CURRENT_NOW:
|
2009-03-28 09:23:52 +07:00
|
|
|
case POWER_SUPPLY_PROP_POWER_NOW:
|
2010-10-24 00:35:15 +07:00
|
|
|
if (battery->rate_now == ACPI_BATTERY_VALUE_UNKNOWN)
|
|
|
|
|
ret = -ENODEV;
|
|
|
|
|
else
|
|
|
|
|
val->intval = battery->rate_now * 1000;
|
2007-09-26 22:43:04 +07:00
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN:
|
|
|
|
|
case POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN:
|
2010-10-24 00:35:15 +07:00
|
|
|
if (battery->design_capacity == ACPI_BATTERY_VALUE_UNKNOWN)
|
|
|
|
|
ret = -ENODEV;
|
|
|
|
|
else
|
|
|
|
|
val->intval = battery->design_capacity * 1000;
|
2007-09-26 22:43:04 +07:00
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_CHARGE_FULL:
|
|
|
|
|
case POWER_SUPPLY_PROP_ENERGY_FULL:
|
2010-10-24 00:35:15 +07:00
|
|
|
if (battery->full_charge_capacity == ACPI_BATTERY_VALUE_UNKNOWN)
|
|
|
|
|
ret = -ENODEV;
|
|
|
|
|
else
|
|
|
|
|
val->intval = battery->full_charge_capacity * 1000;
|
2007-09-26 22:43:04 +07:00
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_CHARGE_NOW:
|
|
|
|
|
case POWER_SUPPLY_PROP_ENERGY_NOW:
|
2010-10-24 00:35:15 +07:00
|
|
|
if (battery->capacity_now == ACPI_BATTERY_VALUE_UNKNOWN)
|
|
|
|
|
ret = -ENODEV;
|
|
|
|
|
else
|
|
|
|
|
val->intval = battery->capacity_now * 1000;
|
2007-09-26 22:43:04 +07:00
|
|
|
break;
|
2012-04-06 07:38:54 +07:00
|
|
|
case POWER_SUPPLY_PROP_CAPACITY:
|
|
|
|
|
if (battery->capacity_now && battery->full_charge_capacity)
|
|
|
|
|
val->intval = battery->capacity_now * 100/
|
|
|
|
|
battery->full_charge_capacity;
|
|
|
|
|
else
|
|
|
|
|
val->intval = 0;
|
|
|
|
|
break;
|
2007-09-26 22:43:04 +07:00
|
|
|
case POWER_SUPPLY_PROP_MODEL_NAME:
|
|
|
|
|
val->strval = battery->model_number;
|
|
|
|
|
break;
|
|
|
|
|
case POWER_SUPPLY_PROP_MANUFACTURER:
|
|
|
|
|
val->strval = battery->oem_info;
|
|
|
|
|
break;
|
2008-01-23 00:46:50 +07:00
|
|
|
case POWER_SUPPLY_PROP_SERIAL_NUMBER:
|
|
|
|
|
val->strval = battery->serial_number;
|
|
|
|
|
break;
|
2007-09-26 22:43:04 +07:00
|
|
|
default:
|
2010-10-24 00:35:15 +07:00
|
|
|
ret = -EINVAL;
|
2007-09-26 22:43:04 +07:00
|
|
|
}
|
2010-10-24 00:35:15 +07:00
|
|
|
return ret;
|
2007-09-26 22:43:04 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static enum power_supply_property charge_battery_props[] = {
|
|
|
|
|
POWER_SUPPLY_PROP_STATUS,
|
|
|
|
|
POWER_SUPPLY_PROP_PRESENT,
|
|
|
|
|
POWER_SUPPLY_PROP_TECHNOLOGY,
|
2009-10-15 17:31:44 +07:00
|
|
|
POWER_SUPPLY_PROP_CYCLE_COUNT,
|
2007-09-26 22:43:04 +07:00
|
|
|
POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
|
|
|
|
|
POWER_SUPPLY_PROP_VOLTAGE_NOW,
|
|
|
|
|
POWER_SUPPLY_PROP_CURRENT_NOW,
|
|
|
|
|
POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
|
|
|
|
|
POWER_SUPPLY_PROP_CHARGE_FULL,
|
|
|
|
|
POWER_SUPPLY_PROP_CHARGE_NOW,
|
2012-04-06 07:38:54 +07:00
|
|
|
POWER_SUPPLY_PROP_CAPACITY,
|
2007-09-26 22:43:04 +07:00
|
|
|
POWER_SUPPLY_PROP_MODEL_NAME,
|
|
|
|
|
POWER_SUPPLY_PROP_MANUFACTURER,
|
2008-01-23 00:46:50 +07:00
|
|
|
POWER_SUPPLY_PROP_SERIAL_NUMBER,
|
2007-09-26 22:43:04 +07:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static enum power_supply_property energy_battery_props[] = {
|
|
|
|
|
POWER_SUPPLY_PROP_STATUS,
|
|
|
|
|
POWER_SUPPLY_PROP_PRESENT,
|
|
|
|
|
POWER_SUPPLY_PROP_TECHNOLOGY,
|
2009-10-15 17:31:44 +07:00
|
|
|
POWER_SUPPLY_PROP_CYCLE_COUNT,
|
2007-09-26 22:43:04 +07:00
|
|
|
POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
|
|
|
|
|
POWER_SUPPLY_PROP_VOLTAGE_NOW,
|
2009-03-28 09:23:52 +07:00
|
|
|
POWER_SUPPLY_PROP_POWER_NOW,
|
2007-09-26 22:43:04 +07:00
|
|
|
POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN,
|
|
|
|
|
POWER_SUPPLY_PROP_ENERGY_FULL,
|
|
|
|
|
POWER_SUPPLY_PROP_ENERGY_NOW,
|
2012-04-06 07:38:54 +07:00
|
|
|
POWER_SUPPLY_PROP_CAPACITY,
|
2007-09-26 22:43:04 +07:00
|
|
|
POWER_SUPPLY_PROP_MODEL_NAME,
|
|
|
|
|
POWER_SUPPLY_PROP_MANUFACTURER,
|
2008-01-23 00:46:50 +07:00
|
|
|
POWER_SUPPLY_PROP_SERIAL_NUMBER,
|
2007-09-26 22:43:04 +07:00
|
|
|
};
|
|
|
|
|
|
2007-05-12 00:18:55 +07:00
|
|
|
/* --------------------------------------------------------------------------
|
|
|
|
|
Battery Management
|
|
|
|
|
-------------------------------------------------------------------------- */
|
2007-09-26 22:42:46 +07:00
|
|
|
struct acpi_offsets {
|
|
|
|
|
size_t offset; /* offset inside struct acpi_sbs_battery */
|
|
|
|
|
u8 mode; /* int or string? */
|
|
|
|
|
};
|
2007-02-20 19:48:06 +07:00
|
|
|
|
2007-09-26 22:42:46 +07:00
|
|
|
static struct acpi_offsets state_offsets[] = {
|
|
|
|
|
{offsetof(struct acpi_battery, state), 0},
|
2009-03-28 09:23:52 +07:00
|
|
|
{offsetof(struct acpi_battery, rate_now), 0},
|
2007-09-26 22:43:04 +07:00
|
|
|
{offsetof(struct acpi_battery, capacity_now), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, voltage_now), 0},
|
2007-09-26 22:42:46 +07:00
|
|
|
};
|
2007-02-20 19:48:06 +07:00
|
|
|
|
2007-09-26 22:42:46 +07:00
|
|
|
static struct acpi_offsets info_offsets[] = {
|
|
|
|
|
{offsetof(struct acpi_battery, power_unit), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_capacity), 0},
|
2007-09-26 22:43:04 +07:00
|
|
|
{offsetof(struct acpi_battery, full_charge_capacity), 0},
|
2007-09-26 22:42:46 +07:00
|
|
|
{offsetof(struct acpi_battery, technology), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_voltage), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_capacity_warning), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_capacity_low), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, capacity_granularity_1), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, capacity_granularity_2), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, model_number), 1},
|
|
|
|
|
{offsetof(struct acpi_battery, serial_number), 1},
|
|
|
|
|
{offsetof(struct acpi_battery, type), 1},
|
|
|
|
|
{offsetof(struct acpi_battery, oem_info), 1},
|
|
|
|
|
};
|
2007-02-20 19:48:06 +07:00
|
|
|
|
2009-10-15 17:31:44 +07:00
|
|
|
static struct acpi_offsets extended_info_offsets[] = {
|
2013-07-30 19:00:42 +07:00
|
|
|
{offsetof(struct acpi_battery, revision), 0},
|
2009-10-15 17:31:44 +07:00
|
|
|
{offsetof(struct acpi_battery, power_unit), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_capacity), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, full_charge_capacity), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, technology), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_voltage), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_capacity_warning), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, design_capacity_low), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, cycle_count), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, measurement_accuracy), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, max_sampling_time), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, min_sampling_time), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, max_averaging_interval), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, min_averaging_interval), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, capacity_granularity_1), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, capacity_granularity_2), 0},
|
|
|
|
|
{offsetof(struct acpi_battery, model_number), 1},
|
|
|
|
|
{offsetof(struct acpi_battery, serial_number), 1},
|
|
|
|
|
{offsetof(struct acpi_battery, type), 1},
|
|
|
|
|
{offsetof(struct acpi_battery, oem_info), 1},
|
|
|
|
|
};
|
|
|
|
|
|
2007-09-26 22:42:46 +07:00
|
|
|
static int extract_package(struct acpi_battery *battery,
|
|
|
|
|
union acpi_object *package,
|
|
|
|
|
struct acpi_offsets *offsets, int num)
|
|
|
|
|
{
|
2007-10-30 03:29:40 +07:00
|
|
|
int i;
|
2007-09-26 22:42:46 +07:00
|
|
|
union acpi_object *element;
|
|
|
|
|
if (package->type != ACPI_TYPE_PACKAGE)
|
|
|
|
|
return -EFAULT;
|
|
|
|
|
for (i = 0; i < num; ++i) {
|
|
|
|
|
if (package->package.count <= i)
|
|
|
|
|
return -EFAULT;
|
|
|
|
|
element = &package->package.elements[i];
|
|
|
|
|
if (offsets[i].mode) {
|
2007-10-30 03:29:40 +07:00
|
|
|
u8 *ptr = (u8 *)battery + offsets[i].offset;
|
|
|
|
|
if (element->type == ACPI_TYPE_STRING ||
|
|
|
|
|
element->type == ACPI_TYPE_BUFFER)
|
|
|
|
|
strncpy(ptr, element->string.pointer, 32);
|
|
|
|
|
else if (element->type == ACPI_TYPE_INTEGER) {
|
|
|
|
|
strncpy(ptr, (u8 *)&element->integer.value,
|
2010-01-28 09:53:19 +07:00
|
|
|
sizeof(u64));
|
|
|
|
|
ptr[sizeof(u64)] = 0;
|
2008-03-18 09:37:42 +07:00
|
|
|
} else
|
|
|
|
|
*ptr = 0; /* don't have value */
|
2007-09-26 22:42:46 +07:00
|
|
|
} else {
|
2008-03-18 09:37:42 +07:00
|
|
|
int *x = (int *)((u8 *)battery + offsets[i].offset);
|
|
|
|
|
*x = (element->type == ACPI_TYPE_INTEGER) ?
|
|
|
|
|
element->integer.value : -1;
|
2007-09-26 22:42:46 +07:00
|
|
|
}
|
2007-02-20 19:48:06 +07:00
|
|
|
}
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int acpi_battery_get_status(struct acpi_battery *battery)
|
|
|
|
|
{
|
2007-09-26 22:42:58 +07:00
|
|
|
if (acpi_bus_get_status(battery->device)) {
|
2007-02-20 19:48:06 +07:00
|
|
|
ACPI_EXCEPTION((AE_INFO, AE_ERROR, "Evaluating _STA"));
|
|
|
|
|
return -ENODEV;
|
|
|
|
|
}
|
2007-09-26 22:42:58 +07:00
|
|
|
return 0;
|
2007-02-20 19:48:06 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int acpi_battery_get_info(struct acpi_battery *battery)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2007-09-26 22:42:58 +07:00
|
|
|
int result = -EFAULT;
|
2005-08-05 11:44:28 +07:00
|
|
|
acpi_status status = 0;
|
2013-05-09 06:11:15 +07:00
|
|
|
char *name = test_bit(ACPI_BATTERY_XINFO_PRESENT, &battery->flags) ?
|
2009-10-15 17:31:44 +07:00
|
|
|
"_BIX" : "_BIF";
|
|
|
|
|
|
2005-08-05 11:44:28 +07:00
|
|
|
struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-02-20 19:48:06 +07:00
|
|
|
if (!acpi_battery_present(battery))
|
|
|
|
|
return 0;
|
2007-09-26 22:42:46 +07:00
|
|
|
mutex_lock(&battery->lock);
|
2009-10-15 17:31:44 +07:00
|
|
|
status = acpi_evaluate_object(battery->device->handle, name,
|
|
|
|
|
NULL, &buffer);
|
2007-09-26 22:42:46 +07:00
|
|
|
mutex_unlock(&battery->lock);
|
2007-09-26 22:42:58 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
if (ACPI_FAILURE(status)) {
|
2009-10-15 17:31:44 +07:00
|
|
|
ACPI_EXCEPTION((AE_INFO, status, "Evaluating %s", name));
|
2006-06-27 11:41:40 +07:00
|
|
|
return -ENODEV;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2014-01-06 21:50:37 +07:00
|
|
|
|
|
|
|
|
if (battery_bix_broken_package)
|
|
|
|
|
result = extract_package(battery, buffer.pointer,
|
|
|
|
|
extended_info_offsets + 1,
|
|
|
|
|
ARRAY_SIZE(extended_info_offsets) - 1);
|
|
|
|
|
else if (test_bit(ACPI_BATTERY_XINFO_PRESENT, &battery->flags))
|
2009-10-15 17:31:44 +07:00
|
|
|
result = extract_package(battery, buffer.pointer,
|
|
|
|
|
extended_info_offsets,
|
|
|
|
|
ARRAY_SIZE(extended_info_offsets));
|
|
|
|
|
else
|
|
|
|
|
result = extract_package(battery, buffer.pointer,
|
|
|
|
|
info_offsets, ARRAY_SIZE(info_offsets));
|
2007-05-12 00:18:55 +07:00
|
|
|
kfree(buffer.pointer);
|
2010-10-22 09:02:06 +07:00
|
|
|
if (test_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags))
|
|
|
|
|
battery->full_charge_capacity = battery->design_capacity;
|
ACPI / battery: Correct battery capacity values on Thinkpads
Add a quirk to correctly report battery capacity on 2010 and 2011
Lenovo Thinkpad models.
The affected models that I tested (x201, t410, t410s, and x220)
exhibit a problem where, when battery capacity reporting unit is mAh,
the values being reported are wrong. Pre-2010 and 2012 models appear
to always report in mWh and are thus unaffected. Also, in mid-2012
Lenovo issued a BIOS update for the 2011 models that fixes the issue
(tested on x220 with a post-1.29 BIOS). No such update is available
for the 2010 models, so those still need this patch.
Problem description: for some reason, the affected Thinkpads switch
the reporting unit between mAh and mWh; generally, mAh is used when a
laptop is plugged in and mWh when it's unplugged, although a
suspend/resume or rmmod/modprobe is needed for the switch to take
effect. The values reported in mAh are *always* wrong. This does
not appear to be a kernel regression; I believe that the values were
never reported correctly. I tested back to kernel 2.6.34, with
multiple machines and BIOS versions.
Simply plugging a laptop into mains before turning it on is enough to
reproduce the problem. Here's a sample /proc/acpi/battery/BAT0/info
from Thinkpad x220 (before a BIOS update) with a 4-cell battery:
present: yes
design capacity: 2886 mAh
last full capacity: 2909 mAh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 145 mAh
design capacity low: 13 mAh
cycle count: 0
capacity granularity 1: 1 mAh
capacity granularity 2: 1 mAh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Once the laptop switches the unit to mWh (unplug from mains, suspend,
resume), the output changes to:
present: yes
design capacity: 28860 mWh
last full capacity: 29090 mWh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 1454 mWh
design capacity low: 200 mWh
cycle count: 0
capacity granularity 1: 1 mWh
capacity granularity 2: 1 mWh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Can you see how the values for "design capacity", etc., differ by a
factor of 10 instead of 14.8 (the design voltage of this battery)?
On the battery itself it says: 14.8V, 1.95Ah, 29Wh, so clearly the
values reported in mWh are correct and the ones in mAh are not.
My guess is that this problem has been around ever since those
machines were released, but because the most common Thinkpad
batteries are rated at 10.8V, the error (8%) is small enough that it
simply hasn't been noticed or at least nobody could be bothered to
look into it.
My patch works around the problem by adjusting the incorrectly
reported mAh values by "10000 / design_voltage". The patch also has
code to figure out if it should be activated or not. It only
activates on Lenovo Thinkpads, only when the unit is mAh, and, as an
extra precaution, only when the battery capacity reported through
ACPI does not match what is reported through DMI (I've never
encountered a machine where the first two conditions would be true
but the last would not, but better safe than sorry).
I've been using this patch for close to a year on several systems
without any problems.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41062
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2012-11-17 04:28:58 +07:00
|
|
|
if (test_bit(ACPI_BATTERY_QUIRK_THINKPAD_MAH, &battery->flags) &&
|
|
|
|
|
battery->power_unit && battery->design_voltage) {
|
|
|
|
|
battery->design_capacity = battery->design_capacity *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
battery->full_charge_capacity = battery->full_charge_capacity *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
battery->design_capacity_warning =
|
|
|
|
|
battery->design_capacity_warning *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
/* Curiously, design_capacity_low, unlike the rest of them,
|
|
|
|
|
is correct. */
|
|
|
|
|
/* capacity_granularity_* equal 1 on the systems tested, so
|
|
|
|
|
it's impossible to tell if they would need an adjustment
|
|
|
|
|
or not if their values were higher. */
|
|
|
|
|
}
|
2006-06-27 11:41:40 +07:00
|
|
|
return result;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
2007-02-20 19:48:06 +07:00
|
|
|
static int acpi_battery_get_state(struct acpi_battery *battery)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2005-08-05 11:44:28 +07:00
|
|
|
int result = 0;
|
|
|
|
|
acpi_status status = 0;
|
|
|
|
|
struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-02-20 19:48:06 +07:00
|
|
|
if (!acpi_battery_present(battery))
|
|
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-09-26 22:42:52 +07:00
|
|
|
if (battery->update_time &&
|
|
|
|
|
time_before(jiffies, battery->update_time +
|
|
|
|
|
msecs_to_jiffies(cache_time)))
|
|
|
|
|
return 0;
|
|
|
|
|
|
2007-09-26 22:42:46 +07:00
|
|
|
mutex_lock(&battery->lock);
|
2007-09-26 22:42:52 +07:00
|
|
|
status = acpi_evaluate_object(battery->device->handle, "_BST",
|
2007-09-26 22:42:46 +07:00
|
|
|
NULL, &buffer);
|
|
|
|
|
mutex_unlock(&battery->lock);
|
2007-08-15 11:19:26 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
if (ACPI_FAILURE(status)) {
|
2006-06-27 10:58:43 +07:00
|
|
|
ACPI_EXCEPTION((AE_INFO, status, "Evaluating _BST"));
|
2006-06-27 11:41:40 +07:00
|
|
|
return -ENODEV;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
2007-09-26 22:42:58 +07:00
|
|
|
|
2007-09-26 22:42:46 +07:00
|
|
|
result = extract_package(battery, buffer.pointer,
|
|
|
|
|
state_offsets, ARRAY_SIZE(state_offsets));
|
2007-09-26 22:42:52 +07:00
|
|
|
battery->update_time = jiffies;
|
2007-05-12 00:18:55 +07:00
|
|
|
kfree(buffer.pointer);
|
2009-08-07 05:57:48 +07:00
|
|
|
|
2011-06-30 10:33:12 +07:00
|
|
|
/* For buggy DSDTs that report negative 16-bit values for either
|
|
|
|
|
* charging or discharging current and/or report 0 as 65536
|
|
|
|
|
* due to bad math.
|
|
|
|
|
*/
|
|
|
|
|
if (battery->power_unit == ACPI_BATTERY_POWER_UNIT_MA &&
|
|
|
|
|
battery->rate_now != ACPI_BATTERY_VALUE_UNKNOWN &&
|
|
|
|
|
(s16)(battery->rate_now) < 0) {
|
2009-08-07 05:57:48 +07:00
|
|
|
battery->rate_now = abs((s16)battery->rate_now);
|
2011-06-30 10:33:12 +07:00
|
|
|
printk_once(KERN_WARNING FW_BUG "battery: (dis)charge rate"
|
|
|
|
|
" invalid.\n");
|
|
|
|
|
}
|
2009-08-07 05:57:48 +07:00
|
|
|
|
2010-10-22 09:02:06 +07:00
|
|
|
if (test_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags)
|
|
|
|
|
&& battery->capacity_now >= 0 && battery->capacity_now <= 100)
|
|
|
|
|
battery->capacity_now = (battery->capacity_now *
|
|
|
|
|
battery->full_charge_capacity) / 100;
|
ACPI / battery: Correct battery capacity values on Thinkpads
Add a quirk to correctly report battery capacity on 2010 and 2011
Lenovo Thinkpad models.
The affected models that I tested (x201, t410, t410s, and x220)
exhibit a problem where, when battery capacity reporting unit is mAh,
the values being reported are wrong. Pre-2010 and 2012 models appear
to always report in mWh and are thus unaffected. Also, in mid-2012
Lenovo issued a BIOS update for the 2011 models that fixes the issue
(tested on x220 with a post-1.29 BIOS). No such update is available
for the 2010 models, so those still need this patch.
Problem description: for some reason, the affected Thinkpads switch
the reporting unit between mAh and mWh; generally, mAh is used when a
laptop is plugged in and mWh when it's unplugged, although a
suspend/resume or rmmod/modprobe is needed for the switch to take
effect. The values reported in mAh are *always* wrong. This does
not appear to be a kernel regression; I believe that the values were
never reported correctly. I tested back to kernel 2.6.34, with
multiple machines and BIOS versions.
Simply plugging a laptop into mains before turning it on is enough to
reproduce the problem. Here's a sample /proc/acpi/battery/BAT0/info
from Thinkpad x220 (before a BIOS update) with a 4-cell battery:
present: yes
design capacity: 2886 mAh
last full capacity: 2909 mAh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 145 mAh
design capacity low: 13 mAh
cycle count: 0
capacity granularity 1: 1 mAh
capacity granularity 2: 1 mAh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Once the laptop switches the unit to mWh (unplug from mains, suspend,
resume), the output changes to:
present: yes
design capacity: 28860 mWh
last full capacity: 29090 mWh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 1454 mWh
design capacity low: 200 mWh
cycle count: 0
capacity granularity 1: 1 mWh
capacity granularity 2: 1 mWh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Can you see how the values for "design capacity", etc., differ by a
factor of 10 instead of 14.8 (the design voltage of this battery)?
On the battery itself it says: 14.8V, 1.95Ah, 29Wh, so clearly the
values reported in mWh are correct and the ones in mAh are not.
My guess is that this problem has been around ever since those
machines were released, but because the most common Thinkpad
batteries are rated at 10.8V, the error (8%) is small enough that it
simply hasn't been noticed or at least nobody could be bothered to
look into it.
My patch works around the problem by adjusting the incorrectly
reported mAh values by "10000 / design_voltage". The patch also has
code to figure out if it should be activated or not. It only
activates on Lenovo Thinkpads, only when the unit is mAh, and, as an
extra precaution, only when the battery capacity reported through
ACPI does not match what is reported through DMI (I've never
encountered a machine where the first two conditions would be true
but the last would not, but better safe than sorry).
I've been using this patch for close to a year on several systems
without any problems.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41062
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2012-11-17 04:28:58 +07:00
|
|
|
if (test_bit(ACPI_BATTERY_QUIRK_THINKPAD_MAH, &battery->flags) &&
|
|
|
|
|
battery->power_unit && battery->design_voltage) {
|
|
|
|
|
battery->capacity_now = battery->capacity_now *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
}
|
2007-02-20 19:48:06 +07:00
|
|
|
return result;
|
|
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-09-26 22:42:58 +07:00
|
|
|
static int acpi_battery_set_alarm(struct acpi_battery *battery)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2005-08-05 11:44:28 +07:00
|
|
|
acpi_status status = 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2009-10-15 17:31:44 +07:00
|
|
|
if (!acpi_battery_present(battery) ||
|
2009-10-15 17:31:24 +07:00
|
|
|
!test_bit(ACPI_BATTERY_ALARM_PRESENT, &battery->flags))
|
2006-06-27 11:41:40 +07:00
|
|
|
return -ENODEV;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-09-26 22:42:46 +07:00
|
|
|
mutex_lock(&battery->lock);
|
2013-06-28 23:24:39 +07:00
|
|
|
status = acpi_execute_simple_method(battery->device->handle, "_BTP",
|
|
|
|
|
battery->alarm);
|
2007-09-26 22:42:46 +07:00
|
|
|
mutex_unlock(&battery->lock);
|
2007-09-26 22:42:58 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
if (ACPI_FAILURE(status))
|
2006-06-27 11:41:40 +07:00
|
|
|
return -ENODEV;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-09-26 22:42:58 +07:00
|
|
|
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Alarm set to %d\n", battery->alarm));
|
2006-06-27 11:41:40 +07:00
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
2007-02-20 19:48:06 +07:00
|
|
|
static int acpi_battery_init_alarm(struct acpi_battery *battery)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2007-02-20 19:48:06 +07:00
|
|
|
/* See if alarms are supported, and if so, set default */
|
2013-06-28 23:24:38 +07:00
|
|
|
if (!acpi_has_method(battery->device->handle, "_BTP")) {
|
2009-10-15 17:31:24 +07:00
|
|
|
clear_bit(ACPI_BATTERY_ALARM_PRESENT, &battery->flags);
|
2007-09-26 22:42:52 +07:00
|
|
|
return 0;
|
2007-02-20 19:48:06 +07:00
|
|
|
}
|
2009-10-15 17:31:24 +07:00
|
|
|
set_bit(ACPI_BATTERY_ALARM_PRESENT, &battery->flags);
|
2007-09-26 22:42:52 +07:00
|
|
|
if (!battery->alarm)
|
|
|
|
|
battery->alarm = battery->design_capacity_warning;
|
2007-09-26 22:42:58 +07:00
|
|
|
return acpi_battery_set_alarm(battery);
|
2007-02-20 19:48:06 +07:00
|
|
|
}
|
2005-04-17 05:20:36 +07:00
|
|
|
|
2007-10-28 16:50:09 +07:00
|
|
|
static ssize_t acpi_battery_alarm_show(struct device *dev,
|
|
|
|
|
struct device_attribute *attr,
|
|
|
|
|
char *buf)
|
|
|
|
|
{
|
|
|
|
|
struct acpi_battery *battery = to_acpi_battery(dev_get_drvdata(dev));
|
|
|
|
|
return sprintf(buf, "%d\n", battery->alarm * 1000);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static ssize_t acpi_battery_alarm_store(struct device *dev,
|
|
|
|
|
struct device_attribute *attr,
|
|
|
|
|
const char *buf, size_t count)
|
|
|
|
|
{
|
|
|
|
|
unsigned long x;
|
|
|
|
|
struct acpi_battery *battery = to_acpi_battery(dev_get_drvdata(dev));
|
2014-01-21 21:40:43 +07:00
|
|
|
if (sscanf(buf, "%lu\n", &x) == 1)
|
2007-10-28 16:50:09 +07:00
|
|
|
battery->alarm = x/1000;
|
|
|
|
|
if (acpi_battery_present(battery))
|
|
|
|
|
acpi_battery_set_alarm(battery);
|
|
|
|
|
return count;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct device_attribute alarm_attr = {
|
2008-10-19 10:28:50 +07:00
|
|
|
.attr = {.name = "alarm", .mode = 0644},
|
2007-10-28 16:50:09 +07:00
|
|
|
.show = acpi_battery_alarm_show,
|
|
|
|
|
.store = acpi_battery_alarm_store,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static int sysfs_add_battery(struct acpi_battery *battery)
|
|
|
|
|
{
|
|
|
|
|
int result;
|
|
|
|
|
|
2011-06-30 10:32:40 +07:00
|
|
|
if (battery->power_unit == ACPI_BATTERY_POWER_UNIT_MA) {
|
2007-10-28 16:50:09 +07:00
|
|
|
battery->bat.properties = charge_battery_props;
|
|
|
|
|
battery->bat.num_properties =
|
|
|
|
|
ARRAY_SIZE(charge_battery_props);
|
|
|
|
|
} else {
|
|
|
|
|
battery->bat.properties = energy_battery_props;
|
|
|
|
|
battery->bat.num_properties =
|
|
|
|
|
ARRAY_SIZE(energy_battery_props);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
battery->bat.name = acpi_device_bid(battery->device);
|
|
|
|
|
battery->bat.type = POWER_SUPPLY_TYPE_BATTERY;
|
|
|
|
|
battery->bat.get_property = acpi_battery_get_property;
|
|
|
|
|
|
|
|
|
|
result = power_supply_register(&battery->device->dev, &battery->bat);
|
|
|
|
|
if (result)
|
|
|
|
|
return result;
|
|
|
|
|
return device_create_file(battery->bat.dev, &alarm_attr);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void sysfs_remove_battery(struct acpi_battery *battery)
|
|
|
|
|
{
|
2011-08-06 05:34:08 +07:00
|
|
|
mutex_lock(&battery->sysfs_lock);
|
2011-06-30 10:34:12 +07:00
|
|
|
if (!battery->bat.dev) {
|
2011-08-06 05:34:08 +07:00
|
|
|
mutex_unlock(&battery->sysfs_lock);
|
2007-10-28 16:50:09 +07:00
|
|
|
return;
|
2011-06-30 10:34:12 +07:00
|
|
|
}
|
|
|
|
|
|
2007-10-28 16:50:09 +07:00
|
|
|
device_remove_file(battery->bat.dev, &alarm_attr);
|
|
|
|
|
power_supply_unregister(&battery->bat);
|
2007-11-13 16:23:06 +07:00
|
|
|
battery->bat.dev = NULL;
|
2011-08-06 05:34:08 +07:00
|
|
|
mutex_unlock(&battery->sysfs_lock);
|
2009-08-07 05:57:48 +07:00
|
|
|
}
|
|
|
|
|
|
ACPI / battery: Correct battery capacity values on Thinkpads
Add a quirk to correctly report battery capacity on 2010 and 2011
Lenovo Thinkpad models.
The affected models that I tested (x201, t410, t410s, and x220)
exhibit a problem where, when battery capacity reporting unit is mAh,
the values being reported are wrong. Pre-2010 and 2012 models appear
to always report in mWh and are thus unaffected. Also, in mid-2012
Lenovo issued a BIOS update for the 2011 models that fixes the issue
(tested on x220 with a post-1.29 BIOS). No such update is available
for the 2010 models, so those still need this patch.
Problem description: for some reason, the affected Thinkpads switch
the reporting unit between mAh and mWh; generally, mAh is used when a
laptop is plugged in and mWh when it's unplugged, although a
suspend/resume or rmmod/modprobe is needed for the switch to take
effect. The values reported in mAh are *always* wrong. This does
not appear to be a kernel regression; I believe that the values were
never reported correctly. I tested back to kernel 2.6.34, with
multiple machines and BIOS versions.
Simply plugging a laptop into mains before turning it on is enough to
reproduce the problem. Here's a sample /proc/acpi/battery/BAT0/info
from Thinkpad x220 (before a BIOS update) with a 4-cell battery:
present: yes
design capacity: 2886 mAh
last full capacity: 2909 mAh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 145 mAh
design capacity low: 13 mAh
cycle count: 0
capacity granularity 1: 1 mAh
capacity granularity 2: 1 mAh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Once the laptop switches the unit to mWh (unplug from mains, suspend,
resume), the output changes to:
present: yes
design capacity: 28860 mWh
last full capacity: 29090 mWh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 1454 mWh
design capacity low: 200 mWh
cycle count: 0
capacity granularity 1: 1 mWh
capacity granularity 2: 1 mWh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Can you see how the values for "design capacity", etc., differ by a
factor of 10 instead of 14.8 (the design voltage of this battery)?
On the battery itself it says: 14.8V, 1.95Ah, 29Wh, so clearly the
values reported in mWh are correct and the ones in mAh are not.
My guess is that this problem has been around ever since those
machines were released, but because the most common Thinkpad
batteries are rated at 10.8V, the error (8%) is small enough that it
simply hasn't been noticed or at least nobody could be bothered to
look into it.
My patch works around the problem by adjusting the incorrectly
reported mAh values by "10000 / design_voltage". The patch also has
code to figure out if it should be activated or not. It only
activates on Lenovo Thinkpads, only when the unit is mAh, and, as an
extra precaution, only when the battery capacity reported through
ACPI does not match what is reported through DMI (I've never
encountered a machine where the first two conditions would be true
but the last would not, but better safe than sorry).
I've been using this patch for close to a year on several systems
without any problems.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41062
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2012-11-17 04:28:58 +07:00
|
|
|
static void find_battery(const struct dmi_header *dm, void *private)
|
|
|
|
|
{
|
|
|
|
|
struct acpi_battery *battery = (struct acpi_battery *)private;
|
|
|
|
|
/* Note: the hardcoded offsets below have been extracted from
|
|
|
|
|
the source code of dmidecode. */
|
|
|
|
|
if (dm->type == DMI_ENTRY_PORTABLE_BATTERY && dm->length >= 8) {
|
|
|
|
|
const u8 *dmi_data = (const u8 *)(dm + 1);
|
|
|
|
|
int dmi_capacity = get_unaligned((const u16 *)(dmi_data + 6));
|
|
|
|
|
if (dm->length >= 18)
|
|
|
|
|
dmi_capacity *= dmi_data[17];
|
|
|
|
|
if (battery->design_capacity * battery->design_voltage / 1000
|
|
|
|
|
!= dmi_capacity &&
|
|
|
|
|
battery->design_capacity * 10 == dmi_capacity)
|
|
|
|
|
set_bit(ACPI_BATTERY_QUIRK_THINKPAD_MAH,
|
|
|
|
|
&battery->flags);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-10-22 09:02:06 +07:00
|
|
|
/*
|
|
|
|
|
* According to the ACPI spec, some kinds of primary batteries can
|
|
|
|
|
* report percentage battery remaining capacity directly to OS.
|
|
|
|
|
* In this case, it reports the Last Full Charged Capacity == 100
|
|
|
|
|
* and BatteryPresentRate == 0xFFFFFFFF.
|
|
|
|
|
*
|
|
|
|
|
* Now we found some battery reports percentage remaining capacity
|
|
|
|
|
* even if it's rechargeable.
|
|
|
|
|
* https://bugzilla.kernel.org/show_bug.cgi?id=15979
|
|
|
|
|
*
|
|
|
|
|
* Handle this correctly so that they won't break userspace.
|
|
|
|
|
*/
|
2011-06-30 10:33:27 +07:00
|
|
|
static void acpi_battery_quirks(struct acpi_battery *battery)
|
2010-10-22 09:02:06 +07:00
|
|
|
{
|
|
|
|
|
if (test_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags))
|
2013-05-09 06:11:15 +07:00
|
|
|
return;
|
2010-10-22 09:02:06 +07:00
|
|
|
|
2013-05-09 06:11:15 +07:00
|
|
|
if (battery->full_charge_capacity == 100 &&
|
|
|
|
|
battery->rate_now == ACPI_BATTERY_VALUE_UNKNOWN &&
|
|
|
|
|
battery->capacity_now >= 0 && battery->capacity_now <= 100) {
|
2010-10-22 09:02:06 +07:00
|
|
|
set_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags);
|
|
|
|
|
battery->full_charge_capacity = battery->design_capacity;
|
|
|
|
|
battery->capacity_now = (battery->capacity_now *
|
|
|
|
|
battery->full_charge_capacity) / 100;
|
|
|
|
|
}
|
ACPI / battery: Correct battery capacity values on Thinkpads
Add a quirk to correctly report battery capacity on 2010 and 2011
Lenovo Thinkpad models.
The affected models that I tested (x201, t410, t410s, and x220)
exhibit a problem where, when battery capacity reporting unit is mAh,
the values being reported are wrong. Pre-2010 and 2012 models appear
to always report in mWh and are thus unaffected. Also, in mid-2012
Lenovo issued a BIOS update for the 2011 models that fixes the issue
(tested on x220 with a post-1.29 BIOS). No such update is available
for the 2010 models, so those still need this patch.
Problem description: for some reason, the affected Thinkpads switch
the reporting unit between mAh and mWh; generally, mAh is used when a
laptop is plugged in and mWh when it's unplugged, although a
suspend/resume or rmmod/modprobe is needed for the switch to take
effect. The values reported in mAh are *always* wrong. This does
not appear to be a kernel regression; I believe that the values were
never reported correctly. I tested back to kernel 2.6.34, with
multiple machines and BIOS versions.
Simply plugging a laptop into mains before turning it on is enough to
reproduce the problem. Here's a sample /proc/acpi/battery/BAT0/info
from Thinkpad x220 (before a BIOS update) with a 4-cell battery:
present: yes
design capacity: 2886 mAh
last full capacity: 2909 mAh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 145 mAh
design capacity low: 13 mAh
cycle count: 0
capacity granularity 1: 1 mAh
capacity granularity 2: 1 mAh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Once the laptop switches the unit to mWh (unplug from mains, suspend,
resume), the output changes to:
present: yes
design capacity: 28860 mWh
last full capacity: 29090 mWh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 1454 mWh
design capacity low: 200 mWh
cycle count: 0
capacity granularity 1: 1 mWh
capacity granularity 2: 1 mWh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Can you see how the values for "design capacity", etc., differ by a
factor of 10 instead of 14.8 (the design voltage of this battery)?
On the battery itself it says: 14.8V, 1.95Ah, 29Wh, so clearly the
values reported in mWh are correct and the ones in mAh are not.
My guess is that this problem has been around ever since those
machines were released, but because the most common Thinkpad
batteries are rated at 10.8V, the error (8%) is small enough that it
simply hasn't been noticed or at least nobody could be bothered to
look into it.
My patch works around the problem by adjusting the incorrectly
reported mAh values by "10000 / design_voltage". The patch also has
code to figure out if it should be activated or not. It only
activates on Lenovo Thinkpads, only when the unit is mAh, and, as an
extra precaution, only when the battery capacity reported through
ACPI does not match what is reported through DMI (I've never
encountered a machine where the first two conditions would be true
but the last would not, but better safe than sorry).
I've been using this patch for close to a year on several systems
without any problems.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41062
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2012-11-17 04:28:58 +07:00
|
|
|
|
|
|
|
|
if (test_bit(ACPI_BATTERY_QUIRK_THINKPAD_MAH, &battery->flags))
|
2013-05-09 06:11:15 +07:00
|
|
|
return;
|
ACPI / battery: Correct battery capacity values on Thinkpads
Add a quirk to correctly report battery capacity on 2010 and 2011
Lenovo Thinkpad models.
The affected models that I tested (x201, t410, t410s, and x220)
exhibit a problem where, when battery capacity reporting unit is mAh,
the values being reported are wrong. Pre-2010 and 2012 models appear
to always report in mWh and are thus unaffected. Also, in mid-2012
Lenovo issued a BIOS update for the 2011 models that fixes the issue
(tested on x220 with a post-1.29 BIOS). No such update is available
for the 2010 models, so those still need this patch.
Problem description: for some reason, the affected Thinkpads switch
the reporting unit between mAh and mWh; generally, mAh is used when a
laptop is plugged in and mWh when it's unplugged, although a
suspend/resume or rmmod/modprobe is needed for the switch to take
effect. The values reported in mAh are *always* wrong. This does
not appear to be a kernel regression; I believe that the values were
never reported correctly. I tested back to kernel 2.6.34, with
multiple machines and BIOS versions.
Simply plugging a laptop into mains before turning it on is enough to
reproduce the problem. Here's a sample /proc/acpi/battery/BAT0/info
from Thinkpad x220 (before a BIOS update) with a 4-cell battery:
present: yes
design capacity: 2886 mAh
last full capacity: 2909 mAh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 145 mAh
design capacity low: 13 mAh
cycle count: 0
capacity granularity 1: 1 mAh
capacity granularity 2: 1 mAh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Once the laptop switches the unit to mWh (unplug from mains, suspend,
resume), the output changes to:
present: yes
design capacity: 28860 mWh
last full capacity: 29090 mWh
battery technology: rechargeable
design voltage: 14800 mV
design capacity warning: 1454 mWh
design capacity low: 200 mWh
cycle count: 0
capacity granularity 1: 1 mWh
capacity granularity 2: 1 mWh
model number: 42T4899
serial number: 21064
battery type: LION
OEM info: SANYO
Can you see how the values for "design capacity", etc., differ by a
factor of 10 instead of 14.8 (the design voltage of this battery)?
On the battery itself it says: 14.8V, 1.95Ah, 29Wh, so clearly the
values reported in mWh are correct and the ones in mAh are not.
My guess is that this problem has been around ever since those
machines were released, but because the most common Thinkpad
batteries are rated at 10.8V, the error (8%) is small enough that it
simply hasn't been noticed or at least nobody could be bothered to
look into it.
My patch works around the problem by adjusting the incorrectly
reported mAh values by "10000 / design_voltage". The patch also has
code to figure out if it should be activated or not. It only
activates on Lenovo Thinkpads, only when the unit is mAh, and, as an
extra precaution, only when the battery capacity reported through
ACPI does not match what is reported through DMI (I've never
encountered a machine where the first two conditions would be true
but the last would not, but better safe than sorry).
I've been using this patch for close to a year on several systems
without any problems.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41062
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2012-11-17 04:28:58 +07:00
|
|
|
|
|
|
|
|
if (battery->power_unit && dmi_name_in_vendors("LENOVO")) {
|
|
|
|
|
const char *s;
|
|
|
|
|
s = dmi_get_system_info(DMI_PRODUCT_VERSION);
|
|
|
|
|
if (s && !strnicmp(s, "ThinkPad", 8)) {
|
|
|
|
|
dmi_walk(find_battery, battery);
|
|
|
|
|
if (test_bit(ACPI_BATTERY_QUIRK_THINKPAD_MAH,
|
|
|
|
|
&battery->flags) &&
|
|
|
|
|
battery->design_voltage) {
|
|
|
|
|
battery->design_capacity =
|
|
|
|
|
battery->design_capacity *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
battery->full_charge_capacity =
|
|
|
|
|
battery->full_charge_capacity *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
battery->design_capacity_warning =
|
|
|
|
|
battery->design_capacity_warning *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
battery->capacity_now = battery->capacity_now *
|
|
|
|
|
10000 / battery->design_voltage;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-10-22 09:02:06 +07:00
|
|
|
}
|
|
|
|
|
|
2007-09-26 22:42:52 +07:00
|
|
|
static int acpi_battery_update(struct acpi_battery *battery)
|
2007-02-20 19:48:06 +07:00
|
|
|
{
|
2008-12-23 06:44:54 +07:00
|
|
|
int result, old_present = acpi_battery_present(battery);
|
2008-01-02 02:27:24 +07:00
|
|
|
result = acpi_battery_get_status(battery);
|
2007-10-28 16:50:09 +07:00
|
|
|
if (result)
|
2007-02-20 19:48:06 +07:00
|
|
|
return result;
|
2007-10-28 16:50:09 +07:00
|
|
|
if (!acpi_battery_present(battery)) {
|
|
|
|
|
sysfs_remove_battery(battery);
|
2008-01-02 02:27:24 +07:00
|
|
|
battery->update_time = 0;
|
2007-10-28 16:50:09 +07:00
|
|
|
return 0;
|
2007-02-20 19:48:06 +07:00
|
|
|
}
|
2008-12-23 06:44:54 +07:00
|
|
|
if (!battery->update_time ||
|
|
|
|
|
old_present != acpi_battery_present(battery)) {
|
2008-01-02 02:27:24 +07:00
|
|
|
result = acpi_battery_get_info(battery);
|
|
|
|
|
if (result)
|
|
|
|
|
return result;
|
|
|
|
|
acpi_battery_init_alarm(battery);
|
|
|
|
|
}
|
2011-07-12 15:03:29 +07:00
|
|
|
if (!battery->bat.dev) {
|
|
|
|
|
result = sysfs_add_battery(battery);
|
|
|
|
|
if (result)
|
|
|
|
|
return result;
|
|
|
|
|
}
|
2010-10-22 09:02:06 +07:00
|
|
|
result = acpi_battery_get_state(battery);
|
2011-06-30 10:33:27 +07:00
|
|
|
acpi_battery_quirks(battery);
|
2010-10-22 09:02:06 +07:00
|
|
|
return result;
|
2007-02-10 13:43:48 +07:00
|
|
|
}
|
|
|
|
|
|
2011-01-07 05:42:27 +07:00
|
|
|
static void acpi_battery_refresh(struct acpi_battery *battery)
|
|
|
|
|
{
|
2012-05-03 20:48:26 +07:00
|
|
|
int power_unit;
|
|
|
|
|
|
2011-01-07 05:42:27 +07:00
|
|
|
if (!battery->bat.dev)
|
|
|
|
|
return;
|
|
|
|
|
|
2012-05-03 20:48:26 +07:00
|
|
|
power_unit = battery->power_unit;
|
|
|
|
|
|
2011-01-07 05:42:27 +07:00
|
|
|
acpi_battery_get_info(battery);
|
2012-05-03 20:48:26 +07:00
|
|
|
|
|
|
|
|
if (power_unit == battery->power_unit)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
/* The battery has changed its reporting units. */
|
2011-01-07 05:42:27 +07:00
|
|
|
sysfs_remove_battery(battery);
|
|
|
|
|
sysfs_add_battery(battery);
|
|
|
|
|
}
|
|
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
/* --------------------------------------------------------------------------
|
|
|
|
|
Driver Interface
|
|
|
|
|
-------------------------------------------------------------------------- */
|
|
|
|
|
|
2009-04-30 22:35:47 +07:00
|
|
|
static void acpi_battery_notify(struct acpi_device *device, u32 event)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2009-04-30 22:35:47 +07:00
|
|
|
struct acpi_battery *battery = acpi_driver_data(device);
|
2010-07-07 08:11:57 +07:00
|
|
|
struct device *old;
|
2009-04-30 22:35:47 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
if (!battery)
|
2006-06-27 11:41:40 +07:00
|
|
|
return;
|
2010-07-07 08:11:57 +07:00
|
|
|
old = battery->bat.dev;
|
2011-01-07 05:42:27 +07:00
|
|
|
if (event == ACPI_BATTERY_NOTIFY_INFO)
|
|
|
|
|
acpi_battery_refresh(battery);
|
2007-09-26 22:42:52 +07:00
|
|
|
acpi_battery_update(battery);
|
|
|
|
|
acpi_bus_generate_netlink_event(device->pnp.device_class,
|
ACPI: struct device - replace bus_id with dev_name(), dev_set_name()
This patch is part of a larger patch series which will remove
the "char bus_id[20]" name string from struct device. The device
name is managed in the kobject anyway, and without any size
limitation, and just needlessly copied into "struct device".
To set and read the device name dev_name(dev) and dev_set_name(dev)
must be used. If your code uses static kobjects, which it shouldn't
do, "const char *init_name" can be used to statically provide the
name the registered device should have. At registration time, the
init_name field is cleared, to enforce the use of dev_name(dev) to
access the device name at a later time.
We need to get rid of all occurrences of bus_id in the entire tree
to be able to enable the new interface. Please apply this patch,
and possibly convert any remaining remaining occurrences of bus_id.
We want to submit a patch to -next, which will remove bus_id from
"struct device", to find the remaining pieces to convert, and finally
switch over to the new api, which will remove the 20 bytes array
and does no longer have a size limitation.
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Len Brown <len.brown@intel.com>
2008-10-30 07:18:59 +07:00
|
|
|
dev_name(&device->dev), event,
|
2007-02-20 19:48:06 +07:00
|
|
|
acpi_battery_present(battery));
|
2014-03-12 00:58:47 +07:00
|
|
|
acpi_notifier_call_chain(device, event, acpi_battery_present(battery));
|
2009-12-14 05:42:36 +07:00
|
|
|
/* acpi_battery_update could remove power_supply object */
|
2010-07-07 08:11:57 +07:00
|
|
|
if (old && battery->bat.dev)
|
2009-06-30 21:36:16 +07:00
|
|
|
power_supply_changed(&battery->bat);
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
2011-03-23 03:19:50 +07:00
|
|
|
static int battery_notify(struct notifier_block *nb,
|
|
|
|
|
unsigned long mode, void *_unused)
|
|
|
|
|
{
|
|
|
|
|
struct acpi_battery *battery = container_of(nb, struct acpi_battery,
|
|
|
|
|
pm_nb);
|
|
|
|
|
switch (mode) {
|
2011-06-30 10:33:40 +07:00
|
|
|
case PM_POST_HIBERNATION:
|
2011-03-23 03:19:50 +07:00
|
|
|
case PM_POST_SUSPEND:
|
2011-06-30 10:33:58 +07:00
|
|
|
if (battery->bat.dev) {
|
|
|
|
|
sysfs_remove_battery(battery);
|
|
|
|
|
sysfs_add_battery(battery);
|
|
|
|
|
}
|
2011-03-23 03:19:50 +07:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2014-01-06 21:50:37 +07:00
|
|
|
static struct dmi_system_id bat_dmi_table[] = {
|
|
|
|
|
{
|
|
|
|
|
.ident = "NEC LZ750/LS",
|
|
|
|
|
.matches = {
|
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "NEC"),
|
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "PC-LZ750LS"),
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
{},
|
|
|
|
|
};
|
|
|
|
|
|
2005-08-05 11:44:28 +07:00
|
|
|
static int acpi_battery_add(struct acpi_device *device)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2005-08-05 11:44:28 +07:00
|
|
|
int result = 0;
|
|
|
|
|
struct acpi_battery *battery = NULL;
|
2013-06-28 23:24:38 +07:00
|
|
|
|
2005-04-17 05:20:36 +07:00
|
|
|
if (!device)
|
2006-06-27 11:41:40 +07:00
|
|
|
return -EINVAL;
|
2006-12-20 03:56:11 +07:00
|
|
|
battery = kzalloc(sizeof(struct acpi_battery), GFP_KERNEL);
|
2005-04-17 05:20:36 +07:00
|
|
|
if (!battery)
|
2006-06-27 11:41:40 +07:00
|
|
|
return -ENOMEM;
|
2006-05-20 03:54:39 +07:00
|
|
|
battery->device = device;
|
2005-04-17 05:20:36 +07:00
|
|
|
strcpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME);
|
|
|
|
|
strcpy(acpi_device_class(device), ACPI_BATTERY_CLASS);
|
2008-09-23 04:37:34 +07:00
|
|
|
device->driver_data = battery;
|
2007-09-26 22:42:46 +07:00
|
|
|
mutex_init(&battery->lock);
|
2011-08-06 05:34:08 +07:00
|
|
|
mutex_init(&battery->sysfs_lock);
|
2013-06-28 23:24:38 +07:00
|
|
|
if (acpi_has_method(battery->device->handle, "_BIX"))
|
2009-10-15 17:31:44 +07:00
|
|
|
set_bit(ACPI_BATTERY_XINFO_PRESENT, &battery->flags);
|
2011-07-12 15:03:29 +07:00
|
|
|
result = acpi_battery_update(battery);
|
|
|
|
|
if (result)
|
|
|
|
|
goto fail;
|
2011-03-23 03:19:50 +07:00
|
|
|
|
2011-07-12 15:03:28 +07:00
|
|
|
printk(KERN_INFO PREFIX "%s Slot [%s] (battery %s)\n",
|
|
|
|
|
ACPI_BATTERY_DEVICE_NAME, acpi_device_bid(device),
|
|
|
|
|
device->status.battery_present ? "present" : "absent");
|
|
|
|
|
|
2011-03-23 03:19:50 +07:00
|
|
|
battery->pm_nb.notifier_call = battery_notify;
|
|
|
|
|
register_pm_notifier(&battery->pm_nb);
|
|
|
|
|
|
2006-06-27 11:41:40 +07:00
|
|
|
return result;
|
2011-07-12 15:03:28 +07:00
|
|
|
|
|
|
|
|
fail:
|
|
|
|
|
sysfs_remove_battery(battery);
|
|
|
|
|
mutex_destroy(&battery->lock);
|
2011-08-06 05:34:08 +07:00
|
|
|
mutex_destroy(&battery->sysfs_lock);
|
2011-07-12 15:03:28 +07:00
|
|
|
kfree(battery);
|
|
|
|
|
return result;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
2013-01-24 06:24:48 +07:00
|
|
|
static int acpi_battery_remove(struct acpi_device *device)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2005-08-05 11:44:28 +07:00
|
|
|
struct acpi_battery *battery = NULL;
|
2005-04-17 05:20:36 +07:00
|
|
|
|
|
|
|
|
if (!device || !acpi_driver_data(device))
|
2006-06-27 11:41:40 +07:00
|
|
|
return -EINVAL;
|
2006-10-01 05:28:50 +07:00
|
|
|
battery = acpi_driver_data(device);
|
2011-03-23 03:19:50 +07:00
|
|
|
unregister_pm_notifier(&battery->pm_nb);
|
2007-10-28 16:50:09 +07:00
|
|
|
sysfs_remove_battery(battery);
|
2007-09-26 22:42:46 +07:00
|
|
|
mutex_destroy(&battery->lock);
|
2011-08-06 05:34:08 +07:00
|
|
|
mutex_destroy(&battery->sysfs_lock);
|
2005-04-17 05:20:36 +07:00
|
|
|
kfree(battery);
|
2006-06-27 11:41:40 +07:00
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
2012-08-10 04:00:02 +07:00
|
|
|
#ifdef CONFIG_PM_SLEEP
|
2006-10-11 04:20:41 +07:00
|
|
|
/* this is needed to learn about changes made in suspended state */
|
2012-06-28 04:26:43 +07:00
|
|
|
static int acpi_battery_resume(struct device *dev)
|
2006-10-11 04:20:41 +07:00
|
|
|
{
|
|
|
|
|
struct acpi_battery *battery;
|
2012-06-28 04:26:43 +07:00
|
|
|
|
|
|
|
|
if (!dev)
|
2006-10-11 04:20:41 +07:00
|
|
|
return -EINVAL;
|
2012-06-28 04:26:43 +07:00
|
|
|
|
|
|
|
|
battery = acpi_driver_data(to_acpi_device(dev));
|
|
|
|
|
if (!battery)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
2007-09-26 22:42:52 +07:00
|
|
|
battery->update_time = 0;
|
2007-10-28 16:50:09 +07:00
|
|
|
acpi_battery_update(battery);
|
2007-02-20 19:48:06 +07:00
|
|
|
return 0;
|
2006-10-11 04:20:41 +07:00
|
|
|
}
|
2014-02-13 10:19:06 +07:00
|
|
|
#else
|
|
|
|
|
#define acpi_battery_resume NULL
|
2012-08-10 04:00:02 +07:00
|
|
|
#endif
|
2006-10-11 04:20:41 +07:00
|
|
|
|
2012-06-28 04:26:43 +07:00
|
|
|
static SIMPLE_DEV_PM_OPS(acpi_battery_pm, NULL, acpi_battery_resume);
|
|
|
|
|
|
2007-09-26 22:42:58 +07:00
|
|
|
static struct acpi_driver acpi_battery_driver = {
|
|
|
|
|
.name = "battery",
|
|
|
|
|
.class = ACPI_BATTERY_CLASS,
|
|
|
|
|
.ids = battery_device_ids,
|
2009-04-30 22:35:47 +07:00
|
|
|
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
|
2007-09-26 22:42:58 +07:00
|
|
|
.ops = {
|
|
|
|
|
.add = acpi_battery_add,
|
|
|
|
|
.remove = acpi_battery_remove,
|
2009-04-30 22:35:47 +07:00
|
|
|
.notify = acpi_battery_notify,
|
2007-09-26 22:42:58 +07:00
|
|
|
},
|
2012-06-28 04:26:43 +07:00
|
|
|
.drv.pm = &acpi_battery_pm,
|
2007-09-26 22:42:58 +07:00
|
|
|
};
|
|
|
|
|
|
2009-04-12 02:45:20 +07:00
|
|
|
static void __init acpi_battery_init_async(void *unused, async_cookie_t cookie)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
2006-08-15 12:37:22 +07:00
|
|
|
if (acpi_disabled)
|
2009-01-11 02:19:05 +07:00
|
|
|
return;
|
2014-01-06 21:50:37 +07:00
|
|
|
|
|
|
|
|
if (dmi_check_system(bat_dmi_table))
|
|
|
|
|
battery_bix_broken_package = 1;
|
2013-10-11 08:54:08 +07:00
|
|
|
acpi_bus_register_driver(&acpi_battery_driver);
|
2009-01-11 02:19:05 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int __init acpi_battery_init(void)
|
|
|
|
|
{
|
|
|
|
|
async_schedule(acpi_battery_init_async, NULL);
|
2006-06-27 11:41:40 +07:00
|
|
|
return 0;
|
2005-04-17 05:20:36 +07:00
|
|
|
}
|
|
|
|
|
|
2005-08-05 11:44:28 +07:00
|
|
|
static void __exit acpi_battery_exit(void)
|
2005-04-17 05:20:36 +07:00
|
|
|
{
|
|
|
|
|
acpi_bus_unregister_driver(&acpi_battery_driver);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
module_init(acpi_battery_init);
|
|
|
|
|
module_exit(acpi_battery_exit);
|