2015-03-18 16:46:04 +07:00
|
|
|
/*
|
|
|
|
* Copyright © 2008-2015 Intel Corporation
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
* Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
|
|
* IN THE SOFTWARE.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/oom.h>
|
2018-07-11 14:36:02 +07:00
|
|
|
#include <linux/sched/mm.h>
|
2015-03-18 16:46:04 +07:00
|
|
|
#include <linux/shmem_fs.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/swap.h>
|
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <linux/dma-buf.h>
|
2016-04-04 20:46:43 +07:00
|
|
|
#include <linux/vmalloc.h>
|
2015-03-18 16:46:04 +07:00
|
|
|
#include <drm/i915_drm.h>
|
|
|
|
|
|
|
|
#include "i915_drv.h"
|
|
|
|
#include "i915_trace.h"
|
|
|
|
|
2019-01-07 18:54:24 +07:00
|
|
|
static bool shrinker_lock(struct drm_i915_private *i915,
|
|
|
|
unsigned int flags,
|
|
|
|
bool *unlock)
|
2015-03-18 16:46:04 +07:00
|
|
|
{
|
2019-01-09 23:42:03 +07:00
|
|
|
struct mutex *m = &i915->drm.struct_mutex;
|
|
|
|
|
|
|
|
switch (mutex_trylock_recursive(m)) {
|
2016-12-14 00:35:09 +07:00
|
|
|
case MUTEX_TRYLOCK_RECURSIVE:
|
2016-10-28 19:58:37 +07:00
|
|
|
*unlock = false;
|
2016-12-14 00:35:09 +07:00
|
|
|
return true;
|
2017-06-09 18:03:49 +07:00
|
|
|
|
|
|
|
case MUTEX_TRYLOCK_FAILED:
|
2017-08-04 17:41:35 +07:00
|
|
|
*unlock = false;
|
2019-01-09 23:42:03 +07:00
|
|
|
if (flags & I915_SHRINK_ACTIVE &&
|
|
|
|
mutex_lock_killable_nested(m, I915_MM_SHRINKER) == 0)
|
2019-01-07 18:54:24 +07:00
|
|
|
*unlock = true;
|
2017-08-04 17:41:35 +07:00
|
|
|
return *unlock;
|
2017-06-09 18:03:49 +07:00
|
|
|
|
2017-08-04 17:41:35 +07:00
|
|
|
case MUTEX_TRYLOCK_SUCCESS:
|
|
|
|
*unlock = true;
|
|
|
|
return true;
|
2016-10-28 19:58:37 +07:00
|
|
|
}
|
|
|
|
|
2016-12-14 00:35:09 +07:00
|
|
|
BUG();
|
2016-10-28 19:58:37 +07:00
|
|
|
}
|
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
static void shrinker_unlock(struct drm_i915_private *i915, bool unlock)
|
2017-04-07 17:49:34 +07:00
|
|
|
{
|
|
|
|
if (!unlock)
|
|
|
|
return;
|
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
mutex_unlock(&i915->drm.struct_mutex);
|
2017-04-07 17:49:34 +07:00
|
|
|
}
|
|
|
|
|
2015-12-04 22:58:54 +07:00
|
|
|
static bool swap_available(void)
|
|
|
|
{
|
|
|
|
return get_nr_swap_pages() > 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool can_release_pages(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
2016-11-01 21:44:10 +07:00
|
|
|
/* Consider only shrinkable ojects. */
|
|
|
|
if (!i915_gem_object_is_shrinkable(obj))
|
2016-04-20 18:09:52 +07:00
|
|
|
return false;
|
|
|
|
|
2015-12-04 22:58:54 +07:00
|
|
|
/* Only report true if by unbinding the object and putting its pages
|
|
|
|
* we can actually make forward progress towards freeing physical
|
|
|
|
* pages.
|
|
|
|
*
|
|
|
|
* If the pages are pinned for any other reason than being bound
|
|
|
|
* to the GPU, simply unbinding from the GPU is not going to succeed
|
|
|
|
* in releasing our pin count on the pages themselves.
|
|
|
|
*/
|
2016-10-28 19:58:37 +07:00
|
|
|
if (atomic_read(&obj->mm.pages_pin_count) > obj->bind_count)
|
2016-08-04 13:52:26 +07:00
|
|
|
return false;
|
|
|
|
|
2017-10-14 03:26:16 +07:00
|
|
|
/* If any vma are "permanently" pinned, it will prevent us from
|
|
|
|
* reclaiming the obj->mm.pages. We only allow scanout objects to claim
|
|
|
|
* a permanent pin, along with a few others like the context objects.
|
|
|
|
* To simplify the scan, and to avoid walking the list of vma under the
|
|
|
|
* object, we just check the count of its permanently pinned.
|
|
|
|
*/
|
2017-10-16 18:40:37 +07:00
|
|
|
if (READ_ONCE(obj->pin_global))
|
2015-12-04 22:58:54 +07:00
|
|
|
return false;
|
|
|
|
|
|
|
|
/* We can only return physical pages to the system if we can either
|
|
|
|
* discard the contents (because the user has marked them as being
|
|
|
|
* purgeable) or if we can move their contents out to swap.
|
|
|
|
*/
|
2016-10-28 19:58:35 +07:00
|
|
|
return swap_available() || obj->mm.madv == I915_MADV_DONTNEED;
|
2015-12-04 22:58:54 +07:00
|
|
|
}
|
|
|
|
|
2016-10-28 19:58:36 +07:00
|
|
|
static bool unsafe_drop_pages(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
|
|
|
if (i915_gem_object_unbind(obj) == 0)
|
2016-11-01 19:11:34 +07:00
|
|
|
__i915_gem_object_put_pages(obj, I915_MM_SHRINKER);
|
2017-10-14 03:26:13 +07:00
|
|
|
return !i915_gem_object_has_pages(obj);
|
2015-12-04 22:58:54 +07:00
|
|
|
}
|
|
|
|
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 18:55:39 +07:00
|
|
|
static void __start_writeback(struct drm_i915_gem_object *obj,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
struct address_space *mapping;
|
|
|
|
struct writeback_control wbc = {
|
|
|
|
.sync_mode = WB_SYNC_NONE,
|
|
|
|
.nr_to_write = SWAP_CLUSTER_MAX,
|
|
|
|
.range_start = 0,
|
|
|
|
.range_end = LLONG_MAX,
|
|
|
|
.for_reclaim = 1,
|
|
|
|
};
|
|
|
|
unsigned long i;
|
|
|
|
|
|
|
|
lockdep_assert_held(&obj->mm.lock);
|
|
|
|
GEM_BUG_ON(i915_gem_object_has_pages(obj));
|
|
|
|
|
|
|
|
switch (obj->mm.madv) {
|
|
|
|
case I915_MADV_DONTNEED:
|
|
|
|
__i915_gem_object_truncate(obj);
|
|
|
|
case __I915_MADV_PURGED:
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!obj->base.filp)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!(flags & I915_SHRINK_WRITEBACK))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Leave mmapings intact (GTT will have been revoked on unbinding,
|
|
|
|
* leaving only CPU mmapings around) and add those pages to the LRU
|
|
|
|
* instead of invoking writeback so they are aged and paged out
|
|
|
|
* as normal.
|
|
|
|
*/
|
|
|
|
mapping = obj->base.filp->f_mapping;
|
|
|
|
|
|
|
|
/* Begin writeback on each dirty page */
|
|
|
|
for (i = 0; i < obj->base.size >> PAGE_SHIFT; i++) {
|
|
|
|
struct page *page;
|
|
|
|
|
|
|
|
page = find_lock_entry(mapping, i);
|
|
|
|
if (!page || xa_is_value(page))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!page_mapped(page) && clear_page_dirty_for_io(page)) {
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
SetPageReclaim(page);
|
|
|
|
ret = mapping->a_ops->writepage(page, &wbc);
|
|
|
|
if (!PageWriteback(page))
|
|
|
|
ClearPageReclaim(page);
|
|
|
|
if (!ret)
|
|
|
|
goto put;
|
|
|
|
}
|
|
|
|
unlock_page(page);
|
|
|
|
put:
|
|
|
|
put_page(page);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-18 20:47:59 +07:00
|
|
|
/**
|
|
|
|
* i915_gem_shrink - Shrink buffer object caches
|
2017-11-23 18:53:38 +07:00
|
|
|
* @i915: i915 device
|
2015-03-18 20:47:59 +07:00
|
|
|
* @target: amount of memory to make available, in pages
|
2017-09-07 06:19:30 +07:00
|
|
|
* @nr_scanned: optional output for number of pages scanned (incremental)
|
2015-03-18 20:47:59 +07:00
|
|
|
* @flags: control flags for selecting cache types
|
|
|
|
*
|
|
|
|
* This function is the main interface to the shrinker. It will try to release
|
|
|
|
* up to @target pages of main memory backing storage from buffer objects.
|
|
|
|
* Selection of the specific caches can be done with @flags. This is e.g. useful
|
|
|
|
* when purgeable objects should be removed from caches preferentially.
|
|
|
|
*
|
|
|
|
* Note that it's not guaranteed that released amount is actually available as
|
|
|
|
* free system memory - the pages might still be in-used to due to other reasons
|
|
|
|
* (like cpu mmaps) or the mm core has reused them before we could grab them.
|
|
|
|
* Therefore code that needs to explicitly shrink buffer objects caches (e.g. to
|
|
|
|
* avoid deadlocks in memory reclaim) must fall back to i915_gem_shrink_all().
|
|
|
|
*
|
|
|
|
* Also note that any kind of pinning (both per-vma address space pins and
|
|
|
|
* backing storage pins at the buffer object level) result in the shrinker code
|
|
|
|
* having to skip the object.
|
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* The number of pages of backing storage actually released.
|
|
|
|
*/
|
2015-03-18 16:46:04 +07:00
|
|
|
unsigned long
|
2017-11-23 18:53:38 +07:00
|
|
|
i915_gem_shrink(struct drm_i915_private *i915,
|
2017-09-07 06:19:30 +07:00
|
|
|
unsigned long target,
|
|
|
|
unsigned long *nr_scanned,
|
|
|
|
unsigned flags)
|
2015-03-18 16:46:04 +07:00
|
|
|
{
|
|
|
|
const struct {
|
|
|
|
struct list_head *list;
|
|
|
|
unsigned int bit;
|
|
|
|
} phases[] = {
|
2017-11-23 18:53:38 +07:00
|
|
|
{ &i915->mm.unbound_list, I915_SHRINK_UNBOUND },
|
|
|
|
{ &i915->mm.bound_list, I915_SHRINK_BOUND },
|
2015-03-18 16:46:04 +07:00
|
|
|
{ NULL, 0 },
|
|
|
|
}, *phase;
|
2019-01-14 21:21:18 +07:00
|
|
|
intel_wakeref_t wakeref = 0;
|
2015-03-18 16:46:04 +07:00
|
|
|
unsigned long count = 0;
|
2017-09-07 06:19:30 +07:00
|
|
|
unsigned long scanned = 0;
|
2016-10-28 19:58:37 +07:00
|
|
|
bool unlock;
|
|
|
|
|
2019-01-07 18:54:24 +07:00
|
|
|
if (!shrinker_lock(i915, flags, &unlock))
|
2016-10-28 19:58:37 +07:00
|
|
|
return 0;
|
2015-03-18 16:46:04 +07:00
|
|
|
|
2017-11-08 16:44:00 +07:00
|
|
|
/*
|
|
|
|
* When shrinking the active list, also consider active contexts.
|
|
|
|
* Active contexts are pinned until they are retired, and so can
|
|
|
|
* not be simply unbound to retire and unpin their pages. To shrink
|
|
|
|
* the contexts, we must wait until the gpu is idle.
|
|
|
|
*
|
|
|
|
* We don't care about errors here; if we cannot wait upon the GPU,
|
|
|
|
* we will free as much as we can and hope to get a second chance.
|
|
|
|
*/
|
|
|
|
if (flags & I915_SHRINK_ACTIVE)
|
2018-07-09 19:20:42 +07:00
|
|
|
i915_gem_wait_for_idle(i915,
|
|
|
|
I915_WAIT_LOCKED,
|
|
|
|
MAX_SCHEDULE_TIMEOUT);
|
2017-11-08 16:44:00 +07:00
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
trace_i915_gem_shrink(i915, target, flags);
|
2018-02-21 16:56:36 +07:00
|
|
|
i915_retire_requests(i915);
|
2015-10-01 18:18:26 +07:00
|
|
|
|
2016-05-02 15:40:28 +07:00
|
|
|
/*
|
|
|
|
* Unbinding of objects will require HW access; Let us not wake the
|
|
|
|
* device just to recover a little memory. If absolutely necessary,
|
|
|
|
* we will force the wake during oom-notifier.
|
|
|
|
*/
|
2019-01-14 21:21:18 +07:00
|
|
|
if (flags & I915_SHRINK_BOUND) {
|
|
|
|
wakeref = intel_runtime_pm_get_if_in_use(i915);
|
|
|
|
if (!wakeref)
|
|
|
|
flags &= ~I915_SHRINK_BOUND;
|
|
|
|
}
|
2016-05-02 15:40:28 +07:00
|
|
|
|
2015-03-18 16:46:04 +07:00
|
|
|
/*
|
|
|
|
* As we may completely rewrite the (un)bound list whilst unbinding
|
|
|
|
* (due to retiring requests) we have to strictly process only
|
|
|
|
* one element of the list at the time, and recheck the list
|
|
|
|
* on every iteration.
|
|
|
|
*
|
|
|
|
* In particular, we must hold a reference whilst removing the
|
|
|
|
* object as we may end up waiting for and/or retiring the objects.
|
|
|
|
* This might release the final reference (held by the active list)
|
|
|
|
* and result in the object being freed from under us. This is
|
|
|
|
* similar to the precautions the eviction code must take whilst
|
|
|
|
* removing objects.
|
|
|
|
*
|
|
|
|
* Also note that although these lists do not hold a reference to
|
|
|
|
* the object we can safely grab one here: The final object
|
|
|
|
* unreferencing and the bound_list are both protected by the
|
|
|
|
* dev->struct_mutex and so we won't ever be able to observe an
|
|
|
|
* object on the bound_list with a reference count equals 0.
|
|
|
|
*/
|
|
|
|
for (phase = phases; phase->list; phase++) {
|
|
|
|
struct list_head still_in_list;
|
2016-07-26 18:01:51 +07:00
|
|
|
struct drm_i915_gem_object *obj;
|
2015-03-18 16:46:04 +07:00
|
|
|
|
|
|
|
if ((flags & phase->bit) == 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&still_in_list);
|
2017-10-16 18:40:37 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We serialize our access to unreferenced objects through
|
|
|
|
* the use of the struct_mutex. While the objects are not
|
|
|
|
* yet freed (due to RCU then a workqueue) we still want
|
|
|
|
* to be able to shrink their pages, so they remain on
|
|
|
|
* the unbound/bound list until actually freed.
|
|
|
|
*/
|
2017-11-23 18:53:38 +07:00
|
|
|
spin_lock(&i915->mm.obj_lock);
|
2016-07-26 18:01:51 +07:00
|
|
|
while (count < target &&
|
|
|
|
(obj = list_first_entry_or_null(phase->list,
|
|
|
|
typeof(*obj),
|
2017-10-16 18:40:37 +07:00
|
|
|
mm.link))) {
|
|
|
|
list_move_tail(&obj->mm.link, &still_in_list);
|
2015-03-18 16:46:04 +07:00
|
|
|
|
|
|
|
if (flags & I915_SHRINK_PURGEABLE &&
|
2016-10-28 19:58:35 +07:00
|
|
|
obj->mm.madv != I915_MADV_DONTNEED)
|
2015-03-18 16:46:04 +07:00
|
|
|
continue;
|
|
|
|
|
2016-04-08 18:11:12 +07:00
|
|
|
if (flags & I915_SHRINK_VMAPS &&
|
2016-10-28 19:58:35 +07:00
|
|
|
!is_vmalloc_addr(obj->mm.mapping))
|
2016-04-08 18:11:12 +07:00
|
|
|
continue;
|
|
|
|
|
2016-10-12 19:48:24 +07:00
|
|
|
if (!(flags & I915_SHRINK_ACTIVE) &&
|
|
|
|
(i915_gem_object_is_active(obj) ||
|
2017-03-01 22:41:28 +07:00
|
|
|
i915_gem_object_is_framebuffer(obj)))
|
2015-10-01 18:18:29 +07:00
|
|
|
continue;
|
|
|
|
|
2015-12-04 22:58:54 +07:00
|
|
|
if (!can_release_pages(obj))
|
|
|
|
continue;
|
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
spin_unlock(&i915->mm.obj_lock);
|
2017-10-16 18:40:37 +07:00
|
|
|
|
2016-10-28 19:58:37 +07:00
|
|
|
if (unsafe_drop_pages(obj)) {
|
2016-10-31 19:40:48 +07:00
|
|
|
/* May arrive from get_pages on another bo */
|
|
|
|
mutex_lock_nested(&obj->mm.lock,
|
2016-11-01 19:11:34 +07:00
|
|
|
I915_MM_SHRINKER);
|
2017-10-14 03:26:13 +07:00
|
|
|
if (!i915_gem_object_has_pages(obj)) {
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 18:55:39 +07:00
|
|
|
__start_writeback(obj, flags);
|
2016-10-28 19:58:37 +07:00
|
|
|
count += obj->base.size >> PAGE_SHIFT;
|
|
|
|
}
|
|
|
|
mutex_unlock(&obj->mm.lock);
|
|
|
|
}
|
2017-10-14 03:26:18 +07:00
|
|
|
scanned += obj->base.size >> PAGE_SHIFT;
|
2017-10-16 18:40:37 +07:00
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
spin_lock(&i915->mm.obj_lock);
|
2015-03-18 16:46:04 +07:00
|
|
|
}
|
2016-11-01 15:48:43 +07:00
|
|
|
list_splice_tail(&still_in_list, phase->list);
|
2017-11-23 18:53:38 +07:00
|
|
|
spin_unlock(&i915->mm.obj_lock);
|
2015-03-18 16:46:04 +07:00
|
|
|
}
|
|
|
|
|
2016-05-02 15:40:28 +07:00
|
|
|
if (flags & I915_SHRINK_BOUND)
|
2019-01-14 21:21:18 +07:00
|
|
|
intel_runtime_pm_put(i915, wakeref);
|
2016-05-02 15:40:28 +07:00
|
|
|
|
2018-02-21 16:56:36 +07:00
|
|
|
i915_retire_requests(i915);
|
2016-10-28 19:58:37 +07:00
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
shrinker_unlock(i915, unlock);
|
2015-10-01 18:18:27 +07:00
|
|
|
|
2017-09-07 06:19:30 +07:00
|
|
|
if (nr_scanned)
|
|
|
|
*nr_scanned += scanned;
|
2015-03-18 16:46:04 +07:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2015-03-18 20:47:59 +07:00
|
|
|
/**
|
2015-10-06 19:47:55 +07:00
|
|
|
* i915_gem_shrink_all - Shrink buffer object caches completely
|
2017-11-23 18:53:38 +07:00
|
|
|
* @i915: i915 device
|
2015-03-18 20:47:59 +07:00
|
|
|
*
|
|
|
|
* This is a simple wraper around i915_gem_shrink() to aggressively shrink all
|
|
|
|
* caches completely. It also first waits for and retires all outstanding
|
|
|
|
* requests to also be able to release backing storage for active objects.
|
|
|
|
*
|
|
|
|
* This should only be used in code to intentionally quiescent the gpu or as a
|
|
|
|
* last-ditch effort when memory seems to have run out.
|
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* The number of pages of backing storage actually released.
|
|
|
|
*/
|
2017-11-23 18:53:38 +07:00
|
|
|
unsigned long i915_gem_shrink_all(struct drm_i915_private *i915)
|
2015-03-18 16:46:04 +07:00
|
|
|
{
|
2019-01-14 21:21:18 +07:00
|
|
|
intel_wakeref_t wakeref;
|
2019-01-14 21:21:23 +07:00
|
|
|
unsigned long freed = 0;
|
drm/i915: Enable lockless lookup of request tracking via RCU
If we enable RCU for the requests (providing a grace period where we can
inspect a "dead" request before it is freed), we can allow callers to
carefully perform lockless lookup of an active request.
However, by enabling deferred freeing of requests, we can potentially
hog a lot of memory when dealing with tens of thousands of requests per
second - with a quick insertion of a synchronize_rcu() inside our
shrinker callback, that issue disappears.
v2: Currently, it is our responsibility to handle reclaim i.e. to avoid
hogging memory with the delayed slab frees. At the moment, we wait for a
grace period in the shrinker, and block for all RCU callbacks on oom.
Suggested alternatives focus on flushing our RCU callback when we have a
certain number of outstanding request frees, and blocking on that flush
after a second high watermark. (So rather than wait for the system to
run out of memory, we stop issuing requests - both are nondeterministic.)
Paul E. McKenney wrote:
Another approach is synchronize_rcu() after some largish number of
requests. The advantage of this approach is that it throttles the
production of callbacks at the source. The corresponding disadvantage
is that it slows things up.
Another approach is to use call_rcu(), but if the previous call_rcu()
is still in flight, block waiting for it. Yet another approach is
the get_state_synchronize_rcu() / cond_synchronize_rcu() pair. The
idea is to do something like this:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
You would of course do an initial get_state_synchronize_rcu() to
get things going. This would not block unless there was less than
one grace period's worth of time between invocations. But this
assumes a busy system, where there is almost always a grace period
in flight. But you can make that happen as follows:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
call_rcu(&my_rcu_head, noop_function);
Note that you need additional code to make sure that the old callback
has completed before doing a new one. Setting and clearing a flag
with appropriate memory ordering control suffices (e.g,. smp_load_acquire()
and smp_store_release()).
v3: More comments on compiler and processor order of operations within
the RCU lookup and discover we can use rcu_access_pointer() here instead.
v4: Wrap i915_gem_active_get_rcu() to take the rcu_read_lock itself.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Goel, Akash" <akash.goel@intel.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1470324762-2545-25-git-send-email-chris@chris-wilson.co.uk
2016-08-04 22:32:41 +07:00
|
|
|
|
2019-01-14 21:21:23 +07:00
|
|
|
with_intel_runtime_pm(i915, wakeref) {
|
|
|
|
freed = i915_gem_shrink(i915, -1UL, NULL,
|
|
|
|
I915_SHRINK_BOUND |
|
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_ACTIVE);
|
|
|
|
}
|
2017-02-08 17:47:10 +07:00
|
|
|
|
drm/i915: Enable lockless lookup of request tracking via RCU
If we enable RCU for the requests (providing a grace period where we can
inspect a "dead" request before it is freed), we can allow callers to
carefully perform lockless lookup of an active request.
However, by enabling deferred freeing of requests, we can potentially
hog a lot of memory when dealing with tens of thousands of requests per
second - with a quick insertion of a synchronize_rcu() inside our
shrinker callback, that issue disappears.
v2: Currently, it is our responsibility to handle reclaim i.e. to avoid
hogging memory with the delayed slab frees. At the moment, we wait for a
grace period in the shrinker, and block for all RCU callbacks on oom.
Suggested alternatives focus on flushing our RCU callback when we have a
certain number of outstanding request frees, and blocking on that flush
after a second high watermark. (So rather than wait for the system to
run out of memory, we stop issuing requests - both are nondeterministic.)
Paul E. McKenney wrote:
Another approach is synchronize_rcu() after some largish number of
requests. The advantage of this approach is that it throttles the
production of callbacks at the source. The corresponding disadvantage
is that it slows things up.
Another approach is to use call_rcu(), but if the previous call_rcu()
is still in flight, block waiting for it. Yet another approach is
the get_state_synchronize_rcu() / cond_synchronize_rcu() pair. The
idea is to do something like this:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
You would of course do an initial get_state_synchronize_rcu() to
get things going. This would not block unless there was less than
one grace period's worth of time between invocations. But this
assumes a busy system, where there is almost always a grace period
in flight. But you can make that happen as follows:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
call_rcu(&my_rcu_head, noop_function);
Note that you need additional code to make sure that the old callback
has completed before doing a new one. Setting and clearing a flag
with appropriate memory ordering control suffices (e.g,. smp_load_acquire()
and smp_store_release()).
v3: More comments on compiler and processor order of operations within
the RCU lookup and discover we can use rcu_access_pointer() here instead.
v4: Wrap i915_gem_active_get_rcu() to take the rcu_read_lock itself.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Goel, Akash" <akash.goel@intel.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1470324762-2545-25-git-send-email-chris@chris-wilson.co.uk
2016-08-04 22:32:41 +07:00
|
|
|
return freed;
|
2015-03-18 16:46:04 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned long
|
|
|
|
i915_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc)
|
|
|
|
{
|
2017-10-14 03:26:19 +07:00
|
|
|
struct drm_i915_private *i915 =
|
2015-03-18 16:46:04 +07:00
|
|
|
container_of(shrinker, struct drm_i915_private, mm.shrinker);
|
|
|
|
struct drm_i915_gem_object *obj;
|
2017-10-14 03:26:19 +07:00
|
|
|
unsigned long num_objects = 0;
|
2017-10-16 18:40:37 +07:00
|
|
|
unsigned long count = 0;
|
2016-07-01 23:23:10 +07:00
|
|
|
|
2017-10-14 03:26:19 +07:00
|
|
|
spin_lock(&i915->mm.obj_lock);
|
|
|
|
list_for_each_entry(obj, &i915->mm.unbound_list, mm.link)
|
|
|
|
if (can_release_pages(obj)) {
|
2015-03-18 16:46:04 +07:00
|
|
|
count += obj->base.size >> PAGE_SHIFT;
|
2017-10-14 03:26:19 +07:00
|
|
|
num_objects++;
|
|
|
|
}
|
2015-03-18 16:46:04 +07:00
|
|
|
|
2017-10-14 03:26:19 +07:00
|
|
|
list_for_each_entry(obj, &i915->mm.bound_list, mm.link)
|
|
|
|
if (!i915_gem_object_is_active(obj) && can_release_pages(obj)) {
|
2015-03-18 16:46:04 +07:00
|
|
|
count += obj->base.size >> PAGE_SHIFT;
|
2017-10-14 03:26:19 +07:00
|
|
|
num_objects++;
|
|
|
|
}
|
|
|
|
spin_unlock(&i915->mm.obj_lock);
|
|
|
|
|
|
|
|
/* Update our preferred vmscan batch size for the next pass.
|
|
|
|
* Our rough guess for an effective batch size is roughly 2
|
|
|
|
* available GEM objects worth of pages. That is we don't want
|
|
|
|
* the shrinker to fire, until it is worth the cost of freeing an
|
|
|
|
* entire GEM object.
|
|
|
|
*/
|
|
|
|
if (num_objects) {
|
|
|
|
unsigned long avg = 2 * count / num_objects;
|
|
|
|
|
|
|
|
i915->mm.shrinker.batch =
|
|
|
|
max((i915->mm.shrinker.batch + avg) >> 1,
|
|
|
|
128ul /* default SHRINK_BATCH */);
|
|
|
|
}
|
2015-03-18 16:46:04 +07:00
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned long
|
|
|
|
i915_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc)
|
|
|
|
{
|
2017-11-23 18:53:38 +07:00
|
|
|
struct drm_i915_private *i915 =
|
2015-03-18 16:46:04 +07:00
|
|
|
container_of(shrinker, struct drm_i915_private, mm.shrinker);
|
|
|
|
unsigned long freed;
|
|
|
|
bool unlock;
|
|
|
|
|
2017-09-07 06:19:30 +07:00
|
|
|
sc->nr_scanned = 0;
|
|
|
|
|
2019-01-07 18:54:24 +07:00
|
|
|
if (!shrinker_lock(i915, 0, &unlock))
|
2015-03-18 16:46:04 +07:00
|
|
|
return SHRINK_STOP;
|
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
freed = i915_gem_shrink(i915,
|
2015-03-18 16:46:04 +07:00
|
|
|
sc->nr_to_scan,
|
2017-09-07 06:19:30 +07:00
|
|
|
&sc->nr_scanned,
|
2015-03-18 16:46:04 +07:00
|
|
|
I915_SHRINK_BOUND |
|
|
|
|
I915_SHRINK_UNBOUND |
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 18:55:39 +07:00
|
|
|
I915_SHRINK_PURGEABLE |
|
|
|
|
I915_SHRINK_WRITEBACK);
|
2018-01-16 04:24:46 +07:00
|
|
|
if (sc->nr_scanned < sc->nr_to_scan)
|
2017-11-23 18:53:38 +07:00
|
|
|
freed += i915_gem_shrink(i915,
|
2017-09-07 06:19:30 +07:00
|
|
|
sc->nr_to_scan - sc->nr_scanned,
|
|
|
|
&sc->nr_scanned,
|
2015-03-18 16:46:04 +07:00
|
|
|
I915_SHRINK_BOUND |
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 18:55:39 +07:00
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_WRITEBACK);
|
2018-01-16 04:24:46 +07:00
|
|
|
if (sc->nr_scanned < sc->nr_to_scan && current_is_kswapd()) {
|
2019-01-14 21:21:18 +07:00
|
|
|
intel_wakeref_t wakeref;
|
|
|
|
|
2019-01-14 21:21:23 +07:00
|
|
|
with_intel_runtime_pm(i915, wakeref) {
|
|
|
|
freed += i915_gem_shrink(i915,
|
|
|
|
sc->nr_to_scan - sc->nr_scanned,
|
|
|
|
&sc->nr_scanned,
|
|
|
|
I915_SHRINK_ACTIVE |
|
|
|
|
I915_SHRINK_BOUND |
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 18:55:39 +07:00
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_WRITEBACK);
|
2019-01-14 21:21:23 +07:00
|
|
|
}
|
2017-06-01 20:33:29 +07:00
|
|
|
}
|
2017-04-07 17:49:34 +07:00
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
shrinker_unlock(i915, unlock);
|
2015-03-18 16:46:04 +07:00
|
|
|
|
2017-09-07 06:19:30 +07:00
|
|
|
return sc->nr_scanned ? freed : SHRINK_STOP;
|
2015-03-18 16:46:04 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_shrinker_oom(struct notifier_block *nb, unsigned long event, void *ptr)
|
|
|
|
{
|
2017-11-23 18:53:38 +07:00
|
|
|
struct drm_i915_private *i915 =
|
2015-03-18 16:46:04 +07:00
|
|
|
container_of(nb, struct drm_i915_private, mm.oom_notifier);
|
|
|
|
struct drm_i915_gem_object *obj;
|
2016-04-20 18:09:51 +07:00
|
|
|
unsigned long unevictable, bound, unbound, freed_pages;
|
2019-01-14 21:21:18 +07:00
|
|
|
intel_wakeref_t wakeref;
|
2015-03-18 16:46:04 +07:00
|
|
|
|
2019-01-14 21:21:23 +07:00
|
|
|
freed_pages = 0;
|
|
|
|
with_intel_runtime_pm(i915, wakeref)
|
|
|
|
freed_pages += i915_gem_shrink(i915, -1UL, NULL,
|
|
|
|
I915_SHRINK_BOUND |
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 18:55:39 +07:00
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_WRITEBACK);
|
2015-03-18 16:46:04 +07:00
|
|
|
|
|
|
|
/* Because we may be allocating inside our own driver, we cannot
|
|
|
|
* assert that there are no objects with pinned pages that are not
|
|
|
|
* being pointed to by hardware.
|
|
|
|
*/
|
2016-04-20 18:09:51 +07:00
|
|
|
unbound = bound = unevictable = 0;
|
2017-11-23 18:53:38 +07:00
|
|
|
spin_lock(&i915->mm.obj_lock);
|
|
|
|
list_for_each_entry(obj, &i915->mm.unbound_list, mm.link) {
|
2016-04-20 18:09:51 +07:00
|
|
|
if (!can_release_pages(obj))
|
|
|
|
unevictable += obj->base.size >> PAGE_SHIFT;
|
2015-03-18 16:46:04 +07:00
|
|
|
else
|
2016-04-20 18:09:51 +07:00
|
|
|
unbound += obj->base.size >> PAGE_SHIFT;
|
2015-03-18 16:46:04 +07:00
|
|
|
}
|
2017-11-23 18:53:38 +07:00
|
|
|
list_for_each_entry(obj, &i915->mm.bound_list, mm.link) {
|
2016-04-20 18:09:51 +07:00
|
|
|
if (!can_release_pages(obj))
|
|
|
|
unevictable += obj->base.size >> PAGE_SHIFT;
|
2015-03-18 16:46:04 +07:00
|
|
|
else
|
2016-04-20 18:09:51 +07:00
|
|
|
bound += obj->base.size >> PAGE_SHIFT;
|
2015-03-18 16:46:04 +07:00
|
|
|
}
|
2017-11-23 18:53:38 +07:00
|
|
|
spin_unlock(&i915->mm.obj_lock);
|
2015-03-18 16:46:04 +07:00
|
|
|
|
|
|
|
if (freed_pages || unbound || bound)
|
2016-04-20 18:09:51 +07:00
|
|
|
pr_info("Purging GPU memory, %lu pages freed, "
|
|
|
|
"%lu pages still pinned.\n",
|
|
|
|
freed_pages, unevictable);
|
2015-03-18 16:46:04 +07:00
|
|
|
|
|
|
|
*(unsigned long *)ptr += freed_pages;
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
2016-04-04 20:46:43 +07:00
|
|
|
static int
|
|
|
|
i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr)
|
|
|
|
{
|
2017-11-23 18:53:38 +07:00
|
|
|
struct drm_i915_private *i915 =
|
2016-04-04 20:46:43 +07:00
|
|
|
container_of(nb, struct drm_i915_private, mm.vmap_notifier);
|
2016-04-28 15:56:39 +07:00
|
|
|
struct i915_vma *vma, *next;
|
|
|
|
unsigned long freed_pages = 0;
|
2019-01-14 21:21:18 +07:00
|
|
|
intel_wakeref_t wakeref;
|
2017-04-07 17:49:35 +07:00
|
|
|
bool unlock;
|
2016-04-04 20:46:43 +07:00
|
|
|
|
2019-01-09 23:42:04 +07:00
|
|
|
if (!shrinker_lock(i915, 0, &unlock))
|
2016-04-04 20:46:43 +07:00
|
|
|
return NOTIFY_DONE;
|
|
|
|
|
2016-04-28 15:56:39 +07:00
|
|
|
/* Force everything onto the inactive lists */
|
2019-01-09 23:42:04 +07:00
|
|
|
if (i915_gem_wait_for_idle(i915,
|
|
|
|
I915_WAIT_LOCKED,
|
|
|
|
MAX_SCHEDULE_TIMEOUT))
|
2016-04-28 15:56:39 +07:00
|
|
|
goto out;
|
|
|
|
|
2019-01-14 21:21:23 +07:00
|
|
|
with_intel_runtime_pm(i915, wakeref)
|
|
|
|
freed_pages += i915_gem_shrink(i915, -1UL, NULL,
|
|
|
|
I915_SHRINK_BOUND |
|
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_VMAPS);
|
2016-04-28 15:56:39 +07:00
|
|
|
|
|
|
|
/* We also want to clear any cached iomaps as they wrap vmap */
|
2019-01-28 17:23:53 +07:00
|
|
|
mutex_lock(&i915->ggtt.vm.mutex);
|
2016-04-28 15:56:39 +07:00
|
|
|
list_for_each_entry_safe(vma, next,
|
2019-01-28 17:23:52 +07:00
|
|
|
&i915->ggtt.vm.bound_list, vm_link) {
|
2016-04-28 15:56:39 +07:00
|
|
|
unsigned long count = vma->node.size >> PAGE_SHIFT;
|
2019-01-28 17:23:52 +07:00
|
|
|
|
|
|
|
if (!vma->iomap || i915_vma_is_active(vma))
|
|
|
|
continue;
|
|
|
|
|
2019-01-28 17:23:53 +07:00
|
|
|
mutex_unlock(&i915->ggtt.vm.mutex);
|
2019-01-28 17:23:52 +07:00
|
|
|
if (i915_vma_unbind(vma) == 0)
|
2016-04-28 15:56:39 +07:00
|
|
|
freed_pages += count;
|
2019-01-28 17:23:53 +07:00
|
|
|
mutex_lock(&i915->ggtt.vm.mutex);
|
2016-04-28 15:56:39 +07:00
|
|
|
}
|
2019-01-28 17:23:53 +07:00
|
|
|
mutex_unlock(&i915->ggtt.vm.mutex);
|
2016-04-04 20:46:43 +07:00
|
|
|
|
2016-04-28 15:56:39 +07:00
|
|
|
out:
|
2017-11-23 18:53:38 +07:00
|
|
|
shrinker_unlock(i915, unlock);
|
2016-04-04 20:46:43 +07:00
|
|
|
|
|
|
|
*(unsigned long *)ptr += freed_pages;
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
2015-03-18 20:47:59 +07:00
|
|
|
/**
|
2017-11-23 18:53:37 +07:00
|
|
|
* i915_gem_shrinker_register - Register the i915 shrinker
|
2017-11-23 18:53:38 +07:00
|
|
|
* @i915: i915 device
|
2015-03-18 20:47:59 +07:00
|
|
|
*
|
|
|
|
* This function registers and sets up the i915 shrinker and OOM handler.
|
|
|
|
*/
|
2017-11-23 18:53:38 +07:00
|
|
|
void i915_gem_shrinker_register(struct drm_i915_private *i915)
|
2015-03-18 16:46:04 +07:00
|
|
|
{
|
2017-11-23 18:53:38 +07:00
|
|
|
i915->mm.shrinker.scan_objects = i915_gem_shrinker_scan;
|
|
|
|
i915->mm.shrinker.count_objects = i915_gem_shrinker_count;
|
|
|
|
i915->mm.shrinker.seeks = DEFAULT_SEEKS;
|
|
|
|
i915->mm.shrinker.batch = 4096;
|
|
|
|
WARN_ON(register_shrinker(&i915->mm.shrinker));
|
2015-03-18 16:46:04 +07:00
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
i915->mm.oom_notifier.notifier_call = i915_gem_shrinker_oom;
|
|
|
|
WARN_ON(register_oom_notifier(&i915->mm.oom_notifier));
|
2016-04-04 20:46:43 +07:00
|
|
|
|
2017-11-23 18:53:38 +07:00
|
|
|
i915->mm.vmap_notifier.notifier_call = i915_gem_shrinker_vmap;
|
|
|
|
WARN_ON(register_vmap_purge_notifier(&i915->mm.vmap_notifier));
|
2016-01-19 20:26:28 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-11-23 18:53:37 +07:00
|
|
|
* i915_gem_shrinker_unregister - Unregisters the i915 shrinker
|
2017-11-23 18:53:38 +07:00
|
|
|
* @i915: i915 device
|
2016-01-19 20:26:28 +07:00
|
|
|
*
|
|
|
|
* This function unregisters the i915 shrinker and OOM handler.
|
|
|
|
*/
|
2017-11-23 18:53:38 +07:00
|
|
|
void i915_gem_shrinker_unregister(struct drm_i915_private *i915)
|
2016-01-19 20:26:28 +07:00
|
|
|
{
|
2017-11-23 18:53:38 +07:00
|
|
|
WARN_ON(unregister_vmap_purge_notifier(&i915->mm.vmap_notifier));
|
|
|
|
WARN_ON(unregister_oom_notifier(&i915->mm.oom_notifier));
|
|
|
|
unregister_shrinker(&i915->mm.shrinker);
|
2015-03-18 16:46:04 +07:00
|
|
|
}
|
2018-07-11 14:36:02 +07:00
|
|
|
|
2019-01-07 18:54:24 +07:00
|
|
|
void i915_gem_shrinker_taints_mutex(struct drm_i915_private *i915,
|
|
|
|
struct mutex *mutex)
|
2018-07-11 14:36:02 +07:00
|
|
|
{
|
2019-01-07 18:54:24 +07:00
|
|
|
bool unlock = false;
|
|
|
|
|
2018-07-11 14:36:02 +07:00
|
|
|
if (!IS_ENABLED(CONFIG_LOCKDEP))
|
|
|
|
return;
|
|
|
|
|
2019-01-07 18:54:24 +07:00
|
|
|
if (!lockdep_is_held_type(&i915->drm.struct_mutex, -1)) {
|
|
|
|
mutex_acquire(&i915->drm.struct_mutex.dep_map,
|
|
|
|
I915_MM_NORMAL, 0, _RET_IP_);
|
|
|
|
unlock = true;
|
|
|
|
}
|
|
|
|
|
2018-07-11 14:36:02 +07:00
|
|
|
fs_reclaim_acquire(GFP_KERNEL);
|
2019-01-07 18:54:24 +07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* As we invariably rely on the struct_mutex within the shrinker,
|
|
|
|
* but have a complicated recursion dance, taint all the mutexes used
|
|
|
|
* within the shrinker with the struct_mutex. For completeness, we
|
|
|
|
* taint with all subclass of struct_mutex, even though we should
|
|
|
|
* only need tainting by I915_MM_NORMAL to catch possible ABBA
|
|
|
|
* deadlocks from using struct_mutex inside @mutex.
|
|
|
|
*/
|
|
|
|
mutex_acquire(&i915->drm.struct_mutex.dep_map,
|
|
|
|
I915_MM_SHRINKER, 0, _RET_IP_);
|
|
|
|
|
|
|
|
mutex_acquire(&mutex->dep_map, 0, 0, _RET_IP_);
|
|
|
|
mutex_release(&mutex->dep_map, 0, _RET_IP_);
|
|
|
|
|
|
|
|
mutex_release(&i915->drm.struct_mutex.dep_map, 0, _RET_IP_);
|
|
|
|
|
2018-07-11 14:36:02 +07:00
|
|
|
fs_reclaim_release(GFP_KERNEL);
|
2019-01-07 18:54:24 +07:00
|
|
|
|
|
|
|
if (unlock)
|
|
|
|
mutex_release(&i915->drm.struct_mutex.dep_map, 0, _RET_IP_);
|
2018-07-11 14:36:02 +07:00
|
|
|
}
|