2019-05-27 13:55:01 +07:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2008-01-16 06:54:43 +07:00
|
|
|
/*
|
|
|
|
* Flash partitions described by the OF (or flattened) device tree
|
|
|
|
*
|
2010-08-09 02:58:20 +07:00
|
|
|
* Copyright © 2006 MontaVista Software Inc.
|
2008-01-16 06:54:43 +07:00
|
|
|
* Author: Vitaly Wool <vwool@ru.mvista.com>
|
|
|
|
*
|
|
|
|
* Revised to handle newer style flash binding by:
|
2010-08-09 02:58:20 +07:00
|
|
|
* Copyright © 2007 David Gibson, IBM Corporation.
|
2008-01-16 06:54:43 +07:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/of.h>
|
|
|
|
#include <linux/mtd/mtd.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 15:04:11 +07:00
|
|
|
#include <linux/slab.h>
|
2008-01-16 06:54:43 +07:00
|
|
|
#include <linux/mtd/partitions.h>
|
|
|
|
|
2013-08-05 18:14:38 +07:00
|
|
|
static bool node_has_compatible(struct device_node *pp)
|
|
|
|
{
|
|
|
|
return of_get_property(pp, "compatible", NULL);
|
|
|
|
}
|
|
|
|
|
2018-03-14 19:10:43 +07:00
|
|
|
static int parse_fixed_partitions(struct mtd_info *master,
|
|
|
|
const struct mtd_partition **pparts,
|
|
|
|
struct mtd_part_parser_data *data)
|
2011-05-30 00:32:33 +07:00
|
|
|
{
|
2015-12-05 06:25:13 +07:00
|
|
|
struct mtd_partition *parts;
|
2015-08-18 22:34:09 +07:00
|
|
|
struct device_node *mtd_node;
|
|
|
|
struct device_node *ofpart_node;
|
2008-01-16 06:54:43 +07:00
|
|
|
const char *partname;
|
|
|
|
struct device_node *pp;
|
2015-08-18 22:34:09 +07:00
|
|
|
int nr_parts, i, ret = 0;
|
|
|
|
bool dedicated = true;
|
2008-01-16 06:54:43 +07:00
|
|
|
|
2011-05-30 04:05:33 +07:00
|
|
|
|
2015-10-31 10:33:29 +07:00
|
|
|
/* Pull of_node from the master device node */
|
|
|
|
mtd_node = mtd_get_of_node(master);
|
2015-08-18 22:34:09 +07:00
|
|
|
if (!mtd_node)
|
2011-05-30 04:05:33 +07:00
|
|
|
return 0;
|
|
|
|
|
2015-08-18 22:34:09 +07:00
|
|
|
ofpart_node = of_get_child_by_name(mtd_node, "partitions");
|
|
|
|
if (!ofpart_node) {
|
2015-12-04 05:26:52 +07:00
|
|
|
/*
|
|
|
|
* We might get here even when ofpart isn't used at all (e.g.,
|
|
|
|
* when using another parser), so don't be louder than
|
|
|
|
* KERN_DEBUG
|
|
|
|
*/
|
2017-07-19 04:43:17 +07:00
|
|
|
pr_debug("%s: 'partitions' subnode not found on %pOF. Trying to parse direct subnodes as partitions.\n",
|
|
|
|
master->name, mtd_node);
|
2015-08-18 22:34:09 +07:00
|
|
|
ofpart_node = mtd_node;
|
|
|
|
dedicated = false;
|
2015-12-04 05:47:32 +07:00
|
|
|
} else if (!of_device_is_compatible(ofpart_node, "fixed-partitions")) {
|
|
|
|
/* The 'partitions' subnode might be used by another parser */
|
|
|
|
return 0;
|
2015-08-18 22:34:09 +07:00
|
|
|
}
|
|
|
|
|
2008-01-16 06:54:43 +07:00
|
|
|
/* First count the subnodes */
|
|
|
|
nr_parts = 0;
|
2015-08-18 22:34:09 +07:00
|
|
|
for_each_child_of_node(ofpart_node, pp) {
|
|
|
|
if (!dedicated && node_has_compatible(pp))
|
2013-08-05 18:14:38 +07:00
|
|
|
continue;
|
|
|
|
|
2008-01-16 06:54:43 +07:00
|
|
|
nr_parts++;
|
2013-08-05 18:14:38 +07:00
|
|
|
}
|
2008-01-16 06:54:43 +07:00
|
|
|
|
|
|
|
if (nr_parts == 0)
|
|
|
|
return 0;
|
|
|
|
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 04:03:40 +07:00
|
|
|
parts = kcalloc(nr_parts, sizeof(*parts), GFP_KERNEL);
|
2015-12-05 06:25:13 +07:00
|
|
|
if (!parts)
|
2008-01-16 06:54:43 +07:00
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
i = 0;
|
2015-08-18 22:34:09 +07:00
|
|
|
for_each_child_of_node(ofpart_node, pp) {
|
2010-10-01 14:06:08 +07:00
|
|
|
const __be32 *reg;
|
2008-01-16 06:54:43 +07:00
|
|
|
int len;
|
2013-02-22 05:29:45 +07:00
|
|
|
int a_cells, s_cells;
|
2008-01-16 06:54:43 +07:00
|
|
|
|
2015-08-18 22:34:09 +07:00
|
|
|
if (!dedicated && node_has_compatible(pp))
|
2013-08-05 18:14:38 +07:00
|
|
|
continue;
|
|
|
|
|
2009-08-25 20:52:41 +07:00
|
|
|
reg = of_get_property(pp, "reg", &len);
|
|
|
|
if (!reg) {
|
2015-08-18 22:34:09 +07:00
|
|
|
if (dedicated) {
|
2017-07-19 04:43:17 +07:00
|
|
|
pr_debug("%s: ofpart partition %pOF (%pOF) missing reg property.\n",
|
|
|
|
master->name, pp,
|
|
|
|
mtd_node);
|
2015-08-18 22:34:09 +07:00
|
|
|
goto ofpart_fail;
|
|
|
|
} else {
|
|
|
|
nr_parts--;
|
|
|
|
continue;
|
|
|
|
}
|
2009-01-23 23:18:05 +07:00
|
|
|
}
|
|
|
|
|
2013-02-22 05:29:45 +07:00
|
|
|
a_cells = of_n_addr_cells(pp);
|
|
|
|
s_cells = of_n_size_cells(pp);
|
2015-08-18 22:34:09 +07:00
|
|
|
if (len / 4 != a_cells + s_cells) {
|
2017-07-19 04:43:17 +07:00
|
|
|
pr_debug("%s: ofpart partition %pOF (%pOF) error parsing reg property.\n",
|
|
|
|
master->name, pp,
|
|
|
|
mtd_node);
|
2015-08-18 22:34:09 +07:00
|
|
|
goto ofpart_fail;
|
|
|
|
}
|
|
|
|
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].offset = of_read_number(reg, a_cells);
|
|
|
|
parts[i].size = of_read_number(reg + a_cells, s_cells);
|
2017-02-09 17:50:24 +07:00
|
|
|
parts[i].of_node = pp;
|
2008-01-16 06:54:43 +07:00
|
|
|
|
|
|
|
partname = of_get_property(pp, "label", &len);
|
|
|
|
if (!partname)
|
|
|
|
partname = of_get_property(pp, "name", &len);
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].name = partname;
|
2008-01-16 06:54:43 +07:00
|
|
|
|
|
|
|
if (of_get_property(pp, "read-only", &len))
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].mask_flags |= MTD_WRITEABLE;
|
2012-11-15 05:11:32 +07:00
|
|
|
|
|
|
|
if (of_get_property(pp, "lock", &len))
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].mask_flags |= MTD_POWERUP_LOCK;
|
2008-01-16 06:54:43 +07:00
|
|
|
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
2015-08-18 22:34:09 +07:00
|
|
|
if (!nr_parts)
|
|
|
|
goto ofpart_none;
|
2009-08-25 20:52:41 +07:00
|
|
|
|
2015-12-05 06:25:13 +07:00
|
|
|
*pparts = parts;
|
2008-01-16 06:54:43 +07:00
|
|
|
return nr_parts;
|
2015-08-18 22:34:09 +07:00
|
|
|
|
|
|
|
ofpart_fail:
|
2017-07-19 04:43:17 +07:00
|
|
|
pr_err("%s: error parsing ofpart partition %pOF (%pOF)\n",
|
|
|
|
master->name, pp, mtd_node);
|
2015-08-18 22:34:09 +07:00
|
|
|
ret = -EINVAL;
|
|
|
|
ofpart_none:
|
|
|
|
of_node_put(pp);
|
2015-12-05 06:25:13 +07:00
|
|
|
kfree(parts);
|
2015-08-18 22:34:09 +07:00
|
|
|
return ret;
|
2008-01-16 06:54:43 +07:00
|
|
|
}
|
2008-04-14 21:19:46 +07:00
|
|
|
|
2018-03-14 19:10:44 +07:00
|
|
|
static const struct of_device_id parse_ofpart_match_table[] = {
|
|
|
|
{ .compatible = "fixed-partitions" },
|
|
|
|
{},
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, parse_ofpart_match_table);
|
|
|
|
|
2011-05-30 00:32:33 +07:00
|
|
|
static struct mtd_part_parser ofpart_parser = {
|
2018-03-14 19:10:43 +07:00
|
|
|
.parse_fn = parse_fixed_partitions,
|
|
|
|
.name = "fixed-partitions",
|
2018-03-14 19:10:44 +07:00
|
|
|
.of_match_table = parse_ofpart_match_table,
|
2011-05-30 00:32:33 +07:00
|
|
|
};
|
|
|
|
|
2011-05-30 04:26:17 +07:00
|
|
|
static int parse_ofoldpart_partitions(struct mtd_info *master,
|
2015-12-05 06:25:14 +07:00
|
|
|
const struct mtd_partition **pparts,
|
2011-05-30 04:26:17 +07:00
|
|
|
struct mtd_part_parser_data *data)
|
|
|
|
{
|
2015-12-05 06:25:13 +07:00
|
|
|
struct mtd_partition *parts;
|
2011-05-30 04:26:17 +07:00
|
|
|
struct device_node *dp;
|
|
|
|
int i, plen, nr_parts;
|
|
|
|
const struct {
|
|
|
|
__be32 offset, len;
|
|
|
|
} *part;
|
|
|
|
const char *names;
|
|
|
|
|
2015-10-31 10:33:29 +07:00
|
|
|
/* Pull of_node from the master device node */
|
|
|
|
dp = mtd_get_of_node(master);
|
2011-05-30 04:26:17 +07:00
|
|
|
if (!dp)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
part = of_get_property(dp, "partitions", &plen);
|
|
|
|
if (!part)
|
|
|
|
return 0; /* No partitions found */
|
|
|
|
|
2017-07-19 04:43:17 +07:00
|
|
|
pr_warn("Device tree uses obsolete partition map binding: %pOF\n", dp);
|
2011-05-30 04:26:17 +07:00
|
|
|
|
|
|
|
nr_parts = plen / sizeof(part[0]);
|
|
|
|
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 04:03:40 +07:00
|
|
|
parts = kcalloc(nr_parts, sizeof(*parts), GFP_KERNEL);
|
2015-12-05 06:25:13 +07:00
|
|
|
if (!parts)
|
2011-05-30 04:26:17 +07:00
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
names = of_get_property(dp, "partition-names", &plen);
|
|
|
|
|
|
|
|
for (i = 0; i < nr_parts; i++) {
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].offset = be32_to_cpu(part->offset);
|
|
|
|
parts[i].size = be32_to_cpu(part->len) & ~1;
|
2011-05-30 04:26:17 +07:00
|
|
|
/* bit 0 set signifies read only partition */
|
|
|
|
if (be32_to_cpu(part->len) & 1)
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].mask_flags = MTD_WRITEABLE;
|
2011-05-30 04:26:17 +07:00
|
|
|
|
|
|
|
if (names && (plen > 0)) {
|
|
|
|
int len = strlen(names) + 1;
|
|
|
|
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].name = names;
|
2011-05-30 04:26:17 +07:00
|
|
|
plen -= len;
|
|
|
|
names += len;
|
|
|
|
} else {
|
2015-12-05 06:25:13 +07:00
|
|
|
parts[i].name = "unnamed";
|
2011-05-30 04:26:17 +07:00
|
|
|
}
|
|
|
|
|
|
|
|
part++;
|
|
|
|
}
|
|
|
|
|
2015-12-05 06:25:13 +07:00
|
|
|
*pparts = parts;
|
2011-05-30 04:26:17 +07:00
|
|
|
return nr_parts;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct mtd_part_parser ofoldpart_parser = {
|
|
|
|
.parse_fn = parse_ofoldpart_partitions,
|
|
|
|
.name = "ofoldpart",
|
|
|
|
};
|
|
|
|
|
2011-05-30 00:32:33 +07:00
|
|
|
static int __init ofpart_parser_init(void)
|
|
|
|
{
|
2013-12-01 18:01:06 +07:00
|
|
|
register_mtd_parser(&ofpart_parser);
|
|
|
|
register_mtd_parser(&ofoldpart_parser);
|
|
|
|
return 0;
|
2011-05-30 00:32:33 +07:00
|
|
|
}
|
|
|
|
|
2013-01-16 08:12:50 +07:00
|
|
|
static void __exit ofpart_parser_exit(void)
|
|
|
|
{
|
|
|
|
deregister_mtd_parser(&ofpart_parser);
|
|
|
|
deregister_mtd_parser(&ofoldpart_parser);
|
|
|
|
}
|
|
|
|
|
2011-05-30 00:32:33 +07:00
|
|
|
module_init(ofpart_parser_init);
|
2013-01-16 08:12:50 +07:00
|
|
|
module_exit(ofpart_parser_exit);
|
2011-05-30 00:32:33 +07:00
|
|
|
|
2008-04-14 21:19:46 +07:00
|
|
|
MODULE_LICENSE("GPL");
|
2011-06-27 04:02:59 +07:00
|
|
|
MODULE_DESCRIPTION("Parser for MTD partitioning information in device tree");
|
|
|
|
MODULE_AUTHOR("Vitaly Wool, David Gibson");
|
2011-06-27 19:34:46 +07:00
|
|
|
/*
|
|
|
|
* When MTD core cannot find the requested parser, it tries to load the module
|
|
|
|
* with the same name. Since we provide the ofoldpart parser, we should have
|
|
|
|
* the corresponding alias.
|
|
|
|
*/
|
2018-03-14 19:10:43 +07:00
|
|
|
MODULE_ALIAS("fixed-partitions");
|
2011-06-27 19:34:46 +07:00
|
|
|
MODULE_ALIAS("ofoldpart");
|