AuxXxilium/kmod
1
0
Fork 0
mirror of https://github.com/AuxXxilium/kmod.git synced 2024-11-23 23:10:53 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

depmod: output_builtin_alias_bin: free idx on error path

Browse Source 
idx is allocated in the beginning but it's not freed if there is
a failure after the allocation.

Change the error path: return immediately if idx allocation fails
and then free it in both success and error path at the end.

Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
This commit is contained in:
Yauheni Kaliuta 2020-11-29 18:47:36 +02:00 committed by Lucas De Marchi
parent 47807c4cfa
commit bd96d05256
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/depmod.c
View File

@ -2412,10 +2412,8 @@ static int output_builtin_alias_bin(struct depmod *depmod, FILE *out)
return 0;
idx = index_create();
if (idx == NULL) {
ret = -ENOMEM;
goto fail;
}
if (idx == NULL)
return -ENOMEM;
ret = kmod_module_get_builtin(depmod->ctx, &builtin);
if (ret < 0) {
@ -2458,13 +2456,12 @@ static int output_builtin_alias_bin(struct depmod *depmod, FILE *out)
if (count)
index_write(idx, out);
index_destroy(idx);
fail:
if (builtin)
kmod_module_unref_list(builtin);
index_destroy(idx);
return ret;
}