From 89596b75185a478939aa2a70049f2fd0cb1bc3b0 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Fri, 19 Jul 2024 17:12:41 +0100 Subject: [PATCH] libkmod: document KMOD_INDEX_MODULES_BUILTIN_ALIAS in kmod_dump_index() The extra enum was introduced a few years ago, although the (only) function using it did not have it's documentation updated. The commit itself has caused an ABI break with kmod v27, since the KMOD_INDEX_MODULES_BUILTIN value has changed. A search through Google, Github and Arch packages have shown one user of kmod_dump_index() - the only API that uses the enum. In that case and all others, no projects referencing the changed enum were found. Although since recent and/or supported distros use kmod v27 or later we've decided to only update the documentation. Cc: Alexey Gladkov Fixes: b866b21 ("Lookup aliases in the modules.builtin.modinfo") Signed-off-by: Emil Velikov Reviewed-by: Lucas De Marchi Link: https://lore.kernel.org/r/20240719-abi-fixes-v1-1-1e6d99a2846b@gmail.com --- libkmod/libkmod.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libkmod/libkmod.c b/libkmod/libkmod.c index 213b424..fecb8e7 100644 --- a/libkmod/libkmod.c +++ b/libkmod/libkmod.c @@ -971,6 +971,7 @@ KMOD_EXPORT void kmod_unload_resources(struct kmod_ctx *ctx) * KMOD_INDEX_MODULES_DEP: index of module dependencies; * KMOD_INDEX_MODULES_ALIAS: index of module aliases; * KMOD_INDEX_MODULES_SYMBOL: index of symbol aliases; + * KMOD_INDEX_MODULES_BUILTIN_ALIAS: index of builtin module aliases. * KMOD_INDEX_MODULES_BUILTIN: index of builtin module. * @fd: file descriptor to dump index to *