AuxXxilium/kmod
1
0
Fork 0
mirror of https://github.com/AuxXxilium/kmod.git synced 2025-03-10 07:53:48 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

depmod: use ferror and fclose to check for error

Browse Source 
Thanks to hpa for point this out.
This commit is contained in:
Lucas De Marchi 2012-06-15 22:14:00 -03:00
parent b7d830bcc8
commit 3f376cd877
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/depmod.c
View File

@ -2236,8 +2236,7 @@ static int depmod_output(struct depmod *depmod, FILE *out)
for (itr = depfiles; itr->name != NULL; itr++) {
FILE *fp = out;
char tmp[NAME_MAX] = "";
int r;
long eof;
int r, ferr;
if (fp == NULL) {
int flags = O_CREAT | O_TRUNC | O_WRONLY;
@ -2263,8 +2262,8 @@ static int depmod_output(struct depmod *depmod, FILE *out)
if (fp == out)
continue;
eof = ftell(fp);
fclose(fp);
ferr = ferror(fp) | fclose(fp);
if (r < 0) {
if (unlinkat(dfd, tmp, 0) != 0)
ERR("unlinkat(%s, %s): %m\n", dname, tmp);
@ -2283,10 +2282,10 @@ static int depmod_output(struct depmod *depmod, FILE *out)
break;
}
if (eof == EOF) {
if (ferr) {
err = -ENOSPC;
ERR("Could not create index: output truncated: %s\n",
strerror(-err));
ERR("Could not create index '%s'. Output is truncated: %s\n",
itr->name, strerror(-err));
break;
}
}