AuxXxilium/kmod
1
0
Fork 0
mirror of https://github.com/AuxXxilium/kmod.git synced 2024-12-03 21:26:55 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

testsuite: Remove duplicate test

Browse Source 
This partially reverts ad7f175 ("Add test for depmod using search dirs
with same prefix"). Testing it twice in the inverted order doesn't
ensure we get the bug with wrong ordering.

As put by Anssi Hannula <anssi@mageia.org>:

	So the bug is triggered only if the shorter name is higher-prio _and_
	shorter name is traversed first. If the long name is traversed first,
	the bug don't trigger with either "search" directive order (and on my
	"make check" runs this is the case).
This commit is contained in:
Lucas De Marchi 2014-04-06 17:43:19 -03:00
parent 6ca7c0926f
commit 3e68b2c455
5 changed files with 0 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
testsuite/rootfs-pristine/test-depmod/search-order-same-prefix2/etc/depmod.d/search.conf
View File

@ -1 +0,0 @@
search foo foobar built-in

1
testsuite/rootfs-pristine/test-depmod/search-order-same-prefix2/lib/modules/4.4.4/correct-modules.dep
View File

@ -1 +0,0 @@
foo/md5.ko:

BIN
testsuite/rootfs-pristine/test-depmod/search-order-same-prefix2/lib/modules/4.4.4/foo/md5.ko
View File

Binary file not shown.

BIN
testsuite/rootfs-pristine/test-depmod/search-order-same-prefix2/lib/modules/4.4.4/foobar/md5.ko
View File

Binary file not shown.

28
testsuite/test-depmod.c
View File

@ -106,33 +106,6 @@ static DEFINE_TEST(depmod_search_order_same_prefix,
},
});
#define SEARCH_ORDER_SAME_PREFIX2_ROOTFS TESTSUITE_ROOTFS "test-depmod/search-order-same-prefix2"
static noreturn int depmod_search_order_same_prefix2(const struct test *t)
{
const char *progname = ABS_TOP_BUILDDIR "/tools/depmod";
const char *const args[] = {
progname,
NULL,
};
test_spawn_prog(progname, args);
exit(EXIT_FAILURE);
}
static DEFINE_TEST(depmod_search_order_same_prefix2,
.description = "check if depmod honor search order in config with same prefi: "
"the same as depmod_search_order_same_prefix, but in inverse order",
.config = {
[TC_UNAME_R] = "4.4.4",
[TC_ROOTFS] = SEARCH_ORDER_SAME_PREFIX2_ROOTFS,
},
.output = {
.files = (const struct keyval[]) {
{ SEARCH_ORDER_SAME_PREFIX2_ROOTFS "/lib/modules/4.4.4/correct-modules.dep",
SEARCH_ORDER_SAME_PREFIX2_ROOTFS "/lib/modules/4.4.4/modules.dep" },
{ }
},
});
static const struct test *tests[] = {
#ifdef ENABLE_ZLIB
@ -140,7 +113,6 @@ static const struct test *tests[] = {
#endif
&sdepmod_search_order_simple,
&sdepmod_search_order_same_prefix,
&sdepmod_search_order_same_prefix2,
NULL,
};