kmod/libkmod/libkmod-file.c

507 lines
10 KiB
C
Raw Normal View History

2011-12-17 01:08:53 +07:00
/*
* libkmod - interface to kernel module operations
*
2013-01-16 20:27:21 +07:00
* Copyright (C) 2011-2013 ProFUSION embedded systems
2011-12-17 01:08:53 +07:00
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
2011-12-17 01:08:53 +07:00
*/
#include <errno.h>
#include <stdbool.h>
2011-12-17 01:08:53 +07:00
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/types.h>
2011-12-17 01:08:53 +07:00
#include <unistd.h>
#ifdef ENABLE_ZSTD
#include <zstd.h>
#endif
#ifdef ENABLE_XZ
#include <lzma.h>
#endif
2011-12-17 01:08:53 +07:00
#ifdef ENABLE_ZLIB
#include <zlib.h>
#endif
#include <shared/util.h>
#include "libkmod.h"
#include "libkmod-internal.h"
2011-12-17 01:08:53 +07:00
struct kmod_file {
int fd;
enum kmod_file_compression_type compression;
2011-12-17 01:08:53 +07:00
off_t size;
void *memory;
int (*load)(struct kmod_file *file);
2012-01-04 17:19:34 +07:00
const struct kmod_ctx *ctx;
libkmod: cache open file for later access If we are accessing several times the modules and reading some sections by sucessive calls to the functions below, we are incurring in a penalty of having to open, parse the header and close the file. For each function. - kmod_module_get_info() - kmod_module_get_versions() - kmod_module_get_symbols() - kmod_module_get_dependency_symbols() These functions are particularly important to depmod. It calls all of them, for each module. Moreover there's a huge bottleneck in the open operation if we are using compression. Every time we open the module we need to uncompress the file and after getting the information we need we discard the result. This is clearly shown by profiling depmod with perf (record + report), using compressed modules: 64.07% depmod libz.so.1.2.7 [.] 0x00000000000074b8 ◆ 18.18% depmod libz.so.1.2.7 [.] crc32 ▒ 2.42% depmod libz.so.1.2.7 [.] inflate ▒ 1.17% depmod libc-2.16.so [.] __memcpy_ssse3_back ▒ 0.96% depmod [kernel.kallsyms] [k] copy_user_generic_string ▒ 0.89% depmod libc-2.16.so [.] __strcmp_sse42 ▒ 0.82% depmod [kernel.kallsyms] [k] hrtimer_interrupt ▒ 0.77% depmod libc-2.16.so [.] _int_malloc ▒ 0.44% depmod kmod-nolib [.] kmod_elf_get_strings ▒ 0.41% depmod kmod-nolib [.] kmod_elf_get_dependency_symbols ▒ 0.37% depmod kmod-nolib [.] kmod_elf_get_section ▒ 0.36% depmod kmod-nolib [.] kmod_elf_get_symbols ... Average of running depmod 5 times, dropping caches between them, in a slow spinning disk: Before: 12.25 +- 0.20 After: 8.20 +- 0.21 m-i-t: 9.62 +- 0.27 So this patch leads to an improvement of ~33% over unpatched version, ending up with 15% speedup over module-init-tools.
2012-10-18 11:36:33 +07:00
struct kmod_elf *elf;
2011-12-17 01:08:53 +07:00
};
#ifdef ENABLE_ZSTD
static int zstd_read_block(struct kmod_file *file, size_t block_size,
ZSTD_inBuffer *input, size_t *input_capacity)
{
ssize_t rdret;
int ret;
if (*input_capacity < block_size) {
free((void *)input->src);
input->src = malloc(block_size);
if (input->src == NULL) {
ret = -errno;
ERR(file->ctx, "zstd: %m\n");
return ret;
}
*input_capacity = block_size;
}
rdret = read(file->fd, (void *)input->src, block_size);
if (rdret < 0) {
ret = -errno;
ERR(file->ctx, "zstd: %m\n");
return ret;
}
input->pos = 0;
input->size = rdret;
return 0;
}
static int zstd_ensure_outbuffer_space(ZSTD_outBuffer *buffer, size_t min_free)
{
uint8_t *old_buffer = buffer->dst;
int ret = 0;
if (buffer->size - buffer->pos >= min_free)
return 0;
buffer->size += min_free;
buffer->dst = realloc(buffer->dst, buffer->size);
if (buffer->dst == NULL) {
ret = -errno;
free(old_buffer);
}
return ret;
}
static int zstd_decompress_block(struct kmod_file *file, ZSTD_DStream *dstr,
ZSTD_inBuffer *input, ZSTD_outBuffer *output,
size_t *next_block_size)
{
size_t out_buf_min_size = ZSTD_DStreamOutSize();
int ret = 0;
do {
ssize_t dsret;
ret = zstd_ensure_outbuffer_space(output, out_buf_min_size);
if (ret) {
ERR(file->ctx, "zstd: %s\n", strerror(-ret));
break;
}
dsret = ZSTD_decompressStream(dstr, output, input);
if (ZSTD_isError(dsret)) {
ret = -EINVAL;
ERR(file->ctx, "zstd: %s\n", ZSTD_getErrorName(dsret));
break;
}
if (dsret > 0)
*next_block_size = (size_t)dsret;
} while (input->pos < input->size
|| output->pos > output->size
|| output->size - output->pos < out_buf_min_size);
return ret;
}
static int load_zstd(struct kmod_file *file)
{
ZSTD_DStream *dstr;
size_t next_block_size;
size_t zst_inb_capacity = 0;
ZSTD_inBuffer zst_inb = { 0 };
ZSTD_outBuffer zst_outb = { 0 };
int ret;
dstr = ZSTD_createDStream();
if (dstr == NULL) {
ret = -EINVAL;
ERR(file->ctx, "zstd: Failed to create decompression stream\n");
goto out;
}
next_block_size = ZSTD_initDStream(dstr);
while (true) {
ret = zstd_read_block(file, next_block_size, &zst_inb,
&zst_inb_capacity);
if (ret != 0)
goto out;
if (zst_inb.size == 0) /* EOF */
break;
ret = zstd_decompress_block(file, dstr, &zst_inb, &zst_outb,
&next_block_size);
if (ret != 0)
goto out;
}
ZSTD_freeDStream(dstr);
free((void *)zst_inb.src);
file->memory = zst_outb.dst;
file->size = zst_outb.pos;
return 0;
out:
if (dstr != NULL)
ZSTD_freeDStream(dstr);
free((void *)zst_inb.src);
free((void *)zst_outb.dst);
return ret;
}
static const char magic_zstd[] = {0x28, 0xB5, 0x2F, 0xFD};
#endif
#ifdef ENABLE_XZ
static void xz_uncompress_belch(struct kmod_file *file, lzma_ret ret)
{
switch (ret) {
case LZMA_MEM_ERROR:
ERR(file->ctx, "xz: %s\n", strerror(ENOMEM));
break;
case LZMA_FORMAT_ERROR:
ERR(file->ctx, "xz: File format not recognized\n");
break;
case LZMA_OPTIONS_ERROR:
ERR(file->ctx, "xz: Unsupported compression options\n");
break;
case LZMA_DATA_ERROR:
ERR(file->ctx, "xz: File is corrupt\n");
break;
case LZMA_BUF_ERROR:
ERR(file->ctx, "xz: Unexpected end of input\n");
break;
default:
ERR(file->ctx, "xz: Internal error (bug)\n");
break;
}
}
static int xz_uncompress(lzma_stream *strm, struct kmod_file *file)
{
uint8_t in_buf[BUFSIZ], out_buf[BUFSIZ];
lzma_action action = LZMA_RUN;
lzma_ret ret;
void *p = NULL;
size_t total = 0;
strm->avail_in = 0;
strm->next_out = out_buf;
strm->avail_out = sizeof(out_buf);
while (true) {
if (strm->avail_in == 0) {
ssize_t rdret = read(file->fd, in_buf, sizeof(in_buf));
if (rdret < 0) {
ret = -errno;
goto out;
}
strm->next_in = in_buf;
strm->avail_in = rdret;
if (rdret == 0)
action = LZMA_FINISH;
}
ret = lzma_code(strm, action);
if (strm->avail_out == 0 || ret != LZMA_OK) {
size_t write_size = BUFSIZ - strm->avail_out;
char *tmp = realloc(p, total + write_size);
if (tmp == NULL) {
ret = -errno;
goto out;
}
memcpy(tmp + total, out_buf, write_size);
total += write_size;
p = tmp;
strm->next_out = out_buf;
strm->avail_out = BUFSIZ;
}
if (ret == LZMA_STREAM_END)
break;
if (ret != LZMA_OK) {
xz_uncompress_belch(file, ret);
ret = -EINVAL;
goto out;
}
}
file->memory = p;
file->size = total;
return 0;
out:
free(p);
return ret;
}
static int load_xz(struct kmod_file *file)
{
lzma_stream strm = LZMA_STREAM_INIT;
lzma_ret lzret;
int ret;
lzret = lzma_stream_decoder(&strm, UINT64_MAX, LZMA_CONCATENATED);
if (lzret == LZMA_MEM_ERROR) {
ERR(file->ctx, "xz: %s\n", strerror(ENOMEM));
return -ENOMEM;
} else if (lzret != LZMA_OK) {
ERR(file->ctx, "xz: Internal error (bug)\n");
return -EINVAL;
}
ret = xz_uncompress(&strm, file);
lzma_end(&strm);
return ret;
}
static const char magic_xz[] = {0xfd, '7', 'z', 'X', 'Z', 0};
#endif
#ifdef ENABLE_ZLIB
#define READ_STEP (4 * 1024 * 1024)
static int load_zlib(struct kmod_file *file)
2011-12-17 01:08:53 +07:00
{
int err = 0;
off_t did = 0, total = 0;
2013-11-18 20:43:10 +07:00
_cleanup_free_ unsigned char *p = NULL;
gzFile gzf;
int gzfd;
2011-12-17 01:08:53 +07:00
errno = 0;
gzfd = fcntl(file->fd, F_DUPFD_CLOEXEC, 3);
if (gzfd < 0)
return -errno;
gzf = gzdopen(gzfd, "rb"); /* takes ownership of the fd */
if (gzf == NULL) {
close(gzfd);
2011-12-17 01:08:53 +07:00
return -errno;
}
2011-12-17 01:08:53 +07:00
for (;;) {
int r;
if (did == total) {
void *tmp = realloc(p, total + READ_STEP);
if (tmp == NULL) {
err = -errno;
goto error;
}
total += READ_STEP;
p = tmp;
}
r = gzread(gzf, p + did, total - did);
2011-12-17 01:08:53 +07:00
if (r == 0)
break;
else if (r < 0) {
int gzerr;
const char *gz_errmsg = gzerror(gzf, &gzerr);
ERR(file->ctx, "gzip: %s\n", gz_errmsg);
/* gzip might not set errno here */
err = gzerr == Z_ERRNO ? -errno : -EINVAL;
2011-12-17 01:08:53 +07:00
goto error;
}
did += r;
}
file->memory = p;
file->size = did;
2013-11-18 20:43:10 +07:00
p = NULL;
gzclose(gzf);
2011-12-17 01:08:53 +07:00
return 0;
2013-11-18 20:43:10 +07:00
2011-12-17 01:08:53 +07:00
error:
gzclose(gzf); /* closes the gzfd */
2011-12-17 01:08:53 +07:00
return err;
}
static const char magic_zlib[] = {0x1f, 0x8b};
#endif
static const struct comp_type {
size_t magic_size;
enum kmod_file_compression_type compression;
const char *magic_bytes;
int (*load)(struct kmod_file *file);
} comp_types[] = {
#ifdef ENABLE_ZSTD
{sizeof(magic_zstd), KMOD_FILE_COMPRESSION_ZSTD, magic_zstd, load_zstd},
#endif
#ifdef ENABLE_XZ
{sizeof(magic_xz), KMOD_FILE_COMPRESSION_XZ, magic_xz, load_xz},
#endif
#ifdef ENABLE_ZLIB
{sizeof(magic_zlib), KMOD_FILE_COMPRESSION_ZLIB, magic_zlib, load_zlib},
#endif
{0, KMOD_FILE_COMPRESSION_NONE, NULL, NULL}
};
static int load_reg(struct kmod_file *file)
2011-12-17 01:08:53 +07:00
{
struct stat st;
if (fstat(file->fd, &st) < 0)
return -errno;
2011-12-17 01:08:53 +07:00
file->size = st.st_size;
file->memory = mmap(NULL, file->size, PROT_READ, MAP_PRIVATE,
file->fd, 0);
if (file->memory == MAP_FAILED) {
file->memory = NULL;
return -errno;
}
2011-12-17 01:08:53 +07:00
return 0;
}
libkmod: cache open file for later access If we are accessing several times the modules and reading some sections by sucessive calls to the functions below, we are incurring in a penalty of having to open, parse the header and close the file. For each function. - kmod_module_get_info() - kmod_module_get_versions() - kmod_module_get_symbols() - kmod_module_get_dependency_symbols() These functions are particularly important to depmod. It calls all of them, for each module. Moreover there's a huge bottleneck in the open operation if we are using compression. Every time we open the module we need to uncompress the file and after getting the information we need we discard the result. This is clearly shown by profiling depmod with perf (record + report), using compressed modules: 64.07% depmod libz.so.1.2.7 [.] 0x00000000000074b8 ◆ 18.18% depmod libz.so.1.2.7 [.] crc32 ▒ 2.42% depmod libz.so.1.2.7 [.] inflate ▒ 1.17% depmod libc-2.16.so [.] __memcpy_ssse3_back ▒ 0.96% depmod [kernel.kallsyms] [k] copy_user_generic_string ▒ 0.89% depmod libc-2.16.so [.] __strcmp_sse42 ▒ 0.82% depmod [kernel.kallsyms] [k] hrtimer_interrupt ▒ 0.77% depmod libc-2.16.so [.] _int_malloc ▒ 0.44% depmod kmod-nolib [.] kmod_elf_get_strings ▒ 0.41% depmod kmod-nolib [.] kmod_elf_get_dependency_symbols ▒ 0.37% depmod kmod-nolib [.] kmod_elf_get_section ▒ 0.36% depmod kmod-nolib [.] kmod_elf_get_symbols ... Average of running depmod 5 times, dropping caches between them, in a slow spinning disk: Before: 12.25 +- 0.20 After: 8.20 +- 0.21 m-i-t: 9.62 +- 0.27 So this patch leads to an improvement of ~33% over unpatched version, ending up with 15% speedup over module-init-tools.
2012-10-18 11:36:33 +07:00
struct kmod_elf *kmod_file_get_elf(struct kmod_file *file)
{
if (file->elf)
return file->elf;
kmod_file_load_contents(file);
libkmod: cache open file for later access If we are accessing several times the modules and reading some sections by sucessive calls to the functions below, we are incurring in a penalty of having to open, parse the header and close the file. For each function. - kmod_module_get_info() - kmod_module_get_versions() - kmod_module_get_symbols() - kmod_module_get_dependency_symbols() These functions are particularly important to depmod. It calls all of them, for each module. Moreover there's a huge bottleneck in the open operation if we are using compression. Every time we open the module we need to uncompress the file and after getting the information we need we discard the result. This is clearly shown by profiling depmod with perf (record + report), using compressed modules: 64.07% depmod libz.so.1.2.7 [.] 0x00000000000074b8 ◆ 18.18% depmod libz.so.1.2.7 [.] crc32 ▒ 2.42% depmod libz.so.1.2.7 [.] inflate ▒ 1.17% depmod libc-2.16.so [.] __memcpy_ssse3_back ▒ 0.96% depmod [kernel.kallsyms] [k] copy_user_generic_string ▒ 0.89% depmod libc-2.16.so [.] __strcmp_sse42 ▒ 0.82% depmod [kernel.kallsyms] [k] hrtimer_interrupt ▒ 0.77% depmod libc-2.16.so [.] _int_malloc ▒ 0.44% depmod kmod-nolib [.] kmod_elf_get_strings ▒ 0.41% depmod kmod-nolib [.] kmod_elf_get_dependency_symbols ▒ 0.37% depmod kmod-nolib [.] kmod_elf_get_section ▒ 0.36% depmod kmod-nolib [.] kmod_elf_get_symbols ... Average of running depmod 5 times, dropping caches between them, in a slow spinning disk: Before: 12.25 +- 0.20 After: 8.20 +- 0.21 m-i-t: 9.62 +- 0.27 So this patch leads to an improvement of ~33% over unpatched version, ending up with 15% speedup over module-init-tools.
2012-10-18 11:36:33 +07:00
file->elf = kmod_elf_new(file->memory, file->size);
return file->elf;
}
2012-01-04 17:19:34 +07:00
struct kmod_file *kmod_file_open(const struct kmod_ctx *ctx,
const char *filename)
2011-12-17 01:08:53 +07:00
{
struct kmod_file *file = calloc(1, sizeof(struct kmod_file));
const struct comp_type *itr;
size_t magic_size_max = 0;
int err = 0;
2011-12-17 01:08:53 +07:00
if (file == NULL)
return NULL;
file->fd = open(filename, O_RDONLY|O_CLOEXEC);
if (file->fd < 0) {
err = -errno;
goto error;
}
for (itr = comp_types; itr->load != NULL; itr++) {
if (magic_size_max < itr->magic_size)
magic_size_max = itr->magic_size;
}
if (magic_size_max > 0) {
char *buf = alloca(magic_size_max + 1);
ssize_t sz;
2011-12-17 01:08:53 +07:00
if (buf == NULL) {
err = -errno;
goto error;
}
sz = read_str_safe(file->fd, buf, magic_size_max + 1);
lseek(file->fd, 0, SEEK_SET);
if (sz != (ssize_t)magic_size_max) {
if (sz < 0)
err = sz;
else
err = -EINVAL;
goto error;
}
for (itr = comp_types; itr->load != NULL; itr++) {
if (memcmp(buf, itr->magic_bytes, itr->magic_size) == 0) {
file->load = itr->load;
file->compression = itr->compression;
break;
}
}
}
if (file->load == NULL) {
file->load = load_reg;
file->compression = KMOD_FILE_COMPRESSION_NONE;
}
2012-01-04 17:19:34 +07:00
file->ctx = ctx;
error:
2011-12-17 01:08:53 +07:00
if (err < 0) {
if (file->fd >= 0)
close(file->fd);
2011-12-17 01:08:53 +07:00
free(file);
errno = -err;
return NULL;
}
return file;
}
/*
* Callers should just check file->memory got updated
*/
void kmod_file_load_contents(struct kmod_file *file)
{
if (file->memory)
return;
/* The load functions already log possible errors. */
file->load(file);
}
2011-12-17 01:08:53 +07:00
void *kmod_file_get_contents(const struct kmod_file *file)
{
return file->memory;
}
off_t kmod_file_get_size(const struct kmod_file *file)
{
return file->size;
}
libkmod: Use kernel decompression when available With the recent changes to bypass loading the file it's possible to reduce the work in userspace and delegating it to the kernel. Without any compression to illustrate: Before: read(3, "\177ELF\2\1", 6) = 6 lseek(3, 0, SEEK_SET) = 0 newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=238592, ...}, AT_EMPTY_PATH) = 0 mmap(NULL, 238592, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fd85cbd1000 finit_module(3, "", 0) = 0 munmap(0x7fd85cbd1000, 238592) = 0 close(3) = 0 After: read(3, "\177ELF\2\1", 6) = 6 lseek(3, 0, SEEK_SET) = 0 finit_module(3, "", 0) = 0 close(3) = 0 When using kernel compression now it's also possible to direct libkmod to take the finit_module() path, avoiding the decompression in userspace and just delegating it to the kernel. Before: read(3, "(\265/\375\244\0", 6) = 6 lseek(3, 0, SEEK_SET) = 0 read(3, "(\265/\375\244", 5) = 5 mmap(NULL, 135168, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3fa431e000 read(3, "\0\244\3\0\\y\6", 7) = 7 mmap(NULL, 372736, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3fa414f000 brk(0x55944c6a1000) = 0x55944c6a1000 read(3, "\356|\6G\27U\20 \312\260s\211\335\333\263\326\330\336\273O\211\356\306K\360Z\341\374U6\342\221"..., 53038) = 53038 mremap(0x7f3fa431e000, 135168, 266240, MREMAP_MAYMOVE) = 0x7f3fa410e000 read(3, ",;\3\nqf\311\362\325\211\7\341\375A\355\221\371L\\\5\7\375 \32\246<(\258=K\304"..., 20851) = 20851 mremap(0x7f3fa410e000, 266240, 397312, MREMAP_MAYMOVE) = 0x7f3fa40ad000 read(3, ")\36\250\213", 4) = 4 read(3, "", 4) = 0 munmap(0x7f3fa414f000, 372736) = 0 init_module(0x7f3fa40ad010, 238592, "") = 0 munmap(0x7f3fa40ad000, 397312) = 0 close(3) = 0 After: read(3, "(\265/\375\244P", 6) = 6 lseek(3, 0, SEEK_SET) = 0 finit_module(3, "", 0x4 /* MODULE_INIT_??? */) = 0 close(3) = 0 Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
2023-06-02 05:40:01 +07:00
enum kmod_file_compression_type kmod_file_get_compression(const struct kmod_file *file)
{
libkmod: Use kernel decompression when available With the recent changes to bypass loading the file it's possible to reduce the work in userspace and delegating it to the kernel. Without any compression to illustrate: Before: read(3, "\177ELF\2\1", 6) = 6 lseek(3, 0, SEEK_SET) = 0 newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=238592, ...}, AT_EMPTY_PATH) = 0 mmap(NULL, 238592, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fd85cbd1000 finit_module(3, "", 0) = 0 munmap(0x7fd85cbd1000, 238592) = 0 close(3) = 0 After: read(3, "\177ELF\2\1", 6) = 6 lseek(3, 0, SEEK_SET) = 0 finit_module(3, "", 0) = 0 close(3) = 0 When using kernel compression now it's also possible to direct libkmod to take the finit_module() path, avoiding the decompression in userspace and just delegating it to the kernel. Before: read(3, "(\265/\375\244\0", 6) = 6 lseek(3, 0, SEEK_SET) = 0 read(3, "(\265/\375\244", 5) = 5 mmap(NULL, 135168, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3fa431e000 read(3, "\0\244\3\0\\y\6", 7) = 7 mmap(NULL, 372736, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3fa414f000 brk(0x55944c6a1000) = 0x55944c6a1000 read(3, "\356|\6G\27U\20 \312\260s\211\335\333\263\326\330\336\273O\211\356\306K\360Z\341\374U6\342\221"..., 53038) = 53038 mremap(0x7f3fa431e000, 135168, 266240, MREMAP_MAYMOVE) = 0x7f3fa410e000 read(3, ",;\3\nqf\311\362\325\211\7\341\375A\355\221\371L\\\5\7\375 \32\246<(\258=K\304"..., 20851) = 20851 mremap(0x7f3fa410e000, 266240, 397312, MREMAP_MAYMOVE) = 0x7f3fa40ad000 read(3, ")\36\250\213", 4) = 4 read(3, "", 4) = 0 munmap(0x7f3fa414f000, 372736) = 0 init_module(0x7f3fa40ad010, 238592, "") = 0 munmap(0x7f3fa40ad000, 397312) = 0 close(3) = 0 After: read(3, "(\265/\375\244P", 6) = 6 lseek(3, 0, SEEK_SET) = 0 finit_module(3, "", 0x4 /* MODULE_INIT_??? */) = 0 close(3) = 0 Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
2023-06-02 05:40:01 +07:00
return file->compression;
}
int kmod_file_get_fd(const struct kmod_file *file)
{
return file->fd;
}
2011-12-17 01:08:53 +07:00
void kmod_file_unref(struct kmod_file *file)
{
libkmod: cache open file for later access If we are accessing several times the modules and reading some sections by sucessive calls to the functions below, we are incurring in a penalty of having to open, parse the header and close the file. For each function. - kmod_module_get_info() - kmod_module_get_versions() - kmod_module_get_symbols() - kmod_module_get_dependency_symbols() These functions are particularly important to depmod. It calls all of them, for each module. Moreover there's a huge bottleneck in the open operation if we are using compression. Every time we open the module we need to uncompress the file and after getting the information we need we discard the result. This is clearly shown by profiling depmod with perf (record + report), using compressed modules: 64.07% depmod libz.so.1.2.7 [.] 0x00000000000074b8 ◆ 18.18% depmod libz.so.1.2.7 [.] crc32 ▒ 2.42% depmod libz.so.1.2.7 [.] inflate ▒ 1.17% depmod libc-2.16.so [.] __memcpy_ssse3_back ▒ 0.96% depmod [kernel.kallsyms] [k] copy_user_generic_string ▒ 0.89% depmod libc-2.16.so [.] __strcmp_sse42 ▒ 0.82% depmod [kernel.kallsyms] [k] hrtimer_interrupt ▒ 0.77% depmod libc-2.16.so [.] _int_malloc ▒ 0.44% depmod kmod-nolib [.] kmod_elf_get_strings ▒ 0.41% depmod kmod-nolib [.] kmod_elf_get_dependency_symbols ▒ 0.37% depmod kmod-nolib [.] kmod_elf_get_section ▒ 0.36% depmod kmod-nolib [.] kmod_elf_get_symbols ... Average of running depmod 5 times, dropping caches between them, in a slow spinning disk: Before: 12.25 +- 0.20 After: 8.20 +- 0.21 m-i-t: 9.62 +- 0.27 So this patch leads to an improvement of ~33% over unpatched version, ending up with 15% speedup over module-init-tools.
2012-10-18 11:36:33 +07:00
if (file->elf)
kmod_elf_unref(file->elf);
if (file->compression == KMOD_FILE_COMPRESSION_NONE) {
if (file->memory)
munmap(file->memory, file->size);
} else {
free(file->memory);
}
close(file->fd);
2011-12-17 01:08:53 +07:00
free(file);
}