AuxXxilium/eudev
1
0
Fork 0
mirror of https://github.com/AuxXxilium/eudev.git synced 2024-11-23 23:10:57 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #266 from bbonev/std-fds

Browse Source 
Ensure that standard file descriptors are open
This commit is contained in:
Boian Bonev 2023-10-05 20:18:39 +03:00 committed by GitHub
commit 901dc17e48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/udev/udevd.c
View File

@ -1135,6 +1135,22 @@ int main(int argc, char *argv[]) {
struct epoll_event ep_worker = { .events = EPOLLIN }; struct epoll_event ep_worker = { .events = EPOLLIN };
int r = 0, one = 1; int r = 0, one = 1;
/*
* Ensure no file descriptor unwillingly falls in the 0..2 range
* Warning: DO NOT OPEN FILES BEFORE THE 3 OPENS BELOW
*/
int fd_stdi = open("/dev/null", O_RDWR);
int fd_stdo = open("/dev/null", O_RDWR);
int fd_stde = open("/dev/null", O_RDWR);
/* Close only the ones that are safe to close */
if (fd_stdi > STDERR_FILENO)
close(fd_stdi);
if (fd_stdo > STDERR_FILENO)
close(fd_stdo);
if (fd_stde > STDERR_FILENO)
close(fd_stde);
udev = udev_new(); udev = udev_new();
if (!udev) { if (!udev) {
r = log_error_errno(errno, "could not allocate udev context: %m"); r = log_error_errno(errno, "could not allocate udev context: %m");
@ -1153,9 +1169,9 @@ int main(int argc, char *argv[]) {
log_warning_errno(r, "failed to parse kernel command line, ignoring: %m"); log_warning_errno(r, "failed to parse kernel command line, ignoring: %m");
if (arg_debug) { if (arg_debug) {
log_set_target(LOG_TARGET_CONSOLE); log_set_target(LOG_TARGET_CONSOLE);
log_set_max_level(LOG_DEBUG); log_set_max_level(LOG_DEBUG);
} }
if (getuid() != 0) { if (getuid() != 0) {
r = log_error_errno(EPERM, "root privileges required"); r = log_error_errno(EPERM, "root privileges required");