AuxXxilium/eudev
1
0
Fork 0
mirror of https://github.com/AuxXxilium/eudev.git synced 2024-12-28 06:35:34 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

input_id: Avoid memory overflow with too long capability masks

Browse Source 
Joey Lee <jlee@novell.com> reported a problem on an MSI laptop which reports a
too long capabilities/key:

E: EV==3
E: KEY==180000 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

This is longer than KEY_MAX and thus caused a memory overflow. Guard against
this now and just ignore the excess blocks.
This commit is contained in:
Martin Pitt 2011-03-18 13:56:32 +01:00
parent 941c40bdc4
commit 88149f668e
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
extras/input_id/input_id.c
View File

@ -61,12 +61,18 @@ static void get_cap_mask (struct udev_device *dev, const char* attr,
i = 0;
while ((word = strrchr(text, ' ')) != NULL) {
val = strtoul (word+1, NULL, 16);
bitmask[i] = val;
if (i < bitmask_size/sizeof(unsigned long))
bitmask[i] = val;
else
DBG("Ignoring %s block %lX which is larger than maximum size\n", attr, val);
*word = '\0';
++i;
}
val = strtoul (text, NULL, 16);
bitmask[i] = val;
if (i < bitmask_size/sizeof(unsigned long))
bitmask[i] = val;
else
DBG("Ignoring %s block %lX which is larger than maximum size\n", attr, val);
if (debug) {
/* printf pattern with the right unsigned long number of hex chars */