AuxXxilium/eudev
1
0
Fork 0
mirror of https://github.com/AuxXxilium/eudev.git synced 2024-12-25 21:25:59 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

unit-name: rework unit_name_replace_instance function()

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=855863
This commit is contained in:
Lennart Poettering 2012-09-12 04:46:38 +02:00
parent 49a32d43de
commit 8556879e0d
3 changed files with 50 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
TODO
View File

@ -49,6 +49,18 @@ Bugfixes:
Features:
* perfomance messages for selinux are gone from debug log?
* http://lists.freedesktop.org/archives/systemd-devel/2012-September/006502.html
* don't use writev() in tmpfiles for sake of compat with sysfs?
* come up with a nice way to write queue/read_ahead_kb for a block device without interfering with readahead
* journald: add kernel cmdline option to disable ratelimiting for debug purposes
* Add a way to reference the machine/boot ID from ExecStart= and similar command lines
* move PID 1 segfaults to /var/lib/systemd/coredump?
* Document word splitting syntax for ExecStart= and friends

35
src/shared/unit-name.c
View File

@ -357,36 +357,29 @@ bool unit_name_is_instance(const char *n) {
char *unit_name_replace_instance(const char *f, const char *i) {
const char *p, *e;
char *r, *k;
size_t a;
size_t a, b;
assert(f);
p = strchr(f, '@');
assert_se(e = strrchr(f, '.'));
if (!p)
return strdup(f);
e = strrchr(f, '.');
if (!e)
assert_se(e = strchr(f, 0));
a = p - f;
b = strlen(i);
if (p) {
size_t b;
b = strlen(i);
r = new(char, a + 1 + b + strlen(e) + 1);
if (!r)
return NULL;
k = mempcpy(r, f, a + 1);
k = mempcpy(k, i, b);
} else {
r = new(char, a + strlen(e) + 1);
if (!r)
return NULL;
k = mempcpy(r, f, a);
}
r = new(char, a + 1 + b + strlen(e) + 1);
if (!r)
return NULL;
k = mempcpy(r, f, a + 1);
k = mempcpy(k, i, b);
strcpy(k, e);
return r;
}

24
src/test/test-unit-name.c
View File

@ -29,6 +29,30 @@
int main(int argc, char* argv[]) {
char *t, *k;
t = unit_name_replace_instance("foo@.service", "waldo");
puts(t);
free(t);
t = unit_name_replace_instance("foo@xyz.service", "waldo");
puts(t);
free(t);
t = unit_name_replace_instance("xyz", "waldo");
puts(t);
free(t);
t = unit_name_replace_instance("", "waldo");
puts(t);
free(t);
t = unit_name_replace_instance("", "");
puts(t);
free(t);
t = unit_name_replace_instance("foo.service", "waldo");
puts(t);
free(t);
t = unit_name_from_path("/waldo", ".mount");
puts(t);
k = unit_name_to_path(t);