AuxXxilium/eudev
1
0
Fork 0
mirror of https://github.com/AuxXxilium/eudev.git synced 2024-12-28 06:35:34 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

extras: ata_id - do not log error if HDIO_GET_IDENTITY fails

Browse Source 
<tomegun> kay: is this a valid issue: https://bugs.archlinux.org/task/27060 ?
<kay> tomegun: udev does not really care if that fails
<tomegun> kay: the suggestion there is to treat EINVAL the same way we treat ENOTTY (i.e. as an info only)
<tomegun> if it really does not matter it might make sense to avoid bogus bug reports
<kay> tomegun: done
This commit is contained in:
Kay Sievers 2012-03-14 01:01:16 +01:00
parent 746b5152cc
commit 4b50a3d004
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ata_id/ata_id.c
View File

@ -532,13 +532,8 @@ int main(int argc, char *argv[])
} else {
/* If this fails, then try HDIO_GET_IDENTITY */
if (ioctl(fd, HDIO_GET_IDENTITY, &id) != 0) {
if (errno == ENOTTY) {
info(udev, "HDIO_GET_IDENTITY unsupported for '%s'\n", node);
rc = 2;
} else {
err(udev, "HDIO_GET_IDENTITY failed for '%s': %m\n", node);
rc = 3;
}
info(udev, "HDIO_GET_IDENTITY failed for '%s': %m\n", node);
rc = 2;
goto close;
}
}