arc: rework

Signed-off-by: AuxXxilium <info@auxxxilium.tech>

files/initrd/opt/arc/arc.sh

@@ -9,6 +9,10 @@
 . ${ARC_PATH}/include/storage.sh
 . ${ARC_PATH}/include/network.sh
 
+[ -z "${LOADER_DISK}" ] && die "Loader Disk not found!"
+
+alias DIALOG='dialog --backtitle "$(backtitle)" --colors --aspect 50'
+
 # Memory: Check Memory installed
 RAMTOTAL=0
 while read -r LINE; do
@@ -157,7 +161,7 @@ function arcMenu() {
       done < <(cat "${TMP_PATH}/modellist" | sort -n -k 2)
     [ ${FLGBETA} -eq 0 ] && echo "b \"\Z1Show beta Models\Zn\"" >>"${TMP_PATH}/menu"
     [ ${FLGNEX} -eq 1 ] && echo "f \"\Z1Show incompatible Models \Zn\"" >>"${TMP_PATH}/menu"
-    dialog --backtitle "$(backtitle)" --colors --menu "Choose Model for Loader" 0 62 0 \
+    DIALOG --menu "Choose Model for Loader" 0 62 0 \
       --file "${TMP_PATH}/menu" 2>"${TMP_PATH}/resp"
     [ $? -ne 0 ] && return 1
     resp="$(<"${TMP_PATH}/resp")"
@@ -294,7 +298,7 @@ function arcsettings() {
       writeConfigKey "extensions.cpuinfo" "" "${USER_CONFIG_FILE}"
     elif [ ${resp} -eq 3 ]; then
       while true; do
-        dialog --backtitle "$(backtitle)" --colors --title "Serial" \
+        DIALOG --title "Serial" \
           --inputbox "Please enter a valid Serial " 0 0 "" \
           2>"${TMP_PATH}/resp"
         [ $? -ne 0 ] && break 2
@@ -306,7 +310,7 @@ function arcsettings() {
         fi
         # At present, the SN rules are not complete, and many SNs are not truly invalid, so not provide tips now.
         break
-        dialog --backtitle "$(backtitle)" --colors --title "Serial" \
+        DIALOG --title "Serial" \
           --yesno "Invalid Serial, continue?" 0 0
         [ $? -eq 0 ] && break
       done
@@ -329,7 +333,7 @@ function arcsettings() {
       writeConfigKey "extensions.cpuinfo" "" "${USER_CONFIG_FILE}"
     elif [ ${resp} -eq 2 ]; then
       while true; do
-        dialog --backtitle "$(backtitle)" --colors --title "Serial" \
+        DIALOG --title "Serial" \
           --inputbox "Please enter a serial number " 0 0 "" \
           2>"${TMP_PATH}/resp"
         [ $? -ne 0 ] && break 2
@@ -341,7 +345,7 @@ function arcsettings() {
         fi
         # At present, the SN rules are not complete, and many SNs are not truly invalid, so not provide tips now.
         break
-        dialog --backtitle "$(backtitle)" --colors --title "Serial" \
+        DIALOG --title "Serial" \
           --yesno "Invalid Serial, continue?" 0 0
         [ $? -eq 0 ] && break
       done
@@ -429,7 +433,7 @@ function make() {
     PAT_HASH_CONF="0"
   fi
   while true; do
-    dialog --backtitle "$(backtitle)" --colors --title "Arc Build" \
+    DIALOG --title "Arc Build" \
       --infobox "Get PAT Data from Syno..." 3 30
     idx=0
     while [ ${idx} -le 3 ]; do # Loop 3 times, if successful, break
@@ -449,7 +453,7 @@ function make() {
     else
       MSG="Successfully got PAT Data.\nPlease confirm or modify as needed."
     fi
-    dialog --backtitle "$(backtitle)" --colors --title "Arc Build" \
+    DIALOG --title "Arc Build" \
       --extra-button --extra-label "Retry" --default-button "OK" \
       --form "${MSG}" 10 110 2 "URL" 1 1 "${PAT_URL}" 1 7 100 0 "HASH" 2 1 "${PAT_HASH}" 2 7 100 0 \
       2>"${TMP_PATH}/resp"
@@ -713,7 +717,7 @@ function modulesMenu() {
           --msgbox "${ITEMS}" 0 0
         ;;
       2)
-        dialog --backtitle "$(backtitle)" --colors --title "Modules" \
+        DIALOG --title "Modules" \
           --infobox "Selecting loaded modules" 0 0
         KOLIST=""
         for I in $(lsmod | awk -F' ' '{print $1}' | grep -v 'Module'); do
@@ -1002,7 +1006,7 @@ function cmdlineMenu() {
         echo "5 \"Reboot after 5 seconds\"" >>"${TMP_PATH}/opts"
         echo "0 \"No reboot\"" >>"${TMP_PATH}/opts"
         echo "-1 \"Restart immediately\"" >>"${TMP_PATH}/opts"
-        dialog --backtitle "$(backtitle)" --colors --title "Kernelpanic" \
+        DIALOG --title "Kernelpanic" \
           --default-item "${KERNELPANIC}" --menu "Choose a time(seconds)" 0 0 0 --file "${TMP_PATH}/opts" \
           2>${TMP_PATH}/resp
         [ $? -ne 0 ] && return
@@ -1219,7 +1223,7 @@ function backupMenu() {
           ;;
         3)
           if ! tty | grep -q "/dev/pts"; then
-            dialog --backtitle "$(backtitle)" --colors --aspect 18 \
+            DIALOG --aspect 18 \
               --msgbox "This feature is only available when accessed via web/ssh." 0 0
             return
           fi
@@ -1246,13 +1250,13 @@ function backupMenu() {
           else                          # ssh
             sz -be /var/www/data/arc-backup.img.gz
           fi
-          dialog --backtitle "$(backtitle)" --colors --aspect 18 \
+          DIALOG --aspect 18 \
               --msgbox "Backup is complete." 0 0
           rm -f /var/www/data/arc-backup.img.gz
           ;;
         4)
           if ! tty | grep -q "/dev/pts"; then
-            dialog --backtitle "$(backtitle)" --colors --aspect 18 \
+            DIALOG --aspect 18 \
               --msgbox "This feature is only available when accessed via web/ssh." 0 0
             return 1
           fi
@@ -1449,7 +1453,7 @@ function backupMenu() {
           ;;
         2)
           if ! tty | grep -q "/dev/pts"; then
-            dialog --backtitle "$(backtitle)" --colors --aspect 18 \
+            DIALOG --aspect 18 \
               --msgbox "This feature is only available when accessed via web/ssh." 0 0
             return
           fi
@@ -2165,7 +2169,7 @@ function sysinfo() {
   fi
   TEXT+="\n  Ports with color \Z1\Zbred\Zn as DUMMY, color \Z2\Zbgreen\Zn has drive connected.\n"
   TEXT+="\n  Drives total: \Zb${NUMPORTS}\Zn"
-  dialog --backtitle "$(backtitle)" --colors --title "Sysinfo" \
+  DIALOG --title "Sysinfo" \
     --msgbox "${TEXT}" 0 0
 }
 
@@ -2267,7 +2271,7 @@ function downgradeMenu() {
   ) 2>&1 | dialog --backtitle "$(backtitle)" --title "Allow downgrade installation" \
       --progressbox "Removing ..." 20 70
   TEXT="Remove VERSION file for all disks completed."
-  dialog --backtitle "$(backtitle)" --colors --aspect 18 \
+  DIALOG --aspect 18 \
     --msgbox "${TEXT}" 0 0
 }
 
@@ -2325,7 +2329,7 @@ function resetPassword() {
   ) 2>&1 | DIALOG --title "Reset DSM Password" \
     --progressbox "Resetting ..." 20 100
   [ -f "${SHADOW_FILE}" ] && rm -rf "${SHADOW_FILE}"
-  DIALOG --title "Reset DSM Password" --aspect 18 \
+  DIALOG --title "Reset DSM Password" \
     --msgbox "Password reset completed." 0 0
 }
 
@@ -2333,7 +2337,7 @@ function resetPassword() {
 # modify bootipwaittime
 function bootipwaittime() {
   ITEMS="$(echo -e "0 \n5 \n10 \n20 \n30 \n60 \n")"
-  dialog --backtitle "$(backtitle)" --colors --title "Boot IP Waittime" \
+  DIALOG --title "Boot IP Waittime" \
     --default-item "${BOOTIPWAIT}" --no-items --menu "Choose Waittime(seconds)\nto get an IP" 0 0 0 ${ITEMS} \
     2>"${TMP_PATH}/resp"
   resp="$(cat ${TMP_PATH}/resp 2>/dev/null)"
@@ -2370,7 +2374,7 @@ function saveMenu() {
   cp -Rf "/opt" "${RDXZ_PATH}"
   (cd "${RDXZ_PATH}"; find . 2>/dev/null | cpio -o -H newc -R root:root | xz --check=crc32 >"${PART3_PATH}/initrd-arc") || true
   rm -rf "${RDXZ_PATH}"
-  dialog --backtitle "$(backtitle)" --colors --aspect 18 \
+  DIALOG --aspect 18 \
     --msgbox "Save to Disk is complete." 0 0
 }
 
@@ -2383,17 +2387,17 @@ function formatdisks() {
     echo "${POSITION}" | grep -q "${LOADER_DISK}" && continue
     echo "\"${POSITION}\" \"${NAME}\" \"off\"" >>"${TMP_PATH}/opts"
   done < <(ls -l /dev/disk/by-id/ | sed 's|../..|/dev|g' | grep -E "/dev/sd|/dev/nvme" | awk -F' ' '{print $NF" "$(NF-2)}' | sort -uk 1,1)
-  dialog --backtitle "$(backtitle)" --colors --title "Format Disks" \
+  DIALOG --title "Format Disks" \
     --checklist "" 0 0 0 --file "${TMP_PATH}/opts" \
     2>${TMP_PATH}/resp
   [ $? -ne 0 ] && return 1
   resp=$(<"${TMP_PATH}/resp")
   [ -z "${resp}" ] && return 1
-  dialog --backtitle "$(backtitle)" --colors --title "Format Disks" \
+  DIALOG --title "Format Disks" \
     --yesno "Warning:\nThis operation is irreversible. Please backup important data. Do you want to continue?" 0 0
   [ $? -ne 0 ] && return 1
   if [ $(ls /dev/md* | wc -l) -gt 0 ]; then
-    dialog --backtitle "$(backtitle)" --colors --title "Format Disks" \
+    DIALOG --title "Format Disks" \
       --yesno "Warning:\nThe current hds is in raid, do you still want to format them?" 0 0
     [ $? -ne 0 ] && return 1
     for I in $(ls /dev/md*); do
@@ -2404,9 +2408,9 @@ function formatdisks() {
     for I in ${resp}; do
       echo y | mkfs.ext4 -T largefile4 "${I}" 2>&1
     done
-  ) 2>&1 | dialog --backtitle "$(backtitle)" --colors --title "Format Disks" \
+  ) 2>&1 | DIALOG --title "Format Disks" \
     --progressbox "Formatting ..." 20 70
-  dialog --backtitle "$(backtitle)" --colors --title "Format Disks" \
+  DIALOG --title "Format Disks" \
     --msgbox "Formatting is complete." 0 0
 }
 
@@ -2462,14 +2466,14 @@ function resetLoader() {
   fi
   CONFDONE="$(readConfigKey "arc.confdone" "${USER_CONFIG_FILE}")"
   BUILDDONE="$(readConfigKey "arc.builddone" "${USER_CONFIG_FILE}")"
-  dialog --backtitle "$(backtitle)" --colors --title "Clean Old" \
+  DIALOG --title "Clean Old" \
     --msgbox "Clean is complete." 5 30
 
 ###############################################################################
 # let user edit the grub.cfg
 function editGrubCfg() {
   while true; do
-    dialog --backtitle "$(backtitle)" --colors --title "Edit grub.cfg with caution" \
+    DIALOG --title "Edit grub.cfg with caution" \
       --editbox "${GRUB_PATH}/grub.cfg" 0 0 2>"${TMP_PATH}/usergrub.cfg"
     [ $? -ne 0 ] && return
     mv -f "${TMP_PATH}/usergrub.cfg" "${GRUB_PATH}/grub.cfg"